search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: Stripy: A Python module for (constrained) triangulation in Cartesian coordinates and on a sphere #1324

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @lmoresi (Louis Moresi) Repository: https://github.com/underworldcode/stripy Version: 0.7.0 Editor: @VivianePons Reviewers: @santisoler

Author instructions

Thanks for submitting your paper to JOSS @lmoresi. Currently, there isn't an JOSS editor assigned to your paper.

@lmoresi if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1324 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1324 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:incollect!' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/processor.rb:57:infind_paper_paths' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:inrun' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:indispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/bin/whedon:116:in<top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

arfon commented 5 years ago

@whedon generate pdf from branch paper

whedon commented 5 years ago 
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1324 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 13 0 13 0 0 145 0 --:--:-- --:--:-- --:--:-- 144 Error reading bibliography ./paper.bib (line 8, column 1): unexpected "y" expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

arfon commented 5 years ago

@lmoresi - please take a look at the errors above with your bibtex file. If you make fixes in your paper branch you can recompile with @whedon generate pdf from branch paper

arfon commented 5 years ago

@openjournals/joss-eics - the submitting author suggested @lheagy as the handling editor.

lmoresi commented 5 years ago

@whedon generate pdf from branch paper

whedon commented 5 years ago 
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

lmoresi commented 5 years ago

@whedon generate pdf from branch paper

whedon commented 5 years ago 
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

lmoresi commented 5 years ago

@whedon generate pdf from branch paper

whedon commented 5 years ago 
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

labarba commented 5 years ago

👋 @VivianePons — Taking into account editor workloads at the moment, I'd like to assign this submission to you for handling. Can you take it on?

labarba commented 5 years ago

@whedon assign @VivianePons as editor

whedon commented 5 years ago

OK, the editor is @VivianePons

VivianePons commented 5 years ago

I have just emails to ask @margauxmouchene and @kmarkert for reviews

VivianePons commented 5 years ago

@lmoresi I have trouble finding available reviewers, do you have any suggestions?

lmoresi commented 5 years ago

@lmoresi I have trouble finding available reviewers, do you have any suggestions?

We're discussing the possible choices. A queston of joss etiquette - is it appropriate to name people here in the open forum ?

VivianePons commented 5 years ago

We usually do it that way but if you'd rather send me an email about it, please do so.

lmoresi commented 5 years ago

It's fine. I just wanted to make sure there were no privacy issues. We have the following suggestions that are mainly from the Earth Science side as we think that is the primary audience for stripy and maybe that will help. We also suggest contacting professor Renka whose original code we wrapped as the starting point for the package (email details below)

lmoresi commented 5 years ago

@VivianePons - did you have any luck with those suggestions or would you like us to extend the list ? (also, fyi, @brmather)

VivianePons commented 5 years ago

I have asked 10 people so far, and I got either no response or too busy. At the moment, I'm waiting for an answer from Robert Renka and another person who was suggested by busy people.

VivianePons commented 5 years ago

@whedon assign @santisoler as reviewer

whedon commented 5 years ago

OK, the reviewer is @santisoler

VivianePons commented 5 years ago

Good news! We have one confirmed reviewer. I would still feel more comfortable with a second one. Anyway, this has been taking quite some time already so I will create the review issue right now and add the second reviewer when I find someone.

VivianePons commented 5 years ago

@whedon create review

VivianePons commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1410. Feel free to close this issue now!