search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: treex: a Python package for manipulating rooted trees #1332

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @RomainAzais (Romain Azais) Repository: https://gitlab.inria.fr/azais/treex Version: v1.1.3 Editor: @VivianePons Reviewers: @dvalters, @VivianePons

Author instructions

Thanks for submitting your paper to JOSS @RomainAzais. Currently, there isn't an JOSS editor assigned to your paper.

@RomainAzais if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1332 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 13 0 13 0 0 135 0 --:--:-- --:--:-- --:--:-- 135 Error producing PDF. ! Misplaced alignment tab character &.

...estore \footnotesize {\sffamily Aza& iuml;s et al., (2019). tre... l.357 Looks like we failed to compile the PDF
arfon commented 5 years ago

:wave: @VivianePons - the submitting author suggested you as the handling editor.

arfon commented 5 years ago

@Azais - for some reason Whedon doesn't like the HTML-escaped characters in the footer. Can you update your paper to look like this? https://gist.github.com/arfon/6b1092c47917335272158679e3d2a6ec

RomainAzais commented 5 years ago

@whedon @arfon The issue was due to accented characters. I removed them from the files paper.md and paper.bib.

arfon commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

VivianePons commented 5 years ago

Yes, I'am taking this one! Trees are my favorite thing ;)

Azais commented 5 years ago

You have the wrong Azais, sorry ! I therefore cannot update the paper.

Good luck to my distant relative,

Another Azais

VivianePons commented 5 years ago

I have fixed the Azais issue in the comment section as I understand @RomainAzais is the author! Sorry @Azais for the confusion. I am not sure how to stop github sending you updates on this thread now that you're in it. But in any case, this is just the pre-review issue. It will be closed as soon as I find reviewers.

@Arfon : I am going to find a reviewer, I am also wondering if I can add myself as a second reviewer if I am the editor?

VivianePons commented 5 years ago

@whedon assign @VivianePons as editor

whedon commented 5 years ago

OK, the editor is @VivianePons

RomainAzais commented 5 years ago

👉 Check article proof 📄 👈

I didn't answer last week but the article proof is correct.

dvberkel commented 5 years ago

@VivianePons You have sent me an email in which you requested a review of the article. I am willing and able to review the paper.

I will start with reading the article.

VivianePons commented 5 years ago

@whedon assign @dvalters as reviewer

dvberkel commented 5 years ago

@whedon commands

whedon commented 5 years ago

OK, the reviewer is @dvalters

whedon commented 5 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references
VivianePons commented 5 years ago

@whedon add @VivianePons as reviewer

whedon commented 5 years ago

OK, @VivianePons is now a reviewer

VivianePons commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1351. Feel free to close this issue now!