openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: OrpailleCC: a Library for Data Stream Analysis on Embedded Systems #1357

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @Azazel7 (Martin Khannouz) Repository: https://github.com/big-data-lab-team/OrpailleCC Version: V1.0 Editor: @gkthiruvathukal Reviewers: @sepandhaghighi

Author instructions

Thanks for submitting your paper to JOSS @Azazel7. Currently, there isn't an JOSS editor assigned to your paper.

@Azazel7 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1357 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon/author.rb:58:in block in build_affiliation_string': Problem with affiliations for Martin Khannouz, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon/author.rb:57:ineach' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon/author.rb:57:in build_affiliation_string' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon/author.rb:17:ininitialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:109:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:109:inblock in parse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:106:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:106:inparse_authors' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon.rb:73:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon/processor.rb:32:innew' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/lib/whedon/processor.rb:32:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/bin/whedon:55:inprepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-96d847bd9060/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

danielskatz commented 5 years ago

👋 @azazel7 - there's a problem with your paper, as seen from the whedon comment above. Please make changes, following the example paper, and then enter @whedon generate pdf as a new comment here to recompile the paper, and repeat until you are happy with it.

danielskatz commented 5 years ago

In this case, the affiliations in the author block need to be simple integers that refer to the affiliations block, not complete affiliations in the author block. Again, see the example.

danielskatz commented 5 years ago

👋 @eramirem - would you be able to edit this submission?

azazel7 commented 5 years ago

@danielskatz Thanks. I made the modifications.

azazel7 commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

labarba commented 5 years ago

@azazel7 — We're missing in your paper a brief description of how the software is used or can be used in research settings. Could you expand that? Please also comment on any extant software that targets the same (or similar) application or functionality.

danielskatz commented 5 years ago

I'm going to mark this as paused for now - please let us know when you have added to the paper as requested by @labarba and are ready to proceed.

azazel7 commented 5 years ago

A paragraph has been refactored to add the required information. The goal of OrpailleCC is to provide a consistent environment to study data stream algorithms for embedded systems. I will use this library for my own research as well. @whedon generate pdf

danielskatz commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

danielskatz commented 5 years ago

@azazel7 - At some point, you will need to add DOIs to references that have them. Once you have done so, you can regenerate the PDF by adding a new comment here that is @whedon generate pdf (not as part of another comment, but as a new comment)

danielskatz commented 5 years ago

@whedon check references

whedon commented 5 years ago
Attempting to check references...
whedon commented 5 years ago

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1109/bigdata.2018.8621946 may be missing for title: A multi-dimensional extension of the Lightweight Temporal Compression method
- https://doi.org/10.1145/362686.362692 may be missing for title: Space/Time Trade-offs in Hash Coding with Allowable Errors
- https://doi.org/10.3390/a10030080 may be missing for title: A hybrid algorithm for optimal wireless sensor network deployment with the minimum number of sensor nodes
- https://doi.org/10.1109/bigdata.2018.8621946 may be missing for title: A multi-dimensional extension of the Lightweight Temporal Compression method
- https://doi.org/10.2307/2685209 may be missing for title: An introduction to kernel and nearest-neighbor nonparametric regression
- https://doi.org/10.1109/hicss.2000.926982 may be missing for title: Energy-efficient communication protocol for wireless microsensor networks
- https://doi.org/10.1109/glocom.2002.1188034 may be missing for title: Analysis of energy consumption and lifetime of heterogeneous wireless sensor networks
- https://doi.org/10.1109/35.925682 may be missing for title: Maximum battery life routing to support ubiquitous mobile computing in wireless ad hoc networks

INVALID DOIs

- None
danielskatz commented 5 years ago

see the above for suggestions, but be aware, it is not always completely correct, so take it with a grain of salt...

danielskatz commented 5 years ago

👋 @gkthiruvathukal - would you be willing to edit this submission?

gkthiruvathukal commented 5 years ago

@danielskatz Yes.

danielskatz commented 5 years ago

@whedon assign @gkthiruvathukal as editor

whedon commented 5 years ago

OK, the editor is @gkthiruvathukal

azazel7 commented 5 years ago

@danielskatz Ok.

azazel7 commented 5 years ago

@whedon check references

whedon commented 5 years ago
Attempting to check references...
whedon commented 5 years ago

OK DOIs

- 10.14778/2824032.2824132 is OK
- 10.1109/lcn.2004.72 is OK
- 10.1109/bigdata.2018.8621946 is OK
- 10.1145/2674005.2674994 is OK
- 10.1016/j.future.2017.03.026 is OK
- 10.1145/3147.3165 is OK
- 10.1145/362686.362692 is OK
- 10.3390/a10030080 is OK
- 10.2307/2685209 is OK
- 10.1109/hicss.2000.926982 is OK
- 10.1109/glocom.2002.1188034 is OK
- 10.1109/35.925682 is OK
- 10.1145/1656274.1656278 is OK

MISSING DOIs

- None

INVALID DOIs

- None
azazel7 commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

azazel7 commented 5 years ago

@danielskatz I found most of the DOIs of the references in the paper, except for two of them.

danielskatz commented 5 years ago

Great - for the couple of the conference proceedings where the cases are incorrect, you might add another {} around the text where you want to preserve the case in the .bib file.

azazel7 commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

azazel7 commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

azazel7 commented 5 years ago

I think it's fixed.

gkthiruvathukal commented 5 years ago

@azazel7 Can you take a look at https://bit.ly/joss-reviewers and suggest any reviewers?

azazel7 commented 5 years ago

@gkthiruvathukal : I had a look at the list and I would suggest the following names:

I made sure that all have a background in C++ as well as knowledge on embedded systems and machine learning. None of them are known by me or any author of OrpailleCC.

gkthiruvathukal commented 5 years ago

@azazel7 Thanks for your suggestions from our list. I was a bit busy grading finals so there was a bit of a delay in getting started. Stay tuned.

gkthiruvathukal commented 5 years ago

@federeghe Would you be willing to contribute a review for this JOSS submission?

gkthiruvathukal commented 5 years ago

@sepandhaghighi Would you also be willing to contribute a review for this JOSS submission?

federeghe commented 5 years ago

@gkthiruvathukal Yes I would, but probably I cannot begin the review before June 1.

sepandhaghighi commented 5 years ago

@gkthiruvathukal Hi Yes, I'm available.

gkthiruvathukal commented 5 years ago

@whedon assign @sepandhaghighi as reviewer

whedon commented 5 years ago

OK, the reviewer is @sepandhaghighi