Closed whedon closed 5 years ago
:wave: @alkirkby, excellent! Would you mind updating the title in the zenodo archive to match the title of the paper: "The MTPy software package for magnetotelluric data analysis and visualisation". After that, we are good to go!
@lheagy, ok no worries, done.
Many thanks @JKutt for your speedy review! and congratulations @alkirkby and team on your submission π
π @openjournals/joss-eics, this submission is ready to be accepted!
Thanks to @JKutt for reviewing and @lheagy for editing!
@whedon accept
Attempting dry run of processing paper acceptance...
OK DOIs
- 10.1111/j.1365-246x.2005.02779.x is OK
- 10.1111/j.1365-246X.2004.02281.x is OK
- 10.1111/j.1365-246X.2004.02203.x is OK
- 10.1029/JB092iB01p00633 is OK
- 10.1190/1.1442813 is OK
- 10.1111/j.1365-246X.2011.05347.x is OK
- 10.1016/j.cageo.2014.01.010 is OK
- 10.1016/J.CAGEO.2014.07.013 is OK
- 10.1190/1.1438799 is OK
- 10.1111/j.1365-246X.1962.tb02992.x is OK
MISSING DOIs
- None
INVALID DOIs
- None
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/709
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/709, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true
@alkirkby - I see a couple of reference problems that I've tried to fix via https://github.com/MTgeophysics/mtpy/pull/82
One is opening quotes that were backwards, and the other is an underscore that caused a URL to not work right. I'm sure my fix will work for the quotes, but I'm not sure it will work for the URL. Can you accept the PR, and see if paper will compile? If not, we can try to fix the underscore in the URL another way.
@whedon generate pdf
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1358 with the following error:
Can't find any papers to compile :-(
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
PDF failed to compile for issue #1358 with the following error:
sh: 0: getcwd() failed: No such file or directory sh: 0: getcwd() failed: No such file or directory pandoc: 10.21105.joss.01358.pdf: openBinaryFile: does not exist (No such file or directory) Looks like we failed to compile the PDF
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon accept
Attempting dry run of processing paper acceptance...
OK DOIs
- 10.1111/j.1365-246x.2005.02779.x is OK
- 10.1111/j.1365-246X.2004.02281.x is OK
- 10.1111/j.1365-246X.2004.02203.x is OK
- 10.1029/JB092iB01p00633 is OK
- 10.1190/1.1442813 is OK
- 10.1111/j.1365-246X.2011.05347.x is OK
- 10.1016/j.cageo.2014.01.010 is OK
- 10.1016/J.CAGEO.2014.07.013 is OK
- 10.1190/1.1438799 is OK
- 10.1111/j.1365-246X.1962.tb02992.x is OK
MISSING DOIs
- None
INVALID DOIs
- None
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/710
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/710, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true
@whedon accept deposit=true
Doing it live! Attempting automated processing of paper acceptance...
π¦π¦π¦ π Tweet for this paper π π¦π¦π¦
π¨π¨π¨ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! π¨π¨π¨
Here's what you must now do:
Party like you just published a paper! πππ¦ππ»π€
Any issues? notify your editorial technical team...
Hi @danielskatz just wondering if the DOI issue should have resolved by now? It's still failing to load the document for me.
It's working now, sorry I was just impatient :)
Yes, thatβs why the review is still open. Letβs see if it resolves a little later; thatβs usually the case.
Actually, itβs now working for me, though it might be cached for you.
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01358/status.svg)](https://doi.org/10.21105/joss.01358)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01358">
<img src="http://joss.theoj.org/papers/10.21105/joss.01358/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01358/status.svg
:target: https://doi.org/10.21105/joss.01358
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Thanks @danielskatz, yep it's working now, I was just a bit impatient. And thanks @lheagy and @JKutt for editing and reviewing!
Submitting author: @alkirkby (Alison Kirkby) Repository: https://github.com/MTgeophysics/mtpy Version: v1.0 Editor: @lheagy Reviewer: @JKutt Archive: 10.5281/zenodo.2698634
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@JKutt, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @lheagy know.
β¨ Please try and complete your review in the next two weeks β¨
Review checklist for @JKutt
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?