Closed whedon closed 5 years ago
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @wmegchel, it looks like you're currently assigned as the reviewer for this paper :tada:.
:star: Important :star:
If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿
To fix this do the following two things:
For a list of things I can do to help you, just type:
@whedon commands
Attempting PDF compilation. Reticulating splines etc...
@lpantano @wmegchel @prasunanand I thought that it can be cumbersome to go through all the dependencies with potentially no access to NVIDIA GPU, below I provide a code ocean capsule which is a container with all the dependencies cached. You can also have reproducible runs of an example. https://codeocean.com/capsule/2291048/tree/v1 I hope that this helps your assessment.
Thanks for this.
@wmegchel and @prasunanand, it is possible to give an update on the reviewing process?
Thanks so much!
@marouenbg, @lpantano I am unable to download Dependencies IBM CPLEX v12.6 (free for academics)
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@prasunanand Thanks for the feedback. I fixed the missing doi in the summary. Which error did you get when you could not download CPLEX? Otherwise, you can skip the installation part and check an installed version at code ocean https://codeocean.com/capsule/4395814/tree
Review done!
Nice work @marouenbg
@whedon check references
Attempting to check references...
OK DOIs
- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
MISSING DOIs
- None
INVALID DOIs
- None
Thank @prasunanand and @wmegchel for the nice review. I will proceed with acceptance.
@marouenbg could you create a Zenodo archive for your repository and pass me the DOI link? Make sure the author and title match the paper information. Congrats!
Awesome! Thanks @prasunanand for the review. @lpantano I need a couple of days to review the text and the we can proceed with the final version. Thank you!
@whedon check references
Attempting to check references...
OK DOIs
- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK
MISSING DOIs
- https://doi.org/10.1007/978-3-642-22194-1_4 may be missing for title: A GPU-based parallel algorithm for large scale linear programming problem
- https://doi.org/10.1145/3297663.3310308 may be missing for title: Simultaneous solving of batched linear programs on a GPU
- https://doi.org/10.1016/j.jpdc.2019.01.001 may be missing for title: Two-dimensional batch linear programming on the GPU
INVALID DOIs
- None
@whedon check references
Attempting to check references...
OK DOIs
- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK
MISSING DOIs
- https://doi.org/10.1007/978-3-642-22194-1_4 may be missing for title: A GPU-based parallel algorithm for large scale linear programming problem
- https://doi.org/10.1145/3297663.3310308 may be missing for title: Simultaneous solving of batched linear programs on a GPU
- https://doi.org/10.1016/j.jpdc.2019.01.001 may be missing for title: Two-dimensional batch linear programming on the GPU
INVALID DOIs
- None
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon check references
Attempting to check references...
OK DOIs
- 10.1371/journal.pone.0086587 is OK
- 10.1101/440701 is OK
- 10.1145/1365490.1365500 is OK
- 10.1287/opre.46.1.84 is OK
- 10.1109/hpcsim.2014.6903792 is OK
- 10.1038/s41596-018-0098-2 is OK
- 10.1016/j.cell.2015.05.019 is OK
- 10.1016/j.ymben.2003.09.002 is OK
- 10.1109/99.660313 is OK
- 10.1007/bf02989823 is OK
- 10.1038/nbt.2488 is OK
- 10.1128/ecosalplus.10.2.1 is OK
- 10.1186/1752-0509-2-79 is OK
- 10.1007/978-3-642-22194-1_4 is OK
- 10.1145/3297663.3310308 is OK
- 10.1016/j.jpdc.2019.01.001 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Hi @lpantano I am all set. A math symbol did not compile in the final text, but it is working now. Here is the zenodo doi DOI/10.5281/zenodo.3233085. Thanks to all involved!
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Submitting author: @marouenbg (Marouen Ben Guebila) Repository: https://github.com/marouenbg/ACHR.cu Version: v0.2 Editor: @lpantano Reviewer: @wmegchel, @prasunanand Archive: 10.5281/zenodo.3233085
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@wmegchel & @prasunanand, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @lpantano know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @wmegchel
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @prasunanand
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?