openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 37 forks source link

[REVIEW]: Pyret: A Python package for analysis of neurophysiology data #137

Closed whedon closed 7 years ago

whedon commented 7 years ago

Submitting author: @nirum (Niru Maheswaranathan) Repository: https://github.com/baccuslab/pyret Version: v0.5.0 Editor: @arokem Reviewer: @kdesimone Archive: 10.5281/zenodo.232521

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/73e486788290a6386e90a21c7e71bbe0"><img src="http://joss.theoj.org/papers/73e486788290a6386e90a21c7e71bbe0/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/73e486788290a6386e90a21c7e71bbe0/status.svg)](http://joss.theoj.org/papers/73e486788290a6386e90a21c7e71bbe0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

Conflict of interest

General checks

Functionality

Documentation

Software paper

whedon commented 7 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands
arokem commented 7 years ago

@whedon commands

whedon commented 7 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List the GitHub usernames of the JOSS editors
@whedon list editors

# List of JOSS reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

:construction: Important :construction:

This is all quite new. Please make sure you check the top of the issue after running a @whedon command (you might also need to refresh the page to see the issue update).

arokem commented 7 years ago

@whedon assign @kdesimone as reviewer

whedon commented 7 years ago

OK, the reviewer is @kdesimone

kdesimone commented 7 years ago

The authors have satisfactorily addressed (and closed) all the issues, which I've linked below.

https://github.com/baccuslab/pyret/issues/88 https://github.com/baccuslab/pyret/issues/86 https://github.com/baccuslab/pyret/issues/85 https://github.com/baccuslab/pyret/issues/83

arokem commented 7 years ago

@arfon: what's the next step here?

IIUC, @nirum and colleagues need to create a DOI for the package that incorporates the fixes from the review. Is that correct?

arfon commented 7 years ago

IIUC, @nirum and colleagues need to create a DOI for the package that incorporates the fixes from the review. Is that correct?

Yes, that's correct. @nirum - please create the archive and update this thread with the DOI so we can accept this submission.

nirum commented 7 years ago

Thanks @kdesimone and @arokem!

I've uploaded the package using zenodo, here is the DOI: DOI

arfon commented 7 years ago

@whedon set 10.5281/zenodo.232521 as archive

whedon commented 7 years ago

OK. 10.5281/zenodo.232521 is the archive.

arfon commented 7 years ago

@arokem thanks for editing this one and for your review @kdesimone :zap:

@nirum - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00137 ⚡️ 🚀 💥