search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: survPen: an R package for hazard and excess hazard modelling with multidimensional penalized splines #1430

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @fauvernierma (Mathieu Fauvernier) Repository: https://github.com/fauvernierma/survPen Version: v1.1.0 Editor: @csoneson Reviewers: @corybrunson, @seabbs

Author instructions

Thanks for submitting your paper to JOSS @fauvernierma. The JOSS editor @csoneson, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@fauvernierma if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @csoneson it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@csoneson) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

Failed to discover a valid open source license.

whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kyleniemeyer commented 5 years ago

@csoneson would you be able to edit this submission?

kyleniemeyer commented 5 years ago

@whedon assign @csoneson as editor

whedon commented 5 years ago

OK, the editor is @csoneson

fauvernierma commented 5 years ago

Hello everyone,

As they are both experts in R and survival analysis, I think that @becarioprecario and @adibender would make appropriate reviewers for the survPen package.

Do you agree ?

csoneson commented 5 years ago

@kyleniemeyer Yes, I can edit this one.

csoneson commented 5 years ago

@fauvernierma - thanks for these suggestions. I agree that they would fit very well as reviewers. @becarioprecario, @adibender, would you be willing to review this JOSS submission?

csoneson commented 5 years ago

@fauvernierma - I had a first quick look at your repository and the paper, and I have a couple of small comments that would be good if you could fix already before we start the review:

becarioprecario commented 5 years ago

Hi,

I am afraid that I cannot commit to make a review of this right now. I am already very late with another JOS review.

Sorry.

Virgilio

csoneson commented 5 years ago

@becarioprecario No problem, thanks for the quick reply!

csoneson commented 5 years ago

@corybrunson, @seabbs - would you be interested in reviewing this submission for JOSS?

fauvernierma commented 5 years ago

I have added a LICENSE file and all references should be in order now

Thank you

csoneson commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

corybrunson commented 5 years ago

@csoneson i would be glad to review. I would expect to finish after one week. (I have only introductory training in survival analysis but the topic interests me.)

csoneson commented 5 years ago

@corybrunson excellent, thank you! As soon as we find one more reviewer I will open the actual review issue, where you can leave your comments etc.

seabbs commented 5 years ago

@csoneson I would also be happy to review.

Not an expert in survival analysis but I have used mgcv fairly regularly (according to vignettes it has a comparable framework).

csoneson commented 5 years ago

@seabbs perfect. I will add you both as reviewers and open the review issue.

csoneson commented 5 years ago

@whedon assign @corybrunson as reviewer

whedon commented 5 years ago

OK, the reviewer is @corybrunson

csoneson commented 5 years ago

@whedon add @seabbs as reviewer

whedon commented 5 years ago

OK, @seabbs is now a reviewer

csoneson commented 5 years ago

@whedon start review

adibender commented 5 years ago

Hello, sorry for late reply, happy to review if still necessary.

arfon commented 5 years ago

@whedon start review

arfon commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1434. Feel free to close this issue now!

csoneson commented 5 years ago

Hi @adibender - thanks for volunteering! I think we are set here - I hope I can come back to you for another paper in the future!

csoneson commented 5 years ago

@corybrunson, @seabbs - let's head over to #1434 for the review!