Closed whedon closed 5 years ago
Yes - see e.g. https://texfaq.org/FAQ-capbibtex. For the DOIs for the articles from 1995, I also can't find them (neither on PubMed nor on https://www.crossref.org/guestquery/). @openjournals/joss-eics - do you have additional suggestions where to look, or is it ok to leave it like this?
Thanks, @csoneson! Are there additional changes that I should make to complete the review process?
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
Hi @fboehm, I made a few fixes to the bib file in https://github.com/fboehm/qtl2pleio/pull/20 (DOIs should not include the full URL in the bibtex file, just the DOI itself).
Hi @fboehm - I have sent another email to @rcorty to get his feedback on the revised submission. If he doesn't reply, we'll find another way forward. @vjcitn - could you take one more look to see if your remaining issues have now been satisfactorily addressed (and if so, complete the final items in the checklist). Thanks!
@kyleniemeyer Thanks for your input! Do you have a suggestion for where to possibly find DOIs for old articles, or is it ok to leave it without?
For the DOIs for the articles from 1995, I also can't find them (neither on PubMed nor on https://www.crossref.org/guestquery/). @openjournals/joss-eics - do you have additional suggestions where to look, or is it ok to leave it like this?
@csoneson I went to the publisher's page for those articles, and they don't have one listed, so I don't think they have DOIs. Some publishers went back and generated DOIs for articles that were published prior to the adoption of DOIs, but apparently this one didn't. So I think it's fine—they just don't have DOIs.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
I believe this article and package are passing all requirements and I've updated my check boxes to reflect this.
I have updated check boxes. Package/paper passes.
@rcorty, @vjcitn - thank you for your reviews!
@fboehm - I'll make another pass through the paper and make sure that nothing is missing, and then we're ready to go. To prepare for acceptance, could you please make a Zenodo archive, and report the DOI in this thread. Make sure that the title and authors of the Zenodo archive match those of the paper.
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@fboehm - one more small thing to fix in the references:
I'm not quite sure why the Bates & Eddelbuettel reference shows up as "D. Bates & Eddelbuettel" in the text - if I compile the paper locally this doesn't happen, and the bib file looks fine.
@csoneson - Thanks so much! I’ve fixed the bib file by making the first S a capital letter.
Zenodo assigned this DOI: 10.5281/zenodo.3263924
Thank you, @vjcitn and @rcorty for your very helpful & constructive reviews!
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@whedon check references
Attempting to check references...
OK DOIs
- 10.1214/aos/1176344552 is OK
- 10.1534/genetics.115.183624 is OK
- 10.1038/nmeth.2848 is OK
- 10.1534/genetics.107.080101 is OK
- 10.1534/g3.119.400098 is OK
- 10.32614/rj-2011-002 is OK
- 10.18637/jss.v040.i08 is OK
- 10.18637/jss.v052.i05 is OK
MISSING DOIs
- None
INVALID DOIs
- None
@whedon set 10.5281/zenodo.3263924 as archive
OK. 10.5281/zenodo.3263924 is the archive.
@whedon set v1.0.3 as version
OK. v1.0.3 is the version.
@whedon accept
Attempting dry run of processing paper acceptance...
OK DOIs
- 10.1214/aos/1176344552 is OK
- 10.1534/genetics.115.183624 is OK
- 10.1038/nmeth.2848 is OK
- 10.1534/genetics.107.080101 is OK
- 10.1534/g3.119.400098 is OK
- 10.32614/rj-2011-002 is OK
- 10.18637/jss.v040.i08 is OK
- 10.18637/jss.v052.i05 is OK
MISSING DOIs
- None
INVALID DOIs
- None
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/802
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/802, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true
@openjournals/joss-eics - we are ready for acceptance here! The only weird thing is that the Bates & Eddelbuettel reference in the paper shows up as "D. Bates & Eddelbuettel" - however, the "D." is not included if I build the markdown locally.
@csoneson yeah, that's strange. Not sure why it's happening. Unless that's a major issue, I think we should just proceed.
@whedon accept deposit=true
Doing it live! Attempting automated processing of paper acceptance...
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨
Here's what you must now do:
Party like you just published a paper! 🎉🌈🦄💃👻🤘
Any issues? notify your editorial technical team...
@fboehm congrats on your submission's publication in JOSS! Thanks to @vjcitn and @rcorty for reviewing, and @csoneson for editing.
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](http://joss.theoj.org/papers/10.21105/joss.01435/status.svg)](https://doi.org/10.21105/joss.01435)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01435">
<img src="http://joss.theoj.org/papers/10.21105/joss.01435/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: http://joss.theoj.org/papers/10.21105/joss.01435/status.svg
:target: https://doi.org/10.21105/joss.01435
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Submitting author: @fboehm (Frederick Boehm) Repository: https://github.com/fboehm/qtl2pleio Version: v1.0.3 Editor: @csoneson Reviewer: @vjcitn, @rcorty Archive: 10.5281/zenodo.3263924
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@vjcitn & @rcorty, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @vjcitn
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @rcorty
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?