openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: f90nml - A Python module for Fortran namelists #1472

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @marshallward (Marshall Ward) Repository: https://github.com/marshallward/f90nml Version: v1.1 Editor: @danielskatz Reviewers: @zbeekman, @tclune

Author instructions

Thanks for submitting your paper to JOSS @marshallward. Currently, there isn't an JOSS editor assigned to your paper.

@marshallward if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
danielskatz commented 5 years ago

Ok, let's see if Damian is available, or we will stick with you. In any case, we need another reviewer. Suggestions from @marshallward or @zbeekman ?

danielskatz commented 5 years ago

@tclune, @kc9qey - would either of you be willing to review this submission to JOSS? (A JOSS review covers the short paper and the code repository, using this set of criteria)

tclune commented 5 years ago

Dan,

I’d be happy to.

Cheers,

On May 24, 2019, at 10:18 AM, Daniel S. Katz notifications@github.com<mailto:notifications@github.com> wrote:

@tclunehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_tclune&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=EDCdNzkccJ25Co3sjWrr1HlJQ3_CoIFWfekFE1ulcLI&m=wd5zQUrrlmafBQD2-dUD6Mhnv44ywmKp9WuBuPFjHY8&s=iz-nAB-DBzjPrLmnSYkJPRexmyleuQlpJ7h-O87wL7k&e=, @kc9qeyhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_kc9qey&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=EDCdNzkccJ25Co3sjWrr1HlJQ3_CoIFWfekFE1ulcLI&m=wd5zQUrrlmafBQD2-dUD6Mhnv44ywmKp9WuBuPFjHY8&s=Tc1sC6Y1UBHLnUQDdagWP_4ApUlCQVABQlCSk0bSuR8&e= - would either of you be willing to review this submission to JOSS? (A JOSS review covers the short paper and the code repository, using this set of criteriahttps://urldefense.proofpoint.com/v2/url?u=https-3A__joss.readthedocs.io_en_latest_review-5Fcriteria.html&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=EDCdNzkccJ25Co3sjWrr1HlJQ3_CoIFWfekFE1ulcLI&m=wd5zQUrrlmafBQD2-dUD6Mhnv44ywmKp9WuBuPFjHY8&s=y-4QWVqF1zspZ-fahatn1WVL9wjgspLz338e-V_souc&e=)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openjournals_joss-2Dreviews_issues_1472-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DABPP7YASFUOA7AQIP3VTN63PW72MDA5CNFSM4HOYUNZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFQHUY-23issuecomment-2D495649747&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=EDCdNzkccJ25Co3sjWrr1HlJQ3_CoIFWfekFE1ulcLI&m=wd5zQUrrlmafBQD2-dUD6Mhnv44ywmKp9WuBuPFjHY8&s=p05-UNcrMRVDXbi0QSTGxBLvOm_PA8tjfVp-aedSQQs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABPP7YBADA4KCHMYK5OXFODPW72MDANCNFSM4HOYUNZQ&d=DwMCaQ&c=ApwzowJNAKKw3xye91w7BE1XMRKi2LN9kiMk5Csz9Zk&r=EDCdNzkccJ25Co3sjWrr1HlJQ3_CoIFWfekFE1ulcLI&m=wd5zQUrrlmafBQD2-dUD6Mhnv44ywmKp9WuBuPFjHY8&s=6JqCnO5PDTmgHXYpwmVVMftOUPdBE17nDcKM2OTir6k&e=.

danielskatz commented 5 years ago

Thanks @tclune - with 2 reviewers now, we'll get going.

danielskatz commented 5 years ago

@whedon add @tclune as reviewer

whedon commented 5 years ago

OK, @tclune is now a reviewer

danielskatz commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1474. Feel free to close this issue now!

rouson commented 5 years ago

@danielskatz It sounds like you have enough reviewers. If not, another person I would recommend is Craig Rasmussen. I'm not sure if my tagging him here work, but here goes: @rasmussn. My experience with python is very limited so I'm probably not the best reviewer.

danielskatz commented 5 years ago

Yes, we're all set, but thanks anyhow.