search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[REVIEW]: pulse #1539

Closed whedon closed 4 years ago

whedon commented 5 years ago

Submitting author: @finsberg (Henrik Nicolay Topnes Finsberg) Repository: https://github.com/finsberg/pulse Version: 2019.0 Editor: @trallard Reviewer: @melund, @trallard Archive: 10.5281/zenodo.3376811

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/9abee735e6abadabe9252d5fcc84fd40"><img src="http://joss.theoj.org/papers/9abee735e6abadabe9252d5fcc84fd40/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/9abee735e6abadabe9252d5fcc84fd40/status.svg)](http://joss.theoj.org/papers/9abee735e6abadabe9252d5fcc84fd40)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@melund & @trallard , please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @trallard know.

āœØ Please try and complete your review in the next two weeks āœØ

Review checklist for @melund

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @trallard

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @melund, @trallard it looks like you're currently assigned to review this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews šŸ˜æ

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

trallard commented 5 years ago

Hi @melund your reviewer checklist is at the top šŸ‘†šŸ¼ thanks a lot for your time and effort. Let's use this issue to keep the review alive and use the submitting repo for any longer reviews/discussions.

As per usual if you run into any problems feel free to ping me here!

melund commented 5 years ago

Thanks, @trallard. I may be a little while before I can get to this. I am going on sommer holiday on Friday. And I will most likely be away from my computer for at least two weeks.

I am sorry, but I am just too busy before I leave to get this done. I will look at it when I get back :)

trallard commented 5 years ago

Hi @melund just checking how you are doing? I am planning to move this forward this week - early the next

melund commented 5 years ago

@trallard I am traveling in Asia and I only have my phone. I am back in a week and then I will try to get look at this.

trallard commented 5 years ago

@whedon remind @melund in 2 weeks

whedon commented 5 years ago

Reminder set for @melund in 2 weeks

finsberg commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

finsberg commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

trallard commented 5 years ago

/ooo July 25 to August 19

ooo[bot] commented 5 years ago

:+1: Marked @trallard as OOO from Thursday, July 25th 2019 to Monday, August 19th 2019. :calendar:

whedon commented 5 years ago

:wave: @melund, please update us on how your review is going.

melund commented 5 years ago

I am done with my review. I think pulse more than qualifies for JOSS. It is a really good example of how to structure an open-source software project. With the recent addition of conda-forge package, I am also sure that the library will continue to work in the future.

All in all, nice work @finsberg šŸ‘

trallard commented 5 years ago

Thanks @melund I just noticed that the item for the license has not been checked on your list but I just double checked and this is in compliance. So @finsberg I am going to move to the following editorial activites.

Can you please make sure to perform the following actions:

  1. Generate a new DOI for the software and past it here
  2. Make sure that the package version is up to date and report here: if needed make a new release and report it here
  3. Do a last review of the paper
trallard commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
trallard commented 5 years ago

@whedon check references

whedon commented 5 years ago 
Attempting to check references...
whedon commented 5 years ago 

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1007/s10439-012-0593-5 may be missing for title: A novel rule-based algorithm for assigning myocardial fiber orientation to computational heart models
- https://doi.org/10.1016/j.jocs.2017.07.013 may be missing for title: Estimating cardiac contraction through high resolution data assimilation of a personalized mechanical model
- https://doi.org/10.1002/cnm.2982 may be missing for title: Efficient estimation of personalized biventricular mechanical function employing gradient-based optimization
- https://doi.org/10.1016/j.cam.2012.10.034 may be missing for title: A computational method to assess the in vivo stresses and unloaded configuration of patient-specific blood vessels

INVALID DOIs

- None
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

finsberg commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
finsberg commented 5 years ago

@whedon check references

whedon commented 5 years ago 
Attempting to check references...
whedon commented 5 years ago 

OK DOIs

- 10.1007/s10439-012-0593-5 is OK
- 10.1016/j.jocs.2017.07.013  is OK
- 10.1002/cnm.2982 is OK
- 10.1016/j.cam.2012.10.034 is OK
- 10.1098/rspa.2015.0641 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

finsberg commented 5 years ago
  1. @trallard How do you want me do generate a DOI for the software? Zenodo?
  2. Package version number 2019.0 is up to date.
  3. I have done final review of the paper, and made a few corrections. The last article proof looks good. I also added the DOIs in the bib-file.
trallard commented 5 years ago

Hey @finsberg you can archive the software in Zenodo and add here the DOI for it

finsberg commented 5 years ago

DOI: 10.5281/zenodo.3376811

melund commented 5 years ago

@trallard I forgot to check the license box. Everything is fine now. Good work @finsberg

arfon commented 5 years ago

:wave: @trallard - I think this paper is waiting on you to make your last checks here.

trallard commented 5 years ago

Hi everyone thanks for the ping! I will finalise this today's evening

trallard commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago 
Attempting PDF compilation. Reticulating splines etc...
trallard commented 4 years ago

@whedon check references

whedon commented 4 years ago 
Attempting to check references...
whedon commented 4 years ago 

OK DOIs

- 10.1007/s10439-012-0593-5 is OK
- 10.1016/j.jocs.2017.07.013  is OK
- 10.1002/cnm.2982 is OK
- 10.1016/j.cam.2012.10.034 is OK
- 10.1098/rspa.2015.0641 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

trallard commented 4 years ago

@whedon set 10.5281/zenodo.3376811 as archive

whedon commented 4 years ago

OK. 10.5281/zenodo.3376811 is the archive.

trallard commented 4 years ago

@whedon set 2019.0 as version

whedon commented 4 years ago

OK. 2019.0 is the version.

trallard commented 4 years ago

@finsberg I have completed my editorial checks and I am willing to recommend this for publication šŸŽ‰

@melund thanks for your contribution as a reviewer šŸ™ŒšŸ¼

@openjournals/jose-eics I am passing this submission to you for acceptance

danielskatz commented 4 years ago

@whedon accept