[REVIEW]: UncertainData.jl: a Julia package for working with measurements and datasets with uncertainties

whedon commented 5 years ago

Submitting author: @kahaaga (Kristian Agasøster Haaga) Repository: https://github.com/kahaaga/UncertainData.jl Version: v0.8.2 Editor: @oliviaguest Reviewer: @dmbates, @ahwillia Archive: 10.5281/zenodo.3522252

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0046149504db950e2415465e045b1b95"><img src="https://joss.theoj.org/papers/0046149504db950e2415465e045b1b95/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0046149504db950e2415465e045b1b95/status.svg)](https://joss.theoj.org/papers/0046149504db950e2415465e045b1b95)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dmbates & @ahwillia, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @oliviaguest know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @dmbates

Conflict of interest

[x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Version: v0.8.2
[x] Authorship: Has the submitting author (@kahaaga) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Authors: Does the paper.md file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

Review checklist for @ahwillia

Conflict of interest

[x] As the reviewer I confirm that I have read the JOSS conflict of interest policy and that there are no conflicts of interest for me to review this work.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Version: v0.8.2
[x] Authorship: Has the submitting author (@kahaaga) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Authors: Does the paper.md file include a list of authors with their affiliations?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] References: Do all archival references that should have a DOI list one (e.g., papers, datasets, software)?

whedon commented 5 years ago


OK DOIs

- 10.5281/zenodo.2647458 is OK

MISSING DOIs

- https://doi.org/10.1137/141000671 may be missing for title: Julia: A fresh approach to numerical computing

INVALID DOIs

- None

whedon commented 5 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1064

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1064, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

oliviaguest commented 5 years ago

@kahaaga can you check out that missing DOI thing and generally check it all looks fine still, please?

kahaaga commented 5 years ago

@oliviaguest I've added the missing DOI now.

Also, in the final proof, one of the references in the first wasn't formatted correctly. I've tried to fix this by changing the citation from [@author1, @author2] to [@author1; @author2], as per the documentation. Can we generate the proof again and check before depositing?

arfon commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago

Attempting PDF compilation. Reticulating splines etc...

whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

arfon commented 5 years ago

☝️ @kahaaga - you can do this yourself with @whedon generate pdf

oliviaguest commented 5 years ago

@kahaaga looking better now?

kahaaga commented 5 years ago

@arfon Thanks for the info, I'll remember that for my next paper!

@oliviaguest The paper is looking great now. It's good to go 👍

oliviaguest commented 5 years ago

@whedon accept deposit=true

whedon commented 5 years ago

I'm sorry @oliviaguest, I'm afraid I can't do that. That's something only editor-in-chiefs are allowed to do.

oliviaguest commented 5 years ago

@arfon :rofl: — need your help!

danielskatz commented 5 years ago

@oliviaguest - please notify @openjournals/joss-eics when a submission is ready for acceptance (since we have a rotation of AEiCs). Is that the case with this one?

oliviaguest commented 5 years ago

@danielskatz yup, ta!

danielskatz commented 5 years ago

@whedon accept

whedon commented 5 years ago

Attempting dry run of processing paper acceptance...

whedon commented 5 years ago


OK DOIs

- 10.1137/141000671 is OK
- 10.5281/zenodo.2647458 is OK

MISSING DOIs

- None

INVALID DOIs

- None

whedon commented 5 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1073

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1073, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

danielskatz commented 5 years ago

@whedon accept deposit=true

whedon commented 5 years ago

Doing it live! Attempting automated processing of paper acceptance...

whedon commented 5 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 5 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1074
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01666
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? notify your editorial technical team...

danielskatz commented 5 years ago

Thanks to @dmbates and @ahwillia for reviewing, and @oliviaguest for editing!

danielskatz commented 5 years ago

Congratulations @kahaaga!

whedon commented 5 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01666/status.svg)](https://doi.org/10.21105/joss.01666)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01666">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01666/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01666/status.svg
   :target: https://doi.org/10.21105/joss.01666

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

kahaaga commented 5 years ago

Thanks to you all: @dmbates, @ahwillia for the reviews, to @danielskatz for help with the initial submission, and to @oliviaguest for managing everything and making the publication process so smooth 😃

openjournals / joss-reviews