search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: The Walrus: the fastest calculation of hafnians, Hermite polynomials and Gaussian boson sampling #1668

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @nquesada (Nicolás Quesada) Repository: https://github.com/xanaduAI/thewalrus Version: 0.7.0 Editor: @katyhuff Reviewers: @PhilipVinc, @poulson

Author instructions

Thanks for submitting your paper to JOSS @nquesada. Currently, there isn't an JOSS editor assigned to your paper.

@nquesada if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 5 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
kyleniemeyer commented 5 years ago

Hi @VivianePons, can you edit this submission?

ooo[bot] commented 5 years ago

:wave: Hey @kyleniemeyer...

Letting you know, @VivianePons is currently OOO until Thursday, October 3rd 2019. :heart:

whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kyleniemeyer commented 5 years ago

@poulson can you edit this submission?

nquesada commented 5 years ago

Hey @kyleniemeyer thanks for helping out in finding an editor for our submission! I assume I can post here the people I can think could be helpful in reviewing, correct?

kyleniemeyer commented 5 years ago

@nquesada sure, suggestions for potential reviewers are always welcome!

nquesada commented 5 years ago

Great! From the list of potential reviewers JOSS has, I think either @goerz or @PhilipVinc would make good reviewers given their background in quantum optics.

goerz commented 5 years ago

I'm currently reviewing another paper, so unfortunately I can't take this on at the moment

PhilipVinc commented 5 years ago

I am available for reviewing the paper.

kyleniemeyer commented 5 years ago

Thanks @PhilipVinc!

kyleniemeyer commented 5 years ago

@whedon add @PhilipVinc as reviewer

nquesada commented 5 years ago

Thanks @PhilipVinc !

nquesada commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

nquesada commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

nquesada commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

PDF failed to compile for issue #1668 with the following error:

Error reading bibliography ./paper.bib (line 208, column 1): unexpected end of input expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

nquesada commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

labarba commented 5 years ago

@whedon assign @poulson as editor

whedon commented 5 years ago

OK, the editor is @poulson

poulson commented 5 years ago

Oh my -- this is my kind of submission, and even local to Toronto! I apologize for the delay and -- reading through it -- am immediately curious about the interpretations of combining the halfnian generalization of the permanent with the immanantal generalization -- via characters of the symmetric group -- of permanents and determinants. I suppose one would just introduce an arbitrary character of the symmetric group rather than chi(sigma) == 1 in the case of the halfnian.

I will send out invitations to reviewers as soon as I finish reading the paper.

nquesada commented 5 years ago

Hey @poulson, thanks for agreeing to be editor of our paper; also, very happy to hear you find our paper interesting!

poulson commented 5 years ago

Hi Max Scheurer (@maxscheurer): given your CPPE project (https://github.com/maxscheurer/cppe), which exposes a python interface for an Eigen-based C++ quantum chemistry simulation, it looks like your expertise would be helpful for reviewing this submission.

While the submission is more focused around combinatorial determinant calculations of structured matrices, my guess is that this isn't too much of a stretch for you.

Please let me know if you have the time and interest to review this submission, and would feel confident doing so.

maxscheurer commented 5 years ago

Hi, I think this is out of my field of expertise, so I don't feel capable to review the manuscript. Sorry...

PhilipVinc commented 5 years ago

@poulson, should you ask Whedon to start the review issue so that I can fill the checklist?

I have a few minor comments on this library, especially on the documentation, which otherwise seems a very fine piece of software. Normally I would leave those on the Review issue?

katyhuff commented 5 years ago

@whedon assign @katyhuff as editor

whedon commented 5 years ago

OK, the editor is @katyhuff

katyhuff commented 5 years ago

@whedon add @poulson as reviewer

whedon commented 5 years ago

OK, @poulson is now a reviewer

katyhuff commented 5 years ago

Hi Folks (@PhilipVinc @nquesada ), I am stepping in as editor because this content is fairly niche, but Jack (@paulson)and I believe he will be an excellent second reviewer for this work. It was a great idea on Jack's part, and I'm happy to take over handing this one. Now that we have two reviewers and one editor, let's get started on the review.

katyhuff commented 5 years ago

@whedon start review

whedon commented 5 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1705. Feel free to close this issue now!

katyhuff commented 5 years ago

Ok folks, let's move over to #1705 , where @PhilipVinc and @poulson will conduct the review.