Closed whedon closed 4 years ago
@whedon check references
Attempting to check references...
OK DOIs
- 10.3390/robotics8020033 is OK
- 10.1007/978-3-319-54413-7 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1109/IROS.2018.8593598 is OK
MISSING DOIs
- https://doi.org/10.1109/jra.1987.1087086 may be missing for title: Introduction to Robotics Mechanics and Control
INVALID DOIs
- None
@nnadeau thanks! The SciPy citation is still not quite right, since our template doesn't play well with the recommended year format. Perhaps just change it to "2001" ?
@whedon generate pdf
Attempting PDF compilation. Reticulating splines etc...
@kyleniemeyer done
@whedon accept
No archive DOI set. Exiting...
ah, whoops! @nnadeau, please archive your repo using a service such as Zenodo, and let me know what the associated DOI is.
@kyleniemeyer
0.7.2
(includes all changes from this review process)10.5281/zenodo.3464672
@whedon set 10.5281/zenodo.3464672 as archive
OK. 10.5281/zenodo.3464672 is the archive.
@nnadeau sorry to drag this out, but it looks like you released v0.7.3βshould that be what we use?
@kyleniemeyer sure! that was outside the scope of this review process (i.e., travis CI update), but sure, go ahead!
DOI: 10.5281/zenodo.3464685
@whedon set 10.5281/zenodo.3464685 as archive
OK. 10.5281/zenodo.3464685 is the archive.
@whedon accept
Attempting dry run of processing paper acceptance...
OK DOIs
- 10.3390/robotics8020033 is OK
- 10.1007/978-3-319-54413-7 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1109/IROS.2018.8593598 is OK
MISSING DOIs
- https://doi.org/10.1109/jra.1987.1087086 may be missing for title: Introduction to Robotics Mechanics and Control
INVALID DOIs
- None
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/990
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/990, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true
@kyleniemeyer looks good! Thank you everyone for this review process.
@whedon accept deposit=true
Doing it live! Attempting automated processing of paper acceptance...
π¦π¦π¦ π Tweet for this paper π π¦π¦π¦
π¨π¨π¨ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! π¨π¨π¨
Here's what you must now do:
Party like you just published a paper! πππ¦ππ»π€
Any issues? notify your editorial technical team...
Congrats @nnadeau on your article's publication in JOSS! Thanks to @adi3 and @CameronDevine for reviewing!
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01738/status.svg)](https://doi.org/10.21105/joss.01738)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01738">
<img src="https://joss.theoj.org/papers/10.21105/joss.01738/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01738/status.svg
:target: https://doi.org/10.21105/joss.01738
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Submitting author: @nnadeau (Nicholas A. Nadeau) Repository: https://github.com/nnadeau/pybotics Version: 0.7.1 Editor: @kyleniemeyer Reviewer: @adi3, @CameronDevine Archive: 10.5281/zenodo.3464685
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@adi3 & @CameronDevine, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kyleniemeyer know.
β¨ Please try and complete your review in the next two weeks β¨
Review checklist for @adi3
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @CameronDevine
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper