openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
704 stars 37 forks source link

[PRE REVIEW]: simode: R Package for Statistical Inference of Ordinary Differential Equations using Separable Integral-Matching #1772

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @ramiyaari (Rami Yaari) Repository: https://github.com/ramiyaari/simode/ Version: v1.1.6 Editor: @mjsottile Reviewers: @cscherrer, @jgoldfar, @osorensen

Author instructions

Thanks for submitting your paper to JOSS @ramiyaari. Currently, there isn't an JOSS editor assigned to your paper.

@ramiyaari if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

Failed to discover a valid open source license.

whedon commented 4 years ago

PDF failed to compile for issue #1772 with the following error:

Could not find bibliography file: simode.bib Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

danielskatz commented 4 years ago

@ramiyaari - I see some high-level issues here:

Please see https://joss.readthedocs.io/en/latest/submitting.html#typical-paper-submission-flow

Also, in your paper, you say the bib is "bibliography: simode.bib" but it's actually "paper.bib" - please fix this, then enter @whedon generate pdf as a new comment in this issue to recompile.

ramiyaari commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #1772 with the following error:

Error producing PDF. ! LaTeX Error: Bad math environment delimiter.

See the LaTeX manual or LaTeX Companion for explanation. Type H for immediate help. ...

l.466 \begin{equation}

Looks like we failed to compile the PDF

ramiyaari commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #1772 with the following error:

Error producing PDF. ! Missing \endgroup inserted.

\endgroup l.482 \begin{eqnarray} Looks like we failed to compile the PDF
ramiyaari commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ramiyaari commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ramiyaari commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

ramiyaari commented 4 years ago

@danielskatz thanks for your comments I believe I fixed all these issues

ramiyaari commented 4 years ago

@whedon commands

whedon commented 4 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references
ramiyaari commented 4 years ago

Please update the software version to 1.1.6 Suggested Reviewers: Jgoldfar, trashbirdecology, MikeLydeamore, MaaniBeigy, llauriciu, matloff, ellessenne, osorensen, RomainAzais

danielskatz commented 4 years ago

@whedon set v1.1.6 as version

whedon commented 4 years ago

OK. v1.1.6 is the version.

danielskatz commented 4 years ago

I still don't see a readme or a license in the source repo.

ramiyaari commented 4 years ago

There is a README.txt and a LICENSE.txt file under inst/joss in the repo, together with paper.md

ramiyaari commented 4 years ago

@danielskatz: There is a README.txt and a LICENSE.txt file under inst/joss in the repo, together with paper.md

danielskatz commented 4 years ago

These need to be at the top level of the repo

ramiyaari commented 4 years ago

OK, fixed it

labarba commented 4 years ago

👋 @mjsottile — Could you handle this submission as editor? simode: R Package for Statistical Inference of Ordinary Differential Equations using Separable Integral-Matching Repository: https://github.com/ramiyaari/simode/

mjsottile commented 4 years ago

Yes, I can take this submission as editor.

labarba commented 4 years ago

@whedon assign @mjsottile as editor

whedon commented 4 years ago

OK, the editor is @mjsottile

mjsottile commented 4 years ago

👋@cscherrer would you be interested in reviewing this paper?

mjsottile commented 4 years ago

@whedon add @cscherrer as reviewer

whedon commented 4 years ago

OK, @cscherrer is now a reviewer

mjsottile commented 4 years ago

@whedon assign @cscherrer as reviewer

whedon commented 4 years ago

OK, the reviewer is @cscherrer

mjsottile commented 4 years ago

Other possible reviewers from the spreadsheet: @jgoldfar - you appear to have knowledge of differential equations and R. @fabian-s - you appear to have knowledge of R and inference methods. Interested in taking this on to help review?

jgoldfar commented 4 years ago

I would be able to take this on at the beginning of November; I'd be happy to help if there is still a need for review.

On Oct 16, 2019, at 12:09 AM, Matthew Sottile notifications@github.com wrote:

Other possible reviewers from the spreadsheet: @jgoldfar https://github.com/jgoldfar - you appear to have knowledge of differential equations and R. @fabian-s https://github.com/fabian-s - you appear to have knowledge of R and inference methods. Interested in taking this on to help review?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1772?email_source=notifications&email_token=ABKORGJBHNLI3VV2BR544G3QO2HY7A5CNFSM4I3SPZ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBK7HSA#issuecomment-542503880, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKORGL2H4XEZAAD5Y3IJTDQO2HY7ANCNFSM4I3SPZ5A.

mjsottile commented 4 years ago

Thanks @jgoldfar. That timeline should be fine in November.

mjsottile commented 4 years ago

@whedon add @jgoldfar as reviewer

whedon commented 4 years ago

OK, @jgoldfar is now a reviewer

mjsottile commented 4 years ago

Hi, @trashbirdecology, @MikeLydeamore, @MaaniBeigy, @llauriciu, @matloff, @ellessenne, @osorensen, @RomainAzais - you were suggested as potential reviewers for this JOSS submission. Let me know if you're interested in reviewing this submission. I am looking for at least one reviewer to add before I start the review process.

osorensen commented 4 years ago

Yes, I am interested.

MaaniBeigy commented 4 years ago

Yes, I am interested.

MaaniBeigy commented 4 years ago

Yes, I am interested

On Wed, 30 Oct 2019, 07:33 Øystein Sørensen, notifications@github.com wrote:

Yes, I am interested.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1772?email_source=notifications&email_token=AI6QPJQF3GOSJPYQO62VO5LQREBQXA5CNFSM4I3SPZ5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECS3GGY#issuecomment-547730203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI6QPJQIJE2CV5K4PA43QOTQREBQXANCNFSM4I3SPZ5A .

mjsottile commented 4 years ago

Thanks @osorensen - I'll add you. @MaaniBeigy , I will hold off adding you unless we need an additional reviewer during the process.