[PRE REVIEW]: SunPy: A Python package for Solar Physics

[whedon]

Submitting author: @Cadair (Stuart Mumford) Repository: https://github.com/sunpy/sunpy Version: v1.0.0 Editor: @arfon Reviewers: @mwcraig, @ceb8

Author instructions

Thanks for submitting your paper to JOSS @Cadair. The JOSS editor @arfon, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@Cadair if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @arfon it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@arfon) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[arfon]

:wave: @Cadair - thanks for your submission to JOSS. Does this JOSS submission accompany a publication in a AAS journal?

[whedon]

PDF failed to compile for issue #1789 with the following error:

Can't find any papers to compile :-(

[arfon]

@whedon generate pdf from branch joss_paper

[whedon]

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[arfon]

Also, @Cadair, could you identify potential reviewers for this submission? Given your epic author list (I'll fix the left-hand margin issue when this paper is published), I suspect finding reviewers might be tough... 😅

[ehsteve]

@arfon FYI, there is a companion paper that was submitted and accepted by ApJ. I am the corresponding author for that paper.

[Cadair]

@arfon Is there a list of reviewers somewhere? People related to the astro ecosystem, i.e. astropy or yt contributors would be at the top of the list I would think of.

[arfon]

@arfon FYI, there is a companion paper that was submitted and accepted by ApJ. I am the corresponding author for that paper.

/ cc @crawfordsm

[arfon]

@Cadair this list of people posted at the top of this thread have volunteered but feel free to suggest people from outside of this list who you think could give a good review.

[arfon]

Also, given this is a joint submission with AAS Journals, could you add metadata like this to the YAML header of the paper.md file @Cadair?

aas-doi: DOI of AAS paper
aas-journal: Name of journal (e.g. Astronomical Journal)

[Cadair]

maybe (without mentioning them) mwcraig ceb8 or dhuppenkothen

I will add the aas metadata (although I don't know the DOI)

[Cadair]

Also ngoldbaum ~or drsophiemurray (who I am not 100% sure shouldn't be on the author list)~

[arfon]

@ceb8 @dhuppenkothen - would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

[ehsteve]

@Cadair I'll ask for the DOI though we aren't published yet but accepted.

[ceb8]

@arfon Yes I can review. When do you need the review by?

[arfon]

@arfon Yes I can review. When do you need the review by?

👍, ideally in the next 2-3 weeks?

[arfon]

:wave: @ngoldbaum - would you be willing to review this submission for JOSS?

[ngoldbaum]

Unfortunately I can't commit to reviewing this right now as I don't have the bandwidth. Good luck finding another reviewer.

[arfon]

Unfortunately I can't commit to reviewing this right now as I don't have the bandwidth. Good luck finding another reviewer.

NP, thanks for the quick response.

[arfon]

:wave: @mwcraig - would you be willing to review this submission for JOSS?

[mwcraig]

@arfon -- I'd be delighted but fear I've got a conflict of interest here. Stuart and I are co-authors on the most recent astropy paper, but perhaps more importantly, have worked together on some of the pieces of Astropy that interface most directly with SunPy.

[mwcraig]

I think I could be unbiased (the JOSS review criteria are pretty straightforward) but felt obligated to make you aware of al the appearance of a conflict of interest.

[arfon]

OK thanks for letting me know @mwcraig. Let me ping @dhuppenkothen one more time to see if she's available, but I might come back to you later :-)

[arfon]

I think I could be unbiased (the JOSS review criteria are pretty straightforward) but felt obligated to make you aware of al the appearance of a conflict of interest.

@mwcraig - Thanks again for the offer to help here. I'd like to take you up on your offer :-)

[arfon]

@whedon assign @mwcraig as reviewer

[whedon]

OK, the reviewer is @mwcraig

[arfon]

@whedon add @ceb8 as reviewer

[whedon]

OK, @ceb8 is now a reviewer

[arfon]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1832. Feel free to close this issue now!

[arfon]

@mwcraig, @ceb8 - many thanks for agreeing to review this submission. Please head over to #1832 where the actual review will take place.