[PRE REVIEW]: momepy: Urban Morphology Measuring Toolkit

[whedon]

Submitting author: @martinfleis (Martin Fleischmann) Repository: https://github.com/martinfleis/momepy Version: v0.1 Editor: @drvinceknight Reviewers: @martibosch, @geraintpalmer

Author instructions

Thanks for submitting your paper to JOSS @martinfleis. Currently, there isn't an JOSS editor assigned to your paper.

@martinfleis if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #1793 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1793/paper/paper.md): mapping values are not allowed in this context at line 2 column 15 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:inparse_stream' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:inload' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:inopen' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon.rb:115:inload_yaml' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon/processor.rb:36:innew' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/bin/whedon:55:inprepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

[arfon]

@labarba - you can mention @openjournals/dev for issues like this.

[martinfleis]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[labarba]

Thanks! I'm not sure what Is going on here... 😕

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[martinfleis]

@arfon @labarba That was my mistake, my markdown editor changed '' to ‘’.

[martinfleis]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

PDF failed to compile for issue #1793 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1793/paper/paper.md): mapping values are not allowed in this context at line 2 column 15 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:inparse_stream' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:inload' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:inopen' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon.rb:115:inload_yaml' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon/processor.rb:36:innew' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/bin/whedon:55:inprepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-1e4ee47b240d/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

[martinfleis]

@whedon generate pdf

[whedon]

Attempting PDF compilation. Reticulating splines etc...

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[martinfleis]

Based on the list of potential reviewers, it seems that following are the closest match based on their research profile and Python as the preferred language. Hope this helps. @sjsrey, @martibosch, @hertzsprung, @kbevers, @Scivision

[labarba]

👋 @drvinceknight — We don't have any editors with field expertise related to architecture or urban planning, and I'm wondering if you could save the day here, given your multi-faceted disposition. Could you handle this as editor? momepy: Urban Morphology Measuring Toolkit https://github.com/martinfleis/momepy

[drvinceknight]

What an interesting sounding piece of software: I'd be very happy to handle this paper :+1:

[kbevers]

This is outside my area of expertise so I will not be reviewing this paper. Thanks for considering me as a potential reviewer.

[labarba]

@whedon assign @drvinceknight as editor

[whedon]

OK, the editor is @drvinceknight

[drvinceknight]

@martinfleis looking through the paper and the documentation, I do not immediately find a simple getting started example. I realise there are many such examples a bit deeper in the documentation. Perhaps you could finish the tutorial? https://docs.momepy.org/en/latest/tutorial.html

I think that this would also be helpful for the review.

[martinfleis]

@drvinceknight Tutorial should not be there, there is the user guide instead (I forgot to remove the link). It is true that a simple getting started example is not present, I will add it to the user guide.

[drvinceknight]

Thank you :+1:

[drvinceknight]

@geraintpalmer would you be able to review this paper for JOSS?

[martibosch]

👋 this looks very linked to my research, I'd also be happy to review it :)

[drvinceknight]

Fantastic, thanks @martibosch :+1:

[drvinceknight]

@whedon assign @martibosch as reviewer

[whedon]

OK, the reviewer is @martibosch

[drvinceknight]

@martibosch I don't know if you have reviewed for JOSS before but there is documentation on the process here https://joss.readthedocs.io/en/latest/index.html and I'm happy to answer any questions. Once I have sufficient reviewers I will open a new issue where the review will take place.

[martibosch]

this is the second time that I have been assigned to review a JOSS paper - the first was last week. Therefore, this will probably be my second JOSS paper as reviewer. I will follow the guidelines of the documentation and get back to you if I have any other question. Cheers!

[drvinceknight]

Ok fantastic, sorry for the slight overload with the request to review two papers at the same time. Your contribution is super appreciated.

[martibosch]

no worries - first of all I am happy to contribute to JOSS, and secondly, in this case I kindly offered because this library is really closely related to my PhD topic, so it is useful for me to be aware of the state of the art.

[geraintpalmer]

@geraintpalmer would you be able to review this paper for JOSS?

Yes I'm happy to do this.

[drvinceknight]

Fantastic, thanks @geraintpalmer :+1:

[drvinceknight]

@whedon add @geraintpalmer as reviewer

[whedon]

OK, @geraintpalmer is now a reviewer

[drvinceknight]

@whedon start review

[drvinceknight]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1807. Feel free to close this issue now!

[drvinceknight]

@geraintpalmer @martibosch the review will take place on #1807 any questions about the process please don't hesitate to ping me.

[martinfleis]

@drvinceknight For some reason the review issue is duplicated in #1806 and #1807. The first one should be probably closed.

[drvinceknight]

Thanks @martinfleis, have taken care of it.