openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: modelStudio: Interactive Studio with Explanations for ML Predictive Models #1798

Closed whedon closed 5 years ago

whedon commented 5 years ago

Submitting author: @hbaniecki (Hubert Baniecki) Repository: https://github.com/ModelOriented/modelStudio Version: v0.1.9 Editor: @terrytangyuan Reviewer: @acolum, @expectopatronum Archive: 10.5281/zenodo.3527770

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9eec8c9d1969fbd44b3ea438a74af911"><img src="https://joss.theoj.org/papers/9eec8c9d1969fbd44b3ea438a74af911/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9eec8c9d1969fbd44b3ea438a74af911/status.svg)](https://joss.theoj.org/papers/9eec8c9d1969fbd44b3ea438a74af911)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@acolum & @expectopatronum, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @terrytangyuan know.

Please try and complete your review in the next two weeks

Review checklist for @acolum

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @expectopatronum

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

hbaniecki commented 5 years ago

@terrytangyuan I have added missing DOIs to the .bib file.

terrytangyuan commented 5 years ago

@whedon check references

whedon commented 5 years ago
Attempting to check references...
whedon commented 5 years ago

OK DOIs

- 10.18653/v1/n16-3020 is OK
- 10.32614/rj-2018-072 is OK
- 10.21105/joss.01444 is OK
- 10.21105/joss.00786 is OK
- 10.32614/rj-2017-016 is OK

MISSING DOIs

- None

INVALID DOIs

- None
terrytangyuan commented 5 years ago

@whedon accept

whedon commented 5 years ago
Attempting dry run of processing paper acceptance...
whedon commented 5 years ago

OK DOIs

- 10.18653/v1/n16-3020 is OK
- 10.32614/rj-2018-072 is OK
- 10.21105/joss.01444 is OK
- 10.21105/joss.00786 is OK
- 10.32614/rj-2017-016 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 5 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1084

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1084, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
terrytangyuan commented 5 years ago

This paper looks good to me now! Handing over to @openjournals/joss-eics!

kyleniemeyer commented 5 years ago

Hi @hbaniecki, I made a few edits to the paper and references, if you could merge these: https://github.com/ModelOriented/modelStudio/pull/31 and https://github.com/ModelOriented/modelStudio/pull/32

hbaniecki commented 5 years ago

Hi @kyleniemeyer, I merged your PR.

kyleniemeyer commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kyleniemeyer commented 5 years ago

@hbaniecki sorry, one last fix I noticed when reviewing: https://github.com/ModelOriented/modelStudio/pull/33

hbaniecki commented 5 years ago

@kyleniemeyer np. I merged.

kyleniemeyer commented 5 years ago

@whedon generate pdf

whedon commented 5 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 5 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kyleniemeyer commented 5 years ago

@whedon accept

whedon commented 5 years ago
Attempting dry run of processing paper acceptance...
kyleniemeyer commented 5 years ago

@whedon accept

whedon commented 5 years ago
Attempting dry run of processing paper acceptance...
whedon commented 5 years ago

OK DOIs

- 10.18653/v1/n16-3020 is OK
- 10.32614/RJ-2018-072 is OK
- 10.21105/joss.01444 is OK
- 10.21105/joss.00786 is OK
- 10.32614/rj-2017-016 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 5 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1090

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1090, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
kyleniemeyer commented 5 years ago

@whedon accept deposit=true

whedon commented 5 years ago
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 5 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 5 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1091
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01798
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? notify your editorial technical team...

kyleniemeyer commented 5 years ago

Congrats @hbaniecki on your article's publication in JOSS! Many thanks to @acolum and @expectopatronum for reviewing this, and @terrytangyuan for editing.

whedon commented 5 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01798/status.svg)](https://doi.org/10.21105/joss.01798)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01798">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01798/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01798/status.svg
   :target: https://doi.org/10.21105/joss.01798

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

hbaniecki commented 5 years ago

wow even after so many reviews i can see a typo. @kyleniemeyer is it possible to fix the paper after the publication?

kyleniemeyer commented 5 years ago

Oh no! Um, I think so. Can you fix the source file and let us know? (@arfon?)

hbaniecki commented 5 years ago

I feel ashamed but hope that it can be updated. Fixed paper.md.

arfon commented 5 years ago

Oh no! Um, I think so. Can you fix the source file and let us know? (@arfon?)

No problem. Paper updated based on the latest paper.md in master. FWIW, the new PDF might not show up for a few hours as there's caching in place for the PDFs on the JOSS site.