openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: Chaste: Cancer, Heart and Soft Tissue Environment #1848

Closed whedon closed 4 years ago

whedon commented 5 years ago

Submitting author: @fcooper8472 (Fergus Cooper) Repository: https://github.com/Chaste/Chaste Version: release_2019.1 Editor: @meg-simula Reviewers: @finsberg, @IgorBaratta Archive: 10.5281/zenodo.3708497

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1a2ae4a7df2dc0623752782decfe2b86"><img src="https://joss.theoj.org/papers/1a2ae4a7df2dc0623752782decfe2b86/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1a2ae4a7df2dc0623752782decfe2b86/status.svg)](https://joss.theoj.org/papers/1a2ae4a7df2dc0623752782decfe2b86)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@finsberg & @SirSharpest, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @meg-simula know.

Please try and complete your review in the next two weeks

Review checklist for @finsberg

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @IgorBaratta

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @SirSharpest

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

danielskatz commented 4 years ago

Thanks - please let me know when that is done

danielskatz commented 4 years ago

@whedon set 10.5281/zenodo.3708497 as archive

whedon commented 4 years ago

OK. 10.5281/zenodo.3708497 is the archive.

mirams commented 4 years ago

@danielskatz I have updated the Zenodo metadata to match the paper title and authors.

danielskatz commented 4 years ago

@whedon accept

whedon commented 4 years ago
Attempting dry run of processing paper acceptance...
whedon commented 4 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published

. Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1369

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1369, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
danielskatz commented 4 years ago

@whedon accept deposit=true

whedon commented 4 years ago
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 4 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 4 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1370
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.01848
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? notify your editorial technical team...

danielskatz commented 4 years ago

Thanks to @finsberg & @IgorBaratta for reviewing! And to @meg-simula for editing!

ooo[bot] commented 4 years ago

:wave: Hey @danielskatz...

Letting you know, @finsberg is currently OOO until Friday, March 27th 2020. :heart:

ooo[bot] commented 4 years ago

:wave: Hey @danielskatz...

Letting you know, @meg-simula is currently OOO until Friday, March 27th 2020. :heart:

danielskatz commented 4 years ago

Congratulations to @fcooper8472! And again, apologies for your getting penalized with some extra work as we changed our guidelines.

whedon commented 4 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.01848/status.svg)](https://doi.org/10.21105/joss.01848)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.01848">
  <img src="https://joss.theoj.org/papers/10.21105/joss.01848/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.01848/status.svg
   :target: https://doi.org/10.21105/joss.01848

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: