openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
697 stars 36 forks source link

[PRE REVIEW]: OrNet - a Python Toolkit to Model the Diffuse Structure of Organelles as Social Networks #1902

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @Marcdh3 (Marcus Hill) Repository: https://github.com/quinngroup/ornet-JOSS Version: v0.1 Editor: @akeshavan Reviewers: @serine, @vc1492a

Author instructions

Thanks for submitting your paper to JOSS @Marcdh3. Currently, there isn't an JOSS editor assigned to your paper.

@Marcdh3 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 4 years ago
Attempting to check references...
whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

OK DOIs

- 10.1101/522763 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kthyng commented 4 years ago

Hi @marcdh3! Can you look through this list and suggest some appropriate reviewers for your submission? It helps to have about 5 suggestions if possible.

Please fix the citations in your paper; you can find more details here: https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography

kthyng commented 4 years ago

Hi @akeshavan and welcome onboard! Would you be interested in editing this?

Marcdh3 commented 4 years ago

Hi @kthyng! Thank you for the quick response. Here are my reviewer suggestions:

Also, I will be working on the citations now, and I'll update you once they are fixed.

Marcdh3 commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

Marcdh3 commented 4 years ago

@kthyng I believe we fixed the citations. Please let us know if there is anything else needing to be fixed.

kthyng commented 4 years ago

@whedon add @akeshavan as editor

kthyng commented 4 years ago

(@akeshavan approved by email)

akeshavan commented 4 years ago

:wave: @camillescott and @nidhog: would you be willing to review this paper for JOSS?

kthyng commented 4 years ago

@whedon add @akeshavan as editor

kthyng commented 4 years ago

@arfon is @akeshavan properly in the system? Can't seem to add her as editor here.

arfon commented 4 years ago

@whedon assign @akeshavan as editor

whedon commented 4 years ago

OK, the editor is @akeshavan

arfon commented 4 years ago

@whedon add @akeshavan as editor

@kthyng it's assign not add for the editor. Sorry for any confusion caused.

kthyng commented 4 years ago

@arfon Oh my goodness. Sorry about that! I almost always copy and paste the whedon commands to be sure they're correct but apparently these times I was sure I was correct! :) Thanks for helping.

arfon commented 4 years ago

@arfon Oh my goodness. Sorry about that! I almost always copy and paste the whedon commands to be sure they're correct but apparently these times I was sure I was correct! :) Thanks for helping.

😁no worries!

akeshavan commented 4 years ago

👋 @serine, @sonal-raj, and @vc1492a -- would you be willing to review this paper for JOSS?

serine commented 4 years ago

This looks interesting. I should be able to take a look at it next week, if I can get a hold of raw/example data. Image analysis isn't my field so I wouldn't know where to source the data from.

One super minor thing, but it feels rather weird to call the repository (repo) ornet-JOSS. I'm assuming JOSS suffix in the name referres to the fact that the tool will be submitted to JOSS for review? If this is the case I think it would be much better to drop JOSS from the repo name, while this is still early days for the repo.

Usually repo's name hints / describes what the content of the repo is and I'd say for a lot of the source code the repo name usually is the name of the tool/library. JOSS paper.md is a very small part of the repo.

Just think about establishing a name for your tool and advertising it to other people.

Cheers

akeshavan commented 4 years ago

@whedon assign @serine as reviewer

whedon commented 4 years ago

OK, the reviewer is @serine

vc1492a commented 4 years ago

@akeshavan thanks for reaching out about the opportunity to review this work. I'll be taking a long vacation in about a week's time and will not be returning until close to the end of January. If that's all right with you and the authors, I'm happy to review this work. However I'll be largely unavailable during that time due to travel.

The work is interesting although it's not typically a field I'm involved in, so my contributions for review in regards to it's utility in the field will be very limited. I can however review for code organization, completeness, documentation suitability, etc. In line with @serine, I'd need to get a hold of some example data in order to review this work effectively - ideally more than one sample in which to test.

Hope this helps!

akeshavan commented 4 years ago

Thanks @vc1492a ! It's holiday season, so I understand that we all will be taking time off.

@Marcdh3 could you upload some raw/example data so that the reviewers can take a look?

akeshavan commented 4 years ago

@whedon add @vc1492a as reviewer

whedon commented 4 years ago

OK, @vc1492a is now a reviewer

Marcdh3 commented 4 years ago

I've uploaded some videos that we've been using in the "samples" directory. Inside of that directory are three sub-directories labeled "control", "llo", and "mdivi". Each sub-directory contains a video (.mov) and an initial segmentation mask (.vtk). The sub-directories correspond to video data of HeLa cells that were either in the control group, exposed to pre-forming toxin listeri-olysin O (LLO), or exposed to mitochondria division inhibitor-1 (mdivi-1). These videos should do a good job illustrating the morphology changes of mitochondria under different conditions.

akeshavan commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1983. Feel free to close this issue now!