openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: CaPS: Casimir Effect in the Plane-Sphere Geometry #1907

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @michael-hartmann (Michael Hartmann) Repository: https://github.com/michael-hartmann/caps/ Version: 0.5 Editor: @danielskatz Reviewers: @eschnett, @jwuttke

Author instructions

Thanks for submitting your paper to JOSS @michael-hartmann. Currently, there isn't an JOSS editor assigned to your paper.

@michael-hartmann if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 4 years ago
Attempting to check references...
whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

OK DOIs

- 10.1093/acprof:oso/9780199238743.001.0001 is OK
- 10.1103/PhysRevLett.109.160403 is OK
- 10.1088/1367-2630/8/10/243 is OK
- 10.1103/PhysRevLett.99.170403 is OK
- 10.1007/s10915-013-9714-z is OK
- 10.21105/joss.01167 is OK
- 10.1103/PhysRevE.91.033203 is OK
- 10.1103/PhysRevE.92.042125 is OK
- 10.1103/PhysRevLett.119.043901 is OK
- 10.1088/1402-4896/aae34e is OK
- 10.1103/PhysRevLett.96.080403 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kthyng commented 4 years ago

Hi @michael-hartmann and thanks for your submission. Please add to your paper to include:

A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience.

and possibly also

A clear Statement of Need that illustrates the research purpose of the software

which is hard to discern from this outside perspective currently. We want to see a clear research use stated clearly.

danielskatz commented 4 years ago

I'm going to mark this as paused for now - @michael-hartmann, please let us know when you have addressed the previous points.

michael-hartmann commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

michael-hartmann commented 4 years ago

@kthyng, @danielskatz

Thank you for your suggestions.

We have addressed the previous points by (i) extending the introduction for a non-specific audience, and (ii) adding references to experiments that have used data generated with our software.

We hope that the review can now continue. :-)

michael-hartmann commented 4 years ago

@whedon check references

whedon commented 4 years ago
Attempting to check references...
whedon commented 4 years ago

OK DOIs

- 10.1016/j.crhy.2011.05.004 is OK
- 10.1103/PhysRevLett.87.211801 is OK
- 10.1103/PhysRevB.63.033402 is OK
- 10.1093/acprof:oso/9780199238743.001.0001 is OK
- 10.1016/j.crhy.2012.04.008 is OK
- 10.1103/PhysRevLett.109.160403 is OK
- 10.1088/1367-2630/8/10/243 is OK
- 10.1103/PhysRevLett.99.170403 is OK
- 10.1007/s10915-013-9714-z is OK
- 10.21105/joss.01167 is OK
- 10.1103/PhysRevE.91.033203 is OK
- 10.1103/PhysRevE.92.042125 is OK
- 10.1103/PhysRevLett.119.043901 is OK
- 10.1088/1402-4896/aae34e is OK
- 10.1103/PhysRevLett.96.080403 is OK
- 10.1103/PhysRevB.100.081406 is OK
- 10.1103/PhysRevA.100.052511 is OK

MISSING DOIs

- None

INVALID DOIs

- None
danielskatz commented 4 years ago

Sorry for the delay in getting back to this - our rotating associate editor-in-chief system showed some flaws over the holidays

danielskatz commented 4 years ago

@whedon assign @danielskatz as editor

whedon commented 4 years ago

OK, the editor is @danielskatz

danielskatz commented 4 years ago

@michael-hartmann - do you have any suggestions for potential reviewers? If so, please mention them here in this thread, without @-tagging them. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission. Please take a look and see if you see any potentially-applicable reviewers.

michael-hartmann commented 4 years ago

@danielskatz Thank you for your reply.

I had a look at the list of JOSS reviewers and think jochym and jwuttke are good candidates. Both have a background in theoretical physics, experience in scattering (might be helpful), and listed C among their programming languages.

danielskatz commented 4 years ago

👋 @jochym - Would you be willing to review this for JOSS?

danielskatz commented 4 years ago

👋 @jwuttke - Would you be willing to review this for JOSS?

danielskatz commented 4 years ago

👋 @eschnett & @stevenrbrandt - would either of you be willing to review this, or have suggestions for others who might?

jwuttke commented 4 years ago

What are reviewers supposed to do?

danielskatz commented 4 years ago

Sorry, I thought you were familiar with JOSS - see https://joss.readthedocs.io/en/latest/reviewer_guidelines.html for general info about the reviewing process, and https://joss.readthedocs.io/en/latest/review_criteria.html for the specific review criteria. In brief, a JOSS review is of the short paper and the software repository, and it is open and collaborative, seeking to improve the paper and software to the point where they can be accepted.

eschnett commented 4 years ago

@danielskatz I accept.

danielskatz commented 4 years ago

@jwuttke - are you willing to be a reviewer for this?

danielskatz commented 4 years ago

@whedon assign @eschnett as reviewer

whedon commented 4 years ago

OK, @eschnett is now a reviewer

danielskatz commented 4 years ago

Thanks @eschnett - we'll start the review once we get another reviewer assigned

jwuttke commented 4 years ago

@jwuttke - are you willing to be a reviewer for this?

ok, I'll give it a try

jwuttke commented 4 years ago

will we get some more instructions, or shall we just start, following the guidelines linked above?

danielskatz commented 4 years ago

I'll add you, then create an issue for the review, which will have instructions

danielskatz commented 4 years ago

@whedon add @jwuttke as reviewer

whedon commented 4 years ago

OK, @jwuttke is now a reviewer

danielskatz commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2011. Feel free to close this issue now!