openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: whampy: Python Package to Interact with, Visualize, and Analyze the Wisconsin H-Alpha Mapper - Sky Survey #1920

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @Deech08 (Dhanesh Krishnarao) Repository: https://github.com/Deech08/whampy Version: v0.1.0a5 Editor: @xuanxu Reviewers: @Gabriel-p, @HeloiseS

Author instructions

Thanks for submitting your paper to JOSS @Deech08. Currently, there isn't an JOSS editor assigned to your paper.

@Deech08 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience :smile_cat:

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

whedon commented 4 years ago
Attempting to check references...
whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

OK DOIs

- 10.3847/0004-637X/823/2/77 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1086/378850 is OK
- 10.3847/1538-4357/aa63e6 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

Failed to discover a valid open source license.

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 4 years ago

@Deech08 thanks for your submission. It looks like you have a BSD license but it is stowed away in a folder along with several other files. I recommend that you create a plain text LICENSE file in your main repository folder. This way GitHub will pick up on the license and render a license badge at the top. Also whedon (our journal system bot) and our reviewers will find it easier to find the license.

Kevin-Mattheus-Moerman commented 4 years ago

@xuanxu @mbobra @dfm @leouieda could one of you edit this submission?

xuanxu commented 4 years ago

@Kevin-Mattheus-Moerman I can edit this

xuanxu commented 4 years ago

@whedon assign @xuanxu as editor

whedon commented 4 years ago

OK, the editor is @xuanxu

Deech08 commented 4 years ago

Thanks for agreeing to edit this @xuanxu - I just pushed an update to my whampy repo with the LICENSE.rst file in the main folder.

xuanxu commented 4 years ago

:wave: @Gabriel-p would you be willing to review this submission for JOSS? I think your knowledge of Python and Astronomy makes you a good fit for this submission.

xuanxu commented 4 years ago

:wave: @ngoldbaum would you be willing to review this submission for JOSS? I think your knowledge of Python and Astrophysics makes you a good fit for this submission.

Gabriel-p commented 4 years ago

@xuanxu I'll check it out as soon as I have a few minutes.

xuanxu commented 4 years ago

:wave: @HeloiseS would you be willing to review this submission for JOSS? I think your knowledge of Python and Astrophysics makes you a good fit for this submission.

Gabriel-p commented 4 years ago

@xuanxu should there be a check list here for the reviewer?

HeloiseS commented 4 years ago

Hello

I'm happy to help. By when does this need doing?

Cheers, Heloise

On Sun, 8 Dec 2019, 10:59 AM Juanjo Bazán, notifications@github.com wrote:

👋 @HeloiseS https://github.com/HeloiseS would you be willing to review this submission for JOSS? I think your knowledge of Python and Astrophysics makes you a good fit for this submission.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1920?email_source=notifications&email_token=ADXN74HAJSJRYLYKC4EXIALQXTHP3A5CNFSM4JSY2DVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGG3HJA#issuecomment-562934692, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXN74AXKQLBDHWJD54XOMTQXTHP3ANCNFSM4JSY2DVA .

xuanxu commented 4 years ago

@Gabriel-p this is the pre-review. Once I have the two reviewers I’ll start the review in a new issue with a checklist for each of the reviewers. Stay tuned!

xuanxu commented 4 years ago

@HeloiseS in the next two/three weeks if possible. Is that ok for you?

HeloiseS commented 4 years ago

Yeah should be fine :)

On Sun, 8 Dec 2019, 2:16 PM Juanjo Bazán, notifications@github.com wrote:

@HeloiseS https://github.com/HeloiseS in the next two/three weeks if possible. Is that ok for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/1920?email_source=notifications&email_token=ADXN74HL5SMYTGG2J4Q53L3QXT6SNA5CNFSM4JSY2DVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGG7WDI#issuecomment-562952973, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXN74FO3B7NN4LEDPQ7OUTQXT6SNANCNFSM4JSY2DVA .

xuanxu commented 4 years ago

@whedon add @Gabriel-p as reviewer

whedon commented 4 years ago

OK, @Gabriel-p is now a reviewer

xuanxu commented 4 years ago

@whedon add @HeloiseS as reviewer

whedon commented 4 years ago

OK, @HeloiseS is now a reviewer

xuanxu commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/1940. Feel free to close this issue now!

xuanxu commented 4 years ago

@Gabriel-p @HeloiseS please head over to #1940 where the review will take place.