openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
699 stars 36 forks source link

[PRE REVIEW]: CMasher: Scientific colormaps for making accessible, informative and 'cmashing' plots #1993

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @1313e (Ellert van der Velden) Repository: https://github.com/1313e/CMasher Version: v1.2.0 Editor: @mbobra Reviewers: @tacaswell, @wafels

Author instructions

Thanks for submitting your paper to JOSS @1313e. Currently, there isn't an JOSS editor assigned to your paper.

@1313e if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago
Attempting to check references...
whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

OK DOIs

- 10.3847/1538-4365/ab1f7d is OK
- 10.21105/joss.01229 is OK
- 10.21105/joss.01399 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.5281/zenodo.3378106 is OK
- 10.5281/zenodo.1214904 is OK
- 10.1371/journal.pone.0199239 is OK
- 10.1063/1.4822401 is OK
- 10.1109/VISUAL.2002.1183788 is OK
- 10.1109/TVCG.2017.2744359 is OK
- 10.1080/15230406.2016.1140074 is OK
- 10.1364/JOSAA.29.000313 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

tacaswell commented 4 years ago

I will review this once it has an editor.

danielskatz commented 4 years ago

👋 @mbobra - would you be willing to edit this submission for JOSS? (Note that one very-well-qualified reviewer has already volunteered)

mbobra commented 4 years ago

@whedon assign @mbobra as editor

whedon commented 4 years ago

OK, the editor is @mbobra

1313e commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #1993 with the following error:

Error producing PDF. ! LaTeX Error: Environment cslreferences undefined.

See the LaTeX manual or LaTeX Companion for explanation. Type H for immediate help. ...

l.458 \begin{cslreferences}

Looks like we failed to compile the PDF

1313e commented 4 years ago

Oh, I guess I cannot use references in figure captions.

1313e commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 4 years ago

PDF failed to compile for issue #1993 with the following error:

Error producing PDF. ! LaTeX Error: Environment cslreferences undefined.

See the LaTeX manual or LaTeX Companion for explanation. Type H for immediate help. ...

l.458 \begin{cslreferences}

Looks like we failed to compile the PDF

1313e commented 4 years ago

Guess that is not the issue. @mbobra Any ideas?

EDIT: I checked if any of the changes to special commands (like references and such) is causing the problem, but that does not seem to be the case.

danielskatz commented 4 years ago

👋 @arfon - can you see the problem here?

arfon commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

arfon commented 4 years ago

👋 @arfon - can you see the problem here?

Sorry, this was an unintended side effect of upgrading Pandoc last night. It's now fixed.

mbobra commented 4 years ago

@whedon assign @tacaswell as reviewer

whedon commented 4 years ago

OK, the reviewer is @tacaswell

mbobra commented 4 years ago

@whedon add @wafels as reviewer

whedon commented 4 years ago

OK, @wafels is now a reviewer

mbobra commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2004. Feel free to close this issue now!