openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
715 stars 38 forks source link

[PRE REVIEW]: mhealthtools: A Modular R Package for Extracting Features from Mobile and Wearable Sensor Data #2000

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @philerooski (Phillip Snyder) Repository: https://github.com/Sage-Bionetworks/mhealthtools Version: 0.2.0 Editor: @trallard Reviewers: @Ebedthan, @AKuederle

Author instructions

Thanks for submitting your paper to JOSS @philerooski. Currently, there isn't an JOSS editor assigned to your paper.

@philerooski if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.16 s (195.9 files/s, 34438.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               22            250           1428           2072
HTML                             1             88              5            408
Rmd                              4            218            481            305
TeX                              1             14              0            158
Markdown                         2             48              0            128
YAML                             1              1              1             18
Dockerfile                       1              1              0              2
-------------------------------------------------------------------------------
SUM:                            32            620           1915           3091
-------------------------------------------------------------------------------
whedon commented 4 years ago
Reference check summary:

OK DOIs

- 10.1038/s41746-019-0090-4 is OK
- 10.21105/joss.01778 is OK
- 10.18637/jss.v059.i10 is OK
- 10.1038/s41746-019-0078-0 is OK
- 10.1038/s41746-019-0084-2 is OK
- 10.1146/annurev-bioeng-062117-121036 is OK
- 10.1145/3341162.3346277 is OK
- 10.5281/zenodo.3563546 is OK

MISSING DOIs

- https://doi.org/10.1038/s41746-019-0178-x may be missing for title: Detecting the impact of subject characteristics on machine learning-based diagnostic applications
- https://doi.org/10.1145/3267305.3267612 may be missing for title: Remote Assessment, in Real-World Setting, of Tremor Severity in Parkinson’s Disease Patients Using Smartphone Inertial Sensors

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

danielskatz commented 4 years ago

👋 @trallard - would you be willing to edit this submission for JOSS?

danielskatz commented 4 years ago

👋 @trallard - a 2nd ping...

trallard commented 4 years ago

Hey @danielskatz sure, assign this to me!

danielskatz commented 4 years ago

Thanks @trallard - you can do it yourself by doing what I do in the next command :)

danielskatz commented 4 years ago

@whedon assign @trallard as editor

whedon commented 4 years ago

OK, the editor is @trallard

trallard commented 4 years ago

@philerooski let's start by finding some reviewers. Have you got someone in mind already? if not you can check the list of registered reviewers :https://bit.ly/joss-reviewers and suggest some (⚠️ please make sure to not use the @ when adding their names to this issue)

philerooski commented 4 years ago

@trallard There is a paper similar to this that has been published in JOSS (https://joss.theoj.org/papers/10.21105/joss.01778) that was reviewed by Abhishektha Boppana (abhishektha), although this reviewer is not familiar with R. Arne Küderle (AKuederle) is familiar with the conceptual aspects of this paper (IMUs, motion/gait analysis), but they do not list R as a programming language that they are familiar with, either. There are many reviewers familiar with both R and bioinformatics: Ebedthan, kanekalla, dcassol, ...

trallard commented 4 years ago

Hi, all I am the editor for this submission and we are looking for at least 2 reviewers to move forward.

@abhishektha Abhishek, are you willing and able to review this submission? @AKuederle Arne, are you willing and able to review this submission? @Ebedthan Anicet, are you willing and able to review this submission? @kanekalla Kishore, are you willing and able to review this submission?

Ebedthan commented 4 years ago

Yes I'll do.

Send me details please. Regards. On Feb 3 2020, at 6:29 pm, Tania Allard notifications@github.com wrote:

Hi, all I am the editor for this submission and we are looking for at least 2 reviewers to move forward.

@abhishektha (https://github.com/abhishektha) Abhishek, are you willing and able to review this submission? @AKuederle (https://github.com/AKuederle) Arne, are you willing and able to review this submission? @Ebedthan (https://github.com/Ebedthan) Anicet, are you willing and able to review this submission? @kanekalla (https://github.com/kanekalla) Kishore, are you willing and able to review this submission?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/openjournals/joss-reviews/issues/2000?email_source=notifications&email_token=AEEDMFMAJD57VU34RQ3USOTRBBPCHA5CNFSM4KD26OM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKU4N7I#issuecomment-581551869), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AEEDMFNTGTX3REX7642C3LDRBBPCHANCNFSM4KD26OMQ).

AKuederle commented 4 years ago

Yes, I would be willing to, but because of my limited R knowledge, I might not be able to comment on aspects of code quality and correctness (?). If this is not an issue, I would be happy to perform the review.

arfon commented 4 years ago

:wave: @trallard - it looks like @Ebedthan and @AKuederle are happy to review here so once they're assigned, the main review thread can be started.

trallard commented 4 years ago

Apologies for the delay my OOO extended and forgot to update. Moving this forward now

trallard commented 4 years ago

@whedon assign @Ebedthan as reviewer

whedon commented 4 years ago

OK, @Ebedthan is now a reviewer

trallard commented 4 years ago

@whedon add @AKuederle as reviewer

whedon commented 4 years ago

OK, @AKuederle is now a reviewer

trallard commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2106.