search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
699 stars 36 forks source link

[REVIEW]: CMasher: Scientific colormaps for making accessible, informative and 'cmashing' plots #2004

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @1313e (Ellert van der Velden) Repository: https://github.com/1313e/CMasher Version: v1.2.2 Editor: @mbobra Reviewer: @tacaswell, @wafels Archive: 10.5281/zenodo.3637633

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/16f291edc5c4fb61e31e6eef45bb558a"><img src="https://joss.theoj.org/papers/16f291edc5c4fb61e31e6eef45bb558a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/16f291edc5c4fb61e31e6eef45bb558a/status.svg)](https://joss.theoj.org/papers/16f291edc5c4fb61e31e6eef45bb558a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@tacaswell & @wafels, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mbobra know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @tacaswell

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @wafels

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @tacaswell, @wafels it looks like you're currently assigned to review this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.3847/1538-4365/ab1f7d is OK
- 10.21105/joss.01229 is OK
- 10.21105/joss.01399 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.5281/zenodo.3378106 is OK
- 10.5281/zenodo.1214904 is OK
- 10.1371/journal.pone.0199239 is OK
- 10.1063/1.4822401 is OK
- 10.1109/VISUAL.2002.1183788 is OK
- 10.1109/TVCG.2017.2744359 is OK
- 10.1080/15230406.2016.1140074 is OK
- 10.1364/JOSAA.29.000313 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

mbobra commented 4 years ago

@tacaswell @wafels Thank you for agreeing to review this submission! Whedon generated a checklist and linked a reviewer guide above -- please let me know if you have any questions or comments.

1313e commented 4 years ago

@mbobra Can you remind me, after the review process has finished, to do something about the placement of Figure 2 in the paper? I will probably remember it, but just to be sure.

1313e commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

1313e commented 4 years ago

Any updates?

mbobra commented 4 years ago

@tacaswell, @wafels Let me know if you have any questions!

mbobra commented 4 years ago

@tacaswell, @wafels Let me know if you still have time to review -- if you're too busy, no worries at all and I can find other reviewers.

1313e commented 4 years ago

@mbobra I don't think this is going anywhere anytime soon? Sadly, the one person I could come up with as a reviewer already is one for this paper, so that doesn't really work.

mbobra commented 4 years ago

@openjournals/joss-eics Can you help us with this?

kthyng commented 4 years ago

@mbobra just pinged @tacaswell by other means. Have you tried email for @wafels?

tacaswell commented 4 years ago

I approve this paper :+1:

tacaswell commented 4 years ago

As a side note, @1313e proposed some of these color maps for inclusion in Matplotlib and we suggested a stand-alone package. I think that this has ended up in a vastly better state than if the color maps had been added to core. There is great value in an curated set of color maps that are nicely name spaced and more opinionated than we can be on core.

mbobra commented 4 years ago

Thank you, @tacaswell!!!

mbobra commented 4 years ago

@1313e An update for you: I pinged wafels via e-mail and he's working on it!

1313e commented 4 years ago

As a side note, @1313e proposed some of these color maps for inclusion in Matplotlib and we suggested a stand-alone package. I think that this has ended up in a vastly better state than if the color maps had been added to core. There is great value in an curated set of color maps that are nicely name spaced and more opinionated than we can be on core.

Yeah, after you proposed to me to make my own package, I had several others telling me to do the same thing, and that is why CMasher exists.

wafels commented 4 years ago

I approve this paper and look forward to seeing the colormaps used in the scientific community.

1313e commented 4 years ago

@mbobra I have just fixed the placement of Figure 2 in the paper. Shall I make a GitHub release for v1.2.2, which automatically makes a Zenodo archive, and post the DOI here?

mbobra commented 4 years ago

@mbobra I have just fixed the placement of Figure 2 in the paper. Shall I make a GitHub release for v1.2.2, which automatically makes a Zenodo archive, and post the DOI here?

Yes please!

1313e commented 4 years ago

@mbobra 10.5281/zenodo.3637633

mbobra commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

1313e commented 4 years ago

Also, the version is v1.2.2 now. Not sure if that needs to be changed.

mbobra commented 4 years ago

@whedon check references

whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.3847/1538-4365/ab1f7d is OK
- 10.21105/joss.01229 is OK
- 10.21105/joss.01399 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.5281/zenodo.3378106 is OK
- 10.5281/zenodo.1214904 is OK
- 10.1371/journal.pone.0199239 is OK
- 10.1063/1.4822401 is OK
- 10.1109/VISUAL.2002.1183788 is OK
- 10.1109/TVCG.2017.2744359 is OK
- 10.1080/15230406.2016.1140074 is OK
- 10.1364/JOSAA.29.000313 is OK

MISSING DOIs

- None

INVALID DOIs

- None
mbobra commented 4 years ago

@whedon set 10.5281/zenodo.3637633 as archive

whedon commented 4 years ago

OK. 10.5281/zenodo.3637633 is the archive.

mbobra commented 4 years ago

@whedon set v1.2.2 as version

whedon commented 4 years ago

OK. v1.2.2 is the version.

mbobra commented 4 years ago

@openjournals/joss-eics This paper is ready for final processing!

kthyng commented 4 years ago

Hi @1313e! I am taking over from here. Can you update the metadata in your zenodo archive to match your paper title and authors?

kthyng commented 4 years ago

@1313e Please take a look at references Sharpe et al, Smith et al 2018, and Smith et al 2019. For each of these either the spacing is odd or the author list seems incomplete. Please verify the best way to reference the Smith packages.

1313e commented 4 years ago

@1313e Please take a look at references Sharpe et al, Smith et al 2018, and Smith et al 2019. For each of these either the spacing is odd or the author list seems incomplete. Please verify the best way to reference the Smith packages.

Could you elaborate on what is wrong with those references? Because, I cannot see anything weird or wrong with any of the references I'm using.

Hi @1313e! I am taking over from here. Can you update the metadata in your zenodo archive to match your paper title and authors?

Of course. Forgot that automated Zenodo archiving will obviously not set those things.

kyleniemeyer commented 4 years ago

@1313e if it helps, it's possible to add a .zenodo.json file to a repository which will specify these metadata, though I can't find an official guide on how to do this/what to include... here is an example though: https://github.com/cboettig/nonparametric-bayes/blob/master/.zenodo.json

1313e commented 4 years ago

@1313e if it helps, it's possible to add a .zenodo.json file to a repository which will specify these metadata, though I can't find an official guide on how to do this/what to include... here is an example though: https://github.com/cboettig/nonparametric-bayes/blob/master/.zenodo.json

@kyleniemeyer I was actually wondering if such a thing existed. I will have a look.

kthyng commented 4 years ago

@1313e Ok, I edited the Sharpe entry directly then. My changes are in PR #4 and you can merge them if you agree. I looked up the details for Nathaniel's papers and they look accurate.

kthyng commented 4 years ago

By the way, since you're interested in colormaps, you might be interested in my paper on them! http://tos.org/oceanography/assets/docs/29-3_thyng.pdf

1313e commented 4 years ago

@1313e Ok, I edited the Sharpe entry directly then. My changes are in PR #4 and you can merge them if you agree. I looked up the details for Nathaniel's papers and they look accurate.

Oooh, those spacings. Kinda weird that they are there, as they don't appear in my bibtex database.

By the way, since you're interested in colormaps, you might be interested in my paper on them! http://tos.org/oceanography/assets/docs/29-3_thyng.pdf

I actually know that paper already and somehow completely forgot to add a citation to cmocean in the paper. Want me to add a citation to that paper?

kthyng commented 4 years ago

Want me to add a citation to that paper?

I'm not reviewing your paper — I just thought you'd be interested in work in the same area.

I'll proceed with the final steps

kthyng commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

kthyng commented 4 years ago

@whedon accept

whedon commented 4 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.3847/1538-4365/ab1f7d is OK
- 10.21105/joss.01229 is OK
- 10.21105/joss.01399 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.5281/zenodo.3378106 is OK
- 10.5281/zenodo.1214904 is OK
- 10.1371/journal.pone.0199239 is OK
- 10.1063/1.4822401 is OK
- 10.1109/VISUAL.2002.1183788 is OK
- 10.1109/TVCG.2017.2744359 is OK
- 10.1080/15230406.2016.1140074 is OK
- 10.1364/JOSAA.29.000313 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1277

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1277, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
kthyng commented 4 years ago

@whedon accept deposit=true

whedon commented 4 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 4 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦