search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: PyEscape #2072

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @AoifeHughes (Aoife Hughes) Repository: https://github.com/AoifeHughes/NarrowEscapeSimulator Version: 1.0 Editor: @drvinceknight Reviewer: @pdebuyl, @markgalassi Archive: 10.5281/zenodo.3725946

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c47ec67686a14361072ed703a58bac15"><img src="https://joss.theoj.org/papers/c47ec67686a14361072ed703a58bac15/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c47ec67686a14361072ed703a58bac15/status.svg)](https://joss.theoj.org/papers/c47ec67686a14361072ed703a58bac15)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@pdebuyl & @markgalassi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @drvinceknight know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @pdebuyl

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @markgalassi

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

drvinceknight commented 4 years ago

@AoifeHughes everything looks good to me.

Could you make a tagged release and archive it (on Zenodo). When you've done that, report the version number and archive DOI here please. Please make sure the archive deposit has the correct metadata (title and author list) to match the paper.

If you could also confirm the version number, it's currently 1.0 if that should be updated as you've modified things throughout the review please let me know.

AoifeHughes commented 4 years ago

Hi @drvinceknight,

Version will be at 1.0 as to me this published version should be marked as that. The DOI is 10.5281/zenodo.3725946 (it's coming up as not working as I write this, but as far as I am aware DOI takes a while to appear online)

Do let me know if I need to do anything more or if I've made any errors.

Thanks!

drvinceknight commented 4 years ago

@whedon set 10.5281/zenodo.3725946 as archive

whedon commented 4 years ago

OK. 10.5281/zenodo.3725946 is the archive.

drvinceknight commented 4 years ago

@whedon accept

whedon commented 4 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.1109/MCSE.2007.55 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1007/s10955-004-5712-8 is OK
- 10.1073/pnas.0706599104 is OK
- 10.1098/rsif.2008.0014 is OK
- 10.1016/j.jcpx.2019.100047 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1400

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1400, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
drvinceknight commented 4 years ago

Sorry for the delay @AoifeHughes, I've recommended acceptance. Thank you @pdebuyl and @markgalassi for your time and effort reviewing this work: it's really appreciated.

danielskatz commented 4 years ago

Thanks - I'll work on finishing this

danielskatz commented 4 years ago

@AoifeHughes - please update the archive's metadata so that the title matches the paper title

danielskatz commented 4 years ago

Additionally, I've suggested some changes to the paper in https://github.com/AoifeHughes/NarrowEscapeSimulator/pull/6

danielskatz commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

AoifeHughes commented 4 years ago

Hi @danielskatz, thank you for the changes, I've reviewed and merged the changes, and just updated the zenodo title.

danielskatz commented 4 years ago

@whedon accept

whedon commented 4 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.3233/978-1-61499-649-1-87 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1007/s10955-004-5712-8 is OK
- 10.1073/pnas.0706599104 is OK
- 10.1098/rsif.2008.0014 is OK
- 10.1016/j.jcpx.2019.100047 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1401

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1401, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
danielskatz commented 4 years ago

@whedon accept deposit=true

whedon commented 4 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 4 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 4 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1402
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02072
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? notify your editorial technical team...

danielskatz commented 4 years ago

Thanks to @pdebuyl & @markgalassi for reviewing, and @drvinceknight for editing!

And congratulations to @AoifeHughes and co-authors!

whedon commented 4 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02072/status.svg)](https://doi.org/10.21105/joss.02072)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02072">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02072/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02072/status.svg
   :target: https://doi.org/10.21105/joss.02072

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: