[REVIEW]: LATTE: Lightcurve Analysis Tool for Transiting Exoplanets

[whedon]

Submitting author: @noraeisner (N. L. Eisner) Repository: https://github.com/noraeisner/LATTE Version: v1.0.0 Editor: @xuanxu Reviewer: @christinahedges, @aureliocarnero Archive: 10.5281/zenodo.3831586

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/216060523b5767f7d2d7c05c4e2257bc"><img src="https://joss.theoj.org/papers/216060523b5767f7d2d7c05c4e2257bc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/216060523b5767f7d2d7c05c4e2257bc/status.svg)](https://joss.theoj.org/papers/216060523b5767f7d2d7c05c4e2257bc)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@christinahedges & @aureliocarnero, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

1. Make sure you're logged in to your GitHub account
2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @xuanxu know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @christinahedges

Conflict of interest

• [x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

• [x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• [x] Repository: Is the source code for this software available at the repository url?
• [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• [x] Contribution and authorship: Has the submitting author (@noraeisner) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• [x] Installation: Does installation proceed as outlined in the documentation?
• [x] Functionality: Have the functional claims of the software been confirmed?
• [x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• [x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• [x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• [x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
• [x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
• [x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @aureliocarnero

Conflict of interest

• [x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

• [x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

• [x] Repository: Is the source code for this software available at the repository url?
• [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• [x] Contribution and authorship: Has the submitting author (@noraeisner) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?

Functionality

• [x] Installation: Does installation proceed as outlined in the documentation?
• [x] Functionality: Have the functional claims of the software been confirmed?
• [x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
• [x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
• [x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• [x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
• [x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
• [x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @christinahedges, @aureliocarnero it looks like you're currently assigned to review this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[xuanxu]

@christinahedges, @aureliocarnero, @noraeisner: this is the review thread for the paper. All of our communications will happen here from now on.

Both reviewers have checklists at the top of this thread with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention openjournals/joss-reviews#2101 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ask me (or the submitting author, or each other) if you have any questions :)

[danielskatz]

@xuanxu - be aware that being in an active collaboration is a conflict - perhaps this review can be completed before the collaboration between @christinahedges and the authors starts

[xuanxu]

@danielskatz Agreed. By her comment I understood that she is not collaborating yet and I assumed there was time enough for the review to finish before the visit, but you are right that's just an assumption I made. @christinahedges can you please clarify this point?

[christinahedges]

Hi @xuanxu and @danielskatz, yes I am not currently collaborating with Norah, our collaboration starts in a few months. If you're happy this is not a conflict then I'm happy! 👍

[danielskatz]

sounds good to me

[xuanxu]

@christinahedges 👍

[aureliocarnero]

Dear @noraeisner, I'm reviewing the installation instructions, and following your recommendations, I came to a message error telling me that:

ModuleNotFoundError: No module named 'tkinter'

It was easy to solve it, I need to do a: "sudo apt-get install python3-tk", but I think it would be nice to explicitly say that in the documentation, same as you name with the matplotlib version: pip install matplotlib==3.2.0rc1 Put another note on tkinter.

[aureliocarnero]

Also, in the installation instructions, when you say that "The first time that the code is run it will also have to download the text data files from MAST (this only has to run once)." Could you please state the size of the data that will be download? Which is ~325M Thanks @noraeisner

[noraeisner]

Dear @aureliocarnero, thank you so much for reviewing the code. I will definitely add the need for tkinter and the size of dowloaded data to the installation instructions. Thank you so much.

[aureliocarnero]

Dear @noraeisner, there is a few comments to make. In order to validate the documentation, you should explain how to perform the automated test. I see there is a directory called tests. Could you put in the code documentation how to run the tests? Ideally, should be done in automatic mode, like using pytests.

[aureliocarnero]

@noraeisner another thing is documentation is lacking Community guidelines, please put those (see above in the checklist about what it means). If you don't know what these are, you can see examples in other JOSS code repositories

[aureliocarnero]

@noraeisner

Also in the README.md file, there are some exclamation marks that I think are an error """"""""""""""""""""""""""""""" Arguments

NOTE: all of these arguments (except new-path, auto and targetlist, new-data) can be changed as option in the GUI. They are arguments in case the same options wish to be run multiple times and the user therfore wishes to identify them in the command line when the program is executed.

!!!!!! --new-data """""""""""""""""""""""""""""""""""""""" There, before --new-data

Also, correct the word therefore (it is written therfore)

[aureliocarnero]

@noraeisner also there is now a new setting called model that you do not explain what it is. Could you please document it?

Now I realized you say in the outputs: (in progress, will be available in next release of LATTE) Modelling of the signal using a Bayesian approach with an MCMC sampling. This makes use of the Pyaneti code (Barragan et al. 2017).

So I guess you mean that, but since it seems is already integrated, I think you should move it to settings and document it properly. Also, could you put an output example of this setting?

[aureliocarnero]

@noraeisner I'm playing around with the code.

When I run the code, in the terminal appears and error but in the end the code runs normally.

First, whenever I'm done, I have to click twice in "DONE" to start the pipeline, and the message in the terminal is the following:

line 468, in set_cursor self.canvas.get_property("window").set_cursor(cursord[cursor]) AttributeError: 'NoneType' object has no attribute 'set_cursor'

If I run with the following command, then I do not get the error (but I still need to click two or three times to the "DONE" bottom): python3 -m LATTE --tic=55525572 --sector=2,5 --noshow --auto --north

[aureliocarnero]

Hello, @noraeisner, I opened an issue in the github repo because I found a bug so I think it is better it is registered there. Cheers Aurelio

[noraeisner]

Hi @aureliocarnero, thank you so much for all your comments. I have added a section in the readme file on how to execute the automated tests (using python3 -m unittest) and I have added a section and a file (CONTRIBUTIONS.md) for the Community guidelines as well as addressed the exclamation marks and spell mistakes in the readme file. I'm so sorry about missing these.

The modelling feature is unfortunately not quite ready to be distributed as I'm finding that it struggles to run on certain computers and is compiler specific so I have removed the 'model' option entirely until this is better tested.

I haven't been able to reproduce the error of the 'done' button freezing yet but I am currently looking into it. I'm also trying to reproduce the 'self.canvas.get_property("window").set_cursor(cursord[cursor])' error. Can I ask what operating software you are using so that I can try and track these issues down that way? I have tested the code on Mac and Linux/Fedora 27 only.

Thank you!

[aureliocarnero]

Thank you a lot @noraeisner for the quick response. So I cannot reproduce again either the canvas.get_property("window") error any longer! It remains a mystery why I had 2 separate errors in the same window of time... I'm using Ubuntu 19.10

I will test again to see if I get an error again.

To try the new version where the settings "model" is no longer available... Do I have to install the code again, I guess?

[aureliocarnero]

@noraeisner two quick comments: 1) Could you please put in the paper, a reference to Kepler? Second paragraph in the paper, I'm missing the reference to Kepler there.

2) Maybe it is a silly thing, May I would recommend to put the Brasseur, Phillip, Fleming, Mullally & White, 2019 as Brasseur et al, 2019.?

3) Please correct the word "eecuting" in the README.md, here: To check, please try eecuting the following command in from your command line: python -m tess_stars2px -t 261136679

[noraeisner]

@aureliocarnero, I'm glad to hear that the problem is no longer occurring but I agree that it is very strange that two errors happened at the same time. I will test the code on an Ubuntu computer in order to see whether the errors are related to the operating system.

Yes, I have removed the modelling routine from the GitHub repository (and I will do the same for the pip install version) so it should now run without it if is is re-installed. I'm so sorry for the inconvenience.

For the other comments:

1. I just added the Kepler reference. That should definitely not have been missing.
2. I completely agree with you that it should just be Brasseur et al, 2019 but as far as I can tell the compile automatically decides how to write the references. Please do let me know if there is a way for me to change it manually.
3. I have corrected this spelling mistake, thank you for spotting this.

It has also come to my attention that some computers have an SSL license issue when running the code for the first time. I have added a couple of sentences to the readme explaining how to diagnose and solve this if it does occur.

[aureliocarnero]

For the other comments:

2. I completely agree with you that it should just be Brasseur et al, 2019 but as far as I can tell the compile automatically decides how to write the references. Please do let me know if there is a way for me to change it manually.

About this, don't worry then, it must be the reference style of JOSS, they might have the limit to 5 authors before going to et al.

[aureliocarnero]

@noraeisner could you please let me know when the LATTE installation in the new version is available in pip install. Maybe already is.

[aureliocarnero]

@noraeisner please update here the documentation changes we have done through the review: https://pypi.org/project/tessLATTE/

[aureliocarnero]

@noraeisner I run the unittests and I had this output (says Run 7 tests, with FAILED errors=3) 1) Could you please put in the section: "Perform automated tests" that you must clone the git repository first and then you must be in the repository home directory to run those?

2) Here is the output of running the unittests:

/home/carnero/codes/LATTE/tests/test_BLS.py:57: ResourceWarning: unclosed file <_io.FileIO name='./tests/tic55525572_lc.fits' mode='rb' closefd=True>
  alltime, allflux, allflux_err, all_md, alltimebinned, allfluxbinned, allx1, allx2, ally1, ally2, alltime12, allfbkg, start_sec, end_sec, in_sec, tessmag, teff, srad = utils.download_data(indir,sector, tic, binfac = 5, test = './tests/tic55525572_lc.fits')
/home/carnero/codes/LATTE/LATTE/filters.py:256: RuntimeWarning: invalid value encountered in greater
  out = np.isnan(work) + (myabs(array - work) > (nsig*sigma))
Detrend data prior to BLS analysis... done.
/home/carnero/.local/lib/python3.7/site-packages/matplotlib/backends/backend_gtk3.py:187: DeprecationWarning: Gtk.Widget.set_double_buffered is deprecated
  self.set_double_buffered(True)
/home/carnero/.local/lib/python3.7/site-packages/matplotlib/backends/backend_gtk3.py:343: DeprecationWarning: Gtk.Window.set_wmclass is deprecated
  self.window.set_wmclass("matplotlib", "Matplotlib")
/home/carnero/.local/lib/python3.7/site-packages/matplotlib/backends/backend_gtk3.py:372: DeprecationWarning: Gtk.Widget.size_request is deprecated
  size_request = child.size_request()
.EEE/home/carnero/codes/LATTE/tests/test_plotting.py:59: ResourceWarning: unclosed file <_io.FileIO name='./tests/tic55525572_lc.fits' mode='rb' closefd=True>
  alltime, allflux, allflux_err, all_md, alltimebinned, allfluxbinned, allx1, allx2, ally1, ally2, alltime12, allfbkg, start_sec, end_sec, in_sec, tessmag, teff, srad = utils.download_data(indir,sector, tic, binfac = 5, test = './tests/tic55525572_lc.fits')
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:2979: RuntimeWarning: invalid value encountered in greater
  lkeep = np.isfinite(X1.sum(axis=1)) * (Q==0) * (X1.sum(axis=1)>0)
/home/carnero/codes/LATTE/tests/test_plotting.py:60: ResourceWarning: unclosed file <_io.FileIO name='./tests/tic55525572_tp.fits' mode='rb' closefd=True>
  X1_list, X4_list, oot_list, intr_list, bkg_list, apmask_list, arrshape_list, t_list, T0_list, tpf_filt_list = utils.download_tpf_mast(indir, transit_sec, transit_list, tic, test = './tests/tic55525572_tp.fits')
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:4170: RuntimeWarning: invalid value encountered in less
  mask_dd = (np.array(time_dd) < peak+0.75) & (np.array(time_dd) > peak-0.75)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:4170: RuntimeWarning: invalid value encountered in greater
  mask_dd = (np.array(time_dd) < peak+0.75) & (np.array(time_dd) > peak-0.75)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:4184: RuntimeWarning: invalid value encountered in less
  mask_dd = (np.array(time_dd) < peak+0.75) & (np.array(time_dd) > peak-0.75)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:4184: RuntimeWarning: invalid value encountered in greater
  mask_dd = (np.array(time_dd) < peak+0.75) & (np.array(time_dd) > peak-0.75)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:4185: RuntimeWarning: invalid value encountered in less
  mask_dd_binned = (np.array(time_dd_binned) < peak+0.75) & (np.array(time_dd_binned) > peak-0.75)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:4185: RuntimeWarning: invalid value encountered in greater
  mask_dd_binned = (np.array(time_dd_binned) < peak+0.75) & (np.array(time_dd_binned) > peak-0.75)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:3395: MatplotlibDeprecationWarning: Adding an axes using the same arguments as a previous axes currently reuses the earlier instance.  In a future version, a new instance will always be created and returned.  Meanwhile, this warning can be suppressed, and the future behavior ensured, by passing a unique label to each axes instance.
  plt.subplot(2,gs,g+1) # define the plotting area
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:3418: MatplotlibDeprecationWarning: Adding an axes using the same arguments as a previous axes currently reuses the earlier instance.  In a future version, a new instance will always be created and returned.  Meanwhile, this warning can be suppressed, and the future behavior ensured, by passing a unique label to each axes instance.
  plt.subplot(2,gs,gs+1+g) # define the plotting area
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:3630: RuntimeWarning: invalid value encountered in less
  mask_dd = (np.array(alltime) < peak+2) & (np.array(alltime) > peak-2)
/home/carnero/codes/LATTE/LATTE/LATTEutils.py:3630: RuntimeWarning: invalid value encountered in greater
  mask_dd = (np.array(alltime) < peak+2) & (np.array(alltime) > peak-2)
1   out of    11 
2   out of    11 
3   out of    11 
4   out of    11 
5   out of    11 
6   out of    11 
7   out of    11 
8   out of    11 
9   out of    11 
10   out of    11 
11   out of    11 

 Calculating the Aperture Mask... done.

Waiting on plot...
/usr/lib/python3.7/unittest/case.py:628: ResourceWarning: unclosed file <_io.FileIO name='./tests/tic55525572_tp.fits' mode='rb' closefd=True>
  testMethod()
.Running Pyaneti modelling - this could take a while so be patient...
Traceback (most recent call last):
  File "/home/carnero/codes/LATTE/LATTE/pyaneti_LATTE.py", line 43, in <module>
    import pyaneti as pti #FORTRAN module
ImportError: bad magic number in 'pyaneti': b'\x03\xf3\r\n'
..
======================================================================
ERROR: test_DVreport (tests.test_DVreport.TestDVreport)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/carnero/codes/LATTE/tests/test_DVreport.py", line 61, in test_DVreport
    ldv.LATTE_DV(tic, indir, syspath, transit_list, sectors_all, target_ra, target_dec, tessmag, teff, srad, [0], [0], tpf_corrupt, FFI = False,  bls = False, model = False, mpi = None, test = './tests/')
TypeError: LATTE_DV() missing 1 required positional argument: 'astroquery_corrupt'

======================================================================
ERROR: tests.test_data_download (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: tests.test_data_download
Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/carnero/codes/LATTE/tests/test_data_download.py", line 17, in <module>
    from nose.tools import assert_true
ModuleNotFoundError: No module named 'nose'

======================================================================
ERROR: tests.test_data_products (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: tests.test_data_products
Traceback (most recent call last):
  File "/usr/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/usr/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/carnero/codes/LATTE/tests/test_data_products.py", line 17, in <module>
    import mock
ModuleNotFoundError: No module named 'mock'

----------------------------------------------------------------------
Ran 7 tests in 36.193s

FAILED (errors=3)

[aureliocarnero]

If there are libraries missing, please correct the pip install execution to correctly import the needed libraries.

[noraeisner]

Hi @aureliocarnero, I'm so sorry that the tests didn't run - there were some files missing from the GitHub page. I have updated it so that it should now run along with the readme file. I should note that the runtime warnings still appear when the tests are run, however these don't stop the code, or tests, form completing. I have looked into them and they are a common problem with the 'requests' and 'reportlab', modules as these don't close their files properly. I haven't been able to find a solution to avoid these but please do let me know if they are a big problem and I will try and find a work-around.

I have also updated the pip install version - now v0.1.13. Thank you so much.

[xuanxu]

@christinahedges did you have the opportunity to start your review?

[aureliocarnero]

Hello @xuanxu , could you please recompile the paper draft to show the new changes in the manuscript? Cheers Aurelio

[aureliocarnero]

Dear @noraeisner . Could you please revise the pip3 install routine? After you updated to the new version, I cannot install LATTE correctly. It runs ok, all the dependencies installations, but when I try to run the program, it tells me that "No module named LATTE" If I install it from the github repo with "pip install .", it works ok. Cheers Aurelio

[xuanxu]

@aureliocarnero I'll recompile the paper now. All the participants in the review can regenerate it anytime, with the same command I'm going to issue next:

[xuanxu]

@whedon generate pdf

[aureliocarnero]

@whedon generate pdf

[aureliocarnero]

@xuanxu thank you, I just saw that it is explained above in the instructions. My fault! Nonetheless, I do not see the new link to the pdf... Maybe it is because it is taking some time to compile?

[xuanxu]

@aureliocarnero Yes, it looks like the process is taking too long, I'm going to take a look.

[xuanxu]

@aureliocarnero In the meantime you can take a look here: http://res.cloudinary.com/hju22ue2k/image/upload/v1583058972/gqtl5cd1ykdsx8v1hdfl.pdf (just created using http://whedon.theoj.org/ )

[xuanxu]

@whedon generate pdf

[whedon]

:point_right: Check article proof :page_facing_up: :point_left:

[christinahedges]

@christinahedges did you have the opportunity to start your review?

@xuanxu I'm sorry I haven't started my review I've been traveling and haven't been able to get to it. As @aureliocarnero has already reviewed this work, would you prefer me to review another submission in the near future?

[xuanxu]

I'm sorry I haven't started my review I've been traveling and haven't been able to get to it.

No problem!

As aureliocarnero has already reviewed this work, would you prefer me to review another submission in the near future?

@christinahedges we want all of the papers to be reviewed by (at least) two different reviewers, so please go ahead with this one.

[christinahedges]

Hi @xuanxu no problem, I can do that. I need some time to get spun up, do you have a deadline when you need my review by?

[xuanxu]

@christinahedges we aim for two-four weeks to have the review but it's an intention, not a hard deadline. And you can comment and provide feedback to the authors as you go.

[aureliocarnero]

Just in case you missed this message:

Dear @noraeisner . Could you please revise the pip3 install routine? After you updated to the new version, I cannot install LATTE correctly. It runs ok, all the dependencies installations, but when I try to run the program, it tells me that "No module named LATTE" If I install it from the github repo with "pip install .", it works ok.

Also, I still have 1 error when I run the unittest. Is this normal?

====================================================================== FAIL: test_nn (LATTE.tests.test_data_download.TestNearestNeighbours)

Traceback (most recent call last): File "/home/carnero/codes/LATTE/LATTE/tests/test_data_download.py", line 50, in test_nn self.assertEqual(output[1], [0.0, 6.795727328666717, 10.622509290130298, 15.63959237521102, 16.881930554329756, 17.79841005439404], "nearest neighbour distances are incorrect") AssertionError: Lists differ: [0.0,[32 chars]130296, 15.63959237521102, 16.88193055432957, [14 chars]4076] != [0.0,[32 chars]130298, 15.63959237521102, 16.881930554329756,[14 chars]9404]

First differing element 2: 10.622509290130296 10.622509290130298

[0.0, 6.795727328666717,

• 10.622509290130296, ? ^

• 10.622509290130298, ? ^

  15.63959237521102,

• 16.88193055432957, ? ^

• 16.881930554329756, ? + ^

• 17.798410054394076] ? ^^

• 17.79841005439404] ? ^ : nearest neighbour distances are incorrect

---

Ran 10 tests in 138.972s

FAILED (failures=1)

Cheers Aurelio

[noraeisner]

Hi @aureliocarnero , I am so sorry for missing your previous message. I have re-uploaded the pip install version (v0.1.15). I have verified that it works on two computers (Mac and Ubuntu), however, as far as I can tell the previous version also worked for me so please do let me know if the problem persists. I have also changed the unittests so that the different roundings do not raise an error. Thank you so much for looking at the code!

[aureliocarnero]

Hello @noraeisner . Now the installation works! I don't know why, but if I installed it with pip3, it gave me an error, but if I did it with pip, then it worked fine. Actually, when I installed with pip3, and executed with python3.6, then it run, so it might be a problem with my python 3 version setup. Basically, if I'm in python 3 enviroment already, running pip install tessLATTE worked perfectly, without need of pip3.

[aureliocarnero]

@noraeisner in terms of the unittest, there is something funny. If I set the --new-path somewhere outside the LATTE directory, it gives me an error, but if I put the path somewhere within the LATTE directory, it runs ok. So I would recommend you say something like this. Could you try to replicate this?

For example: when it asks me about the new-path and I put: ./LATTE_output (what is recommended), then it worked, but if I put /home/carnero/codes/tempLATTE, then it failed.

Nonetheless, now the unittest gives no errors at all! That is good. I will test the mpi example case, and if I can run it, then I will validate all the code. We are close! Cheers Aurelio

[christinahedges]

Hi @xuanxu

Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

This link has expired for me, would you be able to tell me how I can get a new one? I'm just going through the checklist now!

Thanks! C

[danielskatz]

@arfon needs to re-enable the invitation

[arfon]

You're invited again @christinahedges.

[christinahedges]

Thanks @arfon.

I've taken a look at LATTE and added my review comments to an issue here. @noraeisner and @xuanxu, I have left comments there why some of the boxes are unticked.

I find the biggest comment I have to be the state of the field in the paper needs to be improved. I think that the SPOC validation reports, MIT QLP validation reports, eleanor, and lightkurve are all relevant context that should be mentioned. I also find in general that the documentation could be improved a little to show the workflow of an average user, and discuss what each validation plot is designed to show.