search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: graphsim: An R package for simulating gene expression data from graph structures of biological pathways #2161

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @TomKellyGenetics (S. Thomas Kelly) Repository: https://github.com/TomKellyGenetics/graphsim Version: v1.0.0-joss Editor: @majensen Reviewer: @rcannood, @corybrunson Archive: 10.5281/zenodo.3931288

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6"><img src="https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6/status.svg)](https://joss.theoj.org/papers/96016c6a55d7f74bacebd187c6ededd6)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@rcannood & @corybrunson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @majensen know.

✨ Please try and complete your review in the next two weeks ✨

Review checklist for @rcannood

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @corybrunson

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @rcannood, @corybrunson it looks like you're currently assigned to review this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.1186/gb-2014-15-2-r29 is OK
- 10.1186/1752-0509-3-41 is OK
- 10.1093/bioinformatics/btm639 is OK
- 10.1016/j.copbio.2007.11.005 is OK
- 10.1515/jib-2017-0027 is OK
- 10.1093/imanum/22.3.329 is OK
- 10.1186/s13062-015-0086-1 is OK
- 10.1101/gad.11.13.1748 is OK
- 10.1093/bioinformatics/btp174 is OK
- 10.1093/bioinformatics/btu736 is OK
- 10.1093/hmg/ddu309 is OK
- 10.1016/0022-2836(75)90213-2 is OK
- 10.1016/j.socnet.2004.11.008 is OK
- 10.1007/BF01386390 is OK
- 10.1177/1558689812454457 is OK
- 10.1111/j.1651-2227.2006.00178.x is OK
- 10.1016/j.patrec.2005.10.010 is OK
- 10.1124/jpet.103.064824 is OK
- 10.1016/j.cell.2009.02.024 is OK
- 10.1103/PhysRevLett.87.198701 is OK
- 10.1039/C3MB25589A is OK
- 10.1186/gb-2010-11-3-r25 is OK
- 10.1186/1471-2407-14-552 is OK
- 10.1016/j.fob.2012.04.003 is OK
- 10.1200/JCO.2008.18.1370 is OK
- 10.1016/S0169-7552(98)00110-X is OK
- 10.1093/nar/gkt1102 is OK
- 10.1093/bioinformatics/btl633 is OK
- 10.1093/annonc/mdg486 is OK
- 10.1093/hmg/ddp046 is OK
- 10.1016/S0968-0004(98)01343-7 is OK
- 10.1016/S1357-4310(99)01461-6 is OK
- 10.1016/S0959-8049(00)00158-1 is OK
- 10.1053/gast.2001.29611 is OK
- 10.1001/jama.297.21.2360 is OK
- 10.1371/journal.pgen.1003254 is OK
- 10.1186/1479-5876-7-43 is OK
- 10.1038/nrd3374 is OK
- 10.1158/1078-0432.ccr-13-3116 is OK
- 10.1016/j.ddtec.2013.12.002 is OK
- 10.1038/nrg3899 is OK
- 10.1016/j.cell.2015.11.015 is OK
- 10.1186/gb-2004-5-10-r80 is OK

MISSING DOIs

- https://doi.org/10.1038/nrg2934 may be missing for title: RNA sequencing: advances, challenges and opportunities
- https://doi.org/10.1101/227033 may be missing for title: Gene expression distribution deconvolution in single-cell RNA sequencing
- https://doi.org/10.3389/fgene.2019.00535 may be missing for title: Inferring Interaction Networks From Multi-Omics Data
- https://doi.org/10.1186/1471-2105-8-s6-s5 may be missing for title: Inferring cellular networks–a review
- https://doi.org/10.1038/nprot.2017.149 may be missing for title: Exponential scaling of single-cell RNA-seq in the past decade
- https://doi.org/10.1038/nrg.2016.87 may be missing for title: Network biology concepts in complex disease comorbidities
- https://doi.org/10.1186/s12859-015-0778-7 may be missing for title: Comparing the normalization methods for the differential analysis of Illumina high-throughput RNA-Seq data
- https://doi.org/10.1109/msp.2007.273053 may be missing for title: Finding module-based gene networks with state-space models - Mining high-dimensional and short time-course gene expression data
- https://doi.org/10.3892/ijo.2012.1744 may be missing for title: Molecular features of triple negative breast cancer cells by genome-wide gene expression profiling analysis
- https://doi.org/10.1186/s12967-017-1197-5 may be missing for title: Transcriptomic profiling and quantitative high-throughput (qHTS) drug screening of CDH1 deficient hereditary diffuse gastric cancer (HDGC) cells identify treatment leads for familial gastric cancer
- https://doi.org/10.1109/csb.2003.1227309 may be missing for title: Combining microarrays and biological knowledge for estimating gene networks via bayesian networks
- https://doi.org/10.1126/science.1087361 may be missing for title: A Bayesian networks approach for predicting protein-protein interactions from genomic data
- https://doi.org/10.1371/journal.pcbi.1002110 may be missing for title: Bayesian inference for genomic data integration reduces misclassification rate in predicting protein-protein interactions
- https://doi.org/10.1186/bcr2887 may be missing for title: Three interrelated themes in current breast cancer research: gene addiction, phenotypic plasticity, and cancer stem cells
- https://doi.org/10.1007/s10555-016-9626-0 may be missing for title: Thrombin-unique coagulation system protein with multifaceted impacts on cancer and metastasis
- https://doi.org/10.1093/bioinformatics/btp692 may be missing for title: RNA-Seq gene expression estimation with read mapping uncertainty
- https://doi.org/10.1093/nar/gkl811 may be missing for title: CancerGenes: a gene selection resource for cancer genome projects
- https://doi.org/10.1111/1567-1364.12094 may be missing for title: The expanding role of yeast in cancer research and diagnosis: insights into the function of the oncosuppressors p53 and BRCA1/2
- https://doi.org/10.3390/ijms10062763 may be missing for title: Yeast two-hybrid, a powerful tool for systems biology
- https://doi.org/10.1002/path.4842 may be missing for title: Cancer predisposition syndromes: lessons for truly precision medicine
- https://doi.org/10.3322/caac.21329 may be missing for title: Translating cancer genomes and transcriptomes for precision oncology
- https://doi.org/10.1038/nrg.2016.49 may be missing for title: Coming of age: ten years of next-generation sequencing technologies
- https://doi.org/10.1038/79120 may be missing for title: Methylation of the CDH1 promoter as the second genetic hit in hereditary diffuse gastric cancer
- https://doi.org/10.1038/aps.2012.30 may be missing for title: E-cadherin promotes proliferation of human ovarian cancer cells in vitro via activating MEK/ERK pathway
- https://doi.org/10.1038/onc.2012.563 may be missing for title: Soluble E-cadherin: a critical oncogene modulating receptor tyrosine kinases, MAPK and PI3K/Akt/mTOR signaling
- https://doi.org/10.1038/onc.2008.470 may be missing for title: E-cadherin directly contributes to PI3K/AKT activation by engaging the PI3K-p85 regulatory subunit to adherens junctions of ovarian carcinoma cells
- https://doi.org/10.1038/onc.2008.343 may be missing for title: Cadherins and cancer: how does cadherin dysfunction promote tumor progression?
- https://doi.org/10.1371/journal.pone.0046665 may be missing for title: Down-regulation of CDH1 is associated with expression of SNAI1 in colorectal adenomas
- https://doi.org/10.1038/sj.bjc.6604560 may be missing for title: Reduced expression of a gene proliferation signature is associated with enhanced malignancy in colon cancer
- https://doi.org/10.1186/gb-2013-14-4-r34 may be missing for title: Interactions between immunity, proliferation and molecular subtype in breast cancer prognosis
- https://doi.org/10.1038/ng.2984 may be missing for title: Recurrent gain-of-function mutations of RHOA in diffuse-type gastric carcinoma
- https://doi.org/10.1038/ng.2983 may be missing for title: Whole-genome sequencing and comprehensive molecular profiling identify new driver mutations in gastric cancer
- https://doi.org/10.1038/ng.3073 may be missing for title: An integrated genomics approach identifies drivers of proliferation in luminal-subtype human breast cancer
- https://doi.org/10.1186/bcr2899 may be missing for title: Analysis of tumor environmental response and oncogenic pathway activation identifies distinct basal and luminal features in HER2-related breast tumor subtypes
- https://doi.org/10.1142/9789814434478_0005 may be missing for title: An algorithm for drawing general undirected graphs
- https://doi.org/10.1093/nar/gkv1108 may be missing for title: SynLethDB: synthetic lethality database toward discovery of selective and sensitive anticancer drug targets
- https://doi.org/10.1038/nature03001 may be missing for title: Finishing the euchromatic sequence of the human genome
- https://doi.org/10.1038/ejhg.2012.247 may be missing for title: Clinical utility gene card for: Hereditary diffuse gastric cancer (HDGC)
- https://doi.org/10.1038/nature14129 may be missing for title: Comprehensive genomic characterization of head and neck squamous cell carcinomas
- https://doi.org/10.1038/nature12222 may be missing for title: Comprehensive molecular characterization of clear cell renal cell carcinoma
- https://doi.org/10.1038/nature21386 may be missing for title: Integrated genomic and molecular characterization of cervical cancer
- https://doi.org/10.1038/nature11252 may be missing for title: Comprehensive molecular characterization of human colon and rectal cancer
- https://doi.org/10.1038/ng.2764 may be missing for title: The Cancer Genome Atlas Pan-Cancer analysis project
- https://doi.org/10.1126/science.1084564 may be missing for title: The Human Genome Project: lessons from large-scale biology
- https://doi.org/10.1038/nbt1485 may be missing for title: The development and impact of 454 sequencing
- https://doi.org/10.1093/bioinformatics/btv733 may be missing for title: PaxtoolsR: pathway analysis in R using Pathway Commons
- https://doi.org/10.1371/journal.pcbi.1003194 may be missing for title: Using biological pathway data with Paxtools
- https://doi.org/10.1093/nar/gkq1039 may be missing for title: Pathway Commons, a web resource for biological pathway data
- https://doi.org/10.1093/bioinformatics/bti623 may be missing for title: ROCR: visualizing classifier performance in R
- https://doi.org/10.1093/clinchem/39.4.561 may be missing for title: Receiver-operating characteristic (ROC) plots: a fundamental evaluation tool in clinical medicine.
- https://doi.org/10.1186/gb-2009-10-3-r25 may be missing for title: Ultrafast and memory-efficient alignment of short DNA sequences to the human genome
- https://doi.org/10.1093/nar/gkq622 may be missing for title: MapSplice: accurate mapping of RNA-seq reads for splice junction discovery
- https://doi.org/10.1038/ncomms11908 may be missing for title: Erratum: The somatic mutation profiles of 2,433 breast cancers refine their genomic and transcriptomic landscapes
- https://doi.org/10.1038/nature10983 may be missing for title: The genomic and transcriptomic architecture of 2,000 breast tumours reveals novel subgroups
- https://doi.org/10.1038/nbt.1637 may be missing for title: Comparative assessment of methods for aligning multiple genome sequences
- https://doi.org/10.1093/bib/bbl026 may be missing for title: Open source tools and toolkits for bioinformatics: significance, and where are we?
- https://doi.org/10.1038/nrg3394 may be missing for title: Reuse of public genome-wide gene expression data
- https://doi.org/10.1093/nar/gks1174 may be missing for title: ArrayExpress update–trends in database growth and links to data analysis tools
- https://doi.org/10.1016/j.ctrv.2011.11.005 may be missing for title: Molecular biology in breast cancer: intrinsic subtypes and signaling pathways
- https://doi.org/10.1200/jco.20.5.1260 may be missing for title: Outcome of preventive surgery and screening for breast and ovarian cancer in BRCA mutation carriers
- https://doi.org/10.1186/gb-2007-8-5-r76 may be missing for title: Identification of conserved gene expression features between murine mammary carcinoma models and human breast tumors
- https://doi.org/10.1634/theoncologist.2010-s5-39 may be missing for title: Molecular stratification of triple-negative breast cancers
- https://doi.org/10.1261/rna.1947110 may be missing for title: Systematic comparison of microarray profiling, real-time PCR, and next-generation sequencing technologies for measuring differential microRNA expression
- https://doi.org/10.1373/clinchem.2015.249623 may be missing for title: Systematic Evaluation of Sanger Validation of Next-Generation Sequencing Variants
- https://doi.org/10.1371/journal.pone.0103917 may be missing for title: A method for quantitative analysis of standard and high-throughput qPCR expression data based on input sample quantity
- https://doi.org/10.1126/science.1105136 may be missing for title: The ENCODE (ENCyclopedia Of DNA Elements) Project
- https://doi.org/10.14343/jcscr.2016.4e1003 may be missing for title: Cancer incidence and mortality worldwide: sources, methods and major patterns in GLOBOCAN 2012
- https://doi.org/10.1200/jco.2006.09.1066 may be missing for title: Meta-analysis of BRCA1 and BRCA2 penetrance
- https://doi.org/10.1093/carcin/21.5.857 may be missing for title: Disorders in cell circuitry during multistage carcinogenesis: the role of homeostasis
- https://doi.org/10.1093/nar/gku1179 may be missing for title: Gene Ontology Consortium: going forward
- https://doi.org/10.1186/bcr326 may be missing for title: Update on HER-2 as a target for cancer therapy: herceptin in the clinical setting
- https://doi.org/10.1016/j.yane.2012.02.046 may be missing for title: Hallmarks of cancer: the next generation
- https://doi.org/10.1038/452788b may be missing for title: James Watson’s genome sequenced at high speed
- https://doi.org/10.1038/44413 may be missing for title: Wellcome funds cancer database
- https://doi.org/10.1073/pnas.70.12.3581 may be missing for title: The Nucleotide Sequence of the lac Operator
- https://doi.org/10.1158/1535-7163.mct-14-0845 may be missing for title: Functional Genetic Screen Identifies Increased Sensitivity to WEE1 Inhibition in Cells with Defects in Fanconi Anemia and HR Pathways
- https://doi.org/10.1200/jco.2008.16.0812 may be missing for title: A synthetic lethal therapeutic approach: poly(ADP) ribose polymerase inhibitors for the treatment of cancers deficient in DNA double-strand break repair
- https://doi.org/10.1016/j.cell.2011.03.020 may be missing for title: Genetic interactions in cancer progression and treatment
- https://doi.org/10.1371/journal.pgen.1004120 may be missing for title: Quantitative genome-wide genetic interaction screens reveal global epistatic relationships of protein complexes in Escherichia coli
- https://doi.org/10.1097/00006842-200405000-00021 may be missing for title: What you see may not be what you get: a brief, nontechnical introduction to overfitting in regression-type models
- https://doi.org/10.1515/9781400841356.321 may be missing for title: On the properties of small-world network models
- https://doi.org/10.1016/s0076-6879(10)70007-0 may be missing for title: Synthetic genetic array (SGA) analysis in Saccharomyces cerevisiae and Schizosaccharomyces pombe
- https://doi.org/10.1186/1471-2164-15-158 may be missing for title: High throughput synthetic lethality screen reveals a tumorigenic role of adenylate cyclase in fumarate hydratase-deficient cancer cells
- https://doi.org/10.1038/nrg2085 may be missing for title: Exploring genetic interactions and networks with yeast
- https://doi.org/10.3389/fgene.2013.00290 may be missing for title: Genetic interaction networks: better understand to better predict
- https://doi.org/10.1038/ng0806-862 may be missing for title: From worm genetic networks to complex human diseases
- https://doi.org/10.1186/1471-2105-10-17 may be missing for title: Predicting genetic interactions with random walks on biological networks
- https://doi.org/10.1016/j.copbio.2010.11.001 may be missing for title: Charting the genetic interaction map of a cell
- https://doi.org/10.1038/ng1640 may be missing for title: The synthetic genetic interaction spectrum of essential genes
- https://doi.org/10.1158/0008-5472.can-12-3956 may be missing for title: A comparative genomic approach for identifying synthetic lethal interactions in human cancer
- https://doi.org/10.4161/cib.7501 may be missing for title: Exploring the conservation of synthetic lethal genetic interaction networks
- https://doi.org/10.1073/pnas.0806261105 may be missing for title: Significant conservation of synthetic lethal genetic interaction networks between distantly related eukaryotes
- https://doi.org/10.1017/s0080456800012163 may be missing for title: XV.—The Correlation between Relatives on the Supposition of Mendelian Inheritance
- https://doi.org/10.1038/sj.onc.1208044 may be missing for title: Towards full employment: using RNAi to find roles for the redundant
- https://doi.org/10.1002/widm.1055 may be missing for title: Mining high-throughput screens for cancer drug targets-lessons from yeast chemical-genomic profiling and synthetic lethality
- https://doi.org/10.1371/journal.pone.0060847 may be missing for title: Systematic Analysis of Experimental Phenotype Data Reveals Gene Functions
- https://doi.org/10.1103/physreve.65.026107 may be missing for title: Growing scale-free networks with tunable clustering
- https://doi.org/10.1038/nchembio.118 may be missing for title: Network pharmacology: the next paradigm in drug discovery
- https://doi.org/10.1016/j.cell.2014.07.027 may be missing for title: Predicting Cancer-Specific Vulnerability via Data-Driven Detection of Synthetic Lethality
- https://doi.org/10.1038/nbt1096 may be missing for title: Systematic interpretation of genetic interactions using protein networks
- https://doi.org/10.1038/nmeth.2436 may be missing for title: Mapping genetic interactions in human cancer cells with RNAi and multiparametric phenotyping
- https://doi.org/10.1371/journal.pone.0010624 may be missing for title: Searching for Signaling Balance through the Identification of Genetic Interactors of the Rab Guanine-Nucleotide Dissociation Inhibitor gdi-1
- https://doi.org/10.1101/gr.102749.109 may be missing for title: Predicting genetic modifier loci using functional gene networks
- https://doi.org/10.1007/978-1-59745-243-4_20 may be missing for title: Effects of functional bias on supervised learning of a gene network model
- https://doi.org/10.1016/j.cell.2012.03.031 may be missing for title: Sequential application of anticancer drugs enhances cell death by rewiring apoptotic signaling networks
- https://doi.org/10.1186/1752-0509-5-73 may be missing for title: Understanding and predicting synthetic lethal genetic interactions in Saccharomyces cerevisiae using domain genetic interactions
- https://doi.org/10.1109/bibm.2013.6732609 may be missing for title: Syn-Lethality: An Integrative Knowledge Base of Synthetic Lethality towards Discovery of Selective Anticancer Therapies
- https://doi.org/10.1038/ncomms3124 may be missing for title: Genome evolution predicts genetic interactions in protein complexes and reveals cancer drug targets
- https://doi.org/10.1037/e400002009-005 may be missing for title: The Small World Problem
- https://doi.org/10.1038/ng1258 may be missing for title: DNA helicase gene interaction network defined using synthetic lethality analyzed by microarray
- https://doi.org/10.1186/1471-2105-9-426 may be missing for title: Mining protein networks for synthetic genetic interactions
- https://doi.org/10.1371/journal.pcbi.1000928 may be missing for title: An integrative multi-network and multi-classifier approach to predict genetic interactions
- https://doi.org/10.1101/gr.077693.108 may be missing for title: Finding friends and enemies in an enemies-only network: A graph diffusion kernel for predicting novel genetic interactions and co-complex membership from yeast genetic interactions
- https://doi.org/10.1126/science.1162609 may be missing for title: Conservation and rewiring of functional modules revealed by an epistasis map in fission yeast
- https://doi.org/10.1038/nmeth1098 may be missing for title: High-throughput genetic interaction mapping in the fission yeast Schizosaccharomyces pombe
- https://doi.org/10.1016/j.ymeth.2006.07.034 may be missing for title: Quantitative genetic analysis in Saccharomyces cerevisiae using epistatic miniarray profiles (E-MAPs) and its application to chromatin functions
- https://doi.org/10.1016/j.neo.2014.04.007 may be missing for title: CSNK1E/CTNNB1 are synthetic lethal to TP53 in colorectal cancer and are markers for prognosis
- https://doi.org/10.1038/ng.114 may be missing for title: Evolutionary plasticity of genetic interaction networks
- https://doi.org/10.1515/9781400841356.130 may be missing for title: An Experimental Study of the Small World Problem
- https://doi.org/10.1089/104303404322959515 may be missing for title: Novel integrase-defective lentiviral episomal vectors for gene transfer
- https://doi.org/10.1093/nar/gku1075 may be missing for title: COSMIC: exploring the world’s knowledge of somatic mutations in human cancer
- https://doi.org/10.1038/msb.2013.54 may be missing for title: A negative genetic interaction map in isogenic cancer cell lines reveals cancer cell vulnerabilities
- https://doi.org/10.1186/s12864-016-2375-1 may be missing for title: Multi-omic measurement of mutually exclusive loss-of-function enriches for candidate synthetic lethal gene pairs
- https://doi.org/10.1515/9781400841356.301 may be missing for title: Collective dynamics of ’small-world’ networks
- https://doi.org/10.1073/pnas.0406614101 may be missing for title: Combining biological networks to predict genetic interactions
- https://doi.org/10.4137/cin.s14026 may be missing for title: In silico prediction of synthetic lethality by meta-analysis of genetic interactions, functions, and pathways in yeast and human cancer
- https://doi.org/10.1142/s0219720015410024 may be missing for title: Predicting essential genes and synthetic lethality via influence propagation in signaling pathways of cancer cell fates
- https://doi.org/10.1371/journal.pcbi.1003637 may be missing for title: Essential Plasticity and Redundancy of Metabolism Unveiled by Synthetic Lethality Analysis
- https://doi.org/10.3390/biom2040635 may be missing for title: Strategies for the Use of Poly(adenosine diphosphate ribose) Polymerase (PARP) Inhibitors in Cancer Therapy
- https://doi.org/10.1515/9781400841356.349 may be missing for title: Emergence of scaling in random networks
- https://doi.org/10.1038/nrg1272 may be missing for title: Network biology: understanding the cell’s functional organization
- https://doi.org/10.1038/nrg2918 may be missing for title: Network medicine: a network-based approach to human disease
- https://doi.org/10.1093/bib/bbr012 may be missing for title: Travelling the world of gene–gene interactions
- https://doi.org/10.1016/s0306-4379(97)00021-5 may be missing for title: A New and Versatile Method for Association Generation
- https://doi.org/10.1111/j.2517-6161.1995.tb02031.x may be missing for title: Controlling the False Discovery Rate: A Practical and Powerful Approach to Multiple Testing
- https://doi.org/10.1093/biostatistics/kxj037 may be missing for title: Adjusting batch effects in microarray expression data using empirical Bayes methods
- https://doi.org/10.1038/nrc1691 may be missing for title: The concept of synthetic lethality in the context of anticancer therapy
- https://doi.org/10.1186/gm99 may be missing for title: Synthetic Lethality: a framework for the development of wiser cancer therapeutics
- https://doi.org/10.1371/journal.pone.0125795 may be missing for title: Predicting human genetic interactions from cancer genome evolution
- https://doi.org/10.1002/emmm.201100150 may be missing for title: Combined genomic and phenotype screening reveals secretory factor SPINK1 as an invasion and survival factor associated with patient prognosis in breast cancer
- https://doi.org/10.1158/1535-7163.mct-14-1092 may be missing for title: Synthetic lethal screens identify vulnerabilities in GPCR signalling and cytoskeletal organization in E-cadherin-deficient cells
- https://doi.org/10.1016/j.neo.2014.04.007 may be missing for title: CSNK1E/CTNNB1 are synthetic lethal to TP53 in colorectal cancer and are markers for prognosis
- https://doi.org/10.1186/1755-8794-6-30 may be missing for title: Identification of potential synthetic lethal genes to p53 using a computational biology approach
- https://doi.org/10.1093/nar/gkv007 may be missing for title: limma powers differential expression analyses for RNA-sequencing and microarray studies
- https://doi.org/10.1083/jcb.200212033 may be missing for title: Adhesion-independent mechanism for suppression of tumor cell invasion by E-cadherin
- https://doi.org/10.1002/j.1460-2075.1995.tb00301.x may be missing for title: E-cadherin is a tumour/invasion suppressor gene mutated in human lobular breast cancers
- https://doi.org/10.1016/j.ccr.2014.08.008 may be missing for title: DAISY: Picking Synthetic Lethals from Cancer Genomes
- https://doi.org/10.1038/bjc.1997.523 may be missing for title: E-cadherin inactivation in lobular carcinoma in situ of the breast: an early event in tumorigenesis
- https://doi.org/10.1101/cshperspect.a003129 may be missing for title: Involvement of Members of the Cadherin Superfamily in Cancer
- https://doi.org/10.1002/(sici)1096-9896(199712)183:4<404::aid-path1148>3.0.co;2-9 may be missing for title: Simultaneous loss of E-cadherin and catenins in invasive lobular breast cancer and lobular carcinoma in situ
- https://doi.org/10.1038/nrc2620 may be missing for title: Transitions between epithelial and mesenchymal states: acquisition of malignant and stem cell traits

INVALID DOIs

- None
majensen commented 4 years ago

Replicating @arfon comment here regarding trimming bibtex entries:

@TomKellyGenetics - you might want to truncate your bibtex entries to only those that are cited in the JOSS paper to prevent Whedon responses like this one: #2137 (comment)

https://github.com/openjournals/joss-reviews/issues/2137#issuecomment-597923101

majensen commented 4 years ago

@TomKellyGenetics - in the first paragraph of Methodology and software, there is a sentence:

...of the popular package, which is often used...

Seems like the package name is missing here, or I'm missing something.

TomKellyGenetics commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

TomKellyGenetics commented 4 years ago

This should build with updates from minor (formatting) corrections from errors found while submitting to CRAN and bioRxiv. I’ll look into removing unneeded references from the bibtex file. An updated submission with corrected documentation has been re-uploaded to CRAN and is pending manual confirmation.

arfon commented 4 years ago

Dear authors and reviewers

We wanted to notify you that in light of the current COVID-19 pandemic, JOSS has decided to suspend submission of new manuscripts and to handle existing manuscripts (such as this one) on a "best efforts basis". We understand that you may need to attend to more pressing issues than completing a review or updating a repository in response to a review. If this is the case, a quick note indicating that you need to put a "pause" on your involvement with a review would be appreciated but is not required.

Thanks in advance for your understanding.

Arfon Smith, Editor in Chief, on behalf of the JOSS editorial team.

TomKellyGenetics commented 4 years ago

Dear Arfon,

Thank you for informing us on your policy. I'm currently based in Japan (which is considering to declare a state of emergency) so we're acutely aware of the developing situation here. I understand completely if reviews will take longer than usual during this time. I am safely able to work from home so can still respond to reviewers if they are able to.

Thank you,

Tom Kelly, Postdoctoral researcher at RIKEN IMS, Yokohama

corybrunson commented 4 years ago

@TomKellyGenetics the submission looks pretty cool, as i'm just starting my review. I have some comments on the paper before i begin exploring the software. Sorry if you've already caught some of these but not yet updated the PDF.

corybrunson commented 4 years ago

@TomKellyGenetics a couple of other comments, specifically on the code in the paper:

corybrunson commented 4 years ago

@TomKellyGenetics one last point on the paper:

rcannood commented 4 years ago

Sorry for my late response, I didn't manage to find any spare time until now. @majensen I wanted to start the review just now, but I see I missed the opportunity to accept whedon's invitation to the repository. (I thought I had retained the rights since my previous review, but apparently they get removed after the review is done.) Could I somehow be invited again?

TomKellyGenetics commented 4 years ago

Thanks @corybrunson, I'll take a look at Issues as they come into the package repo (I think the problem with plot_directed is resolved).

I can reformat the Statement of Need if this is required explicitly by JOSS. I made it a separate section (as done by other recent submissions) so it would be clear for the editorial process.

Sorry it seems that some text formatting for language and package names weren't handled well when exporting LaTeX to whedon-compatible markdown. I've fixed these on the biorXiv version and I'll update the JOSS submission accordingly.

Wang et al (2018) also simulate gene expression counts as a log-normal distribution. This package was originally developed before this publication. The approach to simulate based on graph structures is our original design. To my knowledge, there are no pre-existing implementations for this procedure in R.

The second author is my PhD supervisor. He was involved in planning, overseeing the project and preparing the manuscript. He has tested the software and given feedback on it.

I'll update the PDF once I've corrected the issues mentioned with the markdown document.

arfon commented 4 years ago

@whedon re-invite @rcannood

whedon commented 4 years ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
arfon commented 4 years ago

@whedon re-invite @rcannood as reviewer

whedon commented 4 years ago

OK, the reviewer has been re-invited.

@rcannood please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

rcannood commented 4 years ago

Thanks @arfon @whedon!

majensen commented 4 years ago

Thanks @arfon; WB @rcannood !

majensen commented 4 years ago

@corybrunson - my opinion as editor (which will be addressed by @arfon if I'm wrong) is that the paper should be sure to include the rationale for writing the software and why there is a niche for it. Not necessary to have a heading (personally, I think that would be stylistically gauche-- but that's only my opinion!).

corybrunson commented 4 years ago

@TomKellyGenetics no problem, i'll come back to the PDF after the next update.

Regarding the Statement of Need, i'll be fine with the current formatting (above the Summary with its own header) if you want to keep it (thank you @majensen for your comment); my concern is that it says only what the software does, not what need it satisfies. The first three paragraphs of the Introduction do this quite well, so i'd suggest encapsulating them into 2 or 3 sentences for that purpose.

Onward to the software itself. : )

TomKellyGenetics commented 4 years ago

@majensen @corybrunson Thanks for your advice, I agree. I thought a separate Statement of Need section was required by JOSS. I'd prefer to merge it into the Summary and avoid repetition so I'll do this as no one seems to object to this.

corybrunson commented 4 years ago

@TomKellyGenetics what do you think about incorporating the summary statement of need you're preparing into the DESCRIPTION and/or README as well? This would resolve the criterion for the software documentation as well as for the paper.

TomKellyGenetics commented 4 years ago

Hi @corybrunson, that sounds like a good idea. I'm planning update the manuscript and documentation in the next few days to make the the changes discussed so far.

TomKellyGenetics commented 4 years ago

@whedon generate pdf

TomKellyGenetics commented 4 years ago

Minor changes to the manuscript to aid further review.

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

corybrunson commented 4 years ago

@TomKellyGenetics i see your recent responses and will get to the repo issues next. I see only a few remaining issues with the paper:

corybrunson commented 4 years ago

@TomKellyGenetics sorry, one more:

TomKellyGenetics commented 4 years ago

Thanks @corybrunson, you've explained what is required very clearly. I've updated the manuscript as suggested.

The "igraph.extensions" library isn't so important at this stage, I've migrated all required functions into "graphsim" to satisfy CRAN requirements (no remote dependencies). It's for convenience to install other packages similar to the initial release of "tidyverse". I've updated the text to clarify this but I can remove it if it is not relevant (i.e., if JOSS submissions should only describe software on CRAN or similar repositories).

corybrunson commented 4 years ago

@TomKellyGenetics That sounds fine! No need to drop the extensions library if you find it useful; i was just unclear about it at first.

majensen commented 4 years ago

@corybrunson @rcannood can I get a progress report here? Are we stalled due to pandemic or ...? thanks

corybrunson commented 4 years ago

@majensen thanks for checking. There are a few issues that remain open on the repo, and @TomKellyGenetics has been making some revisions to the paper. (They may wish to comment.) I expect to be done with my review once these changes are made. (I don't expect to be slowed by the pandemic.)

rcannood commented 4 years ago

Same here. I am waiting for TomKellyGenetics/graphsim#13 to tick the final two checkboxes on my review checklist.

TomKellyGenetics commented 4 years ago

@majensen Sorry for the delays. I'm balancing childcare at home and a new position not related to this work. I'm still able work during the pandemic but revisions are taking longer than I'd have liked.

I expect the most time-consuming aspect will be revising the vignettes. The reviewers made good suggestions and I will make the requested revisions. Overall, I'm impressed by the JOSS review process and feel it will genuinely improve the package and paper.

It is a holiday period here in Japan next week. I will get back onto it after that and update you when it is ready. Thanks all for your patience.

rcannood commented 4 years ago

I understand your situation very well :smile: Enjoy your family and your holidays!

majensen commented 4 years ago

Thanks @TomKellyGenetics , no pressure at all, just checking if all was well.

majensen commented 4 years ago

How are things @TomKellyGenetics? Hope they are settling down for you.

TomKellyGenetics commented 4 years ago

Thanks for following up, it's taken longer than I'd planned but you can see most of the recent progress here: https://github.com/TomKellyGenetics/graphsim/issues/13

The main update is that the paper has been migrated to Rmarkdown format (with a few changes to the figure formatting that I've yet to test on Whedon). https://github.com/TomKellyGenetics/graphsim/blob/master/paper/paper.Rmd

I've also made changes to the computation of the state parameter which addresses this. Figures have been updated to reflect this change.

I'm unable to exactly reproduce the heatmaps displayed in the paper. They're based on the graph with inhibitions, and i'm also not clear on how to incorporate the vector state into these calculations, after looking into the code only a slight bit. (For issues running examples, etc. in the package itself, i'll open issues on the GitHub repo.)

I've started on the vignettes which was raised by both reviewers. This includes reformatting the vignettes in similar style to the Rmarkdown paper and including examples from the data directory as suggested. https://github.com/TomKellyGenetics/graphsim/issues/11 https://github.com/TomKellyGenetics/graphsim/issues/6

As discussed on the issue I'll update the manuscript text after the documentation. I should have some time to finish the biggest changes to the vignettes soon. I'll update this thread when the revised package and manuscript and ready for further review.

arfon commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

PDF failed to compile for issue #2161 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in initialize': No such file or directory @ rb_sysopen - tmp/2161/paper/paper.yml (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:inopen' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon.rb:123:inload_yaml' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon/processor.rb:36:innew' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/bin/whedon:63:inprepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:ininvoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:instart' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-45a043c4bfc2/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:inload' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

arfon commented 4 years ago

@TomKellyGenetics - a few comments on your paper:

The fact that paper.md and paper.tex exist in your repository confuses Whedon (hence the errors above).

The compiled paper compiled here is very long (15 pages currently) and much longer than we normally expect at JOSS (~1000 words is the guidance on length). Could you take a look at reducing the length, for example, by moving some of the long code examples to other documentation?

TomKellyGenetics commented 4 years ago

Thanks @arfon. I was unsure if Whedon would handle the new format. I'll look into that (I think adding the paper.tex to .gitignore and removing it from the repository) will avoid this.

I realise the manuscript is longer than recommended for the journal, I contacted @karthik about this before submitting. As suggested by reviewers, migrating to Rmarkdown format and including examples of empirical networks aids readers to understand and reproduce the results. Unfortunately the Rmarkdown format does make the manuscript even longer (to include all code needed to produce the figures).

I'll consider removing some of it (e.g., Figures 2 and 3), when the vignettes have been updated to cover this material. As suggested here, removing warning messages in Rmarkdown would also make it shorter.

I'll check if panes of different sizes (e.g., Figure 2E) are compatible with Whedon. Since LaTeX many packages are not supported, it was difficult to include subcaptions on the figures, is it possible to add this functionality? The code to add captions in R also makes the manuscript longer than otherwise needed.

TomKellyGenetics commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

TomKellyGenetics commented 4 years ago

Here's a preview of the manuscript in Rmarkdown form with the code examples simplified (I'll add more details in the vignettes). This is a work-in-progress.

I've contacted my coauthor to discuss to reducing the length of the paper.

arfon commented 4 years ago

Here's a preview of the manuscript in Rmarkdown form with the code examples simplified (I'll add more details in the vignettes). This is a work-in-progress.

I've contacted my coauthor to discuss to reducing the length of the paper.

Thanks for working on this @TomKellyGenetics.

I'll check if panes of different sizes (e.g., Figure 2E) are compatible with Whedon. Since LaTeX many packages are not supported, it was difficult to include subcaptions on the figures, is it possible to add this functionality?

I don't believe a subcaption is possible with Pandoc and this template sorry.

karthik commented 4 years ago

Unfortunately the Rmarkdown format does make the manuscript even longer (to include all code needed to produce the figures).

Have you considered just hiding those blocks?