openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: fnnls: An Implementation of Fast Nonnegative Least Squares #2225

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @jvendrow (Joshua Vendrow) Repository: https://github.com/jvendrow/fnnls Version: v.0.0.1 Editor: Pending Reviewer: Pending Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @jvendrow. Currently, there isn't an JOSS editor assigned to your paper.

@jvendrow if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.04 s (398.0 files/s, 32895.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           7            223            231            368
Markdown                         5             63              0            145
TeX                              1             11              0            108
YAML                             1              0              0              8
-------------------------------------------------------------------------------
SUM:                            14            297            231            629
-------------------------------------------------------------------------------

Statistical information for the repository '2225' was gathered on 2020/05/22.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Joshua Vendrow                   5             5              4            0.66
jamiehadd                        2            55              1            4.13
jvendrow                        10          1028            263           95.21

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Joshua Vendrow              776        15520.0          0.2               11.60
jamiehadd                    46           83.6          0.1                8.70
whedon commented 4 years ago
Reference check summary:

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.1002/(sici)1099-128x(199709/10)11:5<393::aid-cem483>3.0.co;2-l may be missing for title: A fast non-negativity-constrained least squares algorithm
- https://doi.org/10.1016/s0169-7439(97)00032-4 may be missing for title: PARAFAC. Tutorial and applications
- https://doi.org/10.1109/camsap45676.2019.9022678 may be missing for title: Neural Nonnegative Matrix Factorization for Hierarchical Multilayer Topic Modeling
- https://doi.org/10.1109/camsap45676.2019.9022678 may be missing for title: Neural Nonnegative Matrix Factorization for Hierarchical Multilayer Topic Modeling
- https://doi.org/10.1007/s00041-008-9030-4 may be missing for title: A randomized Kaczmarz algorithm with exponential convergence
- https://doi.org/10.1287/moor.1100.0456 may be missing for title: Randomized methods for linear constraints: convergence rates and conditioning

INVALID DOIs

- https://doi.org/10.1038/s41592-019-0686-2 is INVALID because of 'https://doi.org/' prefix
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

jvendrow commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

PDF failed to compile for issue #2225 with the following error:

Error reading bibliography ./paper.bib (line 10, column 3): unexpected "d" expecting space, ",", white space or "}" Error running filter pandoc-citeproc: Filter returned error status 1 Looks like we failed to compile the PDF

jvendrow commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

jvendrow commented 4 years ago

@whedon commands

whedon commented 4 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository
jvendrow commented 4 years ago

@whedon check repository

whedon commented 4 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.04 s (314.8 files/s, 26214.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           7            223            231            368
Markdown                         5             63              0            145
TeX                              1             11              0            117
YAML                             1              0              0              8
-------------------------------------------------------------------------------
SUM:                            14            297            231            638
-------------------------------------------------------------------------------

Statistical information for the repository '2225' was gathered on 2020/05/23.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Joshua Vendrow                   5             5              4            0.66
jamiehadd                        2            55              1            4.12
jvendrow                        11          1030            265           95.22

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Joshua Vendrow              776        15520.0          0.3               11.60
jamiehadd                    46           83.6          0.2                8.70
jvendrow commented 4 years ago

@whedon check references

whedon commented 4 years ago
Reference check summary:

OK DOIs

- 10.1002/(sici)1099-128x(199709/10)11:5<393::aid-cem483>3.0.co;2-l is OK
- 10.1016/s0169-7439(97)00032-4 is OK
- 10.1137/1.9781611971217 is OK
- 10.1109/camsap45676.2019.9022678 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1007/BF02242280 is OK
- 10.1007/s00041-008-9030-4 is OK
- 10.1287/moor.1100.0456 is OK

MISSING DOIs

- https://doi.org/10.1109/camsap45676.2019.9022678 may be missing for title: Neural Nonnegative Matrix Factorization for Hierarchical Multilayer Topic Modeling

INVALID DOIs

- 10.5555/3008751.3008829 is INVALID
jvendrow commented 4 years ago

Here are some reviewer recommendations:

seba-1511 gaxler diegoonna
 mikeaalv
 olivertomic

arfon commented 4 years ago

Hi @jvendrow. Many thanks for your submission to JOSS. Unfortunately, after consulting with the JOSS editorial board, we have decided that this submission is out of scope for JOSS due to its limited scope.

arfon commented 4 years ago

@whedon reject

whedon commented 4 years ago

Paper rejected.