Closed whedon closed 4 years ago
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.
:warning: JOSS reduced service mode :warning:
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
For a list of things I can do to help you, just type:
@whedon commands
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@whedon generate pdf
Software report (experimental):
github.com/AlDanial/cloc v 1.84 T=0.18 s (134.8 files/s, 24308.5 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Python 13 645 1289 1167
Markdown 4 92 0 300
TeX 1 18 0 221
reStructuredText 3 176 127 221
DOS Batch 1 8 1 27
YAML 1 2 0 15
make 1 4 6 10
-------------------------------------------------------------------------------
SUM: 24 945 1423 1961
-------------------------------------------------------------------------------
Statistical information for the repository '2393' was gathered on 2020/06/25.
The following historical commit information, by author, was found:
Author Commits Insertions Deletions % of changes
Kieran 27 7164 4063 100.00
Below are the number of rows from each author that have survived and are still
intact in the current revision:
Author Rows Stability Age % in comments
Kieran 3101 43.3 9.3 15.58
Potential reviewers:
brechmos Deech08 cmillion KshitijAggarwal devanshkv zpace garrettj403 nespinoza ygrange
Kieran Leschinski Department of Astrophysics University of Vienna
Am Do., 25. Juni 2020 um 20:05 Uhr schrieb whedon <notifications@github.com
:
π Check article proof π π https://github.com/openjournals/joss-papers/blob/joss.02393/joss.02393/10.21105.joss.02393.pdf
β You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2393#issuecomment-649735211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACH66QSCX6BBXHXNA33W643RYOGVFANCNFSM4OITOHUA .
:wave: @astronomyk - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.
Since reopening JOSS earlier in the month we've had a very large number of papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.
Thanks in advance for your patience!
π @dfm - would you be able to edit this submission?
@whedon invite @dfm as editor
@dfm has been invited to edit this submission.
π @astronomyk, thanks for your submission to JOSS. I have a few questions about your submission before we can go out for review:
Basically, if the software can be applied to other instrument/observatories then I think it would be good to make it clear this is possible somewhere in the documentation/examples.
@arfon sorry for the late response. Thanks for the tips regarding extending the documentation.
In answer to your questions:
there's capability for including a custom atmosphere model,
Indeed there is the ability for this. If the user knows the Cn2 profile of the atmosphere, they can include this directly by setting the .layerAltitude
and .Cn2h
attribute. Otherwise, the standard 5 ESO profile (Q1-4, plus Median) are included for convenience. I agree the documentation doesn't explain how to do this though. I will add that to my list of updates for AnisoCADO.
software suitable for more general use
the original reason for writing the software was for the MICADO instrument. Hence a lot of the psf_utils functions are related to generating a pupil for the ELT. However essentially any other AO system could be modelled assuming there is a function available to generate the optical transfer function for telescopes pupil. Currently there is no "generic" code for doing arbitary telescope pupils, but we have plans to bring Poppy into the mix in order to do exactly this. No point in reinventing the wheel.
So to answer the question of suitability for other instruments: Off the shelf, it is currently only good at simulating ELT PSFs. However if the user has an image of their own telescope pupil, then it can be used to generate PSFs for other observatories. Another point for me to make clear in the documentation.
@whedon query scope
Thanks for providing this additional information @astronomyk. After consulting with the JOSS editorial team, we've concluded that this package is (currently) out of scope for JOSS.
We'd welcome a resubmission if a major effort was made to make this package more generalized and suitable for other instruments.
@whedon reject
Paper rejected.
Submitting author: @astronomyk (Kieran Leschinski) Repository: https://github.com/astronomyk/AnisoCADO Version: v0.2 Editor: Pending Reviewer: Pending Managing EiC: Kristen Thyng
:warning: JOSS reduced service mode :warning:
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Author instructions
Thanks for submitting your paper to JOSS @astronomyk. Currently, there isn't an JOSS editor assigned to your paper.
The author's suggestion for the handling editor is @harpolea.
@astronomyk if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: