openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: AnisoCADO: a python package for analytically generating adaptive optics point spread functions for the Extremely Large Telescope #2393

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @astronomyk (Kieran Leschinski) Repository: https://github.com/astronomyk/AnisoCADO Version: v0.2 Editor: Pending Reviewer: Pending Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @astronomyk. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @harpolea.

@astronomyk if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.18 s (134.8 files/s, 24308.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          13            645           1289           1167
Markdown                         4             92              0            300
TeX                              1             18              0            221
reStructuredText                 3            176            127            221
DOS Batch                        1              8              1             27
YAML                             1              2              0             15
make                             1              4              6             10
-------------------------------------------------------------------------------
SUM:                            24            945           1423           1961
-------------------------------------------------------------------------------

Statistical information for the repository '2393' was gathered on 2020/06/25.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Kieran                          27          7164           4063          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Kieran                     3101           43.3          9.3               15.58
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

astronomyk commented 4 years ago

Potential reviewers:

brechmos Deech08 cmillion KshitijAggarwal devanshkv zpace garrettj403 nespinoza ygrange


Kieran Leschinski Department of Astrophysics University of Vienna

Am Do., 25. Juni 2020 um 20:05 Uhr schrieb whedon <notifications@github.com

:

πŸ‘‰ Check article proof πŸ“„ πŸ‘ˆ https://github.com/openjournals/joss-papers/blob/joss.02393/joss.02393/10.21105.joss.02393.pdf

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2393#issuecomment-649735211, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACH66QSCX6BBXHXNA33W643RYOGVFANCNFSM4OITOHUA .

arfon commented 4 years ago

:wave: @astronomyk - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS earlier in the month we've had a very large number of papers submitted and as such, yours has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

danielskatz commented 4 years ago

πŸ‘‹ @dfm - would you be able to edit this submission?

danielskatz commented 4 years ago

@whedon invite @dfm as editor

whedon commented 4 years ago

@dfm has been invited to edit this submission.

arfon commented 4 years ago

πŸ‘‹ @astronomyk, thanks for your submission to JOSS. I have a few questions about your submission before we can go out for review:

Basically, if the software can be applied to other instrument/observatories then I think it would be good to make it clear this is possible somewhere in the documentation/examples.

astronomyk commented 4 years ago

@arfon sorry for the late response. Thanks for the tips regarding extending the documentation.

In answer to your questions:

labarba commented 4 years ago

@whedon query scope

arfon commented 4 years ago

Thanks for providing this additional information @astronomyk. After consulting with the JOSS editorial team, we've concluded that this package is (currently) out of scope for JOSS.

We'd welcome a resubmission if a major effort was made to make this package more generalized and suitable for other instruments.

arfon commented 4 years ago

@whedon reject

whedon commented 4 years ago

Paper rejected.