search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
706 stars 37 forks source link

[PRE REVIEW]: Grama: A Grammar of Model Analysis #2443

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @zdelrosario (Zachary del Rosario) Repository: https://github.com/zdelrosario/py_grama Version: v0.1.3 Editor: @mjsottile Reviewers: @BastinRobin, @rodrigokataishi Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @zdelrosario. Currently, there isn't an JOSS editor assigned to your paper.

@zdelrosario if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.45 s (314.2 files/s, 71675.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          80           2590           3357           7397
Jupyter Notebook                32              2          14617           1798
Markdown                        10            297              0           1159
TeX                              1             12              0            139
reStructuredText                 7            108            195            117
make                             7             20              7             53
DOS Batch                        1              8              1             26
YAML                             2              8              4             21
-------------------------------------------------------------------------------
SUM:                           140           3045          18181          10710
-------------------------------------------------------------------------------

Statistical information for the repository '2443' was gathered on 2020/07/05.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Rick Fenrich                     4             9              9            0.06
Zach                            98         11672           4374           54.86
zach                            52          2514            900           11.67
zdelrosario                    125          7103           2669           33.41

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Rick Fenrich                  6           66.7          3.2                0.00
zdelrosario               13338          187.8          3.5               10.57
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

danielskatz commented 4 years ago

@whedon check references

danielskatz commented 4 years ago

@whedon check references

danielskatz commented 4 years ago

@openjournals/dev - something seems broken here - the reference check does not return

danielskatz commented 4 years ago

👋 @zdelrosario - while we get the process started, you might fix some of the bib issues that you can see in the generated PDF related to cases (e.g., "AIAA scitec 2020 forum") by protecting words or letters in {}s and any other issues you see (such as Ward et al. missing the book/proceedings). Once you have made changes in the .bib or .md files, add @whedon generate pdf as a new comment here to see how things look.

zdelrosario commented 4 years ago

Suggested reviewers:

danielskatz commented 4 years ago

👋 @mjsottile - would you be willing to edit this submission?

danielskatz commented 4 years ago

@whedon invited @mjsottile as editor

whedon commented 4 years ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands
danielskatz commented 4 years ago

@whedon invite @mjsottile as editor

whedon commented 4 years ago

@mjsottile has been invited to edit this submission.

zdelrosario commented 4 years ago

@whedon generate pdf

@danielskatz working on broken references---still getting the hang of this (nifty!) submission system....

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

mjsottile commented 4 years ago

@whedon assign @mjsottile as editor

whedon commented 4 years ago

OK, the editor is @mjsottile

arfon commented 4 years ago

@whedon check references

arfon commented 4 years ago

@danielskatz - looks like the DOI checker is failing to parse the lines that look like this one.

@zdelrosario - could you try removing the lines of your BibTeX file that start with @comment?

zdelrosario commented 4 years ago

@arfon Done!

@whedon generate pdf

danielskatz commented 4 years ago

@whedon generate pdf

FYI: commands to whedon need to be at the start of a comment

whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

danielskatz commented 4 years ago

@whedon check references

whedon commented 4 years ago 
Reference check summary:

OK DOIs

-  10.25080/Majora-92bf1922-00a  is OK
- 10.21105/joss.01686 is OK
- 10.3233/978-1-61499-649-1-87 is OK

MISSING DOIs

- https://doi.org/10.1061/9780784413609.257 may be missing for title: UQLab: A framework for uncertainty quantification in Matlab

INVALID DOIs

- https://doi.org/10.2514/6.2020-0414 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1073/pnas.1319030111 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1038/s41592-019-0686-2 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1109/MCSE.2011.37 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1109/MCSE.2007.55 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.commatsci.2018.05.018 is INVALID because of 'https://doi.org/' prefix
danielskatz commented 4 years ago

Looks like the problem has been solved.

@zdelrosario - there are some DOIs that you should probably add to your bib file (though note that whedon sometimes gets these wrong). Also, the invalid ones need to have the "https://doi.org/" removed

zdelrosario commented 4 years ago

@whedon check references

@danielskatz removed the https and added the UQLab doi. Thanks!

whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.2514/6.2020-0414 is OK
- 10.1073/pnas.1319030111 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1109/MCSE.2011.37 is OK
- 10.1109/MCSE.2007.55 is OK
-  10.25080/Majora-92bf1922-00a  is OK
- 10.21105/joss.01686 is OK
- 10.3233/978-1-61499-649-1-87 is OK
- 10.1016/j.commatsci.2018.05.018 is OK
- 10.1061/9780784413609.257 is OK

MISSING DOIs

- None

INVALID DOIs

- None
mjsottile commented 4 years ago

:wave: @rodrigokataishi, @bastinrobin, @jaeyk, @lesaffre - the author of this submission to JOSS has indicated that you may be interested in reviewing this submission. If you are interested and willing to provide a review within the next few weeks I would greatly appreciate it. Please respond in this issue if you are willing and I will add you as a reviewer. Thank you!

jaeyk commented 4 years ago

@mjsottile I'm in the process of reviewing another submission. I can review this submission if I can start working on it 1-2 weeks later.

BastinRobin commented 4 years ago

I am interested!.

On Thu, Jul 9, 2020 at 10:40 AM Matthew Sottile notifications@github.com wrote:

👋 @rodrigokataishi https://github.com/rodrigokataishi, @BastinRobin https://github.com/BastinRobin, @jaeyk https://github.com/jaeyk, @lesaffre https://github.com/lesaffre - the author of this submission to JOSS has indicated that you may be interested in reviewing this submission. If you are interested and willing to provide a review within the next few weeks I would greatly appreciate it. Please respond in this issue if you are willing and I will add you as a reviewer. Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2443#issuecomment-655904288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA24IR65S7DXAKHVV2S5KNDR2VGK5ANCNFSM4ORASUXQ .

-- Regards,

Bastin Robin.J bastinrobins@gmail.com

rodrigokataishi commented 4 years ago

I´m interested too. Please let me know how to proceed. Best, r

On Thu, Jul 9, 2020 at 2:41 AM Bastin Robin notifications@github.com wrote:

I am interested!.

On Thu, Jul 9, 2020 at 10:40 AM Matthew Sottile notifications@github.com wrote:

👋 @rodrigokataishi https://github.com/rodrigokataishi, @BastinRobin https://github.com/BastinRobin, @jaeyk https://github.com/jaeyk, @lesaffre https://github.com/lesaffre - the author of this submission to JOSS has indicated that you may be interested in reviewing this submission. If you are interested and willing to provide a review within the next few weeks I would greatly appreciate it. Please respond in this issue if you are willing and I will add you as a reviewer. Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/openjournals/joss-reviews/issues/2443#issuecomment-655904288 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA24IR65S7DXAKHVV2S5KNDR2VGK5ANCNFSM4ORASUXQ

.

-- Regards,

Bastin Robin.J bastinrobins@gmail.com

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2443#issuecomment-655913111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEQ6OJ4UIGWX3YBVHFRT3LR2VJ65ANCNFSM4ORASUXQ .

--

Linux User # 474893, Ubuntu User # 23033

mjsottile commented 4 years ago

Excellent - I will add @BastinRobin and @rodrigokataishi as reviewers now. If you are still interested @jaeyk after you complete the other review, let me know and if we need an additional review I will add you. @rodrigokataishi - you will see instructions on the process when I initiate the review and the new review issue is created.

mjsottile commented 4 years ago

@whedon assign @BastinRobin as reviewer

whedon commented 4 years ago

OK, @BastinRobin is now a reviewer

mjsottile commented 4 years ago

@whedon add @rodrigokataishi as reviewer

whedon commented 4 years ago

OK, @rodrigokataishi is now a reviewer

mjsottile commented 4 years ago

@whedon start review

whedon commented 4 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2462.

jaeyk commented 4 years ago

@mjsottile I'm almost done with the other review. Let me know if you need an additional reviewer. Thanks.