search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: ALVA: An adaptive MATLAB package for layered viscoelastic analysis #2548

Closed whedon closed 3 years ago

whedon commented 4 years ago

Submitting author: @asmusskar (Asmus Skar) Repository: https://github.com/asmusskar/ALVA Version: v1.2 Editor: @Kevin-Mattheus-Moerman Reviewer: @AnaWaldila, @CBenghi Archive: 10.5281/zenodo.4289275

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d1a4081402f444afcf68231832a14fc1"><img src="https://joss.theoj.org/papers/d1a4081402f444afcf68231832a14fc1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d1a4081402f444afcf68231832a14fc1/status.svg)](https://joss.theoj.org/papers/d1a4081402f444afcf68231832a14fc1)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@AnaWaldila & @CBenghi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @AnaWaldila

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @CBenghi

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @AnaWaldila, @CBenghi it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 4 years ago 
Reference check summary:

OK DOIs

- 10.1080/10298436.2018.1483502 is OK
- 10.1080/14680629.2010.9690274 is OK
- 10.1080/14680629.2012.757558 is OK
- 10.3141/2037-06 is OK
- 10.3850/978-981-11-0449-7-132-cd is OK
- 10.1080/14680629.2020.1741429 is OK

MISSING DOIs

- https://doi.org/10.1080/10298436.2020.1790559 may be missing for title: Analytic pavement modeling with a fragmented layer

INVALID DOIs

- None
whedon commented 4 years ago

:point_right: Check article proof :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila, @CBenghi this is where the review takes place. Please can you let me know when you expect to be able to complete your review? Thanks again for your help! Let me know if you have any questions.

AnaWaldila commented 4 years ago

Hi, I need more 2 weeks, please. My father had an ischemic stroke and I am in hospital with him. Kind regards, Ana Reis

Obter o Outlook para Androidhttps://aka.ms/ghei36

De: Kevin Mattheus Moerman notifications@github.com Enviado: quinta-feira, 20 de agosto de 2020 09:55 Para: openjournals/joss-reviews Cc: Ana Waldila; Mention Assunto: Re: [openjournals/joss-reviews] [REVIEW]: ALVA: An adaptive MATLAB package for layered viscoelastic elastic analysis (#2548)

@AnaWaldilahttps://github.com/AnaWaldila, @CBenghihttps://github.com/CBenghi this is where the review takes place. Please can you let me know when you expect to be able to complete your review? Thanks again for your help! Let me know if you have any questions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/2548#issuecomment-677647152, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO7SK34AZQVLB3QOMOQ2KSTSBUMLFANCNFSM4PVKTOHQ.

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila thanks for letting us know. Sorry to hear that. We can be flexible. Let us know when you are able to pick this up again.

Kevin-Mattheus-Moerman commented 4 years ago

@CBenghi how are you getting on with this review? Let me know if you have any questions.

CBenghi commented 4 years ago

Sorry to hear that, @AnaWaldila. I need a little more time to adjust to recent workplace changes, will be able to pick up next week. Sorry for the delay. Claudio

AnaWaldila commented 4 years ago

Hi Kelvin, So.... my father deaed in 26th August. Well, sorry about the long time to reviewer the paper. I am finishing now. The last part is completing the list of revision that I received from @whedon. I have a question:

In Performance, did I put my considerations about the software? Because I have some suggestions for the author of the software. I dind't unsderstand this case. Well, thank you for understanding and I am sorry for the long time to revision. Kind Regards, Ana Reis

Ana Waldila de Queiroz Ramiro Reis

Doutoranda em Engenharia Civil - Estrutura (UERJ)

Engenheira Civil

Tel: (21) 9 7945 - 6510

E-mail: anawaldila@hotmail.com

De: Claudio Benghi notifications@github.com Enviado: terça-feira, 1 de setembro de 2020 06:34 Para: openjournals/joss-reviews joss-reviews@noreply.github.com Cc: Ana Waldila anawaldila@hotmail.com; Mention mention@noreply.github.com Assunto: Re: [openjournals/joss-reviews] [REVIEW]: ALVA: An adaptive MATLAB package for layered viscoelastic elastic analysis (#2548)

Sorry to hear that, @AnaWaldilahttps://github.com/AnaWaldila. I need a little more time to adjust to recent workplace changes, will be able to pick up next week. Sorry for the delay. Claudio

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/2548#issuecomment-684575560, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO7SK3ZZV5EWMZQDDONCZJTSDSW25ANCNFSM4PVKTOHQ.

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila our condolences on your loss. Thank you for your continued help here. Again we can be flexible with time so please take as much time as you need, all your help is greatly appreciated.

In Performance, did I put my considerations about the software? Because I have some suggestions for the author of the software. I dind't unsderstand this case.

Yes please comment here if you have minor comments/issues or open dedicated issues on the software repository for longer comments/issues. Let me know if you are still unsure what to do or if you have more questions.

AnaWaldila commented 4 years ago

Hi Kevin, I finished the revision. Thank you soo much for the compreension and thank you for the condolences. The last days was hard for me. How can I send to you my considerations about the paper? One more time, thank you for compreension and I are allways avaiable for a new revision to you. Kind Regards, Ana Reis

Ana Waldila de Queiroz Ramiro Reis

Doutoranda em Engenharia Civil - Estrutura (UERJ)

Engenheira Civil

Tel: (21) 9 7945 - 6510

E-mail: anawaldila@hotmail.com

De: Kevin Mattheus Moerman notifications@github.com Enviado: quarta-feira, 2 de setembro de 2020 07:56 Para: openjournals/joss-reviews joss-reviews@noreply.github.com Cc: Ana Waldila anawaldila@hotmail.com; Mention mention@noreply.github.com Assunto: Re: [openjournals/joss-reviews] [REVIEW]: ALVA: An adaptive MATLAB package for layered viscoelastic elastic analysis (#2548)

@AnaWaldilahttps://github.com/AnaWaldila our condolences on your loss. Thank you for your continued help here. Again we can be flexible with time so please take as much time as you need, all your help is greatly appreciated.

In Performance, did I put my considerations about the software? Because I have some suggestions for the author of the software. I dind't unsderstand this case.

Yes please comment here if you have minor comments/issues or open dedicated issues on the software repository for longer comments/issues. Let me know if you are still unsure what to do or if you have more questions.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/2548#issuecomment-685531498, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO7SK36C4YMHCPCZA2CEPCDSDYJEXANCNFSM4PVKTOHQ.

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila thanks for your help here. Would you be able to log in to GitHub and to comment in this issue with your findings? Also you should be able to tick the boxes related to the review items at the top of this issue (let me know if you are not able to tick them). Let me know if you have any questions.

AnaWaldila commented 4 years ago

Hi, Kelvin I opened this e-mail in GitHub and I see all boxes. Thank you for help me. I cheked some boxes and next, here, I will put my considerations, because the author needs to rectify some cases in paper. All parts in bold are my answers.

Functionality • Functionality: Have the functional claims of the software been confirmed? All of results presents in repository confirmed the functional of the software. One result input by the reviewer presents problems in result (layer frictionless). • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Software paper • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided? About general explanations, YES. • State of the field: Do the authors describe how this software compares to other commonly-used packages? NO. It needs a clear explanation about this. The author needs to explain how compareted ALVA with ELLA1, ELLVA and analytical analysis. Also that, explain more about ELLEA1, ELLVA and the analytical methods. All procession of the user can change parameters (like layers, geometry structure, materials and for exemple) are need presented in context, i.e, a short description to user the software. • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)? It’s interesting to use an impersonal expressions (expressions like “we” are not common in publishing papers). • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

NO. Next, references presented in software and not presented in list of references

Burmister, D. M. (1945). The general theory of stresses and displacements in layered systems. i. Journal of applied physics, 16(2), 89–94. Huang, Y.H., 2003. Pavement Analysis Design, 2nd Edition, Prentice-Hall, New Jersey. Ioannides, A. M., & Khazanovich, L. (1998). General formulation for multilayered pavement systems. Journal of transportation engineering, 124(1), 82–90. Levenberg, E. (2018). ELLVA_VD: Isotropic Layered Viscoelasticity in Excel: Analysis tool for interpretation of deflections measured with a moving load

Next, references presented in paper and not presented in software

Chabot, A., Chupin, O., Deloffre, L., & Duhamel, D. (2010). ViscoRoute 2.0 a: Tool for the simulation of moving load effects on asphalt pavement. Road Materials and Pavement Design, 11(2), 227–250. doi:10.1080/14680629.2010.9690274 Erlingsson, S., & Ahmed, A. W. (2013). Fast layered elastic response program for the analysis of flexible pavement structures. Road Materials and Pavement Design, 14(1), 196–210. doi:10.1080/14680629.2012.757558 Khazanovich, L., & Wang, Q. (2007). MnLayer: High-performance layered elastic analysis program. Transportation Research Record, 2037(2037), 63–75. doi:10.3141/2037-06 Levenberg, E., & Skar, A. (2020). Analytic pavement modeling with a fragmented layer. International Journal of Pavement Engineering. Taylor; Francis Ltd. Maina, J. W., De Beer, M., & Matsui, K. (2007). Effects of layer interface slip on the response and performance of elastic multi-layered flexible airport pavement systems. Maintenance and Rehabilitation of Pavements and Technological Control - Proceedings of the 5th International Conference, Mairepav 2007, 145–150. Skar, A., Levenberg, E., Andersen, S., & Andersen, M. B. (2020). Analysis of a moving measurement platform based on line profile sensors for project-level pavement evaluation. Road Materials and Pavement Design, 1–17. doi:10.1080/14680629.2020.1741429

Next, the list of references that’s appears in both cases (software and list of references), but the citation are differens:

Levenberg, E. (2016a). ELLEA1: Isotropic layered elasticity in excel: Pavement analysis tool for students and engineers. Levenberg, E. (2016b). ELLVA1: Isotropic layered viscoelasticity in excel (moving load): Advanced pavement analysis tool for students and engineers. Levenberg, E. (2016c). Viscoelastic pavement modeling with a spreadsheet. Proceedings of the Eighth International Conference on Maintenance and Rehabilitation of Pavements (mairepav8), 746–755. doi:10.3850/978-981-11-0449-7-132-cd

Please, for all cases, put the same type of references in software and in paper. Also that, it's important to references all scripts (some scripts does not have references).

Kevin-Mattheus-Moerman commented 4 years ago

@asmusskar have a look at the above comments :point_up:. Can you deal with these/formulate a response?

Kevin-Mattheus-Moerman commented 4 years ago

@CBenghi I hope that you are now also able to continue with this review. Let me know if you have any questions. Thanks

CBenghi commented 4 years ago

@Kevin-Mattheus-Moerman,

Unfortuntely all University staff IT is completely absorbed in the solution of a major incident that has crippled all fundamental services at a critical time of the new academic year, which would be hard in normal times, but unbearable in Covid times.

At the moment I cannot tell when I'll have access to online services to install Matlab; sadly, this has been going on for weeks.

@asmusskar, I would be able to test the software using Octave instead of Matlab, do you think this might be worth an attempt?

Apologies for the delay, this incident is truly unprecented in terms of scale and scope for our university.

Thanks, Claudio

asmusskar commented 4 years ago

Yes @CBenghi should be compatible with Octave 👍

Den 14. sep. 2020 kl. 17.30 skrev Claudio Benghi notifications@github.com:  @Kevin-Mattheus-Moerman,

Unfortuntely all University staff IT is completely absorbed in the solution of a major incident that has crippled all fundamental services at a critical time of the new academic year, which would be hard in normal times, but unbearable in Covid times.

At the moment I cannot tell when I'll have access to online services to install Matlab; sadly, this has been going on for weeks.

@asmusskar, I would be able to test the software using Octave instead of Matlab, do you think this might be worth an attempt?

Apologies for the delay, this incident is truly unprecented in terms of scale and scope for our university.

Thanks, Claudio

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

asmusskar commented 4 years ago

Will do my best @Kevin-Mattheus-Moerman https://github.com/Kevin-Mattheus-Moerman, any fixed deadline?

On Mon, Sep 14, 2020 at 3:02 PM Kevin Mattheus Moerman < notifications@github.com> wrote:

@asmusskar https://github.com/asmusskar have a look at the above comments ☝️. Can you deal with these/formulate a response?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2548#issuecomment-692036812, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEUAW74DFOZGFBBWHMGW2LSFYH6XANCNFSM4PVKTOHQ .

Kevin-Mattheus-Moerman commented 4 years ago

@asmusskar great. No fixed deadline. We just recommend not delaying things to much to avoid losing track of the reviewers.

Kevin-Mattheus-Moerman commented 4 years ago

@asmusskar can you report any updates on progress? Thanks

Kevin-Mattheus-Moerman commented 4 years ago

@asmusskar we do not have strict deadlines, but to avoid loosing track of the reviewers I do recommend responding in a timely manor.

asmusskar commented 4 years ago

Hi Kevin,

sure, I can respond within a few days. However I'm not sure in what format.. I respond to the reviewers comments here, and then implement the changes in the code/paper/readme accordingly?

Asmus

On Sun, Oct 4, 2020 at 12:51 PM Kevin Mattheus Moerman < notifications@github.com> wrote:

@asmusskar https://github.com/asmusskar we do not have strict deadlines, but to avoid loosing track of the reviewers I do recommend responding in a timely manor.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2548#issuecomment-703237289, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEUAW2WPID7IC2CRMENVPDSJBHTRANCNFSM4PVKTOHQ .

asmusskar commented 4 years ago

Hi @Kevin-Mattheus-Moerman https://github.com/Kevin-Mattheus-Moerman, @AnaWaldila https://github.com/AnaWaldila, @CBenghi https://github.com/CBenghi

thank you for your helpful comments on the ALVA computer package.

We have revised the software/paper accordingly and feel your comments helped clarify and improve ALVA.

Please find the response (in yellow) to the reviewers comments below:

Functionality

· Functionality: Have the functional claims of the software been confirmed? All of results presents in repository confirmed the functional of the software. One result input by the reviewer presents problems in result (layer frictionless).

· Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

o The implementation of ALVA presents 3 types of interface: Bonded, Slip and Frictionless. When the user change the type to Frictionless (line 65 of the first validation example), the results between ALVA and Analytical Case are different. Please, justify. The current version of ALVA requires minimum two layers. Thus, in order to resemble a one-layer system (i.e., half-space) the two layers should have identical material properties and their interface be bonded. Based on the Reviewers comment the following text was added in the README: “..minimum two layers is required for analysis of pavement systems in ALVA. For analysis of one-layer / half-space system, select identical parameters for each layer, as well as ”bonded” interface conditions..”

o Presentating a graphic with 3 types of interface (Bonded, Slip and Frictionless), comparing the solution of ALVA and analytical process for the each case. There is no closed form solution available for this problem. Thus, based on the Reviewers comments a new validation example “ALVA_bonding_validation1.m” was included and compared to benchmark results published by the European Commission. In addition, we show that a high interface spring value yields the same solution as the “bonded” case (self-validation).

o Its interesting the author compare in all graphics the results between ALVA and ELLEA1 about all interfaces between layers. It is not clear to the Author if this point needs to be addressed

o Presentating in all scripts references that used.

o *In repository, its interesting the author explain the input data used in each example (*https://github.com/asmusskar/ALVA https://github.com/asmusskar/ALVA). Definition of pavement system in each example script has been removed

o *In repository (*https://github.com/asmusskar/ALVA https://github.com/asmusskar/ALVA) that’s describe ALVA, the author can put an explanation in paragraph of main.m (where describes the archive main.m) about the validation examples, i. e, the validation examples are the main.m archive. Accepted and amended accordingly

o Suggestion to future work: Create an interface using AppDesigner or an interaction with user in Command Window. Validation examples are good to understand the process of input data, but the user need this type of script to input own data to create an analysis. Thanks for the suggestion; this is definitely something that we will consider in a future release of the software.

Software paper • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided? About general explanations, YES. • State of the field: Do the authors describe how this software compares to other commonly-used packages? NO. It needs a clear explanation about this. The author needs to explain how compareted ALVA with ELLA1, ELLVA and analytical analysis. Also that, explain more about ELLEA1, ELLVA and the analytical methods. Based on the Reviewers comment, the following text was added: “… The code have been validated by comparing ALVA responses at several positions within pavement system to analytical solutions and other commonly used software packages, i.e.: (i) for a one-layer model with the analytical solution for an elastic half-space, (ii) for elastic multilayered systems with the software package ELLEA [@Levenberg:2016a], and (ii) for viscoelastic multilayered systems with the software package ELLVA [@Levenberg:2016b]. Moreover, the code have been validated against benchmark results, covering a range of commonly used software packages, published by the European Commission [@amadeus:2000a]..”. The information added is limited due to two reasons: (i) The layered elastic theory (LET) and mathematical formulations for implementation is widely covered in the referenced literature, and (ii) no existing software provide their source code or explain in detail how equations are solved computationally. This is basically one of the main arguments for publishing ALVA open-source.

• References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

NO. Next, references presented in software and not presented in list of references

Burmister, D. M. (1945). The general theory of stresses and displacements in layered systems. i. Journal of applied physics, 16(2), 89–94. Huang, Y.H., 2003. Pavement Analysis Design, 2nd Edition, Prentice-Hall, New Jersey. Ioannides, A. M., & Khazanovich, L. (1998). General formulation for multilayered pavement systems. Journal of transportation engineering, 124(1), 82–90. Levenberg, E. (2018). ELLVA_VD: Isotropic Layered Viscoelasticity in Excel: Analysis tool for interpretation of deflections measured with a moving load

Next, references presented in paper and not presented in software

Chabot, A., Chupin, O., Deloffre, L., & Duhamel, D. (2010). ViscoRoute 2.0 a: Tool for the simulation of moving load effects on asphalt pavement. Road Materials and Pavement Design, 11(2), 227–250. doi:10.1080/14680629.2010.9690274 Erlingsson, S., & Ahmed, A. W. (2013). Fast layered elastic response program for the analysis of flexible pavement structures. Road Materials and Pavement Design, 14(1), 196–210. doi:10.1080/14680629.2012.757558 Khazanovich, L., & Wang, Q. (2007). MnLayer: High-performance layered elastic analysis program. Transportation Research Record, 2037(2037), 63–75. doi:10.3141/2037-06 Levenberg, E., & Skar, A. (2020). Analytic pavement modeling with a fragmented layer. International Journal of Pavement Engineering. Taylor; Francis Ltd. Maina, J. W., De Beer, M., & Matsui, K. (2007). Effects of layer interface slip on the response and performance of elastic multi-layered flexible airport pavement systems. Maintenance and Rehabilitation of Pavements and Technological Control - Proceedings of the 5th International Conference, Mairepav 2007, 145–150. Skar, A., Levenberg, E., Andersen, S., & Andersen, M. B. (2020). Analysis of a moving measurement platform based on line profile sensors for project-level pavement evaluation. Road Materials and Pavement Design, 1–17. doi:10.1080/14680629.2020.1741429

Next, the list of references that’s appears in both cases (software and list of references), but the citation are differens:

Levenberg, E. (2016a). ELLEA1: Isotropic layered elasticity in excel: Pavement analysis tool for students and engineers. Levenberg, E. (2016b). ELLVA1: Isotropic layered viscoelasticity in excel (moving load): Advanced pavement analysis tool for students and engineers. Levenberg, E. (2016c). Viscoelastic pavement modeling with a spreadsheet. Proceedings of the Eighth International Conference on Maintenance and Rehabilitation of Pavements (mairepav8), 746–755. doi:10.3850/978-981-11-0449-7-132-cd

Please, for all cases, put the same type of references in software and in paper. Also that, it's important to references all scripts (some scripts does not have references).

To comply with the reviewers comments, all references in the script also appear in the paper (with the same citation format).

Best Regards,

Asmus

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila, @CBenghi it looks like the author has made several changes and replied to issues raised. Can you resume review at this point please? Thanks again for your help!

AnaWaldila commented 4 years ago

Hey @Kevin-Mattheus-Moerman, sorry for late to answer. Dont't worry, I will see what @asmusskar answered about the revision in few days.

AnaWaldila commented 4 years ago

@asmusskar, thank you to modify all topics of revision. Only 3 other topics I need that you modify, but in this case, are details.

@Kevin-Mattheus-Moerman , after these modifications, my revision is finished. The author modifyed all recomendations and the paper, to me, is clear, well written, good examples and validations.

asmusskar commented 4 years ago

Thanks @AnaWaldila, the modifications proposed have now been implemented.

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila thanks for your reviewing efforts. The authors have made some changes :point_up:, are you able to resume this review? Thanks!

AnaWaldila commented 4 years ago

@Kevin-Mattheus-Moerman Yes, I saw. It is already correct.

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila great. Are you able to tick more boxes at the top of this issue or clarify any remaining issues? Thanks

AnaWaldila commented 4 years ago

@Kevin-Mattheus-Moerman ok! I already checked all boxes! Anything else I need to complete? Thanks!

AnaWaldila commented 4 years ago

@Kevin-Mattheus-Moerman I have a question, sorry for that. About the pdf paper. @asmusskar modified in repository the introduction and The presentation that has been in paper.md. Is The final pdf file made by the author or by the journal? Thanks!

Kevin-Mattheus-Moerman commented 4 years ago

@whedon generate pdf

Kevin-Mattheus-Moerman commented 4 years ago

@AnaWaldila we can update the paper draft here by calling @whedon generate pdf

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 4 years ago

@whedon check references

whedon commented 4 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1080/10298436.2018.1483502 is OK
- 10.1080/14680629.2010.9690274 is OK
- 10.1080/14680629.2012.757558 is OK
- 10.3141/2037-06 is OK
- 10.3850/978-981-11-0449-7-132-cd is OK
- 10.1080/10298436.2020.1790559 is OK
- 10.3141/1896-11 is OK
- 10.1080/14680629.2020.1741429 is OK

MISSING DOIs

- None

INVALID DOIs

- None
AnaWaldila commented 4 years ago

@Kevin-Mattheus-Moerman. I saw the final paper to check if it is allrigth. Sorry about that, but I did not understand why figures are not in pdf paper. I saw in this exact moment, the figures are in paper.md, like @asmusskar put.

Kevin-Mattheus-Moerman commented 4 years ago

Thanks @AnaWaldila for pointing that out. I'll check with our tech support on why this is happening.

Kevin-Mattheus-Moerman commented 4 years ago

@openjournals/dev can you check why this paper does not contain the images it shows in the paper.md. Is it because the images are in a different (/images) folder (so they are found on the repo but not by whedon?). They are using the following HTML format to render the images (which I assume is fine?): 

<p>
     <img src="images/N_layer.png" width="50%">
</p>
<p>
     <b>Figure 1</b>: N-Layered half-space model
</p>
Kevin-Mattheus-Moerman commented 4 years ago

@openjournals/dev :point_up:

xuanxu commented 4 years ago

Figures should be included using markdown format with something similar to:

![N-layered half-space model.\label{fig:model}](images/N_layer.png)

(Example from the docs)

Kevin-Mattheus-Moerman commented 4 years ago

@asmusskar can you update your paper to use this markdown format for the images :point_up: ? You can run @whedon generate pdf when done.

asmusskar commented 4 years ago

Thanks, the paper is now updated.

@Kevin-Mattheus-Moerman is this my last chance to make changes (proof read the article)?

asmusskar commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

asmusskar commented 4 years ago

@Kevin-Mattheus-Moerman, @AnaWaldila and @CBenghi my co-author corrected a few typos otherwise the paper and figures are updated according to your comments. Please see the article proof below :point_down:

@whedon generate pdf

asmusskar commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 4 years ago

@CBenghi thanks for your help here. Please can you finalize this review at your earliest convenience?