search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
717 stars 38 forks source link

[REVIEW]: pirecorder: Controlled and automated image and video recording with the raspberry pi #2584

Closed whedon closed 4 years ago

whedon commented 4 years ago

Submitting author: @JolleJolles (Jolle Wolter Jolles) Repository: http://github.com/jollejolles/pirecorder Version: v3.2.0 Editor: @marcosvital Reviewer: @lucask07, @DerJH Archive: 10.5281/zenodo.4058628

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cd4781aefbc0f72a36470fd81e48c2fb"><img src="https://joss.theoj.org/papers/cd4781aefbc0f72a36470fd81e48c2fb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cd4781aefbc0f72a36470fd81e48c2fb/status.svg)](https://joss.theoj.org/papers/cd4781aefbc0f72a36470fd81e48c2fb)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@lucask07 & @DerJH, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @marcosvital know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @lucask07

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @DerJH

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41598-019-43845-9 is OK
- 10.1111/2041-210X.13005 is OK
- 10.1371/journal.pcbi.1006959 is OK
- 10.1371/journal.pbio.2003026 is OK
- 10.1016/j.cub.2017.08.004 is OK
- 10.1098/rspb.2017.2629 is OK
- 10.1016/j.anbehav.2019.06.022 is OK
- 10.1371/journal.pone.0169758 is OK
- 10.1016/j.dsr.2019.103136 is OK
- 10.1111/jofo.12182 is OK
- 10.1371/journal.pone.0220751 is OK
- 10.1089/zeb.2016.1412 is OK
- 10.3389/fevo.2018.00026 is OK

MISSING DOIs

- None

INVALID DOIs

- None
marcosvital commented 4 years ago

Good, all references are fine.

@JolleJolles, I'll generate another manuscript proof, so you can take a carefull (maybe final?) look. I'll read it myself too, and will let you know if I find any issues, ok?

marcosvital commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

JolleJolles commented 4 years ago

Good, all references are fine.

@JolleJolles, I'll generate another manuscript proof, so you can take a carefull (maybe final?) look. I'll read it myself too, and will let you know if I find any issues, ok?

Hi @marcosvital, I have read the proofs and they look good. I just have three small changes, all for the last paragraph:

I will wait to hear if you have any final corrections to make and then commit these changes. I will then also generate a final release of the package and publish that to pypi.

Jolles et al 2020 BibTeX: @article{Jolles2020, author = {Jolles, Jolle W and Mazu{\'{e}}, Geoffrey P F and Davidson, Jacob and Behrmann-Godel, Jasminca and Couzin, Iain D}, doi = {10.1038/s41598-020-69057-0}, journal = {Scientific Reports}, pages = {12282}, title = {{{\textless}i{\textgreater}Schistocephalus{\textless}/i{\textgreater} parasite infection alters sticklebacks' movement ability and thereby shapes social interactions}}, volume = {10}, number = {1}, year = {2020} }

marcosvital commented 4 years ago

@JolleJolles, everything seems fine, and I would like to ask for one more change: please include the "statement of need" as a titled paragraph. I believe that could be done with your second paragraph, as it seems to cover this content. It should look like in this paper.

JolleJolles commented 4 years ago

I have incorporated your requested change and committed my suggested changes to the paper.

JolleJolles commented 4 years ago

@whedon check references

whedon commented 4 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41598-019-43845-9 is OK
- 10.1111/2041-210X.13005 is OK
- 10.1371/journal.pcbi.1006959 is OK
- 10.1371/journal.pbio.2003026 is OK
- 10.1016/j.cub.2017.08.004 is OK
- 10.1098/rspb.2017.2629 is OK
- 10.1016/j.anbehav.2019.06.022 is OK
- 10.1038/s41598-020-69057-0 is OK
- 10.1371/journal.pone.0169758 is OK
- 10.1016/j.dsr.2019.103136 is OK
- 10.1111/jofo.12182 is OK
- 10.1371/journal.pone.0220751 is OK
- 10.1089/zeb.2016.1412 is OK
- 10.3389/fevo.2018.00026 is OK

MISSING DOIs

- None

INVALID DOIs

- None
JolleJolles commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

JolleJolles commented 4 years ago

I noticed some small errors with the references so fixed them now.

JolleJolles commented 4 years ago

@whedon generate pdf

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

JolleJolles commented 4 years ago

Okay the final proofs looks good. I have committed the final changes and release pirecorder 3.2.0, which is now also available on pypi.

JolleJolles commented 4 years ago

@marcosvital is there anything else you need me to do? And what are the next steps for publishing the paper? Many thanks

marcosvital commented 4 years ago

@JolleJolles, we are almost there! You will need to archive the last release of the package (on Zenodo, figshare, or other) if you already didn't do this. After that, just let me know the archive DOI. Once this is done, we'll be ready to publish.

marcosvital commented 4 years ago

@whedon set v3.2.0 as version

whedon commented 4 years ago

OK. v3.2.0 is the version.

JolleJolles commented 4 years ago

@marcosvital v3.2.0 is indeed the last release and it is available on Zenodo (https://zenodo.org/record/4058628#.X3y8vZMzZoA) Thanks

marcosvital commented 4 years ago

@whedon set 10.5281/zenodo.4058628 as archive

whedon commented 4 years ago

OK. 10.5281/zenodo.4058628 is the archive.

marcosvital commented 4 years ago

@whedon accept

whedon commented 4 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 4 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41598-019-43845-9 is OK
- 10.1111/2041-210X.13005 is OK
- 10.1371/journal.pcbi.1006959 is OK
- 10.1371/journal.pbio.2003026 is OK
- 10.1016/j.cub.2017.08.004 is OK
- 10.1098/rspb.2017.2629 is OK
- 10.1016/j.anbehav.2019.06.022 is OK
- 10.1038/s41598-020-69057-0 is OK
- 10.1371/journal.pone.0169758 is OK
- 10.1016/j.dsr.2019.103136 is OK
- 10.1111/jofo.12182 is OK
- 10.1371/journal.pone.0220751 is OK
- 10.1089/zeb.2016.1412 is OK
- 10.3389/fevo.2018.00026 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 4 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1785

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1785, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
kthyng commented 4 years ago

Hi @JolleJolles! I will help you through the rest of the publishing process. First, please edit the metadata for your Zenodo archive so that the title and author list exactly match your JOSS paper.

kthyng commented 4 years ago

Paper looks good, and I see that the version is up to date!

JolleJolles commented 4 years ago

Hi @JolleJolles! I will help you through the rest of the publishing process. First, please edit the metadata for your Zenodo archive so that the title and author list exactly match your JOSS paper.

Hi @kthyng, I have updated the Zenodo archive. I hope it is okay now? Otherwise let me know what else I need to change. Thanks

kthyng commented 4 years ago

@JolleJolles Ok we are all set now!

kthyng commented 4 years ago

@whedon accept deposit=true

whedon commented 4 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 4 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 4 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1793
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02584
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

kthyng commented 4 years ago

Congrats to @JolleJolles on your new publication! Thanks to editor @marcosvital and reviewers @lucask07 and @DerJH for making all of this possible.

(I will close this issue once the doi resolves)

JolleJolles commented 4 years ago

Congrats to @JolleJolles on your new publication! Thanks to editor @marcosvital and reviewers @lucask07 and @DerJH for making all of this possible.

(I will close this issue once the doi resolves)

Wonderful! Thanks all for your help with this, I am very excited my paper is now published in JOSS.

whedon commented 4 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02584/status.svg)](https://doi.org/10.21105/joss.02584)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02584">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02584/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02584/status.svg
   :target: https://doi.org/10.21105/joss.02584

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: