Closed whedon closed 3 years ago
@Christopher-Khan Apologies for the delay. This looks good now!
@whedon accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1111/j.1467-9868.2005.00503.x is OK
- 10.18637/jss.v033.i01 is OK
- 10.1109/tuffc.2014.2928 is OK
- 10.1109/tuffc.2015.007004 is OK
- 10.1109/tuffc.2017.2729944 is OK
- 10.1186/1753-6561-6-s2-s10 is OK
- 10.3389/fgene.2013.00270 is OK
- 10.1016/j.neuroimage.2008.08.020 is OK
- 10.1109/isbi.2014.6868131 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1790
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1790, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true
Hi @Christopher-Khan! I see that you archive and version are set and up to date. I just looked at your paper and unfortunately it is far too long. A JOSS paper is to be between 250 and 1000 words. Can you move some of the content from the paper to your documentation?
Hi @kthyng! Sure. I can move the section titled "Example Benchmark Comparing GENRE with glmnet" to my documentation on GitHub. That will make the paper two pages shorter. Do you want me to make a new Zenodo archive then and give the DOI for that one? I ask because I don't think Zenodo allows for files in archives to be updated if the archive is more than a week old. Thank you!
@Christopher-Khan if you make a new release on github, Zenodo will create a new version of the same entry with a new doi. Probably thatβs better than creating a new archive
@whedon generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@krystophny thank you. That's what I meant actually instead of creating a new archive. @kthyng I have moved the section in the JOSS paper titled "Example Benchmark Comparing GENRE with glmnet" from the paper to the section in the README.md file titled "Comparing with Other Packages". The new DOI is below. I hope the paper is better now in terms of its length.
DOI: 10.5281/zenodo.4076520
Thank you for your time.
@Christopher-Khan Yes looks good! We can proceed now.
@whedon set 10.5281/zenodo.4076520 as archive
OK. 10.5281/zenodo.4076520 is the archive.
@whedon accept
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1111/j.1467-9868.2005.00503.x is OK
- 10.18637/jss.v033.i01 is OK
- 10.1109/tuffc.2014.2928 is OK
- 10.1109/tuffc.2015.007004 is OK
- 10.1109/tuffc.2017.2729944 is OK
- 10.1186/1753-6561-6-s2-s10 is OK
- 10.3389/fgene.2013.00270 is OK
- 10.1016/j.neuroimage.2008.08.020 is OK
- 10.1109/isbi.2014.6868131 is OK
MISSING DOIs
- None
INVALID DOIs
- None
:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1797
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1797, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true
@whedon accept deposit=true
Doing it live! Attempting automated processing of paper acceptance...
π¦π¦π¦ π Tweet for this paper π π¦π¦π¦
π¨π¨π¨ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! π¨π¨π¨
Here's what you must now do:
Party like you just published a paper! πππ¦ππ»π€
Any issues? Notify your editorial technical team...
Congrats on the new publication @Christopher-Khan! Thanks to editor @sjpfenninger and reviewers @marouenbg and @krystophny for your time and expertise!!
(will close this issue once doi resolves)
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02644/status.svg)](https://doi.org/10.21105/joss.02644)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02644">
<img src="https://joss.theoj.org/papers/10.21105/joss.02644/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02644/status.svg
:target: https://doi.org/10.21105/joss.02644
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Awesome! Thank you @kthyng, @sjpfenninger, @marouenbg, and @krystophny! This review process has been great!
@whedon set v1.0.2 as version
I'm sorry @Christopher-Khan, I'm afraid I can't do that. That's something only editors are allowed to do.
@sjpfenninger. Last thing. Do I need to set the version at the top of this review from v1.0.1 to v1.0.2 because that's the newest version that actually got accepted? If so, I believe only editors can do that. Thank you!
@whedon set v1.0.2 as version
OK. v1.0.2 is the version.
@arfon Great! Thank you!
Submitting author: @Christopher-Khan (Christopher Khan) Repository: https://github.com/VU-BEAM-Lab/GENRE Version: v1.0.2 Editor: @sjpfenninger Reviewer: @marouenbg, @krystophny Archive: 10.5281/zenodo.4076520
:warning: JOSS reduced service mode :warning:
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@marouenbg & @krystophny, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sjpfenninger know.
β¨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest β¨
Review checklist for @marouenbg
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @krystophny
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper