[REVIEW]: Mosquitto

[whedon]

Submitting author: @ralight (Roger A. Light) Repository: https://github.com/eclipse/mosquitto Version: v1.4.11 Editor: @arfon Reviewer: @brainstorm Archive: 10.5281/zenodo.582351

Status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/ebbbbf7c7a2f7e98e32ae41ee88a3bca"><img src="http://joss.theoj.org/papers/ebbbbf7c7a2f7e98e32ae41ee88a3bca/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/ebbbbf7c7a2f7e98e32ae41ee88a3bca/status.svg)](http://joss.theoj.org/papers/ebbbbf7c7a2f7e98e32ae41ee88a3bca)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

Conflict of interest

• [x] As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

General checks

• [x] Repository: Is the source code for this software available at the repository url?
• [x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
• [x] Version: Does the release version given match the GitHub release (v1.4.11)?
• [x] Authorship: Has the submitting author (ralight) made major contributions to the software?

Functionality

• [x] Installation: Does installation proceed as outlined in the documentation?
• [x] Functionality: Have the functional claims of the software been confirmed?
• [x] Performance: Have any performance claims of the software been confirmed?

Documentation

• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
• [x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
• [x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g. API method documentation)?
• [x] Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
• [x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

• [x] Authors: Does the paper.md file include a list of authors with their affiliations?
• [x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
• [x] References: Do all archival references that should have a DOI list one (e.g. papers, datasets, software)?

[whedon]

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @brainstorm it looks like you're currently assigned as the reviewer for this paper :tada:.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿

To fix this do the following two things:

1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

2. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

For a list of things I can do to help you, just type:

@whedon commands

[brainstorm]

Since, coincidentally I've been using this software recently for my experiments with The Things Network, it has been a breeze to validate its functionality and performance. Good piece of software, @ralight 👍

@arfon, I'm done with it, ready to deposit.

[ralight]

Well awesome, that is a nice coincidence and this was a lot more straightforward than I was expecting. Thanks very much.

[ralight]

I've uploaded an archive to zenodo: http://doi.org/10.5281/zenodo.582351

[arfon]

@ralight - do you have an institutional affiliation? If so, could you add it to your paper.md file please? e.g.

---
title: 'Mosquitto: server and client implementation of the MQTT protocol'
tags:
  - Internet of Things
  - MQTT
  - Pubsub
  - Messaging
authors:
  - name: Roger A Light
    orcid: 0000-0001-9218-7797
    affiliation: 1
affiliations:
  - name: The University of Nottingham
    index: 1
date: 17 May 2017
bibliography: paper.bib
---

[ralight]

I do, but I'd prefer not to list it for this paper, the work is not affiliated to UoN.

[arfon]

@whedon set 10.5281/zenodo.582351 as archive

[whedon]

OK. 10.5281/zenodo.582351 is the archive.

[arfon]

@brainstorm - many thanks for your review ✨

@ralight - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00265 ⚡️:rocket: :boom: