[REVIEW]: c212: An R Package for the Detection of Safety Signals in Clinical Trials Using Body-Systems (System Organ Classes)

whedon commented 3 years ago

Submitting author: @rcarragh (Raymond Bernard Carragher) Repository: https://github.com/rcarragh/c212 Version: 1.00 Editor: @csoneson Reviewers: @rrrlw, @MelvinSMunsaka Archive: 10.5281/zenodo.4304831

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4b7357f98bc7ac39777a7229ec30f108"><img src="https://joss.theoj.org/papers/4b7357f98bc7ac39777a7229ec30f108/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4b7357f98bc7ac39777a7229ec30f108/status.svg)](https://joss.theoj.org/papers/4b7357f98bc7ac39777a7229ec30f108)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@rrrlw & @emilydolson, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @rrrlw

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@rcarragh) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @emilydolson

Conflict of interest

[ ] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[ ] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[ ] Repository: Is the source code for this software available at the repository url?
[ ] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[ ] Contribution and authorship: Has the submitting author (@rcarragh) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[ ] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[ ] Installation: Does installation proceed as outlined in the documentation?
[ ] Functionality: Have the functional claims of the software been confirmed?
[ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[ ] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[ ] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[ ] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[ ] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[ ] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[ ] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[ ] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[ ] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @MelvinSMunsaka

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@rcarragh) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

csoneson commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

csoneson commented 3 years ago

👋 @rcarragh - I've made a PR here with a couple of small fixes to the bibliography, could you please check and merge?

csoneson commented 3 years ago

The next steps will then be:

[ ] Make a tagged release of your software, and list the version tag of the archived version here.
[ ] Archive the reviewed software in Zenodo
[ ] Check that the Zenodo archive has the correct metadata: the title and author list should match those of the paper; you may also add the authors' ORCID.
[ ] List the Zenodo DOI of the archived version here.

rcarragh commented 3 years ago

@csoneson I've checked and merged the changes, thanks.

csoneson commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

csoneson commented 3 years ago

@whedon check references

whedon commented 3 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.2517-6161.1995.tb02031.x is OK
- 10.1198/jasa.2010.tm09329 is OK
- 10.1002/sim.5310 is OK
- 10.1016/j.jspi.2007.06.006 is OK
- doi:10.1201/9781420011302.fmatt is OK
- 10.1111/j.0006-341X.2004.00186.x is OK
- 10.1080/10543406.2010.520181 is OK
- 10.1080/19466315.2017.1409134 is OK
- 10.1007/978-981-10-7826-2_11 is OK
- 10.1007/978-981-10-7826-2_11 is OK
- 10.5281/zenodo.3235282 is OK
- 10.1002/sim.8304 is OK
- 10.1002/sim.8495 is OK
- 10.1002/sim.8563 is OK

MISSING DOIs

- None

INVALID DOIs

- None

rcarragh commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

rcarragh commented 3 years ago

@csoneson - I've done the following:

Tagged release of software in github: 1.00 I have archived the corresponding software on Zenodo The title and author on Zenodo match the paper; Co-author does not have an ORCID. Zenodo archive DOI: 10.5281/zenodo.4304831

I hope this is correct, thanks.

csoneson commented 3 years ago

Thanks @rcarragh - could you just remove the initial rcarragh/c212 from the Zenodo record title, so that it matches the paper title? The rest looks good.

csoneson commented 3 years ago

@whedon set 1.00 as version

whedon commented 3 years ago

OK. 1.00 is the version.

rcarragh commented 3 years ago

Hi @csoneson, I've removed the initial rcarragh/c212 from the Zenodo record title Thanks

csoneson commented 3 years ago

@whedon set 10.5281/zenodo.4304831 as archive

whedon commented 3 years ago

OK. 10.5281/zenodo.4304831 is the archive.

csoneson commented 3 years ago

@whedon accept

whedon commented 3 years ago

Attempting dry run of processing paper acceptance...

csoneson commented 3 years ago

Thanks @rcarragh - the associate editor-in-chief on rotation will take over from here and finalize the acceptance of your submission.

whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/1958

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/1958, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true

whedon commented 3 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/j.2517-6161.1995.tb02031.x is OK
- 10.1198/jasa.2010.tm09329 is OK
- 10.1002/sim.5310 is OK
- 10.1016/j.jspi.2007.06.006 is OK
- doi:10.1201/9781420011302.fmatt is OK
- 10.1111/j.0006-341X.2004.00186.x is OK
- 10.1080/10543406.2010.520181 is OK
- 10.1080/19466315.2017.1409134 is OK
- 10.1007/978-981-10-7826-2_11 is OK
- 10.1007/978-981-10-7826-2_11 is OK
- 10.5281/zenodo.3235282 is OK
- 10.1002/sim.8304 is OK
- 10.1002/sim.8495 is OK
- 10.1002/sim.8563 is OK

MISSING DOIs

- None

INVALID DOIs

- None

rcarragh commented 3 years ago

I would like to says thanks to @csoneson for organising the review process, and thanks to the reviewers, @rrrlw and @MelvinSMunsaka, for their helpful and insightful comments. Doubly so given the current difficult working conditions many are facing.

rcarragh commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago

I'm sorry @rcarragh, I'm afraid I can't do that. That's something only editor-in-chiefs are allowed to do.

rcarragh commented 3 years ago

I checked the proof and crossref in openjournals/joss-papers#1958 and they look good from my point of view.

kyleniemeyer commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago

Doing it live! Attempting automated processing of paper acceptance...

whedon commented 3 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 3 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/1962
Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02706
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 3 years ago

Congrats @rcarragh on your article's publication in JOSS!

Many thanks to @rrrlw and @MelvinSMunsaka for reviewing this, and @csoneson for editing it.

whedon commented 3 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02706/status.svg)](https://doi.org/10.21105/joss.02706)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02706">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02706/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02706/status.svg
   :target: https://doi.org/10.21105/joss.02706

This is how it will look in your documentation:

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://joss.theoj.org/reviewer-signup.html
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews