openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
699 stars 36 forks source link

[PRE REVIEW]: hectorui: A web-based interactive scenario builder and visualization application for the Hector climate model #2736

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @evanoffPNNL (Jason Evanoff) Repository: https://github.com/JGCRI/hectorui/ Version: 1.1.0 Editor: @kthyng Reviewers: @marvinjonathcn, @tscheypidi Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @evanoffPNNL. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @danielskatz.

@evanoffPNNL if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

Failed to discover a Statement of need section in paper

whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=1.00 s (67.1 files/s, 14256.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            24           1097            289           3118
INI                             12            703           1281           2596
R                               11            437            677           1715
CSS                              4            173             60            749
Markdown                         4            127              0            567
JavaScript                       4             65             33            264
TeX                              1              0              0             93
YAML                             4             12              0             58
SVG                              2              0              1             46
Rmd                              1             23             58              1
-------------------------------------------------------------------------------
SUM:                            67           2637           2399           9207
-------------------------------------------------------------------------------

Statistical information for the repository 'bf1174da4bea7e5858394c46' was
gathered on 2020/10/09.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
crvernon                         1           352              0           97.24
evanoffPNNL                      1            10              0            2.76

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
crvernon                    352          100.0          0.0                9.09
evanoffPNNL                  10          100.0          0.0               10.00
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-8-939-2015 is OK
- 10.5194/bg-13-4329-2016 is OK

MISSING DOIs

- 10.1371/journal.pone.0223542 may be a valid DOI for title: Joint emulation of Earth System Model temperature-precipitation realizations with internal variability and space-time and cross-variable correlation: fldgen v2. 0 software description
- 10.1016/j.techfore.2006.05.026 may be a valid DOI for title: Scenarios of long-term socio-economic and environmental development under climate stabilization
- 10.5547/issn0195-6574-ej-volsi2006-nosi3-17 may be a valid DOI for title: Multi-gas mitigation analysis on stabilization scenarios using AIM global model
- 10.1007/s10584-011-0151-4 may be a valid DOI for title: RCP4. 5: a pathway for stabilization of radiative forcing by 2100
- 10.1007/s10584-011-0152-3 may be a valid DOI for title: RCP2. 6: exploring the possibility to keep global mean temperature increase below 2 C

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @kthyng

kthyng commented 3 years ago

@evanoffPNNL Thank you for your submission! I will be your editor. Please add a "Statement of Need" to your paper to start. Also, can you recommend reviewers for this submission? You can recommend from your network or from this list of volunteers (as long as not conflicting). If you are providing github handles, please do not use "@" so that they are not prematurely notified with excessive email.

evanoffPNNL commented 3 years ago

@kthyng Thanks for your quick turn around on getting the review process started! The statement of need was an oversight that has been fixed in the latest release today. I am also listing a number of reviewers that seemed appropriate from my perspective in no particular order. Please let me know if there's anything else needed.

jhollist, nuest , khaors, garretrc, marvinjonathcn, mikejohnson51, arbennett

crvernon commented 3 years ago

@kthyng @evanoffPNNL The latest release is: https://github.com/JGCRI/hectorui/releases/tag/v1.1.1 and the accompanying DOI from Zenodo link is: http://doi.org/10.5281/zenodo.4075376

This is what is now represented on the master.

Thanks!

kthyng commented 3 years ago

Hi @crvernon! We'll need that information at the end of the review process to make sure everything is up to date at that point, and there should be an up to date zenodo archive at that time too.

kthyng commented 3 years ago

I'll get back to this next week to get the review going.

crvernon commented 3 years ago

Thanks @kthyng ! Let us know if you need anything else. Have a great day!

kthyng commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 3 years ago

@whedon check references

whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-8-939-2015 is OK
- 10.5194/bg-13-4329-2016 is OK

MISSING DOIs

- 10.1371/journal.pone.0223542 may be a valid DOI for title: Joint emulation of Earth System Model temperature-precipitation realizations with internal variability and space-time and cross-variable correlation: fldgen v2. 0 software description
- 10.1016/j.techfore.2006.05.026 may be a valid DOI for title: Scenarios of long-term socio-economic and environmental development under climate stabilization
- 10.5547/issn0195-6574-ej-volsi2006-nosi3-17 may be a valid DOI for title: Multi-gas mitigation analysis on stabilization scenarios using AIM global model
- 10.1007/s10584-011-0151-4 may be a valid DOI for title: RCP4. 5: a pathway for stabilization of radiative forcing by 2100
- 10.1007/s10584-011-0152-3 may be a valid DOI for title: RCP2. 6: exploring the possibility to keep global mean temperature increase below 2 C

INVALID DOIs

- None
kthyng commented 3 years ago

@evanoffPNNL and @crvernon — please modify your bib file to include the missing DOIs listed above.

@evanoffPNNL thanks for the long list of reviewer ideas! I'll invite people now.

kthyng commented 3 years ago

@mikejohnson51 and @nuest — are you interested in reviewing this submission to JOSS? Reviews for JOSS are open on github and are checklist-driven. As you find items to bring up in the review process, you open issues to the software repository itself, link to the review issue, and explain the comment. We're asking for reviews within 5-6 weeks, a long timeline due to the pandemic. You can find more information about the reviewing process here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html#

evanoffPNNL commented 3 years ago

@whedon check references

whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-8-939-2015 is OK
- 10.5194/bg-13-4329-2016 is OK
- 10.1007/s10584-011-0149-y is OK
- 10.5547/ISSN0195-6574-EJ-VolSI2006-NoSI3-17 is OK
- 10.1007/s10584-011-0152-3 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1371/journal.pone.0223542 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.5194/gmd-12-677-2019 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.techfore.2006.05.026 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1007/s10584-011-0151-4 is INVALID because of 'https://doi.org/' prefix
evanoffPNNL commented 3 years ago

@whedon check references

whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-8-939-2015 is OK
- 10.5194/bg-13-4329-2016 is OK
- 10.1371/journal.pone.0223542 is OK
- 10.5194/gmd-12-677-2019 is OK
- 10.1016/j.techfore.2006.05.026 is OK
- 10.1007/s10584-011-0149-y is OK
- 10.5547/ISSN0195-6574-EJ-VolSI2006-NoSI3-17 is OK
- 10.1007/s10584-011-0151-4 is OK
- 10.1007/s10584-011-0152-3 is OK

MISSING DOIs

- None

INVALID DOIs

- None
evanoffPNNL commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

evanoffPNNL commented 3 years ago

Hi @kthyng, we have fixed the DOI issue. The latest release is 1.1.3 - https://github.com/JGCRI/hectorui/releases/tag/v1.1.3

If there's anything else we can do to be of assistance please let us know.

kthyng commented 3 years ago

Ok thanks @evanoffPNNL. We'll wait a few more days to see if we hear back from potential reviewers before trying others.

kthyng commented 3 years ago

@marvinjonathcn: are you interested in reviewing this submission to JOSS? Reviews for JOSS are open on github and are checklist-driven. As you find items to bring up in the review process, you open issues to the software repository itself, link to the review issue, and explain the comment. We're asking for reviews within 5-6 weeks, a long timeline due to the pandemic. You can find more information about the reviewing process here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html#

nuest commented 3 years ago

@kthyng Sorry, I am just about to start another JOSS review and wouldn't be able to get to this even within the extended timeline.

@tscheypidi are you a JOSS reviewer yet?

marvinjqs commented 3 years ago

Hello @kthyng , I would like to be a reviewer for this publication.

kthyng commented 3 years ago

@marvinjonathcn - excellent! I will add you now. We need to find another reviewer before continue on in the review process, so hold tight for now.

kthyng commented 3 years ago

@whedon assign @marvinjonathcn as reviewer

whedon commented 3 years ago

OK, @marvinjonathcn is now a reviewer

kthyng commented 3 years ago

@nuest of course, totally understand, thanks for getting back to me.

kthyng commented 3 years ago

@tscheypidi Here is the link to sign up as a JOSS reviewer generally if you'd like. Are you interested in being a reviewer on this submission?

tscheypidi commented 3 years ago

@kthyng @nuest Thanks for the invitation. I haven't reviewed for JOSS yet, but I am happy to help.

kthyng commented 3 years ago

Ok thanks @tscheypidi, looks like you are a good fit.

kthyng commented 3 years ago

@whedon add @tscheypidi as reviewer

whedon commented 3 years ago

OK, @tscheypidi is now a reviewer

kthyng commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2782.