openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: The Pencil Code, a modular MPI code for partial differential equations and particles: multipurpose and multiuser-maintained #2807

Closed whedon closed 3 years ago

whedon commented 4 years ago

Submitting author: @AxelBrandenburg (Axel Brandenburg) Repository: https://github.com/pencil-code/pencil-code Version: v2021.02.20 Editor: @arfon Reviewer: @zingale, @rtfisher Archive: 10.5281/zenodo.4553325

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/cf8fd46283ea70a6c752b6893113ea02"><img src="https://joss.theoj.org/papers/cf8fd46283ea70a6c752b6893113ea02/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/cf8fd46283ea70a6c752b6893113ea02/status.svg)](https://joss.theoj.org/papers/cf8fd46283ea70a6c752b6893113ea02)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@zingale & @rtfisher, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @zingale

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @rtfisher

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 4 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @zingale, @rtfisher it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
arfon commented 4 years ago

@zingale, @rtfisher - This is the review thread for the paper. All of our communications will happen here from now on.

Please read the "Reviewer instructions & questions" in the first comment above.

Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention https://github.com/openjournals/joss-reviews/issues/2807 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule.

whedon commented 4 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 4 years ago

@rtfisher - @whedon will automatically remind you in a week about starting your review, please ignore as I'm noting here that you're expecting to supply your review towards the end of November.

rtfisher commented 4 years ago

Thank you! I'll be in touch in a couple of weeks.

-B

On Sat, Oct 31, 2020 at 10:56 AM Arfon Smith notifications@github.com wrote:

@rtfisher https://github.com/rtfisher - @whedon https://github.com/whedon will automatically remind you in a week about starting your review, please ignore as I'm noting here that you're expecting to supply your review towards the end of November.

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-719944799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2Y7COODNXFMBXJ5TOSVNDSNQQSBANCNFSM4TF5YSQA .

-- Dr. Robert Fisher Associate Professor / Graduate Program Director University of Massachusetts/Dartmouth Department of Physics 285 Old Westport Road North Dartmouth, Massachusetts 02747 robert.fisher@umassd.edu http://www.novastella.org

whedon commented 4 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.combustflame.2017.07.008 is OK
- 10.1017/S0022112010002946 is OK
- 10.1103/PhysRevE.70.016308 is OK
- 10.1017/S1473550404001983 is OK
- 10.1016/j.physrep.2005.06.005 is OK
- 10.1086/429584 is OK
- 10.1086/499486 is OK
- 10.1051/0004-6361:20065371 is OK
- 10.1086/498634 is OK
- 10.1111/j.1365-2966.2006.10488.x is OK
- 10.1086/520827 is OK
- 10.1038/nature06086 is OK
- 10.1051/0004-6361:20077943 is OK
- 10.1051/0004-6361:20077942 is OK
- 10.1016/j.newar.2008.04.005 is OK
- 10.1016/j.crhy.2008.07.008 is OK
- 10.1016/j.cpc.2008.03.003 is OK
- 10.1051/0004-6361:200810307 is OK
- 10.1088/0004-637X/691/2/1092 is OK
- 10.1007/s10509-008-9799-2 is OK
- 10.1017/S1743921309993218 is OK
- 10.1088/0067-0049/189/1/142 is OK
- 10.1088/0067-0049/190/2/297 is OK
- 10.1088/0004-637X/722/2/1437 is OK
- 10.1016/j.jcp.2010.10.022 is OK
- 10.1111/j.1745-3933.2011.01037.x is OK
- 10.1017/S1743921311019995 is OK
- 10.1088/0067-0049/194/2/47 is OK
- 10.1017/S1743921311006569 is OK
- 10.1051/0004-6361/201016374 is OK
- 10.1016/j.jcp.2011.09.026 is OK
- 10.1002/chem.201201974 is OK
- 10.1088/1742-6596/440/1/012014 is OK
- 10.1103/PhysRevE.87.053110 is OK
- 10.2458/azu_uapress_9780816531240-ch018 is OK
- 10.1017/S1743921313008284 is OK
- 10.1017/S1743921313012921 is OK
- 10.1146/annurev-astro-081913-040012 is OK
- 10.1088/0004-637X/809/2/149 is OK
- 10.1086/497118 is OK
- 10.1088/0004-637X/697/2/1269 is OK
- 10.1086/527373 is OK
- 10.1086/516730 is OK
- 10.1086/380189 is OK
- 10.1086/498078 is OK
- 10.1088/0004-637X/704/2/L75 is OK
- 10.1086/431214 is OK
- 10.1086/368374 is OK
- 10.1111/j.1365-2966.2007.11801.x is OK
- 10.1103/PhysRevLett.100.184501 is OK
- 10.1086/516729 is OK
- 10.1103/PhysRevE.68.026304 is OK
- 10.1088/1367-2630/9/8/300 is OK
- 10.1051/0004-6361:20034417 is OK
- 10.1051/0004-6361:200600011 is OK
- 10.1051/0004-6361:20031371 is OK
- 10.1086/502968 is OK
- 10.1063/1.1651480 is OK
- 10.1111/j.1745-3933.2008.00423.x is OK
- 10.1002/asna.200510414 is OK
- 10.1051/0004-6361/200811265 is OK
- 10.1086/521781 is OK
- 10.1088/0004-637X/735/2/122 is OK
- 10.1051/0004-6361:200809365 is OK
- 10.1002/asna.200510362 is OK
- 10.1051/0004-6361/200811498 is OK
- 10.1051/0004-6361:20053221 is OK
- 10.1051/0004-6361:20047086 is OK
- 10.1002/asna.200911252 is OK
- 10.1086/587982 is OK
- 10.1002/asna.200510365 is OK
- 10.1051/0004-6361:20077948 is OK
- 10.1111/j.1745-3933.2006.00191.x is OK
- 10.1088/2041-8205/715/2/L68 is OK
- 10.1111/j.1365-2966.2009.14800.x is OK
- 10.1111/j.1365-2966.2004.08127.x is OK
- 10.1103/PhysRevE.70.026405 is OK
- 10.1088/2041-8205/755/1/L22 is OK
- 10.1088/0004-637X/697/2/1206 is OK
- 10.1002/asna.200911308 is OK
- 10.1088/0004-637X/706/1/712 is OK
- 10.1086/593146 is OK
- 10.1111/j.1365-2966.2009.15188.x is OK
- 10.1051/0004-6361:200810626 is OK
- 10.1051/0004-6361/201219127 is OK
- 10.1088/0004-637X/704/2/1239 is OK
- 10.1051/0004-6361:20040435 is OK
- 10.1051/0004-6361/201016019 is OK
- 10.1088/0004-637X/697/2/1153 is OK
- 10.1051/0004-6361:20079232 is OK
- 10.1088/2041-8205/740/2/L50 is OK
- 10.1088/2041-8205/719/1/L1 is OK
- 10.1002/asna.200911311 is OK
- 10.1088/0004-637X/749/2/179 is OK
- 10.1088/0004-637X/699/2/1059 is OK
- 10.1051/0004-6361/201015884 is OK
- 10.1051/0004-6361:200810359 is OK
- 10.1051/0004-6361:200810385 is OK
- 10.1111/j.1365-2966.2007.11511.x is OK
- 10.1086/508675 is OK
- 10.1111/j.1365-2966.2010.16309.x is OK
- 10.1051/0004-6361:200810797 is OK
- 10.1111/j.1365-2966.2007.12659.x is OK
- 10.1051/0004-6361:20053120 is OK
- 10.1007/s11214-012-9909-x is OK
- 10.1051/0004-6361/201015568 is OK
- 10.1088/0004-637X/756/1/62 is OK
- 10.1051/0004-6361/201015979 is OK
- 10.1051/0004-6361/201014700 is OK
- 10.1111/j.1365-2966.2008.14006.x is OK
- 10.1007/s11214-009-9490-0 is OK
- 10.1080/03091929.2010.506438 is OK
- 10.1088/0004-637X/697/1/923 is OK
- 10.1051/0004-6361:20077781 is OK
- 10.1007/s11207-012-9949-0 is OK
- 10.1103/PhysRevE.70.056301 is OK
- 10.1051/0004-6361/201016068 is OK
- 10.1051/0004-6361/201117023 is OK
- 10.1051/0004-6361/201116749 is OK
- 10.1103/PhysRevD.81.123002 is OK
- 10.1111/j.1365-2966.2009.15640.x is OK
- 10.1088/0004-637X/707/2/1233 is OK
- 10.1088/1367-2630/9/8/305 is OK
- 10.1002/asna.200710772 is OK
- 10.1103/PhysRevD.87.083007 is OK
- 10.1088/0004-637X/740/1/18 is OK
- 10.1088/0034-4885/74/4/046901 is OK
- 10.1007/s11207-010-9683-4 is OK
- 10.1111/j.1365-2966.2009.14646.x is OK
- 10.1103/PhysRevE.70.036408 is OK
- 10.1111/j.1365-2966.2012.20801.x is OK
- 10.1111/j.1365-2966.2011.19586.x is OK
- 10.1111/j.1365-2966.2010.18184.x is OK
- 10.1051/0004-6361/201014287 is OK
- 10.1086/509143 is OK
- 10.1111/j.1365-2966.2006.11034.x is OK
- 10.1111/j.1365-2966.2006.10476.x is OK
- 10.1051/0004-6361:20054639 is OK
- 10.1002/asna.201111638 is OK
- 10.1002/asna.201111625 is OK
- 10.1051/0004-6361/201117701 is OK
- 10.1063/1.2222399 is OK
- 10.1002/asna.200410373 is OK
- 10.1088/0004-637X/748/1/51 is OK
- 10.1051/0004-6361/201117871 is OK
- 10.1088/0004-637X/727/1/11 is OK
- 10.1111/j.1365-2966.2009.16004.x is OK
- 10.1051/0004-6361:20054658 is OK
- 10.1002/asna.201111619 is OK
- 10.1088/0004-637X/741/2/92 is OK
- 10.1063/1.3533656 is OK
- 10.1111/j.1365-2966.2010.17408.x is OK
- 10.1051/0004-6361/200912653 is OK
- 10.1103/PhysRevD.86.103005 is OK
- 10.1088/0004-637X/753/1/6 is OK
- 10.1111/j.1365-2966.2011.20153.x is OK
- 10.1103/PhysRevE.84.056314 is OK
- 10.1051/0004-6361/200913722 is OK
- 10.1111/j.1365-2966.2008.13974.x is OK
- 10.1051/0004-6361:20078936 is OK
- 10.1103/PhysRevE.69.056407 is OK
- 10.1051/0004-6361:20030783 is OK
- 10.1093/mnras/sts297 is OK
- 10.1088/0067-0049/201/2/18 is OK
- 10.1088/0004-637X/748/2/79 is OK
- 10.1051/0004-6361/201016108 is OK
- 10.1051/0004-6361/201015661 is OK
- 10.1111/j.1365-2966.2009.15108.x is OK
- 10.1111/j.1365-2966.2008.14173.x is OK
- 10.1103/PhysRevE.79.016302 is OK
- 10.1051/0004-6361:20079098 is OK
- 10.1088/0004-637X/765/2/115 is OK
- 10.1051/0004-6361/201219473 is OK
- 10.1051/0004-6361/201016047 is OK
- 10.1088/0741-3335/51/12/124043 is OK
- 10.1088/0004-637X/778/1/41 is OK
- 10.1007/s11207-012-0108-4 is OK
- 10.1088/0004-637X/750/1/34 is OK
- 10.1017/S174392131100994X is OK
- 10.1002/asna.201011478 is OK
- 10.1023/B:ASTR.0000045000.08395.a3 is OK
- 10.1088/0004-637X/778/2/141 is OK
- 10.1007/s11207-012-0031-8 is OK
- 10.1038/nature12281 is OK
- 10.1093/mnrasl/sls042 is OK
- 10.1093/mnras/sts516 is OK
- 10.1088/0004-637X/759/1/54 is OK
- 10.1088/0004-637X/742/1/34 is OK
- 10.1051/0004-6361/201015073 is OK
- 10.1103/PhysRevE.82.016304 is OK
- 10.1103/PhysRevE.81.036401 is OK
- 10.1002/asna.200811131 is OK
- 10.1051/0004-6361:200809891 is OK
- 10.1002/asna.200811027 is OK
- 10.1002/asna.200710881 is OK
- 10.1088/2041-8205/777/2/L37 is OK
- 10.1088/2041-8205/776/2/L23 is OK
- 10.1051/0004-6361/201220939 is OK
- 10.1093/mnras/sts398 is OK
- 10.1088/0004-637X/763/2/117 is OK
- 10.1051/0004-6361/201220469 is OK
- 10.1051/0004-6361/201220078 is OK
- 10.1051/swsc/2012011 is OK
- 10.1088/0004-637X/753/1/32 is OK
- 10.1051/0004-6361/201015631 is OK
- 10.1051/0004-6361/201015637 is OK
- 10.1002/asna.200911254 is OK
- 10.1111/j.1365-2966.2009.15254.x is OK
- 10.1088/0004-637X/776/1/12 is OK
- 10.1051/0004-6361/201321353 is OK
- 10.1093/mnras/stt560 is OK
- 10.1111/j.1365-2966.2012.21731.x is OK
- 10.1111/j.1365-2966.2012.21758.x is OK
- 10.1088/0004-637X/758/2/103 is OK
- 10.1103/PhysRevE.86.016313 is OK
- 10.1002/asna.201111620 is OK
- 10.1086/591118 is OK
- 10.1017/S1743921307010654 is OK
- 10.1088/0004-637X/758/1/48 is OK
- 10.1088/0067-0049/200/1/6 is OK
- 10.1051/0004-6361/201117889 is OK
- 10.1103/PhysRevE.84.025403 is OK
- 10.1051/0004-6361/201116708 is OK
- 10.1088/0004-637X/719/1/67 is OK
- 10.1051/eas/1042029 is OK
- 10.1017/S1743921307000919 is OK
- 10.1007/11369875_9 is OK
- 10.1111/j.1365-2966.2012.21748.x is OK
- 10.1111/j.1365-2966.2012.21010.x is OK
- 10.1088/0067-0049/200/1/7 is OK
- 10.1002/asna.201211648 is OK
- 10.1103/PhysRevE.84.016406 is OK
- 10.1103/PhysRevE.83.016304 is OK
- 10.1002/asna.200911313 is OK
- 10.1002/asna.200710861 is OK
- 10.1103/PhysRevE.69.056303 is OK
- 10.1103/PhysRevE.87.043104 is OK
- 10.1111/j.1745-3933.2011.01167.x is OK
- 10.1088/2041-8205/735/1/L9 is OK
- 10.1051/0004-6361/201116766 is OK
- 10.1103/PhysRevE.80.055301 is OK
- 10.1051/0004-6361/20078822 is OK
- 10.1063/1.1832142 is OK
- 10.1051/0004-6361/201322315 is OK
- 10.1088/2041-8205/780/2/L22 is OK
- 10.1007/s11214-013-9967-8 is OK
- 10.1093/mnras/stt1273 is OK
- 10.1080/03091929.2012.715158 is OK
- 10.1088/0004-637X/762/2/127 is OK
- 10.1111/j.1365-2966.2011.19693.x is OK
- 10.1103/PhysRevE.84.046321 is OK
- 10.1088/0004-637X/737/2/62 is OK
- 10.1016/j.jcp.2010.08.028 is OK
- 10.1088/0031-8949/2010/T142/014028 is OK
- 10.1080/03091929.2010.504185 is OK
- 10.1111/j.1365-2966.2009.15483.x is OK
- 10.1088/0004-637X/701/2/1269 is OK
- 10.1086/525011 is OK
- 10.1051/0004-6361:20065519 is OK
- 10.1017/S1743921304005721 is OK
- 10.1051/0004-6361/201322461 is OK
- 10.1088/0031-8949/2013/T155/014027 is OK
- 10.1017/S1743921313002457 is OK
- 10.1051/0004-6361/201321185 is OK
- 10.1093/mnras/stt590 is OK
- 10.1088/0031-8949/86/01/018405 is OK
- 10.1063/1.4733450 is OK
- 10.1002/asna.201111617 is OK
- 10.1103/PhysRevE.84.056407 is OK
- 10.1051/0004-6361/201116705 is OK
- 10.1017/S1743921311015249 is OK
- 10.1007/s12043-011-0112-5 is OK
- 10.1017/S1743921310010148 is OK
- 10.1051/eas/1041012 is OK
- 10.1088/0067-0049/182/1/468 is OK
- 10.1016/j.asr.2009.01.033 is OK
- 10.1017/S1743921309030403 is OK
- 10.1088/0031-8949/2008/T130/014016 is OK
- 10.1111/j.1365-2966.2008.13099.x is OK
- 10.1016/j.pepi.2005.03.012 is OK
- 10.1093/mnras/stu438 is OK
- 10.1088/0004-637X/786/2/91 is OK
- 10.1093/mnras/stu1755 is OK
- 10.1017/jfm.2013.290 is OK
- 10.1088/0004-637X/773/2/120 is OK
- 10.1017/S1743921313002676 is OK
- 10.1017/S1743921313002640 is OK
- 10.1051/0004-6361/201321297 is OK
- 10.1088/0031-8949/86/01/018406 is OK
- 10.1017/S1743921312004644 is OK
- 10.1002/asna.201211654 is OK
- 10.1051/0004-6361/201117862 is OK
- 10.1017/S1743921311015055 is OK
- 10.1017/S1743921311017832 is OK
- 10.1017/S1743921311017704 is OK
- 10.1017/S1743921311007538 is OK
- 10.1017/S1743921311007186 is OK
- 10.1007/s10509-010-0276-3 is OK
- 10.1002/asna.200911298 is OK
- 10.1002/asna.200911242 is OK
- 10.1103/PhysRevE.77.026405 is OK
- 10.1002/asna.200610558 is OK
- 10.1088/0004-637X/786/1/51 is OK
- 10.1093/mnras/stt1147 is OK
- 10.1051/eas/1362004 is OK
- 10.1093/mnras/stt891 is OK
- 10.1017/S1743921313002822 is OK
- 10.1017/S1743921313002755 is OK
- 10.1017/S1743921313002743 is OK
- 10.1051/epjconf/20134604003 is OK
- 10.1017/S1743921312019618 is OK
- 10.1080/03091929.2012.681307 is OK
- 10.1002/asna.201312135 is OK
- 10.1051/0004-6361/201117871e is OK
- 10.1017/S1743921312004772 is OK
- 10.1017/S1743921312004620 is OK
- 10.1017/S1743921312004619 is OK
- 10.2298/SAJ1183087A is OK
- 10.1017/S174392131101533X is OK
- 10.1017/S1743921311018023 is OK
- 10.1017/S1743921311017868 is OK
- 10.1017/S1743921311007502 is OK
- 10.1017/S1743921311007496 is OK
- 10.1017/S174392131100737X is OK
- 10.1017/S1743921311007307 is OK
- 10.5281/zenodo.2315093 is OK
- 10.1017/S1743921309992626 is OK
- 10.1016/j.asr.2009.08.020 is OK
- 10.1007/978-1-4419-0239-9_7 is OK
- 10.1017/S1743921307001433 is OK
- 10.1017/S1743921304005101 is OK
- 10.1201/9780203493137.ch9 is OK
- 10.1103/PhysRevE.89.033009 is OK
- 10.1007/s11214-013-9988-3 is OK
- 10.1093/mnras/stt2402 is OK
- 10.1103/PhysRevE.90.041003 is OK
- 10.1155/2014/750754 is OK
- 10.1088/0169-5983/46/4/041401 is OK
- 10.1088/0004-637X/789/1/77 is OK
- 10.1093/mnras/stu809 is OK
- 10.1103/PhysRevE.91.021001 is OK
- 10.1016/j.atmosres.2014.07.017 is OK
- 10.1088/0004-637X/795/1/16 is OK
- 10.1051/0004-6361/201423412 is OK
- 10.1088/2041-8205/796/1/L12 is OK
- 10.1051/0004-6361/201424521 is OK
- 10.1051/0004-6361/201423499 is OK
- 10.1051/0004-6361/201322681 is OK
- 10.1051/0004-6361/201425396 is OK
- 10.1093/mnras/stu2540 is OK
- 10.1088/2041-8205/795/1/L8 is OK
- 10.1002/asna.201412141 is OK
- 10.1093/mnras/stu1708 is OK
- 10.1007/s11214-013-0009-3 is OK
- 10.1088/0004-637X/791/1/12 is OK
- 10.1093/mnras/stu1954 is OK
- 10.1088/0004-637X/803/2/95 is OK
- 10.1017/S1743921314001884 is OK
- 10.1063/1.4891340 is OK
- 10.1051/0004-6361/201322837 is OK
- 10.1051/0004-6361/201424919 is OK
- 10.1088/0004-637X/791/1/48 is OK
- 10.1088/0004-637X/792/1/69 is OK
- 10.1088/0004-637X/797/2/101 is OK
- 10.1088/0004-637X/791/1/62 is OK
- 10.1088/0004-637X/792/2/86 is OK
- 10.1103/PhysRevLett.114.075001 is OK
- 10.1051/0004-6361/201525880 is OK
- 10.3847/0004-637X/824/1/60 is OK
- 10.1051/0004-6361/201525840 is OK
- 10.1051/0004-6361/201526657 is OK
- 10.1103/PhysRevE.93.033125 is OK
- 10.3847/0004-637X/817/2/102 is OK
- 10.1051/0004-6361/201730421 is OK
- 10.3847/0004-637X/816/1/28 is OK
- 10.1051/0004-6361/201628165 is OK
- 10.3847/0004-637X/816/1/2 is OK
- 10.1007/s11214-014-0117-8 is OK
- 10.1007/s11214-015-0199-y is OK
- 10.1088/0004-637X/814/2/155 is OK
- 10.1093/mnras/stv1766 is OK
- 10.1088/0004-637X/811/2/135 is OK
- 10.1093/mnras/stv1598 is OK
- 10.1051/0004-6361/201425274 is OK
- 10.1103/PhysRevLett.115.095001 is OK
- 10.1051/0004-6361/201425120 is OK
- 10.1088/0004-637X/807/2/143 is OK
- 10.1016/j.ascom.2015.02.005 is OK
- 10.1038/nphys3315 is OK
- 10.1088/0004-637X/805/2/166 is OK
- 10.1088/0004-637X/806/1/118 is OK
- 10.1093/mnras/stv195 is OK
- 10.1088/0004-637X/804/2/95 is OK
- 10.1093/mnras/stv459 is OK
- 10.1088/0004-637X/804/1/35 is OK
- 10.1126/sciadv.1500109 is OK
- 10.1007/s11214-014-0100-4 is OK
- 10.1093/mnras/stw1257 is OK
- 10.1201/9780203493137.ch9 is OK
- 10.3847/0067-0049/224/2/39 is OK
- 10.1088/1742-6596/719/1/012006 is OK
- 10.3847/0004-637X/822/1/55 is OK
- 10.1093/mnras/stw888 is OK
- 10.1093/mnras/stx1291 is OK
- 10.1093/pasj/psx008 is OK
- 10.1051/0004-6361/201628960 is OK
- 10.1103/PhysRevLett.118.055102 is OK
- 10.3847/1538-4357/836/1/21 is OK
- 10.1051/0004-6361/201628973 is OK
- 10.3847/0004-637X/831/1/82 is OK
- 10.3847/1538-4357/833/1/43 is OK
- 10.3847/0004-637X/832/2/150 is OK
- 10.1093/mnras/stw1941 is OK
- 10.1051/0004-6361/201630106 is OK
- 10.1103/PhysRevLett.116.101101 is OK
- 10.1051/0004-6361/201526272 is OK
- 10.1088/0031-8949/91/10/104008 is OK
- 10.1093/mnras/stw1619 is OK
- 10.1088/1367-2630/aa5de6 is OK
- 10.1093/mnrasl/slw248 is OK
- 10.1093/mnras/stx148 is OK
- 10.1002/2017MS000930 is OK
- 10.3847/2041-8213/aa83ab is OK
- 10.1002/asna.201713384 is OK
- 10.3847/2041-8213/aa855d is OK
- 10.1017/jfm.2017.364 is OK
- 10.3847/2041-8213/aa844b is OK
- 10.1016/j.cpc.2017.03.011 is OK
- 10.1007/s41116-017-0007-8 is OK
- 10.3847/1538-4357/aa7b33 is OK
- 10.1007/s11214-015-0230-3 is OK
- 10.1063/1.5001338 is OK
- 10.1051/0004-6361/201630208 is OK
- 10.1093/mnras/stx1425 is OK
- 10.1002/asna.201713406 is OK
- 10.1103/PhysRevD.96.083505 is OK
- 10.3847/1538-4357/aa8a66 is OK
- 10.1051/0004-6361/201732191 is OK
- 10.3847/1538-3881/aa8811 is OK
- 10.1051/epjconf/201716002010 is OK
- 10.3847/1538-4357/aa8fcf is OK
- 10.3847/2041-8213/aa96a1 is OK
- 10.1103/PhysRevE.96.053105 is OK
- 10.3847/1538-4357/aa93e7 is OK
- 10.1103/PhysRevD.96.123528 is OK
- 10.1088/1475-7516/2017/12/002 is OK
- 10.1093/mnras/stx1989 is OK
- 10.1017/S0022377818000806 is OK
- 10.1002/asna.201813477 is OK
- 10.1002/asna.201813472 is OK
- 10.1103/PhysRevE.97.023105 is OK
- 10.1140/epjp/i2018-11865-7 is OK
- 10.3847/1538-4357/aaadaa is OK
- 10.1051/0004-6361/201833018 is OK
- 10.1051/0004-6361/201628136 is OK
- 10.1051/0004-6361/201732413 is OK
- 10.1080/03091929.2018.1515313 is OK
- 10.1093/mnras/stx3255 is OK
- 10.3847/1538-4357/aab891 is OK
- 10.3847/1538-4357/aae97a is OK
- 10.3847/1538-4357/aae97f is OK
- 10.1016/j.physrep.2018.02.006 is OK
- 10.1093/mnras/stx3164 is OK
- 10.1093/mnras/sty1570 is OK
- 10.1051/0004-6361/201732066 is OK
- 10.3847/1538-4357/aaba75 is OK
- 10.1093/mnras/sty593 is OK
- 10.1093/mnras/stz1509 is OK
- 10.1007/s11084-019-09579-4 is OK
- 10.1007/s41115-017-0001-9 is OK
- 10.1093/mnras/stz2042 is OK
- 10.3847/1538-4357/ab2f85 is OK
- 10.3847/1538-4357/ab258e is OK
- 10.3847/2515-5172/ab2894 is OK
- 10.1063/1.5092152 is OK
- 10.1051/0004-6361/201935945 is OK
- 10.1126/science.aat5330 is OK
- 10.1103/PhysRevE.99.043206 is OK
- 10.3390/galaxies7020045 is OK
- 10.1051/0004-6361/201935385 is OK
- 10.1093/mnras/sty3369 is OK
- 10.1080/03091929.2019.1571584 is OK
- 10.1093/mnras/stz2084 is OK
- 10.1103/PhysRevFluids.4.024608 is OK
- 10.1017/S0022377818001290 is OK
- 10.1080/10618562.2019.1593385 is OK
- 10.3847/1538-4357/aaffd8 is OK
- 10.5194/acp-19-639-2019 is OK
- 10.1103/PhysRevE.98.063107 is OK
- 10.1093/mnras/sty1757 is OK
- 10.1051/0004-6361/201834921 is OK
- 10.3847/1538-4357/aae7d4 is OK
- 10.1002/asna.201913602 is OK
- 10.3847/2515-5172/aaeac9 is OK
- 10.1175/JAS-D-18-0081.1 is OK
- 10.1051/0004-6361/201832783 is OK
- 10.1093/mnras/sty1594 is OK
- 10.1088/1475-7516/2018/08/034 is OK
- 10.3847/1538-4357/aaca99 is OK
- 10.3847/1538-4357/aac3d4 is OK
- 10.1080/03091929.2019.1672676 is OK
- 10.1080/03091929.2018.1492720 is OK
- 10.1080/03091929.2019.1571586 is OK
- 10.1080/03091929.2019.1591393 is OK
- 10.1080/03091929.2019.1653460 is OK
- 10.1080/03091929.2019.1653461 is OK
- 10.1080/03091929.2019.1670173 is OK
- 10.1088/1742-6596/1031/1/012007 is OK
- 10.1093/mnras/stz1354 is OK
- 10.1051/0004-6361/201730825 is OK
- 10.1093/pasj/psu123 is OK
- 10.3847/2041-8213/aa9988 is OK
- 10.3847/2041-8213/ab974a is OK
- 10.3847/1538-4357/ab8d37 is OK
- 10.1103/PhysRevD.101.103028 is OK
- 10.1103/PhysRevFluids.5.043702 is OK
- 10.3847/1538-4357/ab791c is OK
- 10.3847/1538-4357/ab77bd is OK
- 10.1103/PhysRevE.101.033102 is OK
- 10.1093/mnras/staa663 is OK
- 10.1017/S1743921319004447 is OK
- 10.1080/03091929.2019.1643849 is OK
- 10.1080/03091929.2019.1676894 is OK
- 10.1080/03091929.2019.1634705 is OK
- 10.1080/03091929.2019.1668382 is OK
- 10.1051/0004-6361/201937037 is OK
- 10.1093/mnras/stz3232 is OK
- 10.1017/S0022377820000082 is OK
- 10.1093/mnras/stz3065 is OK
- 10.1175/JAS-D-19-0107.1 is OK
- 10.3847/1538-4357/ab5e7f is OK
- 10.1051/0004-6361/201936841 is OK
- 10.1093/mnras/stz2957 is OK
- 10.3847/1538-4357/ab5961 is OK
- 10.3847/1538-4357/ab3f3b is OK
- 10.1088/1742-6596/1336/1/012012 is OK
- 10.3847/1538-4357/ab3e07 is OK
- 10.3847/1538-4365/ab4356 is OK
- 10.1007/s41115-019-0005-8 is OK
- 10.1080/03091929.2019.1677015 is OK
- 10.3847/1538-4357/ab24bd is OK
- 10.3847/1538-4357/aaf383 is OK
- 10.1016/j.combustflame.2020.02.016 is OK
- 10.1016/j.ijmultiphaseflow.2018.11.001 is OK
- 10.1017/jfm.2019.493 is OK
- 10.1051/0004-6361/201525839 is OK
- 10.3847/1538-4357/ab8dc0 is OK
- 10.1051/0004-6361/202037666 is OK
- 10.1093/mnras/staa1795 is OK
- 10.1017/S0022377820000665 is OK

MISSING DOIs

- 10.1051/eas/1044018 may be a valid DOI for title: Modelling the evolution of planets in disks
- 10.1007/3-540-36238-x_12 may be a valid DOI for title: Numerical Simulations of MHD Turbulence in Accretion Disks
- 10.1051/0004-6361/201014287 may be a valid DOI for title: Surface appearance of dynamo-generated large-scale fields
- 10.1017/s1743921307010654 may be a valid DOI for title: Why coronal mass ejections are necessary for the dynamo
- 10.1017/s1539299600015197 may be a valid DOI for title: Ejection of Bi-Helical Fields from the Sun
- 10.1086/498078 may be a valid DOI for title: Gravoturbulent Formation of Planetesimals
- 10.1007/3-540-27401-4_1 may be a valid DOI for title: Passive scalar diffusion as a damped wave
- 10.1007/978-94-007-1063-4_3 may be a valid DOI for title: MHD simulations of small and large scale dynamos
- 10.1016/j.fusengdes.2016.02.077 may be a valid DOI for title: Scoping Studies for NBI Launch Geometries on DEMO
- 10.1007/978-3-319-00116-6_24 may be a valid DOI for title: Numerical simulations of the Kelvin-Helmholtz instability with the Gadget-2 SPH code
- 10.1016/j.proci.2016.06.187 may be a valid DOI for title: The effect of turbulent clustering on particle reactivity
- 10.1051/epjconf/201716002010 may be a valid DOI for title: Dynamos and Differential Rotation: Advances at the Crossroads of Analytics, Numerics, and Observations
- 10.17226/25217_16 may be a valid DOI for title: Perspectives on Reproducibility and Sustainability of Open-Source Scientific Software from Seven Years of the Dedalus Project
- 10.1002/asna.201913632 may be a valid DOI for title: Effects of small-scale dynamo and compressibility on the Ξ›effect
- 10.1051/0004-6361/201935280 may be a valid DOI for title: Antisolar differential rotation of slowly rotating cool stars
- 10.1051/0004-6361/201834921 may be a valid DOI for title: Overshooting in simulations of compressible convection
- 10.3847/1538-4365/ab3a4c may be a valid DOI for title: GAMERA: A three-dimensional finite-volume MHD solver for non-orthogonal curvilinear geometries
- 10.3847/1538-4357/abad92 may be a valid DOI for title: Hall cascade with fractional magnetic helicity in neutron star crusts
- 10.1016/j.idm.2020.08.014 may be a valid DOI for title: Piecewise quadratic growth during the 2019 novel coronavirus epidemic
- 10.1103/physrevlett.124.255102 may be a valid DOI for title: Dynamo in weakly collisional non-magnetized plasmas impeded by Landau damping of magnetic fields
- 10.1017/s1743921320000721 may be a valid DOI for title: Global simulations of stellar dynamos
- 10.3847/1538-4357/ab9a2e may be a valid DOI for title: A simple, entropy-based dissipation trigger for SPH
- 10.1093/mnras/staa2591 may be a valid DOI for title: The Lagrangian hydrodynamics code MAGMA2
- 10.3847/1538-4357/abac58 may be a valid DOI for title: Turbulence sets the length scale for planetesimal formation: Local 2D simulations of streaming instability and planetesimal formation

INVALID DOIs

- None
AxelBrandenburg commented 4 years ago

Hi Whedon, The supplied bibtex file contains all references that quote the Pencil Code, but those with missing DOIs are not quoted in the paper, I believe. Axel

PS: thanks, Arfon, for reviving the process!

On Sat, Oct 31, 2020 at 08:01:38AM -0700, whedon wrote:

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.combustflame.2017.07.008 is OK
- 10.1017/S0022112010002946 is OK
- 10.1103/PhysRevE.70.016308 is OK
- 10.1017/S1473550404001983 is OK
- 10.1016/j.physrep.2005.06.005 is OK
- 10.1086/429584 is OK
- 10.1086/499486 is OK
- 10.1051/0004-6361:20065371 is OK
- 10.1086/498634 is OK
- 10.1111/j.1365-2966.2006.10488.x is OK
- 10.1086/520827 is OK
- 10.1038/nature06086 is OK
- 10.1051/0004-6361:20077943 is OK
- 10.1051/0004-6361:20077942 is OK
- 10.1016/j.newar.2008.04.005 is OK
- 10.1016/j.crhy.2008.07.008 is OK
- 10.1016/j.cpc.2008.03.003 is OK
- 10.1051/0004-6361:200810307 is OK
- 10.1088/0004-637X/691/2/1092 is OK
- 10.1007/s10509-008-9799-2 is OK
- 10.1017/S1743921309993218 is OK
- 10.1088/0067-0049/189/1/142 is OK
- 10.1088/0067-0049/190/2/297 is OK
- 10.1088/0004-637X/722/2/1437 is OK
- 10.1016/j.jcp.2010.10.022 is OK
- 10.1111/j.1745-3933.2011.01037.x is OK
- 10.1017/S1743921311019995 is OK
- 10.1088/0067-0049/194/2/47 is OK
- 10.1017/S1743921311006569 is OK
- 10.1051/0004-6361/201016374 is OK
- 10.1016/j.jcp.2011.09.026 is OK
- 10.1002/chem.201201974 is OK
- 10.1088/1742-6596/440/1/012014 is OK
- 10.1103/PhysRevE.87.053110 is OK
- 10.2458/azu_uapress_9780816531240-ch018 is OK
- 10.1017/S1743921313008284 is OK
- 10.1017/S1743921313012921 is OK
- 10.1146/annurev-astro-081913-040012 is OK
- 10.1088/0004-637X/809/2/149 is OK
- 10.1086/497118 is OK
- 10.1088/0004-637X/697/2/1269 is OK
- 10.1086/527373 is OK
- 10.1086/516730 is OK
- 10.1086/380189 is OK
- 10.1086/498078 is OK
- 10.1088/0004-637X/704/2/L75 is OK
- 10.1086/431214 is OK
- 10.1086/368374 is OK
- 10.1111/j.1365-2966.2007.11801.x is OK
- 10.1103/PhysRevLett.100.184501 is OK
- 10.1086/516729 is OK
- 10.1103/PhysRevE.68.026304 is OK
- 10.1088/1367-2630/9/8/300 is OK
- 10.1051/0004-6361:20034417 is OK
- 10.1051/0004-6361:200600011 is OK
- 10.1051/0004-6361:20031371 is OK
- 10.1086/502968 is OK
- 10.1063/1.1651480 is OK
- 10.1111/j.1745-3933.2008.00423.x is OK
- 10.1002/asna.200510414 is OK
- 10.1051/0004-6361/200811265 is OK
- 10.1086/521781 is OK
- 10.1088/0004-637X/735/2/122 is OK
- 10.1051/0004-6361:200809365 is OK
- 10.1002/asna.200510362 is OK
- 10.1051/0004-6361/200811498 is OK
- 10.1051/0004-6361:20053221 is OK
- 10.1051/0004-6361:20047086 is OK
- 10.1002/asna.200911252 is OK
- 10.1086/587982 is OK
- 10.1002/asna.200510365 is OK
- 10.1051/0004-6361:20077948 is OK
- 10.1111/j.1745-3933.2006.00191.x is OK
- 10.1088/2041-8205/715/2/L68 is OK
- 10.1111/j.1365-2966.2009.14800.x is OK
- 10.1111/j.1365-2966.2004.08127.x is OK
- 10.1103/PhysRevE.70.026405 is OK
- 10.1088/2041-8205/755/1/L22 is OK
- 10.1088/0004-637X/697/2/1206 is OK
- 10.1002/asna.200911308 is OK
- 10.1088/0004-637X/706/1/712 is OK
- 10.1086/593146 is OK
- 10.1111/j.1365-2966.2009.15188.x is OK
- 10.1051/0004-6361:200810626 is OK
- 10.1051/0004-6361/201219127 is OK
- 10.1088/0004-637X/704/2/1239 is OK
- 10.1051/0004-6361:20040435 is OK
- 10.1051/0004-6361/201016019 is OK
- 10.1088/0004-637X/697/2/1153 is OK
- 10.1051/0004-6361:20079232 is OK
- 10.1088/2041-8205/740/2/L50 is OK
- 10.1088/2041-8205/719/1/L1 is OK
- 10.1002/asna.200911311 is OK
- 10.1088/0004-637X/749/2/179 is OK
- 10.1088/0004-637X/699/2/1059 is OK
- 10.1051/0004-6361/201015884 is OK
- 10.1051/0004-6361:200810359 is OK
- 10.1051/0004-6361:200810385 is OK
- 10.1111/j.1365-2966.2007.11511.x is OK
- 10.1086/508675 is OK
- 10.1111/j.1365-2966.2010.16309.x is OK
- 10.1051/0004-6361:200810797 is OK
- 10.1111/j.1365-2966.2007.12659.x is OK
- 10.1051/0004-6361:20053120 is OK
- 10.1007/s11214-012-9909-x is OK
- 10.1051/0004-6361/201015568 is OK
- 10.1088/0004-637X/756/1/62 is OK
- 10.1051/0004-6361/201015979 is OK
- 10.1051/0004-6361/201014700 is OK
- 10.1111/j.1365-2966.2008.14006.x is OK
- 10.1007/s11214-009-9490-0 is OK
- 10.1080/03091929.2010.506438 is OK
- 10.1088/0004-637X/697/1/923 is OK
- 10.1051/0004-6361:20077781 is OK
- 10.1007/s11207-012-9949-0 is OK
- 10.1103/PhysRevE.70.056301 is OK
- 10.1051/0004-6361/201016068 is OK
- 10.1051/0004-6361/201117023 is OK
- 10.1051/0004-6361/201116749 is OK
- 10.1103/PhysRevD.81.123002 is OK
- 10.1111/j.1365-2966.2009.15640.x is OK
- 10.1088/0004-637X/707/2/1233 is OK
- 10.1088/1367-2630/9/8/305 is OK
- 10.1002/asna.200710772 is OK
- 10.1103/PhysRevD.87.083007 is OK
- 10.1088/0004-637X/740/1/18 is OK
- 10.1088/0034-4885/74/4/046901 is OK
- 10.1007/s11207-010-9683-4 is OK
- 10.1111/j.1365-2966.2009.14646.x is OK
- 10.1103/PhysRevE.70.036408 is OK
- 10.1111/j.1365-2966.2012.20801.x is OK
- 10.1111/j.1365-2966.2011.19586.x is OK
- 10.1111/j.1365-2966.2010.18184.x is OK
- 10.1051/0004-6361/201014287 is OK
- 10.1086/509143 is OK
- 10.1111/j.1365-2966.2006.11034.x is OK
- 10.1111/j.1365-2966.2006.10476.x is OK
- 10.1051/0004-6361:20054639 is OK
- 10.1002/asna.201111638 is OK
- 10.1002/asna.201111625 is OK
- 10.1051/0004-6361/201117701 is OK
- 10.1063/1.2222399 is OK
- 10.1002/asna.200410373 is OK
- 10.1088/0004-637X/748/1/51 is OK
- 10.1051/0004-6361/201117871 is OK
- 10.1088/0004-637X/727/1/11 is OK
- 10.1111/j.1365-2966.2009.16004.x is OK
- 10.1051/0004-6361:20054658 is OK
- 10.1002/asna.201111619 is OK
- 10.1088/0004-637X/741/2/92 is OK
- 10.1063/1.3533656 is OK
- 10.1111/j.1365-2966.2010.17408.x is OK
- 10.1051/0004-6361/200912653 is OK
- 10.1103/PhysRevD.86.103005 is OK
- 10.1088/0004-637X/753/1/6 is OK
- 10.1111/j.1365-2966.2011.20153.x is OK
- 10.1103/PhysRevE.84.056314 is OK
- 10.1051/0004-6361/200913722 is OK
- 10.1111/j.1365-2966.2008.13974.x is OK
- 10.1051/0004-6361:20078936 is OK
- 10.1103/PhysRevE.69.056407 is OK
- 10.1051/0004-6361:20030783 is OK
- 10.1093/mnras/sts297 is OK
- 10.1088/0067-0049/201/2/18 is OK
- 10.1088/0004-637X/748/2/79 is OK
- 10.1051/0004-6361/201016108 is OK
- 10.1051/0004-6361/201015661 is OK
- 10.1111/j.1365-2966.2009.15108.x is OK
- 10.1111/j.1365-2966.2008.14173.x is OK
- 10.1103/PhysRevE.79.016302 is OK
- 10.1051/0004-6361:20079098 is OK
- 10.1088/0004-637X/765/2/115 is OK
- 10.1051/0004-6361/201219473 is OK
- 10.1051/0004-6361/201016047 is OK
- 10.1088/0741-3335/51/12/124043 is OK
- 10.1088/0004-637X/778/1/41 is OK
- 10.1007/s11207-012-0108-4 is OK
- 10.1088/0004-637X/750/1/34 is OK
- 10.1017/S174392131100994X is OK
- 10.1002/asna.201011478 is OK
- 10.1023/B:ASTR.0000045000.08395.a3 is OK
- 10.1088/0004-637X/778/2/141 is OK
- 10.1007/s11207-012-0031-8 is OK
- 10.1038/nature12281 is OK
- 10.1093/mnrasl/sls042 is OK
- 10.1093/mnras/sts516 is OK
- 10.1088/0004-637X/759/1/54 is OK
- 10.1088/0004-637X/742/1/34 is OK
- 10.1051/0004-6361/201015073 is OK
- 10.1103/PhysRevE.82.016304 is OK
- 10.1103/PhysRevE.81.036401 is OK
- 10.1002/asna.200811131 is OK
- 10.1051/0004-6361:200809891 is OK
- 10.1002/asna.200811027 is OK
- 10.1002/asna.200710881 is OK
- 10.1088/2041-8205/777/2/L37 is OK
- 10.1088/2041-8205/776/2/L23 is OK
- 10.1051/0004-6361/201220939 is OK
- 10.1093/mnras/sts398 is OK
- 10.1088/0004-637X/763/2/117 is OK
- 10.1051/0004-6361/201220469 is OK
- 10.1051/0004-6361/201220078 is OK
- 10.1051/swsc/2012011 is OK
- 10.1088/0004-637X/753/1/32 is OK
- 10.1051/0004-6361/201015631 is OK
- 10.1051/0004-6361/201015637 is OK
- 10.1002/asna.200911254 is OK
- 10.1111/j.1365-2966.2009.15254.x is OK
- 10.1088/0004-637X/776/1/12 is OK
- 10.1051/0004-6361/201321353 is OK
- 10.1093/mnras/stt560 is OK
- 10.1111/j.1365-2966.2012.21731.x is OK
- 10.1111/j.1365-2966.2012.21758.x is OK
- 10.1088/0004-637X/758/2/103 is OK
- 10.1103/PhysRevE.86.016313 is OK
- 10.1002/asna.201111620 is OK
- 10.1086/591118 is OK
- 10.1017/S1743921307010654 is OK
- 10.1088/0004-637X/758/1/48 is OK
- 10.1088/0067-0049/200/1/6 is OK
- 10.1051/0004-6361/201117889 is OK
- 10.1103/PhysRevE.84.025403 is OK
- 10.1051/0004-6361/201116708 is OK
- 10.1088/0004-637X/719/1/67 is OK
- 10.1051/eas/1042029 is OK
- 10.1017/S1743921307000919 is OK
- 10.1007/11369875_9 is OK
- 10.1111/j.1365-2966.2012.21748.x is OK
- 10.1111/j.1365-2966.2012.21010.x is OK
- 10.1088/0067-0049/200/1/7 is OK
- 10.1002/asna.201211648 is OK
- 10.1103/PhysRevE.84.016406 is OK
- 10.1103/PhysRevE.83.016304 is OK
- 10.1002/asna.200911313 is OK
- 10.1002/asna.200710861 is OK
- 10.1103/PhysRevE.69.056303 is OK
- 10.1103/PhysRevE.87.043104 is OK
- 10.1111/j.1745-3933.2011.01167.x is OK
- 10.1088/2041-8205/735/1/L9 is OK
- 10.1051/0004-6361/201116766 is OK
- 10.1103/PhysRevE.80.055301 is OK
- 10.1051/0004-6361/20078822 is OK
- 10.1063/1.1832142 is OK
- 10.1051/0004-6361/201322315 is OK
- 10.1088/2041-8205/780/2/L22 is OK
- 10.1007/s11214-013-9967-8 is OK
- 10.1093/mnras/stt1273 is OK
- 10.1080/03091929.2012.715158 is OK
- 10.1088/0004-637X/762/2/127 is OK
- 10.1111/j.1365-2966.2011.19693.x is OK
- 10.1103/PhysRevE.84.046321 is OK
- 10.1088/0004-637X/737/2/62 is OK
- 10.1016/j.jcp.2010.08.028 is OK
- 10.1088/0031-8949/2010/T142/014028 is OK
- 10.1080/03091929.2010.504185 is OK
- 10.1111/j.1365-2966.2009.15483.x is OK
- 10.1088/0004-637X/701/2/1269 is OK
- 10.1086/525011 is OK
- 10.1051/0004-6361:20065519 is OK
- 10.1017/S1743921304005721 is OK
- 10.1051/0004-6361/201322461 is OK
- 10.1088/0031-8949/2013/T155/014027 is OK
- 10.1017/S1743921313002457 is OK
- 10.1051/0004-6361/201321185 is OK
- 10.1093/mnras/stt590 is OK
- 10.1088/0031-8949/86/01/018405 is OK
- 10.1063/1.4733450 is OK
- 10.1002/asna.201111617 is OK
- 10.1103/PhysRevE.84.056407 is OK
- 10.1051/0004-6361/201116705 is OK
- 10.1017/S1743921311015249 is OK
- 10.1007/s12043-011-0112-5 is OK
- 10.1017/S1743921310010148 is OK
- 10.1051/eas/1041012 is OK
- 10.1088/0067-0049/182/1/468 is OK
- 10.1016/j.asr.2009.01.033 is OK
- 10.1017/S1743921309030403 is OK
- 10.1088/0031-8949/2008/T130/014016 is OK
- 10.1111/j.1365-2966.2008.13099.x is OK
- 10.1016/j.pepi.2005.03.012 is OK
- 10.1093/mnras/stu438 is OK
- 10.1088/0004-637X/786/2/91 is OK
- 10.1093/mnras/stu1755 is OK
- 10.1017/jfm.2013.290 is OK
- 10.1088/0004-637X/773/2/120 is OK
- 10.1017/S1743921313002676 is OK
- 10.1017/S1743921313002640 is OK
- 10.1051/0004-6361/201321297 is OK
- 10.1088/0031-8949/86/01/018406 is OK
- 10.1017/S1743921312004644 is OK
- 10.1002/asna.201211654 is OK
- 10.1051/0004-6361/201117862 is OK
- 10.1017/S1743921311015055 is OK
- 10.1017/S1743921311017832 is OK
- 10.1017/S1743921311017704 is OK
- 10.1017/S1743921311007538 is OK
- 10.1017/S1743921311007186 is OK
- 10.1007/s10509-010-0276-3 is OK
- 10.1002/asna.200911298 is OK
- 10.1002/asna.200911242 is OK
- 10.1103/PhysRevE.77.026405 is OK
- 10.1002/asna.200610558 is OK
- 10.1088/0004-637X/786/1/51 is OK
- 10.1093/mnras/stt1147 is OK
- 10.1051/eas/1362004 is OK
- 10.1093/mnras/stt891 is OK
- 10.1017/S1743921313002822 is OK
- 10.1017/S1743921313002755 is OK
- 10.1017/S1743921313002743 is OK
- 10.1051/epjconf/20134604003 is OK
- 10.1017/S1743921312019618 is OK
- 10.1080/03091929.2012.681307 is OK
- 10.1002/asna.201312135 is OK
- 10.1051/0004-6361/201117871e is OK
- 10.1017/S1743921312004772 is OK
- 10.1017/S1743921312004620 is OK
- 10.1017/S1743921312004619 is OK
- 10.2298/SAJ1183087A is OK
- 10.1017/S174392131101533X is OK
- 10.1017/S1743921311018023 is OK
- 10.1017/S1743921311017868 is OK
- 10.1017/S1743921311007502 is OK
- 10.1017/S1743921311007496 is OK
- 10.1017/S174392131100737X is OK
- 10.1017/S1743921311007307 is OK
- 10.5281/zenodo.2315093 is OK
- 10.1017/S1743921309992626 is OK
- 10.1016/j.asr.2009.08.020 is OK
- 10.1007/978-1-4419-0239-9_7 is OK
- 10.1017/S1743921307001433 is OK
- 10.1017/S1743921304005101 is OK
- 10.1201/9780203493137.ch9 is OK
- 10.1103/PhysRevE.89.033009 is OK
- 10.1007/s11214-013-9988-3 is OK
- 10.1093/mnras/stt2402 is OK
- 10.1103/PhysRevE.90.041003 is OK
- 10.1155/2014/750754 is OK
- 10.1088/0169-5983/46/4/041401 is OK
- 10.1088/0004-637X/789/1/77 is OK
- 10.1093/mnras/stu809 is OK
- 10.1103/PhysRevE.91.021001 is OK
- 10.1016/j.atmosres.2014.07.017 is OK
- 10.1088/0004-637X/795/1/16 is OK
- 10.1051/0004-6361/201423412 is OK
- 10.1088/2041-8205/796/1/L12 is OK
- 10.1051/0004-6361/201424521 is OK
- 10.1051/0004-6361/201423499 is OK
- 10.1051/0004-6361/201322681 is OK
- 10.1051/0004-6361/201425396 is OK
- 10.1093/mnras/stu2540 is OK
- 10.1088/2041-8205/795/1/L8 is OK
- 10.1002/asna.201412141 is OK
- 10.1093/mnras/stu1708 is OK
- 10.1007/s11214-013-0009-3 is OK
- 10.1088/0004-637X/791/1/12 is OK
- 10.1093/mnras/stu1954 is OK
- 10.1088/0004-637X/803/2/95 is OK
- 10.1017/S1743921314001884 is OK
- 10.1063/1.4891340 is OK
- 10.1051/0004-6361/201322837 is OK
- 10.1051/0004-6361/201424919 is OK
- 10.1088/0004-637X/791/1/48 is OK
- 10.1088/0004-637X/792/1/69 is OK
- 10.1088/0004-637X/797/2/101 is OK
- 10.1088/0004-637X/791/1/62 is OK
- 10.1088/0004-637X/792/2/86 is OK
- 10.1103/PhysRevLett.114.075001 is OK
- 10.1051/0004-6361/201525880 is OK
- 10.3847/0004-637X/824/1/60 is OK
- 10.1051/0004-6361/201525840 is OK
- 10.1051/0004-6361/201526657 is OK
- 10.1103/PhysRevE.93.033125 is OK
- 10.3847/0004-637X/817/2/102 is OK
- 10.1051/0004-6361/201730421 is OK
- 10.3847/0004-637X/816/1/28 is OK
- 10.1051/0004-6361/201628165 is OK
- 10.3847/0004-637X/816/1/2 is OK
- 10.1007/s11214-014-0117-8 is OK
- 10.1007/s11214-015-0199-y is OK
- 10.1088/0004-637X/814/2/155 is OK
- 10.1093/mnras/stv1766 is OK
- 10.1088/0004-637X/811/2/135 is OK
- 10.1093/mnras/stv1598 is OK
- 10.1051/0004-6361/201425274 is OK
- 10.1103/PhysRevLett.115.095001 is OK
- 10.1051/0004-6361/201425120 is OK
- 10.1088/0004-637X/807/2/143 is OK
- 10.1016/j.ascom.2015.02.005 is OK
- 10.1038/nphys3315 is OK
- 10.1088/0004-637X/805/2/166 is OK
- 10.1088/0004-637X/806/1/118 is OK
- 10.1093/mnras/stv195 is OK
- 10.1088/0004-637X/804/2/95 is OK
- 10.1093/mnras/stv459 is OK
- 10.1088/0004-637X/804/1/35 is OK
- 10.1126/sciadv.1500109 is OK
- 10.1007/s11214-014-0100-4 is OK
- 10.1093/mnras/stw1257 is OK
- 10.1201/9780203493137.ch9 is OK
- 10.3847/0067-0049/224/2/39 is OK
- 10.1088/1742-6596/719/1/012006 is OK
- 10.3847/0004-637X/822/1/55 is OK
- 10.1093/mnras/stw888 is OK
- 10.1093/mnras/stx1291 is OK
- 10.1093/pasj/psx008 is OK
- 10.1051/0004-6361/201628960 is OK
- 10.1103/PhysRevLett.118.055102 is OK
- 10.3847/1538-4357/836/1/21 is OK
- 10.1051/0004-6361/201628973 is OK
- 10.3847/0004-637X/831/1/82 is OK
- 10.3847/1538-4357/833/1/43 is OK
- 10.3847/0004-637X/832/2/150 is OK
- 10.1093/mnras/stw1941 is OK
- 10.1051/0004-6361/201630106 is OK
- 10.1103/PhysRevLett.116.101101 is OK
- 10.1051/0004-6361/201526272 is OK
- 10.1088/0031-8949/91/10/104008 is OK
- 10.1093/mnras/stw1619 is OK
- 10.1088/1367-2630/aa5de6 is OK
- 10.1093/mnrasl/slw248 is OK
- 10.1093/mnras/stx148 is OK
- 10.1002/2017MS000930 is OK
- 10.3847/2041-8213/aa83ab is OK
- 10.1002/asna.201713384 is OK
- 10.3847/2041-8213/aa855d is OK
- 10.1017/jfm.2017.364 is OK
- 10.3847/2041-8213/aa844b is OK
- 10.1016/j.cpc.2017.03.011 is OK
- 10.1007/s41116-017-0007-8 is OK
- 10.3847/1538-4357/aa7b33 is OK
- 10.1007/s11214-015-0230-3 is OK
- 10.1063/1.5001338 is OK
- 10.1051/0004-6361/201630208 is OK
- 10.1093/mnras/stx1425 is OK
- 10.1002/asna.201713406 is OK
- 10.1103/PhysRevD.96.083505 is OK
- 10.3847/1538-4357/aa8a66 is OK
- 10.1051/0004-6361/201732191 is OK
- 10.3847/1538-3881/aa8811 is OK
- 10.1051/epjconf/201716002010 is OK
- 10.3847/1538-4357/aa8fcf is OK
- 10.3847/2041-8213/aa96a1 is OK
- 10.1103/PhysRevE.96.053105 is OK
- 10.3847/1538-4357/aa93e7 is OK
- 10.1103/PhysRevD.96.123528 is OK
- 10.1088/1475-7516/2017/12/002 is OK
- 10.1093/mnras/stx1989 is OK
- 10.1017/S0022377818000806 is OK
- 10.1002/asna.201813477 is OK
- 10.1002/asna.201813472 is OK
- 10.1103/PhysRevE.97.023105 is OK
- 10.1140/epjp/i2018-11865-7 is OK
- 10.3847/1538-4357/aaadaa is OK
- 10.1051/0004-6361/201833018 is OK
- 10.1051/0004-6361/201628136 is OK
- 10.1051/0004-6361/201732413 is OK
- 10.1080/03091929.2018.1515313 is OK
- 10.1093/mnras/stx3255 is OK
- 10.3847/1538-4357/aab891 is OK
- 10.3847/1538-4357/aae97a is OK
- 10.3847/1538-4357/aae97f is OK
- 10.1016/j.physrep.2018.02.006 is OK
- 10.1093/mnras/stx3164 is OK
- 10.1093/mnras/sty1570 is OK
- 10.1051/0004-6361/201732066 is OK
- 10.3847/1538-4357/aaba75 is OK
- 10.1093/mnras/sty593 is OK
- 10.1093/mnras/stz1509 is OK
- 10.1007/s11084-019-09579-4 is OK
- 10.1007/s41115-017-0001-9 is OK
- 10.1093/mnras/stz2042 is OK
- 10.3847/1538-4357/ab2f85 is OK
- 10.3847/1538-4357/ab258e is OK
- 10.3847/2515-5172/ab2894 is OK
- 10.1063/1.5092152 is OK
- 10.1051/0004-6361/201935945 is OK
- 10.1126/science.aat5330 is OK
- 10.1103/PhysRevE.99.043206 is OK
- 10.3390/galaxies7020045 is OK
- 10.1051/0004-6361/201935385 is OK
- 10.1093/mnras/sty3369 is OK
- 10.1080/03091929.2019.1571584 is OK
- 10.1093/mnras/stz2084 is OK
- 10.1103/PhysRevFluids.4.024608 is OK
- 10.1017/S0022377818001290 is OK
- 10.1080/10618562.2019.1593385 is OK
- 10.3847/1538-4357/aaffd8 is OK
- 10.5194/acp-19-639-2019 is OK
- 10.1103/PhysRevE.98.063107 is OK
- 10.1093/mnras/sty1757 is OK
- 10.1051/0004-6361/201834921 is OK
- 10.3847/1538-4357/aae7d4 is OK
- 10.1002/asna.201913602 is OK
- 10.3847/2515-5172/aaeac9 is OK
- 10.1175/JAS-D-18-0081.1 is OK
- 10.1051/0004-6361/201832783 is OK
- 10.1093/mnras/sty1594 is OK
- 10.1088/1475-7516/2018/08/034 is OK
- 10.3847/1538-4357/aaca99 is OK
- 10.3847/1538-4357/aac3d4 is OK
- 10.1080/03091929.2019.1672676 is OK
- 10.1080/03091929.2018.1492720 is OK
- 10.1080/03091929.2019.1571586 is OK
- 10.1080/03091929.2019.1591393 is OK
- 10.1080/03091929.2019.1653460 is OK
- 10.1080/03091929.2019.1653461 is OK
- 10.1080/03091929.2019.1670173 is OK
- 10.1088/1742-6596/1031/1/012007 is OK
- 10.1093/mnras/stz1354 is OK
- 10.1051/0004-6361/201730825 is OK
- 10.1093/pasj/psu123 is OK
- 10.3847/2041-8213/aa9988 is OK
- 10.3847/2041-8213/ab974a is OK
- 10.3847/1538-4357/ab8d37 is OK
- 10.1103/PhysRevD.101.103028 is OK
- 10.1103/PhysRevFluids.5.043702 is OK
- 10.3847/1538-4357/ab791c is OK
- 10.3847/1538-4357/ab77bd is OK
- 10.1103/PhysRevE.101.033102 is OK
- 10.1093/mnras/staa663 is OK
- 10.1017/S1743921319004447 is OK
- 10.1080/03091929.2019.1643849 is OK
- 10.1080/03091929.2019.1676894 is OK
- 10.1080/03091929.2019.1634705 is OK
- 10.1080/03091929.2019.1668382 is OK
- 10.1051/0004-6361/201937037 is OK
- 10.1093/mnras/stz3232 is OK
- 10.1017/S0022377820000082 is OK
- 10.1093/mnras/stz3065 is OK
- 10.1175/JAS-D-19-0107.1 is OK
- 10.3847/1538-4357/ab5e7f is OK
- 10.1051/0004-6361/201936841 is OK
- 10.1093/mnras/stz2957 is OK
- 10.3847/1538-4357/ab5961 is OK
- 10.3847/1538-4357/ab3f3b is OK
- 10.1088/1742-6596/1336/1/012012 is OK
- 10.3847/1538-4357/ab3e07 is OK
- 10.3847/1538-4365/ab4356 is OK
- 10.1007/s41115-019-0005-8 is OK
- 10.1080/03091929.2019.1677015 is OK
- 10.3847/1538-4357/ab24bd is OK
- 10.3847/1538-4357/aaf383 is OK
- 10.1016/j.combustflame.2020.02.016 is OK
- 10.1016/j.ijmultiphaseflow.2018.11.001 is OK
- 10.1017/jfm.2019.493 is OK
- 10.1051/0004-6361/201525839 is OK
- 10.3847/1538-4357/ab8dc0 is OK
- 10.1051/0004-6361/202037666 is OK
- 10.1093/mnras/staa1795 is OK
- 10.1017/S0022377820000665 is OK

MISSING DOIs

- 10.1051/eas/1044018 may be a valid DOI for title: Modelling the evolution of planets in disks
- 10.1007/3-540-36238-x_12 may be a valid DOI for title: Numerical Simulations of MHD Turbulence in Accretion Disks
- 10.1051/0004-6361/201014287 may be a valid DOI for title: Surface appearance of dynamo-generated large-scale fields
- 10.1017/s1743921307010654 may be a valid DOI for title: Why coronal mass ejections are necessary for the dynamo
- 10.1017/s1539299600015197 may be a valid DOI for title: Ejection of Bi-Helical Fields from the Sun
- 10.1086/498078 may be a valid DOI for title: Gravoturbulent Formation of Planetesimals
- 10.1007/3-540-27401-4_1 may be a valid DOI for title: Passive scalar diffusion as a damped wave
- 10.1007/978-94-007-1063-4_3 may be a valid DOI for title: MHD simulations of small and large scale dynamos
- 10.1016/j.fusengdes.2016.02.077 may be a valid DOI for title: Scoping Studies for NBI Launch Geometries on DEMO
- 10.1007/978-3-319-00116-6_24 may be a valid DOI for title: Numerical simulations of the Kelvin-Helmholtz instability with the Gadget-2 SPH code
- 10.1016/j.proci.2016.06.187 may be a valid DOI for title: The effect of turbulent clustering on particle reactivity
- 10.1051/epjconf/201716002010 may be a valid DOI for title: Dynamos and Differential Rotation: Advances at the Crossroads of Analytics, Numerics, and Observations
- 10.17226/25217_16 may be a valid DOI for title: Perspectives on Reproducibility and Sustainability of Open-Source Scientific Software from Seven Years of the Dedalus Project
- 10.1002/asna.201913632 may be a valid DOI for title: Effects of small-scale dynamo and compressibility on the Ξ›effect
- 10.1051/0004-6361/201935280 may be a valid DOI for title: Antisolar differential rotation of slowly rotating cool stars
- 10.1051/0004-6361/201834921 may be a valid DOI for title: Overshooting in simulations of compressible convection
- 10.3847/1538-4365/ab3a4c may be a valid DOI for title: GAMERA: A three-dimensional finite-volume MHD solver for non-orthogonal curvilinear geometries
- 10.3847/1538-4357/abad92 may be a valid DOI for title: Hall cascade with fractional magnetic helicity in neutron star crusts
- 10.1016/j.idm.2020.08.014 may be a valid DOI for title: Piecewise quadratic growth during the 2019 novel coronavirus epidemic
- 10.1103/physrevlett.124.255102 may be a valid DOI for title: Dynamo in weakly collisional non-magnetized plasmas impeded by Landau damping of magnetic fields
- 10.1017/s1743921320000721 may be a valid DOI for title: Global simulations of stellar dynamos
- 10.3847/1538-4357/ab9a2e may be a valid DOI for title: A simple, entropy-based dissipation trigger for SPH
- 10.1093/mnras/staa2591 may be a valid DOI for title: The Lagrangian hydrodynamics code MAGMA2
- 10.3847/1538-4357/abac58 may be a valid DOI for title: Turbulence sets the length scale for planetesimal formation: Local 2D simulations of streaming instability and planetesimal formation

INVALID DOIs

- None

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-719945448

whedon commented 4 years ago

:wave: @zingale, please update us on how your review is going.

whedon commented 4 years ago

:wave: @rtfisher, please update us on how your review is going.

rtfisher commented 4 years ago

As mentioned previously, I have some pressing prior obligations to attend to. I will be able to focus on the review after 11/17.

Best wishes,

Bob

On Sat, Nov 7, 2020 at 9:54 AM whedon notifications@github.com wrote:

πŸ‘‹ @rtfisher https://github.com/rtfisher, please update us on how your review is going.

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-723455721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2Y7CIYOSZNFNBBDR3NGJ3SOVNTTANCNFSM4TF5YSQA .

-- Dr. Robert Fisher Associate Professor / Graduate Program Director University of Massachusetts/Dartmouth Department of Physics 285 Old Westport Road North Dartmouth, Massachusetts 02747 robert.fisher@umassd.edu http://www.novastella.org

zingale commented 4 years ago

I hope to have a good first pass done by the end of this week

zingale commented 4 years ago

I don't see any API documentation on the webpage -- am I missing it?

arfon commented 3 years ago

:wave: @rtfisher - just checking in to see when you might be able to provide a review by?

rtfisher commented 3 years ago

Apologies -- absolutely buried here. I should have something in a week or so.

On Tue, Dec 8, 2020 at 5:07 PM Arfon Smith notifications@github.com wrote:

πŸ‘‹ @rtfisher https://github.com/rtfisher - just checking in to see when you might be able to provide a review by?

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-741111487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2Y7CIQGRSPIULUU4J54RLST2PT3ANCNFSM4TF5YSQA .

-- Dr. Robert Fisher Associate Professor / Graduate Program Director University of Massachusetts/Dartmouth Department of Physics 285 Old Westport Road North Dartmouth, Massachusetts 02747 robert.fisher@umassd.edu http://www.novastella.org

zingale commented 3 years ago

I think I'm basically done with my review. The authors address the 4 issues I filed. I'll continue to poke around a bit, but it looks good to me.

arfon commented 3 years ago

:wave: @rtfisher - happy near year! Do you think you might be able to complete your review soon?

rtfisher commented 3 years ago

Apologies again! Between the AAS meeting and the start of the semester, I was booked solid. This is now at the top of my queue.

rtfisher commented 3 years ago

I'm done with the review of most of the items. Overall I am impressed with the code framework, test suite, and documentation. I have just two issues.

One is that I do not have access to IDL, and so cannot directly confirm the graphical output presented for the test case. I'm not sure how much of an issue that is for JOSS.

Additionally, I don't agree with the statement, "While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics are publicly available, this does not generally seem to be the case for higher order finite-difference or spectral codes." This may have been true at one point in time, but I know of at least SpECTRE (https://arxiv.org/abs/1609.00098) which is a DG code with exponential convergence on smooth problems, and therefore falls into precisely this category. There may be others. It seems to me they should be mentioned.

arfon commented 3 years ago

Thanks for the update @rtfisher!

One is that I do not have access to IDL, and so cannot directly confirm the graphical output presented for the test case. I'm not sure how much of an issue that is for JOSS.

OK, no problem.

Additionally, I don't agree with the statement, "While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics are publicly available, this does not generally seem to be the case for higher order finite-difference or spectral codes." This may have been true at one point in time, but I know of at least SpECTRE (https://arxiv.org/abs/1609.00098) which is a DG code with exponential convergence on smooth problems, and therefore falls into precisely this category. There may be others. It seems to me they should be mentioned.

Right, it seems like that language should be modified. @AxelBrandenburg - what do you think about this?

AxelBrandenburg commented 3 years ago

Dear Arfon and Robert,

I'm done with the review of most of the items. Overall I am impressed with the code framework, test suite, and documentation. I have just two issues.

Thanks, Robert, for your positive assessment.

One is that I do not have access to IDL, and so cannot directly confirm the graphical output presented for the test case. I'm not sure how much of an issue that is for JOSS.

On page 9 of the manual, https://github.com/pencil-code/website/blob/master/doc/manual.pdf we have now added:

The same can be achieved using Python (see Sect. 5.19.5 for details) with unix > python python > from matplotlib import pylab as plt python > var = pc.read.var(trimall=True) python > plt.imshow(var.uu[0, 0, :, : ].T, origin=’lower’) where we also make sure that the axis are shown in a natural way.

We also recall that in https://github.com/pencil-code/pencil-code/blob/master/README.md under "Documentation", item 3, it says: Information about PythonCodingStyle and the PythonCodingStyle can be found on the wiki. The latter refers to https://github.com/pencil-code/pencil-code/wiki

Additionally, I don't agree with the statement, "While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics are publicly available, this does not generally seem to be the case for higher order finite-difference or spectral codes." This may have been true at one point in time, but I know of at least SpECTRE (https://arxiv.org/abs/1609.00098) which is a DG code with exponential convergence on smooth problems, and therefore falls into precisely this category. There may be others. It seems to me they should be mentioned.

We fully agree. This refers to the foreword of the manual, page vii, lines 2-6, where we now write:

While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics were publicly available, this did not seem to be generally the case for higher order finite-difference or spectral codes. This has changed since 2001; examples are the SpECTRE code, which is a discontinuous Galerkin code, and there are also the Snoopy and Dedalus codes, which are spectral.

In the actual JOSS submission (paper.md), we have now added under "Key references" Another example is SpECTRE, a task-based discontinuous Galerkin code for relativistic astrophysics [@Kidder_2017].

We hope that with this our JOSS submission satisfies now the publication requirements. Cheers, Axel

On Sun, Jan 31, 2021 at 12:31:09PM -0800, Robert Fisher wrote:

I'm done with the review of most of the items. Overall I am impressed with the code framework, test suite, and documentation. I have just two issues.

One is that I do not have access to IDL, and so cannot directly confirm the graphical output presented for the test case. I'm not sure how much of an issue that is for JOSS.

Additionally, I don't agree with the statement, "While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics are publicly available, this does not generally seem to be the case for higher order finite-difference or spectral codes." This may have been true at one point in time, but I know of at least SpECTRE (https://arxiv.org/abs/1609.00098) which is a DG code with exponential convergence on smooth problems, and therefore falls into precisely this category. There may be others. It seems to me they should be mentioned.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-770445620

AxelBrandenburg commented 3 years ago

PS: there was a small typo in our README.md and reply below: "PythonCodingStyle and the PythonCodingStyle" -> "Python with the Pencil Code and the Python Coding Style", which is now fixed.

On Sat, Feb 06, 2021 at 05:41:16AM +0100, Axel Brandenburg wrote:

Dear Arfon and Robert,

I'm done with the review of most of the items. Overall I am impressed with the code framework, test suite, and documentation. I have just two issues.

Thanks, Robert, for your positive assessment.

One is that I do not have access to IDL, and so cannot directly confirm the graphical output presented for the test case. I'm not sure how much of an issue that is for JOSS.

On page 9 of the manual, https://github.com/pencil-code/website/blob/master/doc/manual.pdf we have now added:

The same can be achieved using Python (see Sect. 5.19.5 for details) with unix > python python > from matplotlib import pylab as plt python > var = pc.read.var(trimall=True) python > plt.imshow(var.uu[0, 0, :, : ].T, origin=’lower’) where we also make sure that the axis are shown in a natural way.

We also recall that in https://github.com/pencil-code/pencil-code/blob/master/README.md under "Documentation", item 3, it says: Information about PythonCodingStyle and the PythonCodingStyle can be found on the wiki. The latter refers to https://github.com/pencil-code/pencil-code/wiki

Additionally, I don't agree with the statement, "While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics are publicly available, this does not generally seem to be the case for higher order finite-difference or spectral codes." This may have been true at one point in time, but I know of at least SpECTRE (https://arxiv.org/abs/1609.00098) which is a DG code with exponential convergence on smooth problems, and therefore falls into precisely this category. There may be others. It seems to me they should be mentioned.

We fully agree. This refers to the foreword of the manual, page vii, lines 2-6, where we now write:

While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics were publicly available, this did not seem to be generally the case for higher order finite-difference or spectral codes. This has changed since 2001; examples are the SpECTRE code, which is a discontinuous Galerkin code, and there are also the Snoopy and Dedalus codes, which are spectral.

In the actual JOSS submission (paper.md), we have now added under "Key references" Another example is SpECTRE, a task-based discontinuous Galerkin code for relativistic astrophysics [@Kidder_2017].

We hope that with this our JOSS submission satisfies now the publication requirements. Cheers, Axel

On Sun, Jan 31, 2021 at 12:31:09PM -0800, Robert Fisher wrote:

I'm done with the review of most of the items. Overall I am impressed with the code framework, test suite, and documentation. I have just two issues.

One is that I do not have access to IDL, and so cannot directly confirm the graphical output presented for the test case. I'm not sure how much of an issue that is for JOSS.

Additionally, I don't agree with the statement, "While some SPH and PPM codes for hydrodynamics and magnetohydrodynamics are publicly available, this does not generally seem to be the case for higher order finite-difference or spectral codes." This may have been true at one point in time, but I know of at least SpECTRE (https://arxiv.org/abs/1609.00098) which is a DG code with exponential convergence on smooth problems, and therefore falls into precisely this category. There may be others. It seems to me they should be mentioned.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-770445620

arfon commented 3 years ago

Thanks for the fast turnaround @AxelBrandenburg! @rtfisher - when you have a moment, please come and take a look at these updates and if you are satisfied with the changes please update the checkboxes above and let us know your recommendation.

arfon commented 3 years ago

@AxelBrandenburg - At this point could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:

I can then move forward with accepting the submission.

AxelBrandenburg commented 3 years ago

Thanks, Arfon, for the promising news. I have now made a new release and uploaded it on zenodo; see https://zenodo.org/record/4553325 Let me know if anything is not quite right yet. Cheers, Axel

Sent from my iPad

On 20 Feb 2021, at 12:44, Arfon Smith notifications@github.com wrote: Zenodo/figshare archive

arfon commented 3 years ago

@whedon set 10.5281/zenodo.4553325 as archive

whedon commented 3 years ago

OK. 10.5281/zenodo.4553325 is the archive.

arfon commented 3 years ago

@whedon set v2021.02.20 as version

whedon commented 3 years ago

OK. v2021.02.20 is the version.

arfon commented 3 years ago

@whedon accept

whedon commented 3 years ago
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2102

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2102, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
arfon commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.combustflame.2017.07.008 is OK
- 10.1017/S0022112010002946 is OK
- 10.1103/PhysRevE.70.016308 is OK
- 10.1017/S1473550404001983 is OK
- 10.1016/j.physrep.2005.06.005 is OK
- 10.1086/429584 is OK
- 10.1086/499486 is OK
- 10.1051/0004-6361:20065371 is OK
- 10.1086/498634 is OK
- 10.1111/j.1365-2966.2006.10488.x is OK
- 10.1086/520827 is OK
- 10.1038/nature06086 is OK
- 10.1051/0004-6361:20077943 is OK
- 10.1051/0004-6361:20077942 is OK
- 10.1016/j.newar.2008.04.005 is OK
- 10.1016/j.crhy.2008.07.008 is OK
- 10.1016/j.cpc.2008.03.003 is OK
- 10.1051/0004-6361:200810307 is OK
- 10.1088/0004-637X/691/2/1092 is OK
- 10.1007/s10509-008-9799-2 is OK
- 10.1017/S1743921309993218 is OK
- 10.1088/0067-0049/189/1/142 is OK
- 10.1088/0067-0049/190/2/297 is OK
- 10.1088/0004-637X/722/2/1437 is OK
- 10.1016/j.jcp.2010.10.022 is OK
- 10.1111/j.1745-3933.2011.01037.x is OK
- 10.1017/S1743921311019995 is OK
- 10.1088/0067-0049/194/2/47 is OK
- 10.1017/S1743921311006569 is OK
- 10.1051/0004-6361/201016374 is OK
- 10.1016/j.jcp.2011.09.026 is OK
- 10.1002/chem.201201974 is OK
- 10.1088/1742-6596/440/1/012014 is OK
- 10.1103/PhysRevE.87.053110 is OK
- 10.2458/azu_uapress_9780816531240-ch018 is OK
- 10.1017/S1743921313008284 is OK
- 10.1017/S1743921313012921 is OK
- 10.1146/annurev-astro-081913-040012 is OK
- 10.1088/0004-637X/809/2/149 is OK
- 10.1086/497118 is OK
- 10.1088/0004-637X/697/2/1269 is OK
- 10.1086/527373 is OK
- 10.1086/516730 is OK
- 10.1086/380189 is OK
- 10.1086/498078 is OK
- 10.1088/0004-637X/704/2/L75 is OK
- 10.1086/431214 is OK
- 10.1086/368374 is OK
- 10.1111/j.1365-2966.2007.11801.x is OK
- 10.1103/PhysRevLett.100.184501 is OK
- 10.1086/516729 is OK
- 10.1103/PhysRevE.68.026304 is OK
- 10.1088/1367-2630/9/8/300 is OK
- 10.1051/0004-6361:20034417 is OK
- 10.1051/0004-6361:200600011 is OK
- 10.1051/0004-6361:20031371 is OK
- 10.1086/502968 is OK
- 10.1063/1.1651480 is OK
- 10.1111/j.1745-3933.2008.00423.x is OK
- 10.1002/asna.200510414 is OK
- 10.1051/0004-6361/200811265 is OK
- 10.1086/521781 is OK
- 10.1088/0004-637X/735/2/122 is OK
- 10.1051/0004-6361:200809365 is OK
- 10.1002/asna.200510362 is OK
- 10.1051/0004-6361/200811498 is OK
- 10.1051/0004-6361:20053221 is OK
- 10.1051/0004-6361:20047086 is OK
- 10.1002/asna.200911252 is OK
- 10.1086/587982 is OK
- 10.1002/asna.200510365 is OK
- 10.1051/0004-6361:20077948 is OK
- 10.1111/j.1745-3933.2006.00191.x is OK
- 10.1088/2041-8205/715/2/L68 is OK
- 10.1111/j.1365-2966.2009.14800.x is OK
- 10.1111/j.1365-2966.2004.08127.x is OK
- 10.1103/PhysRevE.70.026405 is OK
- 10.1088/2041-8205/755/1/L22 is OK
- 10.1088/0004-637X/697/2/1206 is OK
- 10.1002/asna.200911308 is OK
- 10.1088/0004-637X/706/1/712 is OK
- 10.1086/593146 is OK
- 10.1111/j.1365-2966.2009.15188.x is OK
- 10.1051/0004-6361:200810626 is OK
- 10.1051/0004-6361/201219127 is OK
- 10.1088/0004-637X/704/2/1239 is OK
- 10.1051/0004-6361:20040435 is OK
- 10.1051/0004-6361/201016019 is OK
- 10.1088/0004-637X/697/2/1153 is OK
- 10.1051/0004-6361:20079232 is OK
- 10.1088/2041-8205/740/2/L50 is OK
- 10.1088/2041-8205/719/1/L1 is OK
- 10.1002/asna.200911311 is OK
- 10.1088/0004-637X/749/2/179 is OK
- 10.1088/0004-637X/699/2/1059 is OK
- 10.1051/0004-6361/201015884 is OK
- 10.1051/0004-6361:200810359 is OK
- 10.1051/0004-6361:200810385 is OK
- 10.1111/j.1365-2966.2007.11511.x is OK
- 10.1086/508675 is OK
- 10.1111/j.1365-2966.2010.16309.x is OK
- 10.1051/0004-6361:200810797 is OK
- 10.1111/j.1365-2966.2007.12659.x is OK
- 10.1051/0004-6361:20053120 is OK
- 10.1007/s11214-012-9909-x is OK
- 10.1051/0004-6361/201015568 is OK
- 10.1088/0004-637X/756/1/62 is OK
- 10.1051/0004-6361/201015979 is OK
- 10.1051/0004-6361/201014700 is OK
- 10.1111/j.1365-2966.2008.14006.x is OK
- 10.1007/s11214-009-9490-0 is OK
- 10.1080/03091929.2010.506438 is OK
- 10.1088/0004-637X/697/1/923 is OK
- 10.1051/0004-6361:20077781 is OK
- 10.1007/s11207-012-9949-0 is OK
- 10.1103/PhysRevE.70.056301 is OK
- 10.1051/0004-6361/201016068 is OK
- 10.1051/0004-6361/201117023 is OK
- 10.1051/0004-6361/201116749 is OK
- 10.1103/PhysRevD.81.123002 is OK
- 10.1111/j.1365-2966.2009.15640.x is OK
- 10.1088/0004-637X/707/2/1233 is OK
- 10.1088/1367-2630/9/8/305 is OK
- 10.1002/asna.200710772 is OK
- 10.1103/PhysRevD.87.083007 is OK
- 10.1088/0004-637X/740/1/18 is OK
- 10.1088/0034-4885/74/4/046901 is OK
- 10.1007/s11207-010-9683-4 is OK
- 10.1111/j.1365-2966.2009.14646.x is OK
- 10.1103/PhysRevE.70.036408 is OK
- 10.1111/j.1365-2966.2012.20801.x is OK
- 10.1111/j.1365-2966.2011.19586.x is OK
- 10.1111/j.1365-2966.2010.18184.x is OK
- 10.1051/0004-6361/201014287 is OK
- 10.1086/509143 is OK
- 10.1111/j.1365-2966.2006.11034.x is OK
- 10.1111/j.1365-2966.2006.10476.x is OK
- 10.1051/0004-6361:20054639 is OK
- 10.1002/asna.201111638 is OK
- 10.1002/asna.201111625 is OK
- 10.1051/0004-6361/201117701 is OK
- 10.1063/1.2222399 is OK
- 10.1002/asna.200410373 is OK
- 10.1088/0004-637X/748/1/51 is OK
- 10.1051/0004-6361/201117871 is OK
- 10.1088/0004-637X/727/1/11 is OK
- 10.1111/j.1365-2966.2009.16004.x is OK
- 10.1051/0004-6361:20054658 is OK
- 10.1002/asna.201111619 is OK
- 10.1088/0004-637X/741/2/92 is OK
- 10.1063/1.3533656 is OK
- 10.1111/j.1365-2966.2010.17408.x is OK
- 10.1051/0004-6361/200912653 is OK
- 10.1103/PhysRevD.86.103005 is OK
- 10.1088/0004-637X/753/1/6 is OK
- 10.1111/j.1365-2966.2011.20153.x is OK
- 10.1103/PhysRevE.84.056314 is OK
- 10.1051/0004-6361/200913722 is OK
- 10.1111/j.1365-2966.2008.13974.x is OK
- 10.1051/0004-6361:20078936 is OK
- 10.1103/PhysRevE.69.056407 is OK
- 10.1051/0004-6361:20030783 is OK
- 10.1093/mnras/sts297 is OK
- 10.1088/0067-0049/201/2/18 is OK
- 10.1088/0004-637X/748/2/79 is OK
- 10.1051/0004-6361/201016108 is OK
- 10.1051/0004-6361/201015661 is OK
- 10.1111/j.1365-2966.2009.15108.x is OK
- 10.1111/j.1365-2966.2008.14173.x is OK
- 10.1103/PhysRevE.79.016302 is OK
- 10.1051/0004-6361:20079098 is OK
- 10.1088/0004-637X/765/2/115 is OK
- 10.1051/0004-6361/201219473 is OK
- 10.1051/0004-6361/201016047 is OK
- 10.1088/0741-3335/51/12/124043 is OK
- 10.1088/0004-637X/778/1/41 is OK
- 10.1007/s11207-012-0108-4 is OK
- 10.1088/0004-637X/750/1/34 is OK
- 10.1017/S174392131100994X is OK
- 10.1002/asna.201011478 is OK
- 10.1023/B:ASTR.0000045000.08395.a3 is OK
- 10.1088/0004-637X/778/2/141 is OK
- 10.1007/s11207-012-0031-8 is OK
- 10.1038/nature12281 is OK
- 10.1093/mnrasl/sls042 is OK
- 10.1093/mnras/sts516 is OK
- 10.1088/0004-637X/759/1/54 is OK
- 10.1088/0004-637X/742/1/34 is OK
- 10.1051/0004-6361/201015073 is OK
- 10.1103/PhysRevE.82.016304 is OK
- 10.1103/PhysRevE.81.036401 is OK
- 10.1002/asna.200811131 is OK
- 10.1051/0004-6361:200809891 is OK
- 10.1002/asna.200811027 is OK
- 10.1002/asna.200710881 is OK
- 10.1088/2041-8205/777/2/L37 is OK
- 10.1088/2041-8205/776/2/L23 is OK
- 10.1051/0004-6361/201220939 is OK
- 10.1093/mnras/sts398 is OK
- 10.1088/0004-637X/763/2/117 is OK
- 10.1051/0004-6361/201220469 is OK
- 10.1051/0004-6361/201220078 is OK
- 10.1051/swsc/2012011 is OK
- 10.1088/0004-637X/753/1/32 is OK
- 10.1051/0004-6361/201015631 is OK
- 10.1051/0004-6361/201015637 is OK
- 10.1002/asna.200911254 is OK
- 10.1111/j.1365-2966.2009.15254.x is OK
- 10.1088/0004-637X/776/1/12 is OK
- 10.1051/0004-6361/201321353 is OK
- 10.1093/mnras/stt560 is OK
- 10.1111/j.1365-2966.2012.21731.x is OK
- 10.1111/j.1365-2966.2012.21758.x is OK
- 10.1088/0004-637X/758/2/103 is OK
- 10.1103/PhysRevE.86.016313 is OK
- 10.1002/asna.201111620 is OK
- 10.1086/591118 is OK
- 10.1017/S1743921307010654 is OK
- 10.1088/0004-637X/758/1/48 is OK
- 10.1088/0067-0049/200/1/6 is OK
- 10.1051/0004-6361/201117889 is OK
- 10.1103/PhysRevE.84.025403 is OK
- 10.1051/0004-6361/201116708 is OK
- 10.1088/0004-637X/719/1/67 is OK
- 10.1051/eas/1042029 is OK
- 10.1017/S1743921307000919 is OK
- 10.1007/11369875_9 is OK
- 10.1111/j.1365-2966.2012.21748.x is OK
- 10.1111/j.1365-2966.2012.21010.x is OK
- 10.1088/0067-0049/200/1/7 is OK
- 10.1002/asna.201211648 is OK
- 10.1103/PhysRevE.84.016406 is OK
- 10.1103/PhysRevE.83.016304 is OK
- 10.1002/asna.200911313 is OK
- 10.1002/asna.200710861 is OK
- 10.1103/PhysRevE.69.056303 is OK
- 10.1103/PhysRevE.87.043104 is OK
- 10.1111/j.1745-3933.2011.01167.x is OK
- 10.1088/2041-8205/735/1/L9 is OK
- 10.1051/0004-6361/201116766 is OK
- 10.1103/PhysRevE.80.055301 is OK
- 10.1051/0004-6361/20078822 is OK
- 10.1063/1.1832142 is OK
- 10.1051/0004-6361/201322315 is OK
- 10.1088/2041-8205/780/2/L22 is OK
- 10.1007/s11214-013-9967-8 is OK
- 10.1093/mnras/stt1273 is OK
- 10.1080/03091929.2012.715158 is OK
- 10.1088/0004-637X/762/2/127 is OK
- 10.1111/j.1365-2966.2011.19693.x is OK
- 10.1103/PhysRevE.84.046321 is OK
- 10.1088/0004-637X/737/2/62 is OK
- 10.1016/j.jcp.2010.08.028 is OK
- 10.1088/0031-8949/2010/T142/014028 is OK
- 10.1080/03091929.2010.504185 is OK
- 10.1111/j.1365-2966.2009.15483.x is OK
- 10.1088/0004-637X/701/2/1269 is OK
- 10.1086/525011 is OK
- 10.1051/0004-6361:20065519 is OK
- 10.1017/S1743921304005721 is OK
- 10.1051/0004-6361/201322461 is OK
- 10.1088/0031-8949/2013/T155/014027 is OK
- 10.1017/S1743921313002457 is OK
- 10.1051/0004-6361/201321185 is OK
- 10.1093/mnras/stt590 is OK
- 10.1088/0031-8949/86/01/018405 is OK
- 10.1063/1.4733450 is OK
- 10.1002/asna.201111617 is OK
- 10.1103/PhysRevE.84.056407 is OK
- 10.1051/0004-6361/201116705 is OK
- 10.1017/S1743921311015249 is OK
- 10.1007/s12043-011-0112-5 is OK
- 10.1017/S1743921310010148 is OK
- 10.1051/eas/1041012 is OK
- 10.1088/0067-0049/182/1/468 is OK
- 10.1016/j.asr.2009.01.033 is OK
- 10.1017/S1743921309030403 is OK
- 10.1088/0031-8949/2008/T130/014016 is OK
- 10.1111/j.1365-2966.2008.13099.x is OK
- 10.1016/j.pepi.2005.03.012 is OK
- 10.1093/mnras/stu438 is OK
- 10.1088/0004-637X/786/2/91 is OK
- 10.1093/mnras/stu1755 is OK
- 10.1017/jfm.2013.290 is OK
- 10.1088/0004-637X/773/2/120 is OK
- 10.1017/S1743921313002676 is OK
- 10.1017/S1743921313002640 is OK
- 10.1051/0004-6361/201321297 is OK
- 10.1088/0031-8949/86/01/018406 is OK
- 10.1017/S1743921312004644 is OK
- 10.1002/asna.201211654 is OK
- 10.1051/0004-6361/201117862 is OK
- 10.1017/S1743921311015055 is OK
- 10.1017/S1743921311017832 is OK
- 10.1017/S1743921311017704 is OK
- 10.1017/S1743921311007538 is OK
- 10.1017/S1743921311007186 is OK
- 10.1007/s10509-010-0276-3 is OK
- 10.1002/asna.200911298 is OK
- 10.1002/asna.200911242 is OK
- 10.1103/PhysRevE.77.026405 is OK
- 10.1002/asna.200610558 is OK
- 10.1088/0004-637X/786/1/51 is OK
- 10.1093/mnras/stt1147 is OK
- 10.1051/eas/1362004 is OK
- 10.1093/mnras/stt891 is OK
- 10.1017/S1743921313002822 is OK
- 10.1017/S1743921313002755 is OK
- 10.1017/S1743921313002743 is OK
- 10.1051/epjconf/20134604003 is OK
- 10.1017/S1743921312019618 is OK
- 10.1080/03091929.2012.681307 is OK
- 10.1002/asna.201312135 is OK
- 10.1051/0004-6361/201117871e is OK
- 10.1017/S1743921312004772 is OK
- 10.1017/S1743921312004620 is OK
- 10.1017/S1743921312004619 is OK
- 10.2298/SAJ1183087A is OK
- 10.1017/S174392131101533X is OK
- 10.1017/S1743921311018023 is OK
- 10.1017/S1743921311017868 is OK
- 10.1017/S1743921311007502 is OK
- 10.1017/S1743921311007496 is OK
- 10.1017/S174392131100737X is OK
- 10.1017/S1743921311007307 is OK
- 10.5281/zenodo.2315093 is OK
- 10.1017/S1743921309992626 is OK
- 10.1016/j.asr.2009.08.020 is OK
- 10.1007/978-1-4419-0239-9_7 is OK
- 10.1017/S1743921307001433 is OK
- 10.1017/S1743921304005101 is OK
- 10.1201/9780203493137.ch9 is OK
- 10.1103/PhysRevE.89.033009 is OK
- 10.1007/s11214-013-9988-3 is OK
- 10.1093/mnras/stt2402 is OK
- 10.1103/PhysRevE.90.041003 is OK
- 10.1155/2014/750754 is OK
- 10.1088/0169-5983/46/4/041401 is OK
- 10.1088/0004-637X/789/1/77 is OK
- 10.1093/mnras/stu809 is OK
- 10.1103/PhysRevE.91.021001 is OK
- 10.1016/j.atmosres.2014.07.017 is OK
- 10.1088/0004-637X/795/1/16 is OK
- 10.1051/0004-6361/201423412 is OK
- 10.1088/2041-8205/796/1/L12 is OK
- 10.1051/0004-6361/201424521 is OK
- 10.1051/0004-6361/201423499 is OK
- 10.1051/0004-6361/201322681 is OK
- 10.1051/0004-6361/201425396 is OK
- 10.1093/mnras/stu2540 is OK
- 10.1088/2041-8205/795/1/L8 is OK
- 10.1002/asna.201412141 is OK
- 10.1093/mnras/stu1708 is OK
- 10.1007/s11214-013-0009-3 is OK
- 10.1088/0004-637X/791/1/12 is OK
- 10.1093/mnras/stu1954 is OK
- 10.1088/0004-637X/803/2/95 is OK
- 10.1017/S1743921314001884 is OK
- 10.1063/1.4891340 is OK
- 10.1051/0004-6361/201322837 is OK
- 10.1051/0004-6361/201424919 is OK
- 10.1088/0004-637X/791/1/48 is OK
- 10.1088/0004-637X/792/1/69 is OK
- 10.1088/0004-637X/797/2/101 is OK
- 10.1088/0004-637X/791/1/62 is OK
- 10.1088/0004-637X/792/2/86 is OK
- 10.1103/PhysRevLett.114.075001 is OK
- 10.1051/0004-6361/201525880 is OK
- 10.3847/0004-637X/824/1/60 is OK
- 10.1051/0004-6361/201525840 is OK
- 10.1051/0004-6361/201526657 is OK
- 10.1103/PhysRevE.93.033125 is OK
- 10.3847/0004-637X/817/2/102 is OK
- 10.1051/0004-6361/201730421 is OK
- 10.3847/0004-637X/816/1/28 is OK
- 10.1051/0004-6361/201628165 is OK
- 10.3847/0004-637X/816/1/2 is OK
- 10.1007/s11214-014-0117-8 is OK
- 10.1007/s11214-015-0199-y is OK
- 10.1088/0004-637X/814/2/155 is OK
- 10.1093/mnras/stv1766 is OK
- 10.1088/0004-637X/811/2/135 is OK
- 10.1093/mnras/stv1598 is OK
- 10.1051/0004-6361/201425274 is OK
- 10.1103/PhysRevLett.115.095001 is OK
- 10.1051/0004-6361/201425120 is OK
- 10.1088/0004-637X/807/2/143 is OK
- 10.1016/j.ascom.2015.02.005 is OK
- 10.1038/nphys3315 is OK
- 10.1088/0004-637X/805/2/166 is OK
- 10.1088/0004-637X/806/1/118 is OK
- 10.1093/mnras/stv195 is OK
- 10.1088/0004-637X/804/2/95 is OK
- 10.1093/mnras/stv459 is OK
- 10.1088/0004-637X/804/1/35 is OK
- 10.1126/sciadv.1500109 is OK
- 10.1007/s11214-014-0100-4 is OK
- 10.1093/mnras/stw1257 is OK
- 10.1201/9780203493137.ch9 is OK
- 10.3847/0067-0049/224/2/39 is OK
- 10.1088/1742-6596/719/1/012006 is OK
- 10.3847/0004-637X/822/1/55 is OK
- 10.1093/mnras/stw888 is OK
- 10.1093/mnras/stx1291 is OK
- 10.1093/pasj/psx008 is OK
- 10.1051/0004-6361/201628960 is OK
- 10.1103/PhysRevLett.118.055102 is OK
- 10.3847/1538-4357/836/1/21 is OK
- 10.1051/0004-6361/201628973 is OK
- 10.3847/0004-637X/831/1/82 is OK
- 10.3847/1538-4357/833/1/43 is OK
- 10.3847/0004-637X/832/2/150 is OK
- 10.1093/mnras/stw1941 is OK
- 10.1051/0004-6361/201630106 is OK
- 10.1103/PhysRevLett.116.101101 is OK
- 10.1051/0004-6361/201526272 is OK
- 10.1088/0031-8949/91/10/104008 is OK
- 10.1093/mnras/stw1619 is OK
- 10.1088/1367-2630/aa5de6 is OK
- 10.1093/mnrasl/slw248 is OK
- 10.1093/mnras/stx148 is OK
- 10.1002/2017MS000930 is OK
- 10.3847/2041-8213/aa83ab is OK
- 10.1002/asna.201713384 is OK
- 10.3847/2041-8213/aa855d is OK
- 10.1017/jfm.2017.364 is OK
- 10.3847/2041-8213/aa844b is OK
- 10.1016/j.cpc.2017.03.011 is OK
- 10.1007/s41116-017-0007-8 is OK
- 10.3847/1538-4357/aa7b33 is OK
- 10.1007/s11214-015-0230-3 is OK
- 10.1063/1.5001338 is OK
- 10.1051/0004-6361/201630208 is OK
- 10.1093/mnras/stx1425 is OK
- 10.1002/asna.201713406 is OK
- 10.1103/PhysRevD.96.083505 is OK
- 10.3847/1538-4357/aa8a66 is OK
- 10.1051/0004-6361/201732191 is OK
- 10.3847/1538-3881/aa8811 is OK
- 10.1051/epjconf/201716002010 is OK
- 10.3847/1538-4357/aa8fcf is OK
- 10.3847/2041-8213/aa96a1 is OK
- 10.1103/PhysRevE.96.053105 is OK
- 10.3847/1538-4357/aa93e7 is OK
- 10.1103/PhysRevD.96.123528 is OK
- 10.1088/1475-7516/2017/12/002 is OK
- 10.1093/mnras/stx1989 is OK
- 10.1017/S0022377818000806 is OK
- 10.1002/asna.201813477 is OK
- 10.1002/asna.201813472 is OK
- 10.1103/PhysRevE.97.023105 is OK
- 10.1140/epjp/i2018-11865-7 is OK
- 10.3847/1538-4357/aaadaa is OK
- 10.1051/0004-6361/201833018 is OK
- 10.1051/0004-6361/201628136 is OK
- 10.1051/0004-6361/201732413 is OK
- 10.1080/03091929.2018.1515313 is OK
- 10.1093/mnras/stx3255 is OK
- 10.3847/1538-4357/aab891 is OK
- 10.3847/1538-4357/aae97a is OK
- 10.3847/1538-4357/aae97f is OK
- 10.1016/j.physrep.2018.02.006 is OK
- 10.1093/mnras/stx3164 is OK
- 10.1093/mnras/sty1570 is OK
- 10.1051/0004-6361/201732066 is OK
- 10.3847/1538-4357/aaba75 is OK
- 10.1093/mnras/sty593 is OK
- 10.1093/mnras/stz1509 is OK
- 10.1007/s11084-019-09579-4 is OK
- 10.1007/s41115-017-0001-9 is OK
- 10.1093/mnras/stz2042 is OK
- 10.3847/1538-4357/ab2f85 is OK
- 10.3847/1538-4357/ab258e is OK
- 10.3847/2515-5172/ab2894 is OK
- 10.1063/1.5092152 is OK
- 10.1051/0004-6361/201935945 is OK
- 10.1126/science.aat5330 is OK
- 10.1103/PhysRevE.99.043206 is OK
- 10.3390/galaxies7020045 is OK
- 10.1051/0004-6361/201935385 is OK
- 10.1093/mnras/sty3369 is OK
- 10.1080/03091929.2019.1571584 is OK
- 10.1093/mnras/stz2084 is OK
- 10.1103/PhysRevFluids.4.024608 is OK
- 10.1017/S0022377818001290 is OK
- 10.1080/10618562.2019.1593385 is OK
- 10.3847/1538-4357/aaffd8 is OK
- 10.5194/acp-19-639-2019 is OK
- 10.1103/PhysRevE.98.063107 is OK
- 10.1093/mnras/sty1757 is OK
- 10.1051/0004-6361/201834921 is OK
- 10.3847/1538-4357/aae7d4 is OK
- 10.1002/asna.201913602 is OK
- 10.3847/2515-5172/aaeac9 is OK
- 10.1175/JAS-D-18-0081.1 is OK
- 10.1051/0004-6361/201832783 is OK
- 10.1093/mnras/sty1594 is OK
- 10.1088/1475-7516/2018/08/034 is OK
- 10.3847/1538-4357/aaca99 is OK
- 10.3847/1538-4357/aac3d4 is OK
- 10.1080/03091929.2019.1672676 is OK
- 10.1080/03091929.2018.1492720 is OK
- 10.1080/03091929.2019.1571586 is OK
- 10.1080/03091929.2019.1591393 is OK
- 10.1080/03091929.2019.1653460 is OK
- 10.1080/03091929.2019.1653461 is OK
- 10.1080/03091929.2019.1670173 is OK
- 10.1088/1742-6596/1031/1/012007 is OK
- 10.1093/mnras/stz1354 is OK
- 10.1051/0004-6361/201730825 is OK
- 10.1093/pasj/psu123 is OK
- 10.3847/2041-8213/aa9988 is OK
- 10.3847/2041-8213/ab974a is OK
- 10.3847/1538-4357/ab8d37 is OK
- 10.1103/PhysRevD.101.103028 is OK
- 10.1103/PhysRevFluids.5.043702 is OK
- 10.3847/1538-4357/ab791c is OK
- 10.3847/1538-4357/ab77bd is OK
- 10.1103/PhysRevE.101.033102 is OK
- 10.1093/mnras/staa663 is OK
- 10.1017/S1743921319004447 is OK
- 10.1080/03091929.2019.1643849 is OK
- 10.1080/03091929.2019.1676894 is OK
- 10.1080/03091929.2019.1634705 is OK
- 10.1080/03091929.2019.1668382 is OK
- 10.1051/0004-6361/201937037 is OK
- 10.1093/mnras/stz3232 is OK
- 10.1017/S0022377820000082 is OK
- 10.1093/mnras/stz3065 is OK
- 10.1175/JAS-D-19-0107.1 is OK
- 10.3847/1538-4357/ab5e7f is OK
- 10.1051/0004-6361/201936841 is OK
- 10.1093/mnras/stz2957 is OK
- 10.3847/1538-4357/ab5961 is OK
- 10.3847/1538-4357/ab3f3b is OK
- 10.1088/1742-6596/1336/1/012012 is OK
- 10.3847/1538-4357/ab3e07 is OK
- 10.3847/1538-4365/ab4356 is OK
- 10.1007/s41115-019-0005-8 is OK
- 10.1080/03091929.2019.1677015 is OK
- 10.3847/1538-4357/ab24bd is OK
- 10.3847/1538-4357/aaf383 is OK
- 10.1016/j.combustflame.2020.02.016 is OK
- 10.1016/j.ijmultiphaseflow.2018.11.001 is OK
- 10.1017/jfm.2019.493 is OK
- 10.1051/0004-6361/201525839 is OK
- 10.3847/1538-4357/ab8dc0 is OK
- 10.1051/0004-6361/202037666 is OK
- 10.1093/mnras/staa1795 is OK
- 10.1017/S0022377820000665 is OK
- 10.1016/j.jcp.2016.12.059 is OK

MISSING DOIs

- 10.1051/eas/1044018 may be a valid DOI for title: Modelling the evolution of planets in disks
- 10.1007/3-540-36238-x_12 may be a valid DOI for title: Numerical Simulations of MHD Turbulence in Accretion Disks
- 10.1051/0004-6361/201014287 may be a valid DOI for title: Surface appearance of dynamo-generated large-scale fields
- 10.1017/s1743921307010654 may be a valid DOI for title: Why coronal mass ejections are necessary for the dynamo
- 10.1017/s1539299600015197 may be a valid DOI for title: Ejection of Bi-Helical Fields from the Sun
- 10.1086/498078 may be a valid DOI for title: Gravoturbulent Formation of Planetesimals
- 10.1007/3-540-27401-4_1 may be a valid DOI for title: Passive scalar diffusion as a damped wave
- 10.1007/978-94-007-1063-4_3 may be a valid DOI for title: MHD simulations of small and large scale dynamos
- 10.1016/j.fusengdes.2016.02.077 may be a valid DOI for title: Scoping Studies for NBI Launch Geometries on DEMO
- 10.1007/978-3-319-00116-6_24 may be a valid DOI for title: Numerical simulations of the Kelvin-Helmholtz instability with the Gadget-2 SPH code
- 10.1016/j.proci.2016.06.187 may be a valid DOI for title: The effect of turbulent clustering on particle reactivity
- 10.1051/epjconf/201716002010 may be a valid DOI for title: Dynamos and Differential Rotation: Advances at the Crossroads of Analytics, Numerics, and Observations
- 10.17226/25217_16 may be a valid DOI for title: Perspectives on Reproducibility and Sustainability of Open-Source Scientific Software from Seven Years of the Dedalus Project
- 10.1002/asna.201913632 may be a valid DOI for title: Effects of small-scale dynamo and compressibility on the Ξ›effect
- 10.1051/0004-6361/201935280 may be a valid DOI for title: Antisolar differential rotation of slowly rotating cool stars
- 10.1051/0004-6361/201834921 may be a valid DOI for title: Overshooting in simulations of compressible convection
- 10.3847/1538-4365/ab3a4c may be a valid DOI for title: GAMERA: A three-dimensional finite-volume MHD solver for non-orthogonal curvilinear geometries
- 10.3847/1538-4357/abad92 may be a valid DOI for title: Hall cascade with fractional magnetic helicity in neutron star crusts
- 10.3847/1538-4357/abc1e8 may be a valid DOI for title: On the existence of shear-current effects in magnetized burgulence
- 10.1051/0004-6361/202038603 may be a valid DOI for title: Physically motivated heat conduction treatment in simulations of solar-like stars: effects on dynamo transitions
- 10.1051/0004-6361/202038564 may be a valid DOI for title: The effect of a dynamo-generated field on the Parker wind
- 10.1093/mnras/stab470 may be a valid DOI for title: Diffusion of large-scale magnetic fields by reconnection in MHD turbulence
- 10.1051/0004-6361/202040068 may be a valid DOI for title: Coagulation of inertial particles in supersonic turbulence
- 10.1016/j.idm.2020.08.014 may be a valid DOI for title: Piecewise quadratic growth during the 2019 novel coronavirus epidemic
- 10.1103/physrevlett.124.255102 may be a valid DOI for title: Dynamo in weakly collisional non-magnetized plasmas impeded by Landau damping of magnetic fields
- 10.1017/s1743921320000721 may be a valid DOI for title: Global simulations of stellar dynamos
- 10.3847/1538-4357/ab9a2e may be a valid DOI for title: A simple, entropy-based dissipation trigger for SPH
- 10.1093/mnras/staa2591 may be a valid DOI for title: The Lagrangian hydrodynamics code MAGMA2
- 10.3847/1538-4357/abac58 may be a valid DOI for title: Turbulence sets the length scale for planetesimal formation: Local 2D simulations of streaming instability and planetesimal formation
- 10.1093/mnras/staa3849 may be a valid DOI for title: Inverse energy transfer in decaying, three dimensional, nonhelical magnetic turbulence due to magnetic reconnection

INVALID DOIs

- None
whedon commented 3 years ago

🐦🐦🐦 πŸ‘‰ Tweet for this paper πŸ‘ˆ 🐦🐦🐦

whedon commented 3 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/2104
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02807
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

    Any issues? Notify your editorial technical team...

arfon commented 3 years ago

@zingale, @rtfisher - many thanks for your reviews here. JOSS relies upon the volunteer efforts of folks like yourselves, and we simply wouldn't be able to do this without you ✨

@AxelBrandenburg - your paper is now accepted and published in JOSS :zap::rocket::boom:

whedon commented 3 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02807/status.svg)](https://doi.org/10.21105/joss.02807)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02807">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02807/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02807/status.svg
   :target: https://doi.org/10.21105/joss.02807

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

rtfisher commented 3 years ago

Thank you Arfon and Axel both for being extraordinarily patient with my review. I look forward to working with you again in the future.

Best wishes,

Bob

On Sun, Feb 21, 2021 at 7:17 AM Arfon Smith notifications@github.com wrote:

@zingale https://github.com/zingale, @rtfisher https://github.com/rtfisher - many thanks for your reviews here. JOSS relies upon the volunteer efforts of folks like yourselves, and we simply wouldn't be able to do this without you ✨

@AxelBrandenburg https://github.com/AxelBrandenburg - your paper is now accepted and published in JOSS βš‘πŸš€πŸ’₯

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2807#issuecomment-782848656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2Y7CKAXKZ6YH4Z2DN7GV3TAD2WDANCNFSM4TF5YSQA .

-- Dr. Robert Fisher Associate Professor / Graduate Program Director University of Massachusetts/Dartmouth Department of Physics 285 Old Westport Road North Dartmouth, Massachusetts 02747 robert.fisher@umassd.edu http://www.novastella.org