openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: iceFEM: A FreeFem package for wave induced ice-shelf vibrations #2922

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @Balaje (Balaje K) Repository: https://github.com/Balaje/iceFem Version: v1.0.0 Editor: @diehlpk Reviewers: @corentin-dev, @iammix Managing EiC: Kristen Thyng

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @Balaje. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @kthyng.

@Balaje if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.42 s (64.9 files/s, 9783.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          23            551            877           2315
Markdown                         2             59              0            167
TeX                              1              3              0             88
Bourne Shell                     1              2              0             10
-------------------------------------------------------------------------------
SUM:                            27            615            877           2580
-------------------------------------------------------------------------------

Statistical information for the repository 'd9aad74985e50ca18fd8847f' was
gathered on 2020/12/18.
No commited files with the specified extensions were found.
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1038/274464a0 may be a valid DOI for title: Iceberg calving from floating glaciers by a vibrating mechanism
- 10.3189/002214311798043681 may be a valid DOI for title: Antarctic ice-shelf calving triggered by the Honshu (Japan) earthquake and tsunami, March 2011
- 10.1016/j.jfluidstructs.2020.103074 may be a valid DOI for title: A coupled fluid-elasticity model for the wave forcing of an ice-shelf
- 10.1016/j.jfluidstructs.2018.03.010 may be a valid DOI for title: Time-domain and modal response of ice shelves to wave forcing using the finite element method
- 10.3189/2013jog12j096 may be a valid DOI for title: Normal modes of a coupled ice-shelf / sub-ice-shelf cavity system
- 10.1016/j.wavemoti.2019.04.004 may be a valid DOI for title: On the shallow-water limit for modelling ocean-wave induced ice-shelf vibrations
- 10.1515/jnum-2012-0013 may be a valid DOI for title: New development in FreeFem++
- 10.1038/s41586-018-0212-1 may be a valid DOI for title: Antarctic ice shelf disintegration triggered by sea ice loss and ocean swell

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 3 years ago

@diehlpk would this be up your alley (on the math and solver side)? Are you able to edit this?

kthyng commented 3 years ago

@whedon invite @diehlpk as editor

whedon commented 3 years ago

@diehlpk has been invited to edit this submission.

diehlpk commented 3 years ago

@kthyng Yes, but I will only be able to work on it beginning of January. I have so many things to finish before the holidays.

diehlpk commented 3 years ago

@whedon assign @diehlpk as editor

whedon commented 3 years ago

OK, the editor is @diehlpk

diehlpk commented 3 years ago

@Balaje Could you please recommend some reviewers?

Balaje commented 3 years ago

@diehlpk 👋 Based on looking at the list, I could suggest

Also, can I push new commits to the repository at this point? I want to upload the manual and some small changes to the code.

Thanks.

diehlpk commented 3 years ago

Sure, the repo will change during the review anyways.

diehlpk commented 3 years ago

@corentin-dev @rabernat @iammix @wingtorres @ilyasst would you be interested to review this paper or could recommend someone?

Balaje commented 3 years ago

@diehlpk Thank you. I've updated the repo.

rabernat commented 3 years ago

Sorry I have to decline. I am not well qualified to review MATLAB code as I don't know the language or packaging conventions.

iammix commented 3 years ago

@diehlpk Hello there, and Happy New Year! Sorry for the delayed response. Yes, I am able to review this paper, however, I will be able to start reviewing this paper at the end of next week(if time is not a problem). Please inform me if I am going to be a reviewer(In this case, are there any guidelines for reviewers). Thank you in advance.

corentin-dev commented 3 years ago

Dear @diehlpk, same thing here, I'll be able to review during this month. Best regards.

On 04/01/2021 13:11, Konstantinos Mixios wrote:

@diehlpk https://github.com/diehlpk Hello there, and Happy New Year! Sorry for the delayed response. Yes, I am able to review this paper, however, I will be able to start reviewing this paper at the end of next week(if time is not a problem). Please inform me if I am going to be a reviewer(In this case, are there any guidelines for reviewers). Thank you in advance.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2922#issuecomment-753940872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOOO3OBQVZCC7FCBX4BJNR3SYGWATANCNFSM4VBLLKJA.

diehlpk commented 3 years ago

Dear @diehlpk, same thing here, I'll be able to review during this month. Best regards. … On 04/01/2021 13:11, Konstantinos Mixios wrote: @diehlpk https://github.com/diehlpk Hello there, and Happy New Year! Sorry for the delayed response. Yes, I am able to review this paper, however, I will be able to start reviewing this paper at the end of next week(if time is not a problem). Please inform me if I am going to be a reviewer(In this case, are there any guidelines for reviewers). Thank you in advance. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2922 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOOO3OBQVZCC7FCBX4BJNR3SYGWATANCNFSM4VBLLKJA.

@corentin-dev sounds good. Thank you for reviewing for JOSS.

diehlpk commented 3 years ago

@whedon assign @corentin-dev as reviewer

whedon commented 3 years ago

OK, @corentin-dev is now a reviewer

diehlpk commented 3 years ago

@iammix Thanks for agreeing to review for JOSS. Please find the guidelines here

https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

diehlpk commented 3 years ago

@iammix and @corentin-dev

As a reviewer, COIs are your present or previous association with any authors of a submission: recent (past four years) collaborators in funded research or work that is published; and lifetime for the family members, business partners, and thesis student/advisor or mentor. In addition, your recent (past year) association with the same organization of a submitter is a COI, for example, being employed at the same institution.

Can you please confirm that you do not have any COI?

diehlpk commented 3 years ago

@whedon add @iammix as reviewer

whedon commented 3 years ago

OK, @iammix is now a reviewer

iammix commented 3 years ago

I confirm that I do not have any COI with the authors.

corentin-dev commented 3 years ago

I confirm that I do not have any COI with the authors.

On 04/01/2021 16:08, Konstantinos Mixios wrote:

I confirm that I do not have any COI with the authors.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2922#issuecomment-754029821, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOOO3OH7JURXLQEPACJUJPLSYHKVFANCNFSM4VBLLKJA.

diehlpk commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/2939.