search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling #2950

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @tomgrylls (Tom Grylls) Repository: https://github.com/uDALES/u-dales Version: 1.0.0 Editor: @Kevin-Mattheus-Moerman Reviewers: @wimvanderbauwhede, @p-costa, @ashwinvis Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @tomgrylls. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @kyleniemeyer.

@tomgrylls if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=1.53 s (51.1 files/s, 19341.0 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
Fortran 90                              35           2973           3385          14709
MATLAB                                   4            572            841           3755
Markdown                                15            516              0           1305
Bourne Shell                            13            155             99            508
Python                                   3             67             61            140
CMake                                    3             40            101            125
YAML                                     3             17             13            123
TeX                                      1              2              0             31
Windows Module Definition                1              3              0              9
---------------------------------------------------------------------------------------
SUM:                                    78           4345           4500          20705
---------------------------------------------------------------------------------------

Statistical information for the repository '971269ea30b7d0a0420568e3' was
gathered on 2021/01/11.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Birgit Sutzl                     4          3509              3           11.60
Chiel                            3         11444           5722           56.72
Tom Grylls                       1            35             18            0.18
dmey                             6           278           9255           31.50

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Tom Grylls                   22           62.9          7.6                4.55
dmey                        246           88.5         12.3               22.76
whedon commented 3 years ago

PDF failed to compile for issue #2950 with the following error:

Can't find any papers to compile :-(

arfon commented 3 years ago

@whedon generate pdf from branch joss-paper

whedon commented 3 years ago 
Attempting PDF compilation from custom branch joss-paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 3 years ago

@tomgrylls I'll be looking for an editor to handle this submission. In the mean time it would be great if you could help suggest reviewers for this work. Also can you please review our documentation on what the paper should contain, in particular the "Statement of need" section is missing. You can update the paper here by calling: @whedon generate pdf. Thanks.

Kevin-Mattheus-Moerman commented 3 years ago

@whedon assign @Kevin-Mattheus-Moerman as editor

whedon commented 3 years ago

OK, the editor is @Kevin-Mattheus-Moerman

tomgrylls commented 3 years ago

@Kevin-Mattheus-Moermanhttps://github.com/Kevin-Mattheus-Moerman thanks for your email. If more editor suggestions would be helpful, I have been through the list and would suggest the following:

kyleniemeyer wkearn abhishekbajpayee wkearn mzamoraz

In terms of the statement of need, we have integrated this requirement into the main body of the text (from the end of the first paragraph) as we felt this helped the readability of the paper and thought that a section title would break the paper up. However, if having the statement of the need requirement within the text is insufficient then please let us know and we will add a separate section and heading.

Thanks,

Tom

From: Kevin Mattheus Moerman notifications@github.com Sent: 14 January 2021 11:47 To: openjournals/joss-reviews joss-reviews@noreply.github.com Cc: Tom Grylls tgrylls@outlook.com; Mention mention@noreply.github.com Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling (#2950)

@whedonhttps://github.com/whedon assign @Kevin-Mattheus-Moermanhttps://github.com/Kevin-Mattheus-Moerman as editor

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/2950#issuecomment-760146693, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMQO73KW6OM34MWEKV4NRMTSZ3KWNANCNFSM4V5HUEFA.

tomgrylls commented 3 years ago

To clarify, I meant reviewer suggestions not editors, sorry about that. If more suggestions would be helpful I have added more options to the list in my previous email:

jayten corentin-dev kyleniemeyer wkearn abhishekbajpayee wkearn mzamoraz zbeekman chennachaos ashwinvis adam-m-jcbs rabernat kegiljarhus p-costa ashwinvis

Thanks for your help and apologies for any confusion on the below,

Tom

From: Tom Grylls tgrylls@outlook.com Sent: 17 January 2021 11:36 To: openjournals/joss-reviews joss-reviews@noreply.github.com; openjournals/joss-reviews reply@reply.github.com Cc: Mention mention@noreply.github.com Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling (#2950)

@Kevin-Mattheus-Moermanhttps://github.com/Kevin-Mattheus-Moerman thanks for your email. If more editor suggestions would be helpful, I have been through the list and would suggest the following:

kyleniemeyer wkearn abhishekbajpayee wkearn mzamoraz

In terms of the statement of need, we have integrated this requirement into the main body of the text (from the end of the first paragraph) as we felt this helped the readability of the paper and thought that a section title would break the paper up. However, if having the statement of the need requirement within the text is insufficient then please let us know and we will add a separate section and heading.

Thanks,

Tom

From: Kevin Mattheus Moerman notifications@github.com Sent: 14 January 2021 11:47 To: openjournals/joss-reviews joss-reviews@noreply.github.com Cc: Tom Grylls tgrylls@outlook.com; Mention mention@noreply.github.com Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling (#2950)

@whedonhttps://github.com/whedon assign @Kevin-Mattheus-Moermanhttps://github.com/Kevin-Mattheus-Moerman as editor

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/2950#issuecomment-760146693, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMQO73KW6OM34MWEKV4NRMTSZ3KWNANCNFSM4V5HUEFA.

Kevin-Mattheus-Moerman commented 3 years ago

@leifdenby @jakubfabian @wimvanderbauwhede @crshapiro @tonyinme @claireverhulst @JuhaTonttila @fjansson would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling?

The JOSS review process takes place on GitHub and focuses on the software and a short paper. This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. Here is an example an ongoing review process to give you an idea.

If you are interested in reviewing, you can comment here. Thanks!

wimvanderbauwhede commented 3 years ago

I am willing to review this work, but my current load at work is very high. How quickly does this need to be done?

Kevin-Mattheus-Moerman commented 3 years ago

Thanks @wimvanderbauwhede that's great. We are hearing this from a lot of editors and reviewers at the moment so this is totally understandable. We usually aim for a 2 week review time but we can and have been very flexible especially in these challenging times. I'd say we will start the review within a week and the review will likely be ongoing for about 1-2 months (given peoples current time constraints) (although usually people submit minor initial comments right away given our open review process). Does that sound reasonable? Let me know what works for you.

Kevin-Mattheus-Moerman commented 3 years ago

@leifdenby @jakubfabian @crshapiro @tonyinme @claireverhulst @JuhaTonttila @fjansson would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling?

The JOSS review process takes place on GitHub and focuses on the software and a short paper. This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. Here is an example an ongoing review process to give you an idea.

If you are interested in reviewing, you can comment here. Thanks!

crshapiro commented 3 years ago

Thank you for inviting me to review software for this innovative journal. Unfortunately, I don't have the time to commit to being a reviewer for something like this.

Kevin-Mattheus-Moerman commented 3 years ago

@leifdenby @jakubfabian @tonyinme @claireverhulst @JuhaTonttila @fjansson would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling?

The JOSS review process takes place on GitHub and focuses on the software and a short paper. This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. Here is an example an ongoing review process to give you an idea.

If you are interested in reviewing, you can comment here. Thanks!

tonyinme commented 3 years ago

Hey Kevin,

Thanks for the invite. Unfortunately, I don't have the time to commit to this.

Thanks, Tony

On Mon, Feb 8, 2021 at 3:27 AM Kevin Mattheus Moerman < notifications@github.com> wrote:

@leifdenby https://github.com/leifdenby @jakubfabian https://github.com/jakubfabian @tonyinme https://github.com/tonyinme @claireverhulst https://github.com/claireverhulst @JuhaTonttila https://github.com/JuhaTonttila @fjansson https://github.com/fjansson would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling?

The JOSS review process takes place on GitHub and focuses on the software and a short paper. This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. Here is an example an ongoing review process to give you an idea.

If you are interested in reviewing, you can comment here. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/2950#issuecomment-775041192, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACULCAPBLEXLJXHZK34O2D3S564BXANCNFSM4V5HUEFA .

Kevin-Mattheus-Moerman commented 3 years ago

@crshapiro @tonyinme thanks for the response. I understand regarding time. Please note that we are not expecting the usual quick turn around at the moment. Instead we can be very flexible and wait if you need quite a lot of time (some reviews take months at the moment). So given this, please let me know if you feel we could assign you but give you (lots of) extra time to complete this review at your own pace. All the best on your busy schedules and thanks for getting back to me.

Kevin-Mattheus-Moerman commented 3 years ago

@wimvanderbauwhede thanks for getting back to me. Many of us are under very unusual time constrains so as the message above shows we can be very flexible regarding time to complete this review. We can likely give you the time you need to complete this work at your own pace. Let me know if you can still help. Thanks again for getting back to me.

wimvanderbauwhede commented 3 years ago

Hi @Kevin-Mattheus-Moerman sorry for dropping this for a while. Yes, I'm still willing to help. I will try to have a look at this in the next two weeks.

Kevin-Mattheus-Moerman commented 3 years ago

@whedon assign @wimvanderbauwhede as reviewer

whedon commented 3 years ago

OK, @wimvanderbauwhede is now a reviewer

Kevin-Mattheus-Moerman commented 3 years ago

@claireverhulst @JuhaTonttila @fjansson @jayten @corentin-dev @zbeekman @ashwinvis @adam-m-jcbs @rabernat @p-costa would you be interested in reviewing this work for the Journal of Open Source Software (JOSS): uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling?

Note we can give you a lot of additional time as we understand reviewers need extra flexibility at the moment.

The JOSS review process takes place on GitHub and focuses on the software and a short paper. This issue is a "pre-review" issue in which reviewers are assigned. Once sufficient reviewers are recruited we will open a dedicated review issue where the review will take place. Here is an example an ongoing review process to give you an idea.

If you are interested in reviewing, you can comment here. Thanks!

ashwinvis commented 3 years ago

@Kevin-Mattheus-Moerman I am willing to take it up if I can take ~1 month to review the work.

p-costa commented 3 years ago

Hi @Kevin-Mattheus-Moerman, I am happy to review it if I can take about one month.

Kevin-Mattheus-Moerman commented 3 years ago

@whedon add @p-costa as reviewer

whedon commented 3 years ago

OK, @p-costa is now a reviewer

Kevin-Mattheus-Moerman commented 3 years ago

@whedon add @ashwinvis as reviewer

whedon commented 3 years ago

OK, @ashwinvis is now a reviewer

Kevin-Mattheus-Moerman commented 3 years ago

Great we now have 3 reviewers and I'll initiate the review process. If others invited want to join I can add them in the review issue as well. Thanks a lot for agreeing to help!

Kevin-Mattheus-Moerman commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3055.

zbeekman commented 3 years ago

Sorry I missed this, my email inbox is a bit of an EPA superfund site at the moment. Looks very interesting, and I appreciate being thought of. Hopefully I'll have the chance to review some CFD for JOSS in the future!