search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[REVIEW]: SAR tools: A QGIS plugin for generating SAR descriptors #2970

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @Narayana-Rao (NR Bhogapurapu) Repository: https://github.com/Narayana-Rao/SAR-tools Version: v0.7 Editor: @hugoledoux Reviewer: @liberostelios, @HenrikJanPersson Archive: 10.5281/zenodo.4621292

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aba2f441ab3c99e7694c97345e1255a0"><img src="https://joss.theoj.org/papers/aba2f441ab3c99e7694c97345e1255a0/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aba2f441ab3c99e7694c97345e1255a0/status.svg)](https://joss.theoj.org/papers/aba2f441ab3c99e7694c97345e1255a0)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@liberostelios, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @liberostelios

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @HenrikJanPersson

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

danielskatz commented 3 years ago

@Narayana-Rao - I'm suggested a few small changes in https://github.com/Narayana-Rao/PolSAR-tools/pull/8 - if you can merge this, we can proceed with acceptance and publication

Narayana-Rao commented 3 years ago

Dear @danielskatz, I have merged your pull request. Please verify and confirm. Thank you!

danielskatz commented 3 years ago

@whedon accept

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/JSTARS.2021.3069299 is OK
- 10.1016/j.rse.2020.111954 is OK
- 10.1016/j.jag.2020.102052 is OK
- 10.1109/tgrs.2020.2976661 is OK
- 10.1016/j.isprsjprs.2020.09.010 is OK
- 10.1109/lgrs.2019.2907703 is OK
- 10.1109/tgrs.2018.2848285 is OK
- 10.1109/TGRS.2009.2014944 is OK
- 10.1016/0030-4018(77)90292-9 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2209

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2209, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
danielskatz commented 3 years ago

@Narayana-Rao - sorry, one more change - I left in a comma I meant to remove... Narayana-Rao/PolSAR-tools#9

danielskatz commented 3 years ago

@whedon accept

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/JSTARS.2021.3069299 is OK
- 10.1016/j.rse.2020.111954 is OK
- 10.1016/j.jag.2020.102052 is OK
- 10.1109/tgrs.2020.2976661 is OK
- 10.1016/j.isprsjprs.2020.09.010 is OK
- 10.1109/lgrs.2019.2907703 is OK
- 10.1109/tgrs.2018.2848285 is OK
- 10.1109/TGRS.2009.2014944 is OK
- 10.1016/0030-4018(77)90292-9 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2210

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2210, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
danielskatz commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 3 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 3 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/2211
  2. Wait a couple of minutes to verify that the paper DOI resolves https://doi.org/10.21105/joss.02970
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

Narayana-Rao commented 3 years ago

Dear @danielskatz, Could you please verify the rendered .pdf file. For me it's showing 404 not found if I click on the DOI link.

danielskatz commented 3 years ago

Congratulations to @Narayana-Rao (NR Bhogapurapu) and co-authors!!

And thanks to @liberostelios and @HenrikJanPersson for reviewing, and @hugoledoux for editing!

danielskatz commented 3 years ago

Dear @danielskatz, Could you please verify the rendered .pdf file. For me it's showing 404 not found if I click on the DOI link.

It works fine for me now. Sometimes if you try it too soon, it doesn't work, and that gets cached in your system/network. I'm going to close this issue now, since it does work for me, but if it still isn't working for you in 24 hours, then reopen it.

whedon commented 3 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.02970/status.svg)](https://doi.org/10.21105/joss.02970)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.02970">
  <img src="https://joss.theoj.org/papers/10.21105/joss.02970/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.02970/status.svg
   :target: https://doi.org/10.21105/joss.02970

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Narayana-Rao commented 3 years ago

Dear @danielskatz, Could you please verify the rendered .pdf file. For me it's showing 404 not found if I click on the DOI link.

It works fine for me now. Sometimes if you try it too soon, it doesn't work, and that gets cached in your system/network. I'm going to close this issue now, since it does work for me, but if it still isn't working for you in 24 hours, then reopen it.

Dear @danielskatz, Thank you very much for your time, edits and prompt responses.