search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: Simulating instrumental systematics of Cosmic Microwave Background experiments with s4cmb #3006

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @JulienPeloton (Julien Peloton) Repository: https://github.com/JulienPeloton/s4cmb Version: 1.0 Editor: @mbobra Reviewers: @Christovis, @changhoonhahn Managing EiC: Kyle Niemeyer

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @JulienPeloton. Currently, there isn't an JOSS editor assigned to your paper.

@JulienPeloton if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

PDF failed to compile for issue #3006 with the following error:

Can't find any papers to compile :-(

whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.26 s (188.6 files/s, 60275.6 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Python                           30           2056           5625           6719
Fortran 90                        4             88            140            265
reStructuredText                  4             82             11            216
Bourne Again Shell                5             51             61            166
YAML                              3             12              0            101
make                              1              4              1             29
Dockerfile                        1              8              4             12
Bourne Shell                      1              1              6              6
--------------------------------------------------------------------------------
SUM:                             49           2302           5848           7514
--------------------------------------------------------------------------------

Statistical information for the repository 'dbf7ce0f3e1550f2d4d36242' was
gathered on 2021/02/04.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Joy Didier                       1           315              0            0.90
Julien                          32          3277           1912           14.81
Mark Mirmelstein                 6            63             25            0.25
Reijo Keskitalo                  2            33             27            0.17
gfabbian                        20           632            254            2.53
mark                             3           180             48            0.65
peloton                        251         20124           8157           80.69

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Joy Didier                  315          100.0         38.2               37.78
Julien                     3247           99.1          1.7               16.01
Mark Mirmelstein             32           50.8         23.5                9.38
Reijo Keskitalo               9           27.3         38.4               11.11
gfabbian                    357           56.5          8.5                7.00
mark                         76           42.2          1.4               11.84
peloton                   10364           51.5         40.6               12.07
kyleniemeyer commented 3 years ago

@whedon generate pdf from branch issues/56/joss

whedon commented 3 years ago 
Attempting PDF compilation from custom branch issues/56/joss. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 3 years ago

Whew, sorry @JulienPeloton, I could not seem to get the branch correct there... can you confirm that is the correct paper location?

We use this pre-review issue to assign the editor and reviewers, and resolve any obvious issues.

kyleniemeyer commented 3 years ago

Hi @mbobra, can you edit this submission?

kyleniemeyer commented 3 years ago

@whedon invite @mbobra as editor

whedon commented 3 years ago

@mbobra has been invited to edit this submission.

JulienPeloton commented 3 years ago

Hi @kyleniemeyer, @mbobra

I confirm this is the correct paper location. The paper lives in

Note that it compiled correctly from the Whedon paper preview service (link). Shall I move the files under the root of the repo instead of paper/ to ease the review process?

kyleniemeyer commented 3 years ago

@JulienPeloton no need, whedon finds the paper easily enough—I just wanted to check that the branch was correct.

mbobra commented 3 years ago

@kyleniemeyer Yes, no problem!

mbobra commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @mbobra

Christovis commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

I'm sorry @Christovis, I'm afraid I can't do that. That's something only editors are allowed to do.

mbobra commented 3 years ago

Thanks for agreeing to review, @Christovis! I really appreciate it.

mbobra commented 3 years ago

@whedon assign @Christovis as reviewer

whedon commented 3 years ago

OK, @Christovis is now a reviewer

mbobra commented 3 years ago

@whedon add @changhoonhahn as reviewer

whedon commented 3 years ago

OK, @changhoonhahn is now a reviewer

mbobra commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3022.

mbobra commented 3 years ago

👋 @Christovis @changhoonhahn See you over in #3022 where the actual review will take place!