[REVIEW]: seaborn: statistical data visualization

whedon commented 3 years ago

Submitting author: @mwaskom (Michael Waskom) Repository: https://github.com/mwaskom/seaborn Version: v0.11.1 Editor: @lpantano Reviewer: @dangeles, @Sara-ShiHo Archive: 10.5281/zenodo.4645478

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/830a6269e989e1d00ed161a2420e043e"><img src="https://joss.theoj.org/papers/830a6269e989e1d00ed161a2420e043e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/830a6269e989e1d00ed161a2420e043e/status.svg)](https://joss.theoj.org/papers/830a6269e989e1d00ed161a2420e043e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dangeles & @Sara-ShiHo, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

Make sure you're logged in to your GitHub account
Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lpantano know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @dangeles

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@mwaskom) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[x] Functionality: Have the functional claims of the software been confirmed?
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[x] A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

Review checklist for @Sara-ShiHo

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the repository url?
[x] License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
- Yes - the 3-Clause BSD License
[x] Contribution and authorship: Has the submitting author (@mwaskom) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
- Yes - mwaskom has 1,841 commits. There is a broad community that has contributed to seaborn, but it is appropriate to have mwaskom as the sole author.
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
- seaborn allows for easy data visualization in python and has the added advantage of integrating closely with matplotlib and pandas
- seaborn has been ongoing since 2012 with over 2700 commits at this point in time
- according to GitHub, there are over 2300 packages which depend on seaborn
- according to Zenodo, there are 196 papers that cite seaborn https://zenodo.org/record/4379347#.YFI2JGRKhhE

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
- Yes, here
[x] Functionality: Have the functional claims of the software been confirmed?
- Test functional claims from the paper:
- [x] opinionated semantic mappings
- [x] acceptance of pandas and numpy
- [x] themes
- [x] allowing matplotlib "add-ons"
[x] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)
- I have not found any explicit claims in the paper or in the documentation.

Documentation

[x] A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?
- This section is in the paper and it addresses the problems which are solved
- The target audience is not explicitly defined in this section
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
- Yes, here
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
- specific case examples are provided in the documentation.
- a full example of how seaborn can be used in a project is linked here and at the end of the paper
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
- Yes, here
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
- Yes, detailed in the README
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support
- Yes, detailed in the README

Software paper

[x] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[x] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
- as stated above, The target audience is not explicitly defined in this section
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
- Yes, this is very clear in the paper
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @dangeles, @Sara-ShiHo it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

whedon commented 3 years ago

PDF failed to compile for issue #3021 with the following error:

Can't find any papers to compile :-(

whedon commented 3 years ago

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.78 s (195.9 files/s, 106969.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              6              0             10          30726
Python                          97           8284           7271          24226
Jupyter Notebook                27              0           9608           1306
reStructuredText                 9            218            471            188
make                             4             37              5            169
CSS                              1             25              6            137
YAML                             1             21              0             78
Markdown                         3             50              0             65
JavaScript                       1              3             11             45
HTML                             1              0              0             23
INI                              1              0              1              4
Bourne Shell                     1              1              0              2
-------------------------------------------------------------------------------
SUM:                           152           8639          17383          56969
-------------------------------------------------------------------------------

Statistical information for the repository 'e36f219b1c654b6af9e0eede' was
gathered on 2021/02/08.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Aaron Spring                     1             2              2            0.00
Agamemnon Krasoulis              1             3              0            0.00
Alexandre Huat                   1             1              1            0.00
Alistair Miles                   4            54             20            0.06
Alvaro Ulloa                     1             1              1            0.00
Andrew Janke                     1             7              7            0.01
André F. Rendeiro                1            17              1            0.01
Antony Lee                       2            53             37            0.07
Ariel Rokem                      1            10              0            0.01
Avinash Thakur                   1             6              6            0.01
Ben Lindsay                      2             6              4            0.01
Benjamin Rose                    2             4              4            0.01
Benjamin Yeh                     1             1              1            0.00
Brian Landry                     3            45              9            0.04
Brian Marks                      1             5              0            0.00
Cameron Pye                      3            20              1            0.02
Cameron Riddell                  1             1              1            0.00
Chris Catalfo                    1             2              2            0.00
Chris Fonnesbeck                 2            10              2            0.01
Chris Hausler                    1             4              0            0.00
Chris Holdgraf                   1             1              1            0.00
Christopher Roberts              1             8              1            0.01
Christopher Whelan               1             2              3            0.00
Clark Fitzgerald                 3            37            276            0.25
Clément Robert                   1             9              0            0.01
Constantine Glen Eva             2            18              8            0.02
CorbanSwain                      4            43             32            0.06
Cynddl                           2             9              4            0.01
Daniel Bauer                     1             1              1            0.00
Daniel Himmelstein               1             1              2            0.00
Daniel Wehner                    2             4              1            0.00
David C. Gemperline             12           174             85            0.21
David Haberthür                  1             1              1            0.00
Dmitrijs Milajevs                1             5              0            0.00
Drew O'Kane                     18           337            146            0.39
Emilio Dorigatti                 1             2              2            0.00
Erik Ziegler                     2             3              0            0.00
Fabian Rost                      1             1              1            0.00
Gravish, Nick                    5            62             11            0.06
Gregory Hitz                     2            14              2            0.01
Gökcen Eraslan                   1            24              1            0.02
Iqrar Agalosi Nureyz             1            18              0            0.01
Isaac Schwabacher                1             2              2            0.00
JWarmenhoven                     7            18              3            0.02
Jake VanderPlas                  4            86             23            0.09
Jan Pipek                        1             1              1            0.00
Jeffrey Arnold                   1             1              1            0.00
Jessime Kirk                     1             1              1            0.00
Jimmy Callin                     1             2              2            0.00
Joel Nothman                     2             5              2            0.01
Joel Ostblom                     2             7              7            0.01
John B. Cole                     5            56             30            0.07
John C. Earls                    1             2              2            0.00
Joris Vankerschaver              1             7              5            0.01
Julian de Ruiter                 6           279             70            0.28
Julien Rebetez                   1             4              0            0.00
Kenta Sato                       1             2              0            0.00
Kevin Emmett                     1             2              1            0.00
Koki Sato                        1             3              0            0.00
Kyle Meyer                       4            13              7            0.02
Luis Pedro Coelho                2            43             11            0.04
Lukas                            1            34              6            0.03
Maoz Gelbart                    47          1938           1776            2.98
MaozGelbart                      3             9              5            0.01
Marcel Martin                    4             7             12            0.02
Margaret Pearce                  1             1              1            0.00
Marçal Gabaldà                   1            16              1            0.01
Matthew Badger                   1             3              1            0.00
Michael Waskom                 532         32011          17986           40.09
Mike Williams                    3            13              2            0.01
Miquela Stein                    2            10              2            0.01
Mitch Negus                      1             1              1            0.00
Olga Botvinnik                  62          1946            562            2.01
Ondrej Zacha                     1             1              1            0.00
Paul Hobson                     15           297             39            0.27
Paul Rougieux                    1             5              2            0.01
Pete Bachant                     3             4              2            0.00
Phillip Cloud                    1             8              4            0.01
Ravi Makhija                     1            12              9            0.02
Roman Werpachowski               1             4              4            0.01
Samuel St-Jean                   2             2              2            0.00
Saulius Lukauskas               20           215            135            0.28
Sebastian Pipping                1             4              4            0.01
Sebastian Pölsterl               1             5              5            0.01
Sergio Pascual                   1             0              4            0.00
Skipper Seabold                  1            11              6            0.01
Stephan Hoyer                    4            54              9            0.05
Stephen W. Thomas                1             2              1            0.00
Takafumi Arakaki                 1             2              2            0.00
Tamas Nagy                       2            14             14            0.02
Thomas A Caswell                 1             1              1            0.00
Thomas Brunner                   3            20              9            0.02
Tim Gates                        1             1              1            0.00
Timofei Bondarev                 1             1              1            0.00
Tobias Knuth                     1             1              1            0.00
Tobias Megies                    2             4              3            0.01
Todd                             1             3              3            0.00
Tom Augspurger                  10           135             33            0.13
TomAugspurger                    2            29              1            0.02
Tomas Ojea                       1             1              1            0.00
Tony Yang                        1             2              1            0.00
Travis Hoppe                     1             1              1            0.00
Tyler Funnell                    1             2              0            0.00
Victor Valente                   1             2              2            0.00
Yaroslav Halchenko               6            90             27            0.09
Yoav Ram                         2            33              2            0.03
ajalexei                         1             1              1            0.00
bennguvaye                       1             1              0            0.00
brains4math                      1             2              2            0.00
cyrusmaher                       1             1              0            0.00
dallascard                       1             1              1            0.00
danielballan                     1            18              6            0.02
diego0020                        1             1              1            0.00
drewokane                        3           421              3            0.34
e-q                              4             6              2            0.01
gfyoung                          1            18              1            0.02
gkunter                         10           221             17            0.19
jeroenboeye                      1             1              2            0.00
joelostblom                      4            10              7            0.01
joooeey                          1             3              3            0.00
linuxandchill                    1             1              1            0.00
moosekaka                        2             9              8            0.01
mtd91429                         1             1              1            0.00
mwaskom                        859         44126          19700           51.18
pyeguy                           1             1              1            0.00
santi                            4             9              1            0.01
stonebig                         1             5              0            0.00
toddrme2178                      1             0              3            0.00
tyarkoni                         2            30              6            0.03
Åsmund Hjulstad                  1             1              1            0.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Aaron Spring                  2          100.0          2.4                0.00
Agamemnon Krasoulis           1           33.3         23.3                0.00
Alexandre Huat                1          100.0         19.1                0.00
Alvaro Ulloa                  1          100.0         41.3                0.00
Andrew Janke                  6           85.7         29.8              100.00
André F. Rendeiro            17          100.0          0.7               11.76
Antony Lee                   46           86.8         62.6                4.35
Ariel Rokem                   6           60.0         31.1               16.67
Avinash Thakur                5           83.3         14.4                0.00
Benjamin Rose                 4          100.0         32.0                0.00
Brian Landry                 19           42.2         60.4               15.79
Brian Marks                   2           40.0         13.2               50.00
Cameron Pye                   5           25.0         43.0                0.00
Cameron Riddell               1          100.0          3.4                0.00
Chris Catalfo                 2          100.0         35.5                0.00
Chris Fonnesbeck              1           10.0         55.7                0.00
Chris Hausler                 2           50.0         73.6                0.00
Chris Holdgraf                1          100.0         49.4                0.00
Christopher Roberts           7           87.5         43.2                0.00
Christopher Whelan            2          100.0         11.5                0.00
Clark Fitzgerald              2            5.4         65.2                0.00
Clément Robert                9          100.0          3.4               11.11
CorbanSwain                   3            7.0         32.9                0.00
David C. Gemperline          81           46.6         58.1                6.17
David Haberthür               1          100.0         12.9                0.00
Drew O'Kane                 142           42.1         65.3                2.82
Emilio Dorigatti              2          100.0          7.7                0.00
Fabian Rost                   1          100.0         36.0                0.00
Gregory Hitz                  9           64.3         65.5                0.00
Gökcen Eraslan                7           29.2         20.3                0.00
Isaac Schwabacher             2          100.0         62.1                0.00
JWarmenhoven                  9           50.0         70.2                0.00
Jake VanderPlas              47           54.7         67.9               17.02
Jan Pipek                     1          100.0         12.5                0.00
Jeffrey Arnold                1          100.0         14.4                0.00
Jessime Kirk                  1          100.0         22.9                0.00
Jimmy Callin                  1           50.0         47.9                0.00
Joel Nothman                  2           40.0         39.2                0.00
John C. Earls                 2          100.0         62.7                0.00
Joris Vankerschaver           4           57.1         51.8               25.00
Julian de Ruiter            172           61.6         59.2                5.81
Kenta Sato                    2          100.0         30.3                0.00
Kevin Emmett                  2          100.0         74.4               50.00
Koki Sato                     2           66.7         25.0                0.00
Kyle Meyer                    6           46.2         67.1                0.00
Lukas                        21           61.8         10.0                4.76
Maoz Gelbart               1664           85.9          5.6                3.49
MaozGelbart                   7           77.8         13.3                0.00
Marcel Martin                 3           42.9         67.0                0.00
Marçal Gabaldà               16          100.0          0.0                0.00
Matthew Badger                3          100.0          4.8                0.00
Michael Waskom            21102           65.9          8.9                7.11
Mike Williams                 9           69.2         56.6                0.00
Mitch Negus                   1          100.0         41.1              100.00
Olga Botvinnik              917           47.1         75.0                3.27
Ondrej Zacha                  1          100.0          0.7                0.00
Paul Hobson                  90           30.3         78.9                1.11
Pete Bachant                  2           50.0         67.0                0.00
Phillip Cloud                 8          100.0         80.9               12.50
Ravi Makhija                  4           33.3         36.9               25.00
Roman Werpachowski            4          100.0          8.2                0.00
Saulius Lukauskas            53           24.7         62.5               15.09
Sebastian Pipping             3           75.0         10.9                0.00
Sebastian Pölsterl            1           20.0         62.4                0.00
Stephan Hoyer                42           77.8         78.0                4.76
Stephen W. Thomas             2          100.0         50.6                0.00
Tamas Nagy                    1            7.1         63.9                0.00
Thomas A Caswell              1          100.0         23.0                0.00
Thomas Brunner                2           10.0         33.5                0.00
Tim Gates                     1          100.0         14.0              100.00
Tom Augspurger               34           25.2         60.8                0.00
Tomas Ojea                    1          100.0          6.1                0.00
Tyler Funnell                 2          100.0         73.0                0.00
Victor Valente                2          100.0         23.0                0.00
Yaroslav Halchenko           25           27.8         72.5               12.00
Yoav Ram                     14           42.4         60.5                0.00
ajalexei                      1          100.0         31.5                0.00
bennguvaye                    1          100.0         10.7                0.00
brains4math                   2          100.0         26.5                0.00
drewokane                   155           36.8         66.3               17.42
gkunter                      36           16.3         59.2                2.78
joelostblom                   2           20.0         39.4                0.00
joooeey                       3          100.0          0.9                0.00
linuxandchill                 1          100.0         29.2                0.00
moosekaka                     5           55.6         49.0                0.00
mtd91429                      1          100.0         27.0                0.00
mwaskom                   14939           33.9         69.4                7.35
stonebig                      2           40.0         35.4                0.00
tyarkoni                     14           46.7         79.8                0.00

lpantano commented 3 years ago

@whedon generate pdf from branch joss_paper

whedon commented 3 years ago

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 3 years ago

:wave: @dangeles, please update us on how your review is going (this is an automated reminder).

whedon commented 3 years ago

:wave: @Sara-ShiHo, please update us on how your review is going (this is an automated reminder).

lpantano commented 3 years ago

@dangeles, @Sara-ShiHo, any updates on this? could you provide a date for when you will be able to work on this, please? Thanks!

Sara-ShiHo commented 3 years ago

Hi @lpantano - thanks for checking in. I will show some progress via the checklist this week. I will have it completed by the 18th.

Sara-ShiHo commented 3 years ago

Hi @whedon @lpantano is it possible to resend the invitation at https://github.com/openjournals/joss-reviews/invitations. I think the invitation has expired for me. Thank you.

danielskatz commented 3 years ago

@whedon re-invite @Sara-ShiHo as reviewer

whedon commented 3 years ago

OK, the reviewer has been re-invited.

@sara-shiho please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

lpantano commented 3 years ago

@whedon re-invite @dangeles as reviewer

whedon commented 3 years ago

OK, the reviewer has been re-invited.

@dangeles please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

lpantano commented 3 years ago

@mwaskom, can you address this issue raised by @Sara-ShiHo:

A statement of need: Does the paper have a section titled 'Statement of Need' that clearly states what problems the software is designed to solve and who the target audience is?

    OK -> This section is in the paper and it addresses the problems which are solved
    NEED TO ADD -> The target audience is not explicitly defined in this section

I think after that, it would be ready to be accepted. Thanks!

mwaskom commented 3 years ago

@lpantano sure, sounds good. Also a couple of people who have seen the draft manuscript have suggested that it might make sense for a paper about a data visualization library to have an example data visualization. I guess that's reasonable. Would it make sense to add one at this stage?

mwaskom commented 3 years ago

OK I added two commits:

https://github.com/mwaskom/seaborn/commit/6494515b9d747e53028b28202c8acc8167062591 addresses the target audience. seaborn is domain-general so the target audience is pretty wide; ~I think it's most helpful to be explicit about some kinds of visualizations that are explicitly out of scope.~ EDIT: actually I worry the original statement might not be accurate; it's probably at least true that seaborn can integrate with matplotlib's mapping functionality to some extent. Revised to make a general statement about the kinds of datasets it's expected to be used with.

https://github.com/mwaskom/seaborn/commit/78598837713d5251d4cb45729f5753821e44a8f2 adds an example script and figure. This seems useful, but I'm happy to revert it if you think it's too late in the process to add it.

mwaskom commented 3 years ago

@whedon generate pdf from branch joss_paper

whedon commented 3 years ago

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lpantano commented 3 years ago

Thank you, it is ok to add more information.

@Sara-ShiHo can you check the update and update the item you didn't check because it was missing or give more feedback? Thanks!

Sara-ShiHo commented 3 years ago

@lpantano & @mwaskom I reread the updated paper and I updated my checklist. One last thing (seeing the example section reminded me) - do you think it is necessary to specify seaborn's current version number in the example section or anywhere else?

mwaskom commented 3 years ago

Happy to do whatever is common for JOSS papers.

lpantano commented 3 years ago

It is a good suggestion, @mwaskom, would you mind to add the version used on the paper under the example section? Not all the papers show code, so there is no mandatory rule, and it should hurt to have it. Thanks @Sara-ShiHo for the sugestion.

mwaskom commented 3 years ago

@whedon generate pdf from branch joss_paper

whedon commented 3 years ago

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...

mwaskom commented 3 years ago

Done! Here's the diff: https://github.com/mwaskom/seaborn/commit/4867bd153881222b2846b7c07929793c10c4d462

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Sara-ShiHo commented 3 years ago

Thank you Michael and Lorena. I don't have any further suggestions.

lpantano commented 3 years ago

@mwaskom,

At this point could you:

[ ] Make a tagged release of your software, and list the version tag of the archived version here.
[ ] Archive the reviewed software in Zenodo or a similar service (e.g., figshare, an institutional repository)
[ ] Check the archival deposit (e.g., in Zenodo) has the correct metadata. This includes the title (should match the paper title) and author list (make sure the list is correct and people who only made a small fix are not on it). You may also add the authors' ORCID.
[ ] Please list the DOI of the archived version here.

I can then move forward with accepting the submission. Thanks!

mwaskom commented 3 years ago

Cool! Does the tagged release need to contain the paper.md file?

mwaskom commented 3 years ago

@whedon generate pdf from branch joss_paper

whedon commented 3 years ago

Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...

mwaskom commented 3 years ago

Just caught a typo 🤦

whedon commented 3 years ago

PDF failed to compile for issue #3021 with the following error:

Can't find any papers to compile :-(

mwaskom commented 3 years ago

@whedon generate pdf from branch joss_review

whedon commented 3 years ago

Attempting PDF compilation from custom branch joss_review. Reticulating splines etc...

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mwaskom commented 3 years ago

OK I have made a slight mess of things by naming the tag with the same string as the branch containing the paper.

In any case, I think it should be resolved.

Provided that the tagged release does not need to contain the paper source, this checklist should be completed. @lpantano please let me know if I need to change that.

[x] Make a tagged release of your software, and list the version tag of the archived version here.
[x] Archive the reviewed software in Zenodo or a similar service (e.g., figshare, an institutional repository)
[x] Check the archival deposit (e.g., in Zenodo) has the correct metadata. This includes the title (should match the paper title) and author list (make sure the list is correct and people who only made a small fix are not on it). You may also add the authors' ORCID.
[x] Please list the DOI of the archived version here.

Release was made with version tag joss_paper, which points at the same commit as v0.11.1.

The DOI for the release is 10.5281/zenodo.4645478.

lpantano commented 3 years ago

@whedon check references

lpantano commented 3 years ago

@whedon check references from branch joss_paper

whedon commented 3 years ago

Attempting to check references... from custom branch joss_paper

lpantano commented 3 years ago

@whedon set 10.5281/zenodo.4645478 as archive

whedon commented 3 years ago

OK. 10.5281/zenodo.4645478 is the archive.

mwaskom commented 3 years ago

@whedon check references from branch joss_review

whedon commented 3 years ago

Attempting to check references... from custom branch joss_review

whedon commented 3 years ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1037/0003-066X.60.2.170 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.25080/Majora-92bf1922-00a is OK
- 10.1073/pnas.1615269114 is OK
- 10.18637/jss.v059.i10 is OK

MISSING DOIs

- 10.1093/oso/9780190222055.003.0002 may be a valid DOI for title: Exploratory Data Analysis

INVALID DOIs

- None

lpantano commented 3 years ago

@whedon accept

whedon commented 3 years ago

Attempting dry run of processing paper acceptance...

openjournals / joss-reviews