openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: The MOOSE geochemistry module #3031

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @WilkAndy (Andy Wilkins) Repository: https://github.com/idaholab/moose Version: snapshot-20-10-27 Editor: @jedbrown Reviewers: smolins Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @WilkAndy. Currently, there isn't an JOSS editor assigned to your paper.

@WilkAndy if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
arfon commented 3 years ago

:wave: @WilkAndy - thanks for your submission. It's not immediately clear how this submission is different from https://github.com/openjournals/joss-reviews/issues/2176 - could you clarify?

WilkAndy commented 3 years ago

Hi @arfon . Yes, the MOOSE framework contains a number of modules designed to solve different types of physical problems. #2176 described the module that allows users to simulate fluid and heat flow through porous materials. This submission describes the module that allows users to model geochemistry.

jedbrown commented 3 years ago

Hi, @WilkAndy. The paper in #2176 mentions chemistry/geochemistry as features several times. I don't know a great way to write criteria to distinguish what is the contribution of a single publication and what other to-be-submitted features does it leverage. Without addressing this specific submission, I think we have to be careful with the precedent and extent to which it may encourage minimum publishable units.

WilkAndy commented 3 years ago

Hi @arfon , I understand your problem: people might just add a few lines of code to an existing project and publish a paper - "look at our exciting new code!" I think the current article does not fall into this category. The chem/geochem mentioned in #2176 is quite basic, and part of the reason for developing the current capability is that geochemists found it difficult to use and lacking features they usually use.

The current addition is a full geochemistry solver, and contains the standard features that geochemists will be familiar with from packages such as GWB or EQ3/6 or ToughReact (I'm not sure whether you've heard of these other packages, but just mention them to demonstrate this is not a small addition to MOOSE). The current addition can be used as a standalone geochem solver, or can be coupled to the rest of MOOSE to model complicated scenarios.

To give you a feel for its size:

/Users/wil04q/projects/moose/modules/geochemistry/> find . -name "*.C" | xargs wc -l
    5025 ./unit/src/GeochemicalSystemTest.C
     771 ./unit/src/GeochemicalDatabaseReaderTest.C
     359 ./unit/src/EquilibriumConstantInterpolatorTest.C
      58 ./unit/src/GeochemistryFormattedOutputTest.C
      92 ./unit/src/GeochemistryActivityCalculatorsTest.C
      34 ./unit/src/main.C
    1874 ./unit/src/MinimalGeochemicalSystemTest.C
    2755 ./unit/src/GeochemicalSolverTest.C
     873 ./unit/src/GeochemistryKineticRateCalculatorTest.C
     306 ./unit/src/GeochemistryIonicStrengthTest.C
      27 ./unit/src/GeochemistrySortedIndicesTest.C
     115 ./unit/src/GeochemicalDatabaseValidatorTest.C
    1509 ./unit/src/GeochemistrySpeciesSwapperTest.C
     159 ./unit/src/GeochemistryActivityCoefficientsDebyeHuckelTest.C
      61 ./test/src/base/GeochemistryTestApp.C
       3 ./build/unity_src/auxkernels_Unity.C
       9 ./build/unity_src/userobjects_Unity.C
      14 ./build/unity_src/utils_Unity.C
       3 ./build/unity_src/kernels_Unity.C
       3 ./build/unity_src/outputs_Unity.C
       6 ./build/unity_src/actions_Unity.C
       2 ./build/unity_src/postprocessors_Unity.C
     212 ./src/auxkernels/GeochemistryQuantityAux.C
      36 ./src/auxkernels/NodalVoidVolumeAux.C
      41 ./src/kernels/GeochemistryDispersion.C
      47 ./src/kernels/GeochemistryTimeDerivative.C
      95 ./src/userobjects/GeochemistryKineticRate.C
     107 ./src/userobjects/NearestNodeNumberUO.C
     222 ./src/userobjects/NodalVoidVolume.C
     126 ./src/userobjects/GeochemistryTimeIndependentReactor.C
     619 ./src/userobjects/GeochemistryTimeDependentReactor.C
     149 ./src/userobjects/GeochemicalModelDefinition.C
     549 ./src/userobjects/GeochemistrySpatialReactor.C
     183 ./src/userobjects/GeochemistryReactorBase.C
      35 ./src/postprocessors/NearestNodeNumber.C
      58 ./src/utils/GeochemistryFormattedOutput.C
     168 ./src/utils/GeochemistryIonicStrength.C
     887 ./src/utils/PertinentGeochemicalSystem.C
      26 ./src/utils/GeochemistrySortedIndices.C
     408 ./src/utils/GeochemicalDatabaseValidator.C
     375 ./src/utils/GeochemistrySpeciesSwapper.C
     457 ./src/utils/GeochemicalSolver.C
     227 ./src/utils/GeochemistryActivityCoefficientsDebyeHuckel.C
      70 ./src/utils/GeochemistryActivityCalculators.C
    2310 ./src/utils/GeochemicalSystem.C
     829 ./src/utils/GeochemicalDatabaseReader.C
     145 ./src/utils/GeochemistryKineticRateCalculator.C
     189 ./src/utils/EquilibriumConstantInterpolator.C
      36 ./src/main.C
     155 ./src/actions/AddTimeDependentReactionSolverAction.C
     268 ./src/actions/AddGeochemistrySolverAction.C
     147 ./src/actions/AddSpatialReactionSolverAction.C
     100 ./src/actions/AddGeochemicalModelInterrogatorAction.C
     139 ./src/actions/AddTimeIndependentReactionSolverAction.C
     330 ./src/outputs/GeochemicalModelInterrogator.C
     343 ./src/outputs/GeochemistryConsoleOutput.C
      84 ./src/base/GeochemistryApp.C
   24230 total
WilkAndy commented 3 years ago

Any thoughts on this submission, @arfon ?

Kevin-Mattheus-Moerman commented 3 years ago

@whedon check repository

whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=119.52 s (133.2 files/s, 15601.9 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
SWIG                           5341          61507              0         632963
C++                            3227          68488          62710         380913
C/C++ Header                   3213          48880         104885         139027
Markdown                       2684          32110             93          76367
Python                          906          15857          21414          69197
JSON                             50              0              0          33699
C                                25           4845           6605          27204
TeX                              71           3427            680          26066
SVG                              29              2             80          13518
CSS                              20            986            372           6146
Bourne Shell                     43            815            695           5115
JavaScript                       27           1314           1622           3461
YAML                             91            283             52           2889
make                             70            667           1366           2092
HTML                             60            215             28           1687
XML                              25              5              7           1202
Cython                            2             82             33            387
Bourne Again Shell               22             58             35            309
m4                                3             30              0            298
Fortran 90                        2            107            303            282
MATLAB                            2             35             20            109
Jupyter Notebook                  4              0            776             77
Dockerfile                        1             18             41             66
Specman e                         2              0              0             55
DOS Batch                         1              9              0             22
GLSL                              1              0             18             19
Fortran 77                        1              6              0             15
--------------------------------------------------------------------------------
SUM:                          15923         239746         201835        1423185
--------------------------------------------------------------------------------

Statistical information for the repository 'f9e46fcceb0b06b7693f4fd4' was
gathered on 2021/02/20.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Aaron Butterfield                8           230              1            0.01
Adam Cahill                      3             6              3            0.00
Adam X. Zabriskie                2           304             67            0.02
Akshay Dandekar                  5           140            113            0.01
Al Casagranda                   14           358            234            0.03
Alain B. Giorla                 28          1373            472            0.11
Alex Lindsay                   763         39360          36756            4.46
Alex McCaskey                    6        143931         140652           16.69
Alexandra Gertman                6            60             10            0.00
Andrea Alfonsi                   4             6              1            0.00
Andrea Jokisaari                30           843             60            0.05
Andrea Rovinelli                65          2211            678            0.17
Andrew E. Slaughter           1722        238392         125936           21.36
Andrew Parnell                   1            37              0            0.00
Andy Wilkins                   445         55377          12290            3.97
Antonio Cervone                  1             1              1            0.00
Antonio Recuero                 55          1501            880            0.14
April Novak                     18          1309             63            0.08
Avery Bingham                   10           481             19            0.03
Axel Seoane                      2           198              4            0.01
Benjamin Spencer               317         11539           9423            1.23
Bertrand Lagree                  3           329              1            0.02
Bob Kinoshita                    2            19              6            0.00
Bradley Fromm                   10           203             43            0.01
Brandon Langley                  2           102             19            0.01
Brian Alger                    219         18022           5175            1.36
Brycen Wendt                    20          2850           1120            0.23
Casey Icenhour                  66          2277           1184            0.20
Casper Versteeg                  1             2              0            0.00
Chandana Jayasundara             4           250             82            0.02
Chandrakanth Boliset             2            80              0            0.00
Chandu Bolisetti                19           506            112            0.04
Chris Green                    266         17496           8404            1.52
Chris Newman                     1            31              0            0.00
Christopher Walton               4           175             22            0.01
Christopher Wong                 2             8              8            0.00
Chuan Lu                         1            31              0            0.00
CiCi Pham                        1           124              0            0.01
Cody Permann                  1837        118240          67487           10.89
Congjian Wang                    4           632             16            0.04
Cormac Garvey                    2             2              2            0.00
Cristian Rabiti                  1             6              6            0.00
Daniel Ruprecht                  2           100              0            0.01
Daniel Schwen                  875         33800          22584            3.31
Daniel VanWasshenova            18           916            674            0.09
Daniel Vogler                    1            67              0            0.00
Danielle Perez                   1             2              0            0.00
David Andrs                    859         57859          48115            6.21
Dehao Liu                        1           147              0            0.01
Derek Gaston                  1004         72644          15430            5.16
Derek Stucki                     2             3              3            0.00
Dewen Yushu                      2           165            362            0.03
Dmitry Karpeev                  28           959            254            0.07
Dylan McDowell                   5           122              2            0.01
Fande Kong                     288          7307           3093            0.61
Floyd Hilty                      3            78             15            0.01
Frederick Gleicher               2            43              0            0.00
Gary Hu                         31          1684            602            0.13
Gavin Ridley                     6           117              6            0.01
Giovanni Pastore                 1             9              1            0.00
Guillaume Giudicelli            13           142             41            0.01
Hai Huang                        1            99              0            0.01
Hailong Chen                    55          5959           1882            0.46
Hao Wang                         3           109              0            0.01
Heather Sheldon                 11           635             41            0.04
Ian                              4            30             20            0.00
Ian Greenquist                   7           384             11            0.02
Ian Halvic                      49          2028           1378            0.20
Jacob Bair                       6           113             11            0.01
Jacob Hirschhorn                 1           120              0            0.01
Jacob L. Bair                    2            62             16            0.00
Jacob Peterson                   1            18              5            0.00
James B. Tompkins                7           487            272            0.04
Jarin French                     3            80             19            0.01
Jaron Senecal                    1            14              0            0.00
Jason                           15           129             71            0.01
Jason D. Hales                 347          7820           3932            0.69
Jason M. Miller                465         43762          22457            3.88
Jed Brown                        8           595             78            0.04
Jesse Carter                    21           398             28            0.02
Jieun Lee                        5            55             40            0.01
John Hutchins                   13           335            153            0.03
John Mangeri                     5           262             26            0.02
John W. Peterson               439         14894          11171            1.53
John-Michael Bradley             4            94              6            0.01
Joshua E. Hansel                92          4212           2174            0.37
Joshua J. Cogliati               2             2              2            0.00
Ju-Yuan Yeh                      3           101              1            0.01
Justin Coleman                   1           136              0            0.01
Karim Ahmed                      5           271             10            0.02
Karthikeyan Chockali            22           710             38            0.04
Katherine Smith                  7           108             82            0.01
Kevin Dugan                      2             8              0            0.00
Kevin J. Dugan                   1             1              0            0.00
Kyle Gamble                     13           323             53            0.02
Kyoungdoc Kim                    1            49              0            0.00
Larry Aagesen                   61          1551            262            0.11
Lauren Winterholler              2           362              0            0.02
Lei Zhao                         1             5              1            0.00
Leo Borrel                       1            79              0            0.00
Leora Chapuis                   19          2744            384            0.18
Liangzhe Zhang                   1            42              0            0.00
Ling Liu                         3           265              7            0.02
Ling Zou                         1             3              0            0.00
Logan Harbour                   72          9299           1089            0.61
Luanjing Guo                     4           803              6            0.05
Lynn Munday                      9           522            160            0.04
MOOSEBUILD                       1             9             21            0.00
Malachi Tolman                   9           255            105            0.02
Marie Backman                   26           950             54            0.06
Mark C. Messner                  1             9             18            0.00
Mark L. Baird                    1             1              1            0.00
Martin Lesueur                   1             2              0            0.00
Martin Luethi                    2           454            454            0.05
Mathias Winkel                   2            75             51            0.01
Matt Ellis                       1             3              1            0.00
Matthias                         1             5              3            0.00
Matthias Kunick                 16          1135            420            0.09
Micah Johnson                    4             7              5            0.00
Michael Pernice                  2            28              0            0.00
Michael Short                    3            94              0            0.01
Michael Tonks                  173          6081           1470            0.44
Moosetest                        1             1              1            0.00
Nicolo Grilli                    1           143              0            0.01
Paul Millet                      1             2              2            0.00
Paul Talbot                      8           401             11            0.02
Peter German                    52          1358            464            0.11
Philip Jagielski                76         10135            830            0.64
Philipp Schaedle                 1            43              0            0.00
Pritam Chakraborty              36          2987            483            0.20
Richard Williamson              10           286             17            0.02
Robert A. Kinoshita              2             7              1            0.00
Robert Carlsen                 339         59041          12057            4.17
Robert Nourgaliev                2            71              0            0.00
Robert Podgorney                 1             4              4            0.00
Roger Pawlowski                  1             1            304            0.02
Roy H. Stogner                  81           848            448            0.08
Ryan Norman                      7            43             21            0.00
Ryosuke Park                    36           642            177            0.05
Samet Kadioglu                   1            48              0            0.00
Samuel K. Tew                   12           530            119            0.04
Scott A. Schoen                 17           547             92            0.04
Sebastian Schunert              91          3013            546            0.21
Shane Stafford                  20           259            192            0.03
Shiyuan Gu                       3           113              0            0.01
Shrey Satpathy                   1           149              0            0.01
Shuaifang Zhang                  1             4              7            0.00
Som L. Dhulipala                 2           118              4            0.01
Srivatsan Hulikal                1            27              5            0.00
Stephanie Pitts                 50          2722            750            0.20
Stephen Novascone               26           763             72            0.05
Stephen Thomas                   1            47              0            0.00
Sterling Harper                 23           664            451            0.07
Steve Prescott                   2           170             48            0.01
Steven Wacker                    1             5              0            0.00
Sudipta Biswas                  78          2868            814            0.22
Swetha Veeraraghavan            36          3657            657            0.25
Tami Grimmett                    1             1              1            0.00
Thomas Poulet                    1             2              0            0.00
Tianchen Hu                      2           456            102            0.03
Topher Matthews                154          4893           1952            0.40
Toptan, Aysenur                  1            41              0            0.00
Vanessa Gertman                  7           215            543            0.04
Vincent Laboure                 11           161             20            0.01
Vishal Patel                     7            80             34            0.01
Wen Jiang                       60          4351           1675            0.35
Wenfeng Liu                      4            49              4            0.00
William Hoffman                  2             9              1            0.00
William Taitano                  1             8              0            0.00
Yang Xia                         1           196              0            0.01
Yaqi Wang                      232          7512           2986            0.62
Yeh, Ju-Yuan                     1            35              0            0.00
Yidong Xia                       6          2665              1            0.16
Yinbin Miao                      1             2              1            0.00
Yingjie Liu                      1           139             11            0.01
Yipeng Gao                       1            40              0            0.00
Zachary M. Prince               59          2650            403            0.18
Ziyu Zhang                      38          2606           1047            0.21
balep                            1            10              7            0.00
crswong888                      37          2612            319            0.17
dewenyushu                      11           427            289            0.04
jbtompkins                       1             0              1            0.00
jmeziere                         2             0              2            0.00
killerpenguin12                  1            34              0            0.00
knw7x9                           1             3              0            0.00
moose                            4            36              5            0.00
moose-maintenance                6         30938          28909            3.51
moosetest                        4            30             14            0.00
rayaprolu143                     2            16              4            0.00
schuseba                        14          1005             32            0.06
wesleyzzz                        1            10              3            0.00
wuxueyang                        1           121              0            0.01

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Aaron Butterfield           101           43.9         10.7               69.31
Adam Cahill                   5           83.3         47.2               40.00
Adam X. Zabriskie           297           97.7         17.7               18.18
Akshay Dandekar              27           19.3         10.5               18.52
Al Casagranda               202           56.4         34.2               49.01
Alain B. Giorla             722           52.6         40.1               62.05
Alex Lindsay              22758           57.8         18.6               53.67
Alex McCaskey                13            0.0         62.6                0.00
Andrea Alfonsi                5           83.3         31.0                0.00
Andrea Jokisaari            157           18.6          3.4               47.77
Andrea Rovinelli           1191           53.9         17.8               75.73
Andrew E. Slaughter      119441           50.1         21.9               25.31
Andy Wilkins              35294           63.7         39.7               35.67
Antonio Recuero             935           62.3          7.9               72.30
April Novak                1224           93.5         22.3               71.08
Axel Seoane                 145           73.2         54.9               48.28
Benjamin Spencer           5762           49.9         42.3               68.48
Bob Kinoshita                 4           21.1         74.4               50.00
Bradley Fromm                42           20.7         41.8               40.48
Brandon Langley              57           55.9         42.2               61.40
Brian Alger               11794           65.4         46.1               12.29
Brycen Wendt               1474           51.7         37.8               68.59
Casey Icenhour             1998           87.7         15.6               32.63
Casper Versteeg               2          100.0          3.2                0.00
Chandana Jayasundara          3            1.2         78.8               33.33
Chandrakanth Boliset         13           16.2         39.8               69.23
Chandu Bolisetti            285           56.3         14.5               61.40
Chris Green               10105           57.8         30.0               53.08
CiCi Pham                   108           87.1         43.1               75.93
Cody Permann              61167           51.7          8.9               34.18
Congjian Wang               231           36.6         47.0               72.73
Daniel Ruprecht              17           17.0         67.0               76.47
Daniel Schwen             17089           50.6         40.5               58.77
Daniel VanWasshenova        375           40.9         10.4               87.47
Danielle Perez                1           50.0         80.4                0.00
David Andrs               17151           29.6          8.0               59.71
Dehao Liu                   121           82.3         31.4               71.90
Derek Gaston              15244           21.0         22.1               57.37
Derek Stucki                  1           33.3         35.7                0.00
Dmitry Karpeev              162           16.9          0.0               67.90
Dylan McDowell              121           99.2          8.7               19.01
Fande Kong                 4462           61.1         26.3               52.15
Floyd Hilty                  36           46.2         55.9               16.67
Frederick Gleicher           22           51.2         64.7               50.00
Gary Hu                    1322           78.5         19.6               74.13
Gavin Ridley                111           94.9          4.6               86.49
Giovanni Pastore              4           44.4         58.8               75.00
Guillaume Giudicelli        170          119.7          0.8               55.29
Hai Huang                    24           24.2         63.9               25.00
Hailong Chen               3564           59.8         30.8               77.89
Hao Wang                     64           58.7         56.3               43.75
Heather Sheldon             273           43.0         46.2               52.38
Ian                         652         2173.3          7.2              111.66
Ian Greenquist              268           69.8         38.0               63.06
Jacob Bair                   50           44.2         63.0               58.00
Jacob Hirschhorn             87           72.5         15.0               93.10
Jacob L. Bair                20           32.3         63.8               40.00
Jacob Peterson               11           61.1         80.6               72.73
James B. Tompkins           171           35.1         43.5               98.83
Jarin French                 34           42.5         55.8               44.12
Jaron Senecal                 1            7.1         45.1                0.00
Jason                        26           20.2         16.1              126.92
Jason D. Hales             1015           13.0         18.1               68.57
Jason M. Miller           14810           33.8         21.6               20.14
Jed Brown                    10            1.7          0.0               50.00
Jesse Carter                247           62.1         44.0               52.23
Jieun Lee                    25           45.5         29.3               44.00
John Hutchins                68           20.3          0.0               54.41
John Mangeri                136           51.9         49.2               53.68
John W. Peterson           7661           51.4         39.9               62.11
John-Michael Bradley         46           48.9         62.4               63.04
Joshua E. Hansel           2599           61.7         27.1               70.76
Ju-Yuan Yeh                  63           62.4         41.4               57.14
Justin Coleman               46           33.8          0.0               71.74
Karim Ahmed                 164           60.5         55.5               42.68
Katherine Smith              17           15.7          0.0               64.71
Kevin J. Dugan                9          900.0         34.8               44.44
Kyle Gamble                 255           78.9         29.9               78.82
Kyoungdoc Kim                41           83.7         36.2               73.17
Larry Aagesen               950           61.3         51.4               50.53
Lei Zhao                      1           20.0         75.3                0.00
Leora Chapuis              1917           69.9         28.5               85.34
Ling Liu                    218           82.3         37.9               47.71
Ling Zou                      2           66.7         18.4               50.00
Logan Harbour              9083           97.7          4.2               64.60
Luanjing Guo                147           18.3          0.0               59.86
Lynn Munday                 452           86.6          6.4               80.53
MOOSEBUILD                    7           77.8          5.5                0.00
Malachi Tolman                2            0.8         48.9                0.00
Marie Backman               285           30.0         58.1               52.28
Mark C. Messner               9          100.0         44.2               88.89
Mark L. Baird                 1          100.0         36.2                0.00
Martin Lesueur                1           50.0         59.2                0.00
Mathias Winkel                1            1.3         74.3                0.00
Matt Ellis                    3          100.0         75.0               33.33
Matthias                      5          100.0          0.9               20.00
Matthias Kunick             856           75.4         26.2               68.11
Michael Pernice              11           39.3          0.0               54.55
Michael Short                19           20.2          0.0               47.37
Michael Tonks              1478           24.3         36.7               59.61
Moosetest                     1          100.0         31.8                0.00
Paul Talbot                  88           21.9          0.0               82.95
Peter German                923           68.0          7.7               94.69
Philip Jagielski             48            0.5          0.0               58.33
Philipp Schaedle             39           90.7         34.9               82.05
Pritam Chakraborty         1241           41.5         62.9               44.32
Richard Williamson           15            5.2          0.0               26.67
Robert Carlsen            41363           70.1         42.4               29.42
Roy H. Stogner              607           71.6         46.5               84.68
Samuel K. Tew               234           44.2         20.5               68.38
Sebastian Schunert         1437           47.7         29.5               72.93
Shane Stafford              171           66.0         72.0               28.07
Shiyuan Gu                   13           11.5          0.0              107.69
Shrey Satpathy               49           32.9         41.9               75.51
Som L. Dhulipala            110           93.2         11.8               58.18
Srivatsan Hulikal            15           55.6         55.9               26.67
Stephanie Pitts            1316           48.3         30.0               64.59
Stephen Novascone           133           17.4         11.3               53.38
Sterling Harper             535           80.6         25.2               41.87
Steven Wacker                 1           20.0         38.3              100.00
Sudipta Biswas             1477           51.5         51.8               64.66
Swetha Veeraraghavan       2234           61.1         34.5               71.17
Tami Grimmett                 1          100.0         69.6              100.00
Topher Matthews            2885           59.0         16.1               73.14
Toptan, Aysenur              41          100.0          9.2                2.44
Vincent Laboure             146           90.7         11.5               69.18
Vishal Patel                 14           17.5         36.7               35.71
Wen Jiang                  2696           62.0         40.7               60.46
William Hoffman               7           77.8         52.0               28.57
Yang Xia                     71           36.2         65.6               39.44
Yaqi Wang                  5035           67.0         25.8               68.26
Yeh, Ju-Yuan                 26           74.3         25.1               88.46
Yidong Xia                  748           28.1         51.9               60.96
Yingjie Liu                  17           12.2         42.1                0.00
Yipeng Gao                   26           65.0         45.1               61.54
Zachary M. Prince          2164           81.7          9.5               56.93
Ziyu Zhang                  127            4.9         72.8               78.74
balep                        10          100.0         11.3               30.00
crswong888                 2220           85.0          5.1               26.49
dewenyushu                  453          106.1          4.6               51.88
jbtompkins                   64          100.0         21.4               70.31
killerpenguin12              31           91.2         11.3              122.58
knw7x9                        3          100.0          0.4                0.00
moose                        29           80.6         21.3               62.07
moosetest                 25943        86476.7         38.9              136.22
rayaprolu143                 14           87.5         18.2               42.86
schuseba                   1412          140.5         16.2               61.69
wesleyzzz                     9           90.0         21.4              177.78
wuxueyang                   103           85.1         14.5               82.52
Kevin-Mattheus-Moerman commented 3 years ago

@arfon @jedbrown can you respond to the authors comments :point_up: thanks

arfon commented 3 years ago

@Kevin-Mattheus-Moerman @WilkAndy - I think we're good to proceed here. As I'm guessing this may not be the last MOOSE-related submission, let's just try and be very clear when dealing with the new submissions we understand how any new submission may related to a historical one.

arfon commented 3 years ago

@whedon invite @jedbrown as editor

@jedbrown - I realize you're not able to devote a bunch of time to editing for JOSS right now but would you be willing to take this one on sometime in early March. @WilkAndy - many of our editors are very busy right now and so there may be some additional delays before we send this submission out for review.

whedon commented 3 years ago

@jedbrown has been invited to edit this submission.

jedbrown commented 3 years ago

I'll do my best. Just when I thought I was getting legs underneath me on Friday, daughter's childcare was canceled again, for at least a week (due to covid cases in other classrooms). So if we're lucky and she's healthy and they reopen, I can look in two weeks.

WilkAndy commented 3 years ago

I understand any delays. Keep your family safe, @jedbrown

kthyng commented 3 years ago

I'll assign @jedbrown here with the understanding that it is not immediately on the table.

kthyng commented 3 years ago

@whedon assign @jedbrown as editor

whedon commented 3 years ago

OK, the editor is @jedbrown

WilkAndy commented 3 years ago

Hi @jedbrown , i'm just keeping this on your radar...

WilkAndy commented 3 years ago

Keeping this JOSS paper on @jedbrown 's radar.

WilkAndy commented 3 years ago

Just wondering if @jedbrown has an ETA for this one?

jedbrown commented 3 years ago

Thanks for the many pings. I'll be able to move this forward by the end of this week.

jedbrown commented 3 years ago

@zgxn @jmp75 :wave: Would you be willing to review this submission for JOSS? It's a well-defined geochemistry module developed within the MOOSE repository.

jedbrown commented 3 years ago

@whedon add smolins as reviewer

whedon commented 3 years ago

OK, smolins is now a reviewer

jedbrown commented 3 years ago

I think I've identified a second reviewer, but got a vacation autoresponder so I'll start the review now and add them (or another reviewer) after they return. If @zgxn or @jmp75 become available, I'd be happy to add you. Thanks for your patience, everyone.

jedbrown commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3314.