openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: imea: A Python package for extracting 2D and 3D shape measurements from images #3072

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @nilskroell (Nils Kroell) Repository: https://git.rwth-aachen.de/ants/sensorlab/imea Version: v0.2.2 Editor: @mbobra Reviewers: @Atif-Anwer, @tuelwer Managing EiC: Daniel S. Katz

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @nilskroell. Currently, there isn't an JOSS editor assigned to your paper.

@nilskroell if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.30 s (39.6 files/s, 13243.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           7            557            752            890
Markdown                         2             66              0            197
TeX                              1             34              0            168
Jupyter Notebook                 2              0           1241            107
-------------------------------------------------------------------------------
SUM:                            12            657           1993           1362
-------------------------------------------------------------------------------

Statistical information for the repository 'a7e7eda1426829055c5a5940' was
gathered on 2021/02/27.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Nils Kroell                     49          3725           3565           76.36
nkroell                          3          2148            109           23.64

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Nils Kroell                2199           59.0          0.1               12.73
whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.mineng.2011.10.001 is OK
- 10.1016/j.wasman.2020.11.003 is OK
- 10.1016/j.ces.2013.02.043 is OK
- 10.1063/5.0002233 is OK
- 10.1109/IEMBS.2005.1617159 is OK
- 10.1016/s0165-0270(96)00080-5 is OK
- 10.1016/j.patrec.2017.08.022 is OK
- 10.1016/j.wasman.2020.09.033 is OK
- 10.7717/peerj.453 is OK
-  10.25080/Majora-92bf1922-00a is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 3 years ago

👋 @nilskroell - Due to the relatively small size of this code, the JOSS editors will now examine if this submission meets the substantial scholarly effort criterion for review by JOSS.

danielskatz commented 3 years ago

@whedon query scope

whedon commented 3 years ago

Submission flagged for editorial review.

nilskroell commented 3 years ago

Hi @danielskatz, thanks for your fast reply!

To give you and the editorial board more context on the scholary effort that was required to develop imea, I would like to add the following four points, which are difficult to be discovered from the repository and LOC:

For our department and project partners, imea has already been extremely useful in extracting shape measurements in various projects in the short time since it was available for internal validation. Several research publications where imea was used for data extraction are already in preparation. An inclusion of imea into JOSS would help me a lot in making imea more visible for other researchers and citable in upcoming publications. I look forward to your decision. If you need any additional information – do not hesitate to ask me, I am happy to reply.

Best regards, Nils

danielskatz commented 3 years ago

This has passed the scope check

danielskatz commented 3 years ago

👋 @mbobra - would you be able to edit this submission?

danielskatz commented 3 years ago

@whedon invite @mbobra as editor

whedon commented 3 years ago

@mbobra has been invited to edit this submission.

mbobra commented 3 years ago

@whedon assign me as editor

whedon commented 3 years ago

OK, the editor is @mbobra

mbobra commented 3 years ago

@nilskroell Thank you for your submission! Please give me a week to find some reviewers (I am tied up until the day after tomorrow, but will search for reviewers after that).

If you have any suggested reviewers, please let me know here (you can give me the Github handle without @ mentioning them, e.g. mbobra instead of @mbobra).

nilskroell commented 3 years ago

@danielskatz : Thanks a lot for the fast decision. I'm glad that imea fits the scope of JOSS.

@mbobra : Thanks a lot for taking the time to edit this submission and the clear and fast communication.

Based on the provided list of potential reviewers I can suggest the following reviewers:

All suggested reviewers are familiar with Python, have currently no active reviews (as indicated in the list) and have at least one time reviewed for JOSS before. I also made sure, that none of them is working at the same university as I am and that the suggested reviewers come from different fields. However, there are many more potential reviewers with expertise in image processing & Python in the list which could be included. If you need more suggestions @mbobra feel free to contact me.

Atif-Anwer commented 3 years ago

Hi!

I've looked at the repo as well as the draft submission and I would be glad to review the submission. However before committing, I would like to ask about the deadline/timeline available for the review; since I am myself teaching this semester etc. I would hopefully be able to review it in a couple of weeks approximately; testing out the package and etc. If that is ok with JOSS's timeline, then I will be glad to formally accept as reviewer on the JOSS pre-review thread. (@mbobra I tried to reply to your email; but the server rejected my email as spam so I figured i'll post here directly)

mbobra commented 3 years ago

@Atif-Anwer Thank you so much for your reply (and persistence)! I'm sorry about the spam filter (I will look into it).

JOSS is operating on a reduced service mode (see here) so we're giving reviewers six weeks to complete their review. This is not a hard deadline, though, so if you need an additional week or so that's fine. Is this okay with you? If so, I'll go ahead and assign you as a reviewer.

Atif-Anwer commented 3 years ago

Six weeks is ample time. Ill be able to do it before that for sure. Thanks!

mbobra commented 3 years ago

@whedon assign @Atif-Anwer as reviewer

whedon commented 3 years ago

OK, @Atif-Anwer is now a reviewer

mbobra commented 3 years ago

@whedon add @tuelwer as reviewer

whedon commented 3 years ago

OK, @tuelwer is now a reviewer

mbobra commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3091.

mbobra commented 3 years ago

@Atif-Anwer @tuelwer See you over in #3091 where the review will take place!