Closed whedon closed 3 years ago
https://zenodo.org/record/4968601#.YMpIOJpKirQ doesn't look like an archive DOI.
@whedon set https://doi.org/10.5281/zenodo.4968601 as archive
OK. 10.5281/zenodo.4968601 is the archive.
@whedon recommend-accept
Attempting dry run of processing paper acceptance...
PDF failed to compile for issue #3079 with the following error:
Can't find any papers to compile :-(
@whedon generate pdf from branch joss_paper
Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@whedon recommend-accept
Attempting dry run of processing paper acceptance...
PDF failed to compile for issue #3079 with the following error:
Can't find any papers to compile :-(
@whedon recommend-accept from branch joss_paper
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1126/science.261.5121.578 is OK
- 10.1137/0153002 is OK
- 10.1103/PhysRevResearch.2.023068 is OK
- 10.3847/1538-4357/aa6ff6 is OK
- 10.3847/1538-4357/aa6ff1 is OK
- 10.1137/15M1055012 is OK
- 10.1063/1.4934378 is OK
- 10.1103/PhysRevFluids.2.083501 is OK
- 10.3847/1538-4357/aaff61 is OK
- 10.1098/rspa.2019.0622 is OK
MISSING DOIs
- 10.3847/1538-4357/abcd9b may be a valid DOI for title: Stratified and vertically-shearing streaming instabilities in protoplanetary disks
INVALID DOIs
- https://doi.org/10.1016/j.aop.2015.02.031 is INVALID because of 'https://doi.org/' prefix
:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.
Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2399
If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2399, then you can now move forward with accepting the submission by compiling again with the flag deposit=true
e.g.
@whedon accept deposit=true from branch joss_paper
@jsoishi: Could you please check the issues with the DOIs signalled above. Thanks!
@dpsanders I've done so. Thanks
On Sun, Jun 20, 2021 at 7:45 PM David P. Sanders @.***> wrote:
@jsoishi https://github.com/jsoishi: Could you please check the issues with the DOIs signalled above. Thanks!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3079#issuecomment-864629766, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7SHYOJFO5MNULAR2OPAMTTTZ4SJANCNFSM4YPGFCIQ .
@whedon generate pdf from branch joss_paper
Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Hi @jsoishi, I'm doing some final checks before publishing. Thanks for fixing those DOI issues. I still see one minor issue with the Lin reference: the journal name is missing. Can you please add that? Otherwise, this looks good to go.
Hi @kyleniemeyer, thanks for catching that. I've pushed to the joss_paper branch with a fix for that just now.
@whedon generate pdf from branch joss_paper
Attempting PDF compilation from custom branch joss_paper. Reticulating splines etc...
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@whedon accept deposit=true from branch joss_paper
Doing it live! Attempting automated processing of paper acceptance...
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨
Here's what you must now do:
Party like you just published a paper! 🎉🌈🦄💃👻🤘
Any issues? Notify your editorial technical team...
Congratulations @jsoishi on your article's publication in JOSS!
Many thanks to @ketch and @caropen for reviewing this, and @dpsanders for editing.
:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:
If you would like to include a link to your paper from your README use the following code snippets:
Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.03079/status.svg)](https://doi.org/10.21105/joss.03079)
HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.03079">
<img src="https://joss.theoj.org/papers/10.21105/joss.03079/status.svg" alt="DOI badge" >
</a>
reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.03079/status.svg
:target: https://doi.org/10.21105/joss.03079
This is how it will look in your documentation:
We need your help!
Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
Congratulations on the paper, @jsoishi! Many thanks to @ketch and @caropen for your reviews, and to @kyleniemeyer for editorial help.
Submitting author: @jsoishi (Jeffrey S. Oishi) Repository: https://github.com/DedalusProject/eigentools Version: 2.2106 Editor: @dpsanders Reviewer: @ketch, @caropen Archive: 10.5281/zenodo.4968601
:warning: JOSS reduced service mode :warning:
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@ketch & @caropen, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dpsanders know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @ketch
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @caropen
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper