search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
719 stars 38 forks source link

[PRE REVIEW]: MLJFlux: Deep learning interface to the MLJ toolbox #3208

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @ayush-1506 (Ayush Shridhar) Repository: https://github.com/FluxML/MLJFlux.jl Version: v0.1.10 Editor: @melissawm Reviewers: @krystophny, @morganericsson Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @ayush-1506. Currently, there isn't an JOSS editor assigned to your paper.

@ayush-1506 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.24 s (152.4 files/s, 51375.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TOML                             7            571              3           2619
Julia                           17            476            220           1381
Markdown                         4            221              0            673
Jupyter Notebook                 5              0           5822            392
YAML                             4              1              1             95
-------------------------------------------------------------------------------
SUM:                            37           1269           6046           5160
-------------------------------------------------------------------------------

Statistical information for the repository '391dac11380847a46cf91887' was
gathered on 2021/04/22.
No commited files with the specified extensions were found.
whedon commented 3 years ago

PDF failed to compile for issue #3208 with the following error: 

 Can't find any papers to compile :-(
ayush-1506 commented 3 years ago

@whedon generate pdf from branch paper

whedon commented 3 years ago 
Attempting PDF compilation from custom branch paper. Reticulating splines etc...
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 3 years ago

@whedon invite @melissawm as editor

:wave: @melissawm - would you be willing to edit this submission for us?

whedon commented 3 years ago

@melissawm has been invited to edit this submission.

melissawm commented 3 years ago

Hello, @arfon - sure I´ll be happy to!

melissawm commented 3 years ago

@whedon assign @melissawm as editor

whedon commented 3 years ago

OK, the editor is @melissawm

melissawm commented 3 years ago

Hello, @ayush-1506 ! Thank you for the submission.

Based on JOSS Guidelines, I'm flagging this for additional scope review.

melissawm commented 3 years ago

@whedon query scope

whedon commented 3 years ago

Submission flagged for editorial review.

danielskatz commented 3 years ago

@melissawm - Can you explain specifically why you flagged this, and what other editors should look for? It seems like enough code/contribution, and it seems like research software, so I'm unsure what the potential issue is. It would be better if the authors provided some examples of research problems where this could be used, but I'm fairly confident this shouldn't be difficult for them to do.

melissawm commented 3 years ago

Hello @danielskatz - ~as I understand it, since the commit history in this is less than 3 months of work, this should be flagged for additional scope check. Otherwise, it does look fine - so if I'm being overzealous let me know and we can go ahead with the review :)~

Indeed I made a mistake - I now realize I was not checking for the complete history. Sorry about this!

ayush-1506 commented 3 years ago

Hi @melissawm 👋 kindly let me know if you'd like something from my side here. Thanks for agreeing to edit this.

melissawm commented 3 years ago

Hello, @ayush-1506 - sorry for the delay. I'm going forward with the pre-review now.

I have a few comments about the paper:

Meanwhile, can you point me to any reviewers that you think would be appropriate from the JOSS reviewer list? Thank you!

ayush-1506 commented 3 years ago

Sure, thanks for pointing this out. Looking at the reviewer list, @{krystophny and dpsanders} seem to be perfect.

melissawm commented 3 years ago

:wave: Hello, @krystophny & @dpsanders , would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

krystophny commented 3 years ago

Hi @melissawm , sure - it could take up to 2 weeks but I'll do my best to start soon.

melissawm commented 3 years ago

Thank you, @krystophny ! Let's wait for a second reviewer before we start the actual review. I'll add you right now.

melissawm commented 3 years ago

@whedon assign @krystophny as reviewer

whedon commented 3 years ago

OK, @krystophny is now a reviewer

ayush-1506 commented 3 years ago

@melissawm Should I suggest a second reviewer here ?

ayush-1506 commented 3 years ago

Ping.

melissawm commented 3 years ago

I'm sorry for the delay, @ayush-1506 . If you do have suggestions, that would be great :)

ayush-1506 commented 3 years ago

Adding a few more here: @{morganericsson , mirca, eviatarbach, dpsanders}. Kindly let me know if you'd like more suggestions.

melissawm commented 3 years ago

Hello, @morganericsson, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

morganericsson commented 3 years ago

@melissawm Sure, I can do that. I think I might need two weekends (so before July, but not by much) to dig into it, just so you know.

melissawm commented 3 years ago

If @ayush-1506 agrees that sounds fine!

ayush-1506 commented 3 years ago

@morganericsson Sure, no worries. Would be great if we could complete the review process by the end of June. Let me know if you'd like any inputs from my side. Thanks for agreeing to review this.

melissawm commented 3 years ago

Thank you, both @morganericsson and @krystophny! I will then set up the review process and this pre-review issue will be automatically closed. You will receive a notification shortly.

melissawm commented 3 years ago

@whedon add @morganericsson as reviewer

whedon commented 3 years ago

OK, @morganericsson is now a reviewer

melissawm commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3375.