[PRE REVIEW]: RayFlare: flexible optical modelling of solar cells

[whedon]

Submitting author: @phoebe-p (Phoebe Pearce) Repository: https://github.com/qpv-research-group/rayflare Version: v1.0.0 Editor: @arfon Reviewers: @kanderso-nrel, @EricaEgg Managing EiC: Arfon Smith

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/15647ef7b3dd688b47c1b802a4f50a67"><img src="https://joss.theoj.org/papers/15647ef7b3dd688b47c1b802a4f50a67/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/15647ef7b3dd688b47c1b802a4f50a67/status.svg)](https://joss.theoj.org/papers/15647ef7b3dd688b47c1b802a4f50a67)

Author instructions

Thanks for submitting your paper to JOSS @phoebe-p. Currently, there isn't an JOSS editor assigned to your paper.

@phoebe-p if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

PDF failed to compile for issue #3317 with the following error:

 Can't find any papers to compile :-(

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.12 s (592.1 files/s, 121561.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          40           2246            770           5128
Jupyter Notebook                13              1           2649           2276
CSS                              1             84             39            541
reStructuredText                11            132            103            259
YAML                             1             13              3             57
DOS Batch                        1              8              1             26
Markdown                         1              3              0             11
make                             1              4              7              9
SVG                              1              0              0              1
-------------------------------------------------------------------------------
SUM:                            70           2491           3572           8308
-------------------------------------------------------------------------------

Statistical information for the repository 'ee80113e34dd1e7e713162e2' was
gathered on 2021/05/26.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Phoebe                           3           761             39            1.11
Phoebe Pearce                   35          3031           1621            6.46
phoebe-p                       196         33654          32872           92.43

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Phoebe Pearce               700           23.1         10.2                9.71
phoebe-p                   7444           22.1          9.6                5.05

[arfon]

@whedon check references from branch paper

[whedon]

Attempting to check references... from custom branch paper

[arfon]

@whedon generate pdf from branch paper

[whedon]

Attempting PDF compilation from custom branch paper. Reticulating splines etc...

[whedon]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1117/12.2550136 is OK
- 10.1007/s10825-018-1171-3 is OK
- 10.1109/PVSC40753.2019.8980868 is OK
- 10.1016/j.cpc.2012.04.026 is OK
- 10.1109/JPHOTOV.2017.2669640 is OK
- 10.1364/OE.23.00A502 is OK
- 10.1364/OE.23.0A1720 is OK
- 10.1016/j.solmat.2019.110051 is OK
- 10.1038/s41560-019-0444-9 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[whedon]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[arfon]

@phoebe-p – thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

[arfon]

@whedon assign me as editor

[whedon]

OK, the editor is @arfon

[arfon]

:wave: @phoebe-p – could you take a look a this list of potential reviewers and identify a few people who would be good candidates to review this submission?

[phoebe-p]

Hi @arfon, my suggestions:

• @dalonsoa would be very suitable, but we have worked together on another software package related to RayFlare and he is also in the paper's acknowledgements (though he did not specifically help with the code for RayFlare), so perhaps this disqualifies him as a reviewer
• brandondube
• alvesjnr
• dsryberg
• samuelduchesne
• ivergara

[arfon]

@sevberg @EricaEgg @kanderso-nrel – would you be willing to review this submission for JOSS? The software under review is a Python package RayFlare: flexible optical modelling of solar cells.

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html

[kandersolar]

I am willing to review but it may take longer than the (extended) 6-week turnaround -- I would want to get more familiar with optical modeling techniques before completing the review. Happy to do it if nobody else is available to do it quicker.

Side note @phoebe-p, the RayFlare_theory.pdf document is amazing, very excited to read it!

[phoebe-p]

@kanderso-nrel thank you! If you do read it, do let me know if you find anything which doesn't seem to make sense - it's a slightly adapted version of a chapter from my thesis so there may be parts which don't make sense/reference something which isn't actually in the document without the context of the rest of the thesis that I missed when adapting it.

[arfon]

@whedon add @kanderso-nrel as reviewer

[whedon]

OK, @kanderso-nrel is now a reviewer

[arfon]

I am willing to review but it may take longer than the (extended) 6-week turnaround -- I would want to get more familiar with optical modeling techniques before completing the review. Happy to do it if nobody else is available to do it quicker.

Thanks @kanderso-nrel - that sounds great! I won't open the main review until I've identified a second reviewer here.

[EricaEgg]

I would also be happy to review.

Thanks for reaching out,

Erica Eggleton

On Tue, Jul 6, 2021 at 11:29 PM Arfon Smith @.***> wrote:

I am willing to review but it may take longer than the (extended) 6-week turnaround -- I would want to get more familiar with optical modeling techniques before completing the review. Happy to do it if nobody else is available to do it quicker.

Thanks @kanderso-nrel https://github.com/kanderso-nrel - that sounds great! I won't open the main review until I've identified a second reviewer here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3317#issuecomment-875447036, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCPASV5OXPNFPVVPPGLKL3TWQM7RANCNFSM45S2GQUQ .

-- Erica Eggleton she/her/hers PhD Candidate Schwartz Research Group https://uwemilab.github.io/ Department of Chemical Engineering https://www.cheme.washington.edu/ University of Washington

[arfon]

@whedon add @EricaEgg as reviewer

[whedon]

OK, @EricaEgg is now a reviewer

[arfon]

@whedon start review

[whedon]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3460.

[arfon]

@kanderso-nrel @EricaEgg - thanks so much for agreeing to review! See you over in #3460 where the actual review will take place.