openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: TsgFEM: Tensegrity Finite Element Method #3350

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @Muhao-Chen (Muhao Chen) Repository: https://github.com/Muhao-Chen/Tensegrity_Finite_Element_Method_TsgFEM Version: v1.1 Editor: @diehlpk Reviewers: @HaoZeke, @Kevin-Mattheus-Moerman, @likask Managing EiC: Kevin M. Moerman

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f1d105231d01a48566c9fefdee41497b"><img src="https://joss.theoj.org/papers/f1d105231d01a48566c9fefdee41497b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f1d105231d01a48566c9fefdee41497b/status.svg)](https://joss.theoj.org/papers/f1d105231d01a48566c9fefdee41497b)

Author instructions

Thanks for submitting your paper to JOSS @Muhao-Chen. Currently, there isn't an JOSS editor assigned to your paper.

@Muhao-Chen if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.19 s (582.4 files/s, 53725.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          86            919           2685           4665
TeX                              1            170              0           1200
Markdown                        21             83              0            240
-------------------------------------------------------------------------------
SUM:                           108           1172           2685           6105
-------------------------------------------------------------------------------

Statistical information for the repository '239e1bb18ad72c1736c25f9e' was
gathered on 2021/06/10.
No commited files with the specified extensions were found.
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/j.aquaeng.2007.01.001 may be a valid DOI for title: Finite element analysis of tensegrity structures in offshore aquaculture installations
- 10.1016/j.compstruct.2017.12.050 may be a valid DOI for title: Nonlinear dynamic and deployment analysis of clustered tensegrity structures using a positional formulation FEM
- 10.1016/j.engstruct.2009.12.042 may be a valid DOI for title: Designing tensegrity modules for pedestrian bridges
- 10.1016/j.engstruct.2021.111965 may be a valid DOI for title: Minimal mass design of active tensegrity structures
- 10.1073/pnas.141199598 may be a valid DOI for title: Mechanical behavior in living cells consistent with the tensegrity model
- 10.1038/nnano.2010.107 may be a valid DOI for title: Self-assembly of three-dimensional prestressed tensegrity structures from DNA
- 10.1126/science.271.5245.84 may be a valid DOI for title: Molecular orientation and two-component nature of the crystalline fraction of spider dragline silk
- 10.1016/j.ijosm.2011.11.003 may be a valid DOI for title: A consideration of the elbow as a tensegrity structure
- 10.1016/j.ast.2020.106147 may be a valid DOI for title: Design and analysis of a growable artificial gravity space habitat
- 10.1063/1.5040850 may be a valid DOI for title: Tensegrity cell mechanical metamaterial with metal rubber
- 10.1016/j.ijsolstr.2018.10.017 may be a valid DOI for title: Deployment of foldable tensegrity-membrane systems via transition between tensegrity configurations and tensegrity-membrane configurations
- 10.21105/joss.01613 may be a valid DOI for title: MOTES: Modeling of Tensegrity Structures
- 10.1016/j.compstruc.2008.11.010 may be a valid DOI for title: Automated discovery and optimization of large irregular tensegrity structures
- 10.1007/s11044-019-09666-4 may be a valid DOI for title: Tensegrity system dynamics with rigid bars and massive strings
- 10.1016/j.compstruct.2020.112188 may be a valid DOI for title: Design of a new tensegrity cantilever structure
- 10.1109/icra.2015.7139590 may be a valid DOI for title: System design and locomotion of SUPERball, an untethered tensegrity robot
- 10.1109/tcst.2020.2975138 may be a valid DOI for title: Model-predictive control with inverse statics optimization for tensegrity spine robots
- 10.1089/soro.2019.0056 may be a valid DOI for title: Rolling Locomotion of Cable-Driven Soft Spherical Tensegrity Robots
- 10.1016/j.compstruct.2020.112454 may be a valid DOI for title: A general approach to minimal mass tensegrity
- 10.2307/3103256 may be a valid DOI for title: Synergetics: explorations in the geometry of thinking
- 10.1016/j.matdes.2019.107966 may be a valid DOI for title: Design and impact response of 3D-printable tensegrity-inspired structures
- 10.1177/026635119601-204 may be a valid DOI for title: Origins of tensegrity: views of Emmerich, Fuller and Snelson
- 10.1016/j.bpj.2017.11.172 may be a valid DOI for title: Mechanisms Defining the Neuronal State Space
- 10.1109/cdc.2006.377427 may be a valid DOI for title: Minimum mass design of tensegrity towers and plates
- 10.21105/joss.01042 may be a valid DOI for title: STEDY: Software for tensegrity dynamics
- 10.1016/j.jfranklin.2009.10.009 may be a valid DOI for title: Optimal tensegrity structures in bending: The discrete Michell truss
- 10.1016/j.mechrescom.2013.10.017 may be a valid DOI for title: Minimum mass design of tensegrity bridges with parametric architecture and multiscale complexity
- 10.1007/s10237-005-0007-9 may be a valid DOI for title: Anisotropic constitutive equations and experimental tensile behavior of brain tissue
- 10.1063/1.4902071 may be a valid DOI for title: Multiscale tunability of solitary wave dynamics in tensegrity metamaterials
- 10.1016/j.jmps.2012.02.007 may be a valid DOI for title: Solitary waves on tensegrity lattices
- 10.1115/imece2005-79706 may be a valid DOI for title: The analysis of tensegrity structures for the design of a morphing wing
- 10.1089/soro.2018.0079 may be a valid DOI for title: Swimming performance of a tensegrity robotic fish
- 10.1115/1.4037565 may be a valid DOI for title: Analysis for feasibility of the method for bars driving the ball tensegrity robot
- 10.1088/1742-6596/1885/5/052024 may be a valid DOI for title: Design and experiments of a bio-inspired tensegrity spine robot for active space debris capturing
- 10.1061/9780784483374.100 may be a valid DOI for title: Deployable Tensegrity Lunar Tower
- 10.1007/978-3-319-45450-4_46 may be a valid DOI for title: Kinematic Analysis of a Flexible Tensegrity Robot
- 10.1177/0956059919845330 may be a valid DOI for title: Analytical study of tensegrity lattices for mass-efficient mechanical energy absorption
- 10.1002/rnc.3708 may be a valid DOI for title: Control-oriented modeling and deployment of tensegrity–membrane systems
- 10.1089/soro.2019.0142 may be a valid DOI for title: Surface Actuation and Sensing of a Tensegrity Structure Using Robotic Skins
- 10.1016/j.paerosci.2020.100692 may be a valid DOI for title: Review of space habitat designs for long term space explorations
- 10.1007/s00158-016-1503-5 may be a valid DOI for title: A minimal mass deployable structure for solar energy harvesting on water canals
- 10.1016/j.compstruct.2016.01.105 may be a valid DOI for title: Globally stable minimal mass compressive tensegrity structures
- 10.2514/6.2016-1511 may be a valid DOI for title: On the impact tolerance of tensegrity-based planetary landers
- 10.2514/6.2018-0693 may be a valid DOI for title: A Novel Deployment Strategy for Tensegrity Towers
- 10.1016/j.compstruct.2018.10.108 may be a valid DOI for title: Minimal mass and self-stress analysis for innovative V-Expander tensegrity cells
- 10.1016/j.compositesb.2016.10.046 may be a valid DOI for title: Mechanical response of 3-dimensional tensegrity lattices
- 10.1016/j.jmps.2019.05.006 may be a valid DOI for title: Unraveling Tensegrity Tessellations for Metamaterials with Tunable Stiffness and Bandgaps
- 10.1016/j.jmps.2018.07.011 may be a valid DOI for title: Material symmetry phase transitions in three-dimensional tensegrity metamaterials
- 10.1016/j.ijsolstr.2010.03.026 may be a valid DOI for title: A Monte Carlo form-finding method for large scale regular and irregular tensegrity structures
- 10.1016/j.compstruc.2015.07.003 may be a valid DOI for title: Node-based genetic form-finding of irregular tensegrity structures
- 10.1260/026635103322987940 may be a valid DOI for title: Review of form-finding methods for tensegrity structures
- 10.1016/j.engstruct.2013.10.014 may be a valid DOI for title: Stiffness matrix based form-finding method of tensegrity structures
- 10.1016/j.mechrescom.2019.103396 may be a valid DOI for title: Shape optimization of a new tensegrity torus
- 10.1016/s0141-0296(98)00026-1 may be a valid DOI for title: Optimum shapes of a cable dome structure
- 10.1007/s11081-011-9172-0 may be a valid DOI for title: Topology optimization of tensegrity structures under compliance constraint: a mixed integer linear programming approach
- 10.1061/(asce)st.1943-541x.0001532 may be a valid DOI for title: General approach for topology-finding of tensegrity structures
- 10.1016/j.compstruct.2016.05.009 may be a valid DOI for title: A novel method for topology design of tensegrity structures
- 10.1016/j.ijsolstr.2012.09.024 may be a valid DOI for title: A unified solution for self-equilibrium and super-stability of rhombic truncated regular polyhedral tensegrities
- 10.2514/1.j053264 may be a valid DOI for title: Double-helix tensegrity structures
- 10.1016/j.compstruc.2017.07.005 may be a valid DOI for title: Form-finding of tensegrity structures based on the Levenberg–Marquardt method
- 10.1007/s12205-019-1700-z may be a valid DOI for title: A New Genetic Algorithm-based Topology Optimization Method of Tensegrity Tori
- 10.1016/j.mechrescom.2017.05.011 may be a valid DOI for title: Form-finding of a new kind of tensegrity tori using overlapping modules
- 10.1016/j.compstruct.2017.01.059 may be a valid DOI for title: On the analytical form-finding of tensegrities
- 10.1016/j.mechrescom.2020.103480 may be a valid DOI for title: Design and Control of Tensegrity Morphing Airfoils
- 10.1016/j.compstruct.2015.08.087 may be a valid DOI for title: A tensegrity approach to the optimal reinforcement of masonry domes and vaults through fiber-reinforced composite materials
- 10.1080/14786440409463229 may be a valid DOI for title: LVIII. The limits of economy of material in frame-structures
- 10.1007/bf00932301 may be a valid DOI for title: Optimal layout of cantilever trusses
- 10.1016/0045-7949(78)90190-6 may be a valid DOI for title: Nearly optimal design of trusses
- 10.1061/(asce)st.1943-541x.0002156 may be a valid DOI for title: Topology optimization of tensegrity structures considering buckling constraints
- 10.1089/soro.2017.0066 may be a valid DOI for title: Adaptive and resilient soft tensegrity robots
- 10.1260/026635103322987940 may be a valid DOI for title: Review of form-finding methods for tensegrity structures
- 10.1098/rspa.1952.0159 may be a valid DOI for title: Analysis of the swimming of long and narrow animals
- 10.1242/jeb.048751 may be a valid DOI for title: Mechanisms underlying rhythmic locomotion: Body-fluid interaction in undulatory swimming
- 10.1073/pnas.1313933111 may be a valid DOI for title: Biological clockwork underlying adaptive rhythmic movements
- 10.1142/s0219455414500424 may be a valid DOI for title: Nonminimal dynamics of general class k tensegrity systems
- 10.1016/j.mechrescom.2014.03.007 may be a valid DOI for title: Network and vector forms of tensegrity system dynamics
- 10.1016/s0141-0296(01)00130-4 may be a valid DOI for title: Linear dynamics of tensegrity structures
- 10.1016/j.compositesb.2016.10.028 may be a valid DOI for title: Morphology and self-stress design of V-Expander tensegrity cells
- 10.1016/j.compstruct.2018.08.067 may be a valid DOI for title: Meta-tensegrity: Design of a tensegrity prism with metal rubber
- 10.1016/j.compstruct.2017.09.074 may be a valid DOI for title: Automatically assembled large-scale tensegrities by truncated regular polyhedral and prismatic elementary cells
- 10.1080/00207170110070563 may be a valid DOI for title: Modelling and control of class NSP tensegrity structures
- 10.1016/s0020-7683(00)00233-x may be a valid DOI for title: Static and dynamic analyses of tensegrity structures. Part II. Quasi-static analysis
- 10.1098/rsif.2014.0520 may be a valid DOI for title: Design and control of compliant tensegrity robots through simulation and hardware validation
- 10.1016/j.compstruct.2018.10.108 may be a valid DOI for title: Minimal mass and self-stress analysis for innovative V-Expander tensegrity cells
- 10.1016/j.mechrescom.2020.103503 may be a valid DOI for title: Mechanics of smart origami sunscreens with energy harvesting ability
- 10.2514/1.j057774 may be a valid DOI for title: Effective beam stiffness properties of n-strut cylindrical tensegrity towers
- 10.1242/jeb.052787 may be a valid DOI for title: Mechanisms underlying rhythmic locomotion: dynamics of muscle activation
- 10.1109/lra.2020.2967288 may be a valid DOI for title: Gyroscopic Tensegrity Robots
- 10.1016/j.mechrescom.2020.103477 may be a valid DOI for title: Design of Minimal Mass Load-bearing Tensegrity Lattices
- 10.1016/j.compstruct.2015.08.087 may be a valid DOI for title: A tensegrity approach to the optimal reinforcement of masonry domes and vaults through fiber-reinforced composite materials
- 10.1016/j.mechrescom.2013.10.017 may be a valid DOI for title: Minimum mass design of tensegrity bridges with parametric architecture and multiscale complexity
- 10.1115/imece2010-38546 may be a valid DOI for title: Marine Energy Devices for Colombian Seas
- 10.1115/1.4027703 may be a valid DOI for title: Analysis of a planar tensegrity mechanism for ocean wave energy harvesting
- 10.1117/12.658409 may be a valid DOI for title: Hydrodynamic loading of tensegrity structures
- 10.1016/s0378-3839(97)00031-8 may be a valid DOI for title: Hydrodynamics around cylindrical strucures
- 10.1117/2.1201302.004699 may be a valid DOI for title: Designing minimal-mass tensegrity telescopes of optimal complexity
- 10.1016/s0045-7949(03)00254-2 may be a valid DOI for title: Integral feasible prestress of cable domes
- 10.1016/j.ijsolstr.2016.11.030 may be a valid DOI for title: Initial prestress design and optimization of tensegrity systems based on symmetry and stiffness
- 10.1016/j.ijsolstr.2005.10.011 may be a valid DOI for title: Adaptive force density method for form-finding problem of tensegrity structures
- 10.1016/j.ijnonlinmec.2014.11.021 may be a valid DOI for title: Non-linear dynamic analysis of tensegrity structures using a co-rotational method
- 10.1016/j.ijsolstr.2010.11.015 may be a valid DOI for title: A comprehensive dynamic model for class-1 tensegrity systems based on quaternions
- 10.1016/j.ijsolstr.2013.05.014 may be a valid DOI for title: A new approach to the analytical and numerical form-finding of tensegrity structures
- 10.1177/1369433217706780 may be a valid DOI for title: An improved multi-objective topology optimization approach for tensegrity structures
- 10.1016/j.compstruc.2015.07.003 may be a valid DOI for title: Node-based genetic form-finding of irregular tensegrity structures
- 10.1016/j.ijsolstr.2017.10.012 may be a valid DOI for title: A sliding cable element of multibody dynamics with application to nonlinear dynamic deployment analysis of clustered tensegrity
- 10.1016/j.mechmat.2017.01.009 may be a valid DOI for title: A reduced-order model for the dynamic and post-buckling behavior of tensegrity structures

INVALID DOIs

- None
Kevin-Mattheus-Moerman commented 3 years ago

@Muhao-Chen thanks for this submission to JOSS. We have some questions in relation to this work.

This looks like it is a continuation of work you and your co-workers previously submitted to JOSS, namely MOTES (paper, review, software repository). Indeed some functionality (e.g. tenseg_plot.m in MOTES and tenseg_plot.m in TsgFEM) seems fully duplicated. Also the README may have been copied from MOTES as the set-up section for TsgFEM refers to MOTES.

Can you clarify how the current new submission, TsgFEM, differs from MOTES? Can you clearly make the case why TsgFEM requires an independent publication on top of, and distinct from MOTES? Can you please also comment on whether it would not be better to integrate TsgFEM+MOTES into a single library and to consider publishing that?

Can you clarify the timeline of development for this work? Based on GitHub uploads it looks like development just started, but the user guide appears to refer to development from 2019.

Muhao-Chen commented 3 years ago

@Kevin-Mattheus-Moerman Thanks for your questions!

Yes, our group push research work on the tensegrity structures. TsgFEM indeed has few functions in common with MOTES. But the major contribution of this work is quite different. All the duplicated and modified functions have been cited in the description of code files, and we also include their license.

Sure, TsgFEM and MOTES are both analysis tools for tensegrity structures (a stable network of bars and strings). TsgFEM is developed based on the assumption that bars are not rigid (the bars and strings can be elastic or plastic), so the simulation and results are representing the physics. MOTES assumes that the bars are rigid and strings are elastic, so it has limitations.

TsgFEM + MOTES is a good idea. Actually, TsgFEM is much more powerful, and now it is able to do what the MOTES can do and do more since we can set a really high stiffness of bars and view them as rigid ones in TsgFEM. Plus, TsgFEM also provides more functionalities in structure statics and dynamics, i.e., linearized dynamics, modal analysis, etc.

Plus, rigid body assumption is very useful in research, but in real engineering constructions, no materials are rigid. Finite Element Method (FEM) analysis is more important, and it is almost a must-study process before putting any structures up. And the FEM information can also provide an insight into the local loadings of structure members.

Yeah, the file structure and README of the two GitHub repositories are similar because I am the co-author of MOTES as well, and I wrote those description files. To be consistent and help people in the tensegrity community who is using our software understand better, I use the same file structure and format.

Yes, we started this work in 2019, but it's not uploaded on GitHub. Until all the TsgFEM files ready, we submitted them to GitHub on 06/09/2021. That's why you only see two commits shown on GitHub.

Kevin-Mattheus-Moerman commented 3 years ago

@Muhao-Chen thanks for this explanation.

Kevin-Mattheus-Moerman commented 3 years ago

@Muhao-Chen can you check if all those references are actually cited in the paper? :point_up: Perhaps clean up the .bib file so it is only the papers from the paper and also add those missing DOIs please. You can call @whedon generate pdf to update the paper.

Muhao-Chen commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Muhao-Chen commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Muhao-Chen commented 3 years ago

@Kevin-Mattheus-Moerman Thank you so much for your help! I removed all the unused bib files and also added the missing DOIs. The pdf format looks good now. Please let me know if there are any questions. Thank you!

Kevin-Mattheus-Moerman commented 3 years ago

@whedon check references

whedon commented 3 years ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2307/3103256 is OK
- 10.1177/026635119601-204 is OK
- 10.1016/j.compstruct.2020.112454 is OK
- 10.1073/pnas.141199598 is OK
- 10.1038/nnano.2010.107 is OK
- 10.1007/978-0-387-74242-7 is OK
- 10.1016/j.compstruct.2020.112188 is OK
- 10.1016/j.engstruct.2009.12.042 is OK
- 10.1016/j.paerosci.2020.100692 is OK
- 10.1061/9780784483374.100 is OK
- 10.1115/1.4037565 is OK
- 10.1109/ICRA.2015.7139590 is OK
- 10.1089/soro.2019.0142 is OK
- 10.1109/TCST.2020.2975138 is OK
- 10.1016/j.mechrescom.2020.103480 is OK
- 10.1089/soro.2018.0079 is OK
- 10.1088/1742-6596/1885/5/052024 is OK
- 10.1016/j.aquaeng.2007.01.001 is OK
- 10.1016/j.compstruct.2017.12.050 is OK
- 10.21105/joss.01042 is OK
- 10.21105/joss.01613 is OK

MISSING DOIs

- None

INVALID DOIs

- None
danielskatz commented 3 years ago

@Muhao-Chen - thanks for your submission. Due to a current shortage of editors (that we are working to resolve), I'm going to put it on our waiting list until an appropriate editor is available.

Muhao-Chen commented 3 years ago

@danielskatz Sure, take your time! Thank you so much for helping!

diehlpk commented 3 years ago

@danielskatz I can take this paper.

diehlpk commented 3 years ago

@whedon assign @diehlpk as editor

whedon commented 3 years ago

OK, the editor is @diehlpk

diehlpk commented 3 years ago

Hi @IgorBaratta @HaoZeke @mikaem @gassmoeller @chennachaos @yangbai90 @thelfer @capitalaslash would you be interested in reviewing this paper?

HaoZeke commented 3 years ago

I'd be happy to take this, but I just moved and might need some more time than usual. Am also a little backed up with other things.

diehlpk commented 3 years ago

I'd be happy to take this, but I just moved and might need some more time than usual. Am also a little backed up with other things.

No worries if you need a little bit longer.

diehlpk commented 3 years ago

@whedon assign @HaoZeke as reviewer

whedon commented 3 years ago

OK, @HaoZeke is now a reviewer

chennachaos commented 3 years ago

Hi @diehlpk, thank you for the opportunity! I have a lot of commitments for the next few months. So, I would like to skip this time.

diehlpk commented 3 years ago

@chennachaos Can you recommend some reviewers for that paper?

thelfer commented 3 years ago

Hi @diehlpk. After briefly reading of the paper, I don't think I have enough experience in this domain to make a proper review.

chennachaos commented 3 years ago

I think @likask, @bhajay, @agshvarts might be interested.

Kevin-Mattheus-Moerman commented 3 years ago

@diehlpk thanks for handling this. FYI here are two other papers I was involved in which feature tensegrity modelling. Perhaps some of the authors/reviewers for these can help review too:

Kevin-Mattheus-Moerman commented 3 years ago

@diehlpk also I would not mind reviewing this as a (n+1)th reviewer

likask commented 3 years ago

@Kevin-Mattheus-Moerman I am happy to review.

diehlpk commented 3 years ago

@whedon add @likask as reviewer

diehlpk commented 3 years ago

@whedon add @Kevin-Mattheus-Moerman as reviewer

whedon commented 3 years ago

OK, @Kevin-Mattheus-Moerman is now a reviewer

diehlpk commented 3 years ago

@whedon start review

whedon commented 3 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/3390.

IgorBaratta commented 3 years ago

Thank you for the invitation to review. Unfortunatelly I don't have access to Matlab at the moment.

diehlpk commented 3 years ago

@whedon add @likask as reviewer

whedon commented 3 years ago

OK, @likask is now a reviewer