search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: pollucheck v1.0: A package to explore open-source air pollution data #3435

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @adithirugis (Adithi Upadhya) Repository: https://github.com/adithirgis/pollucheck Version: 1.0.0 Editor: @ajstewartlang Reviewer: @nmstreethran, @ibarraespinosa Archive: 10.5281/zenodo.5128607

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6844e6db054970a02c1ddbcf9e9f0cc2"><img src="https://joss.theoj.org/papers/6844e6db054970a02c1ddbcf9e9f0cc2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6844e6db054970a02c1ddbcf9e9f0cc2/status.svg)](https://joss.theoj.org/papers/6844e6db054970a02c1ddbcf9e9f0cc2)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@nmstreethran & @ibarraespinosa, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ajstewartlang know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @nmstreethran

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @ibarraespinosa

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @nmstreethran, @ibarraespinosa it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago

Failed to discover a Statement of need section in paper

whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.20 s (139.7 files/s, 483198.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            13            211              0          93166
R                                7             49             58           2251
Markdown                         6            265              0            590
TeX                              1              6              0             56
Rmd                              1             64            127              1
-------------------------------------------------------------------------------
SUM:                            28            595            185          96064
-------------------------------------------------------------------------------

Statistical information for the repository 'adbaf3aa7f52be1d2f44b18c' was
gathered on 2021/06/30.
No commited files with the specified extensions were found.
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/cvr/cvaa092 is OK
- 10.18637/jss.v027.i03 is OK
- 10.1016/j.envsoft.2011.09.008 is OK
- 10.21105/joss.00333 is OK
- 10.21105/joss.02250 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ibarraespinosa commented 3 years ago

hello @ajstewartlang, I can't update the checklist.

adithirgis commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

adithirgis commented 3 years ago

@whedon commands

whedon commented 3 years ago

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository
adithirgis commented 3 years ago

@whedon check references

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/cvr/cvaa092 is OK
- 10.18637/jss.v027.i03 is OK
- 10.1016/j.envsoft.2011.09.008 is OK
- 10.21105/joss.00333 is OK
- 10.21105/joss.02250 is OK

MISSING DOIs

- None

INVALID DOIs

- None
ajstewartlang commented 3 years ago

hello @ajstewartlang, I can't update the checklist.

hi @ibarraespinosa can you double check that you've accepted the GH email invitation to this repo ok?

ibarraespinosa commented 3 years ago

I got this message Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account.

danielskatz commented 3 years ago

@whedon re-invite @ibarraespinosa as reviewer

whedon commented 3 years ago

OK, the reviewer has been re-invited.

@ibarraespinosa please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

ibarraespinosa commented 3 years ago

Thanks 😊

Em qui, 8 de jul de 2021 09:58, whedon @.***> escreveu:

OK, the reviewer has been re-invited.

@ibarraespinosa https://github.com/ibarraespinosa please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3435#issuecomment-876417186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74BGZXG445FS2YVO3ITTWWOGJANCNFSM47SIO46Q .

whedon commented 3 years ago

:wave: @nmstreethran, please update us on how your review is going (this is an automated reminder).

whedon commented 3 years ago

:wave: @ibarraespinosa, please update us on how your review is going (this is an automated reminder).

adithirgis commented 3 years ago

@whedon check references

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/cvr/cvaa092 is OK
- 10.18637/jss.v027.i03 is OK
- 10.1016/j.envsoft.2011.09.008 is OK
- 10.21105/joss.00333 is OK
- 10.21105/joss.02250 is OK

MISSING DOIs

- None

INVALID DOIs

- None
adithirgis commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

adithirgis commented 3 years ago

@whedon check references

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/cvr/cvaa092 is OK
- 10.18637/jss.v027.i03 is OK
- 10.1016/j.envsoft.2011.09.008 is OK
- 10.21105/joss.00333 is OK
- 10.21105/joss.02250 is OK
- 10.1016/j.asr.2021.02.008 is OK
- 10.1016/j.atmosenv.2007.09.003 is OK
- 10.1016/j.atmosenv.2014.11.062 is OK

MISSING DOIs

- None

INVALID DOIs

- None
adithirgis commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ibarraespinosa commented 3 years ago

Hello @ajstewartlang, I have already reviewed the paper by @adithirgis. It consists in a software to analyze air pollution measurements with different databases. pollucheck analyze different type of data-sets. I have been working with air pollution since 14 years ago in many countries and I`m sure this software will be used in many countries. Thanks for the invitation to review this paper and have a nice day.

adithirgis commented 3 years ago

Thank you so much @ibarraespinosa , we have addressed the OpenAQ issue, please let us know if you still face same issue.

ajstewartlang commented 3 years ago

Many thanks for your helpful review @ibarraespinosa - @nmstreethran are you getting on ok with your review?

nmstreethran commented 3 years ago

Hi @ajstewartlang, I'm working on the review just now and will open an issue in the target repository. I'll update you once my review is complete.

Thanks.

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/cvr/cvaa092 is OK
- 10.18637/jss.v027.i03 is OK
- 10.1016/j.envsoft.2011.09.008 is OK
- 10.21105/joss.00333 is OK
- 10.21105/joss.02250 is OK
- 10.1016/j.asr.2021.02.008 is OK
- 10.1016/j.atmosenv.2007.09.003 is OK
- 10.1016/j.atmosenv.2014.11.062 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

adithirgis commented 3 years ago

Hi @ibarraespinosa!

We have implemented your suggestion of adding case study.

Thank you!

ibarraespinosa commented 3 years ago

Hi Adithi, thanks you!.

Em ter., 20 de jul. de 2021 às 08:31, Adithi R. Upadhya < @.***> escreveu:

Hi @ibarraespinosa https://github.com/ibarraespinosa!

We have implemented your suggestion of adding case study.

Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/3435#issuecomment-883319450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRM74E7NWMQOACWJUHCRATTYVNCTANCNFSM47SIO46Q .

adithirgis commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

adithirgis commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

nmstreethran commented 3 years ago

Hi @ajstewartlang, I have completed my review (adithirgis/pollucheck#2). pollucheck is very useful for performing exploratory data analysis on open air pollution data. The app provides users an interactive way to do this without needing any programming knowledge. I'm happy to recommend this submission for publication. Please let me know if there is anything else I can do.

Thanks!

adithirgis commented 3 years ago

Thanks @ibarraespinosa and @nmstreethran for a thorough review.

Thanks @ajstewartlang!

ajstewartlang commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ajstewartlang commented 3 years ago

@whedon check references

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1093/cvr/cvaa092 is OK
- 10.18637/jss.v027.i03 is OK
- 10.1016/j.envsoft.2011.09.008 is OK
- 10.21105/joss.00333 is OK
- 10.21105/joss.02250 is OK
- 10.1016/j.asr.2021.02.008 is OK
- 10.1016/j.atmosenv.2007.09.003 is OK
- 10.1016/j.atmosenv.2014.11.062 is OK

MISSING DOIs

- None

INVALID DOIs

- None
ajstewartlang commented 3 years ago

Many thanks @ibarraespinosa and @nmstreethran for your helpful and detailed reviews. I've had a read through myself @adithirgis and agree that pollucheck is a very nice and useful piece of software. Congrats!

@adithirgis can I now ask you to do the following please?

adithirgis commented 3 years ago

Thanks @ajstewartlang!

ajstewartlang commented 3 years ago

@whedon set 10.5281/zenodo.5126939 as archive