search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
712 stars 38 forks source link

[REVIEW]: mcboost: Multi-Calibration Boosting for R #3453

Closed whedon closed 3 years ago

whedon commented 3 years ago

Submitting author: @pfistfl (Florian Pfisterer) Repository: https://github.com/mlr-org/mcboost Version: v.0.3.3 Editor: @osorensen Reviewer: @mwt, @OwenWard Archive: 10.5281/zenodo.5156518

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/19899bbe517d82bb1d5c7dbb2e8c539f"><img src="https://joss.theoj.org/papers/19899bbe517d82bb1d5c7dbb2e8c539f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/19899bbe517d82bb1d5c7dbb2e8c539f/status.svg)](https://joss.theoj.org/papers/19899bbe517d82bb1d5c7dbb2e8c539f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mwt & @OwenWard, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:

  1. Make sure you're logged in to your GitHub account
  2. Be sure to accept the invite at this URL: https://github.com/openjournals/joss-reviews/invitations

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Review checklist for @mwt

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

Review checklist for @OwenWard

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

whedon commented 3 years ago

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @mwt, @OwenWard it looks like you're currently assigned to review this paper :tada:.

:warning: JOSS reduced service mode :warning:

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

:star: Important :star:

If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿

To fix this do the following two things:

  1. Set yourself as 'Not watching' https://github.com/openjournals/joss-reviews:

watching

  1. You may also like to change your default settings for this watching repositories in your GitHub profile here: https://github.com/settings/notifications

notifications

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf
whedon commented 3 years ago 
Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.03 s (1368.2 files/s, 134688.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               22            180            687           1125
Markdown                         6            141              0            458
JSON                             1              0              0            367
Rmd                              3            245            406            354
YAML                             2             25             28             99
TeX                              1             23              2             85
SVG                              8              0              0              8
-------------------------------------------------------------------------------
SUM:                            43            614           1123           2496
-------------------------------------------------------------------------------

Statistical information for the repository '9e953606421e4ed3702ebec1' was
gathered on 2021/07/04.
No commited files with the specified extensions were found.
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41467-020-18297-9 is OK
- 10.1093/jamia/ocaa283 is OK
- 10.1109/FOCS.2019.00016 is OK
- 10.1145/3306618.3314287 is OK
- 10.21105/joss.01903 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

whedon commented 3 years ago

:wave: @mwt, please update us on how your review is going (this is an automated reminder).

whedon commented 3 years ago

:wave: @OwenWard, please update us on how your review is going (this is an automated reminder).

mwt commented 3 years ago

@osorensen @pfistfl it looks all clear to me. There are automated tests which all pass and there are vignettes which compile and seem to be doing what they're supposed to.

osorensen commented 3 years ago

Thanks for conducting the review, @mwt!

pfistfl commented 3 years ago

@mwt @osorensen Thank you so much for the review! If there are any questions/ issues please let me know!

osorensen commented 3 years ago

@OwenWard, could you please update us on how it is going with your review?

OwenWard commented 3 years ago

@osorensen I'm nearly done, hoping to finish this week!

OwenWard commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

OwenWard commented 3 years ago

@pfistfl I opened a pull request for two very small typos I spotted, one in an error message and one in the paper. Also the figure doesn't currently appear in the pdf of the article proof, but that should be an easy fix. @osorensen otherwise everything looks good to me.

pfistfl commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

pfistfl commented 3 years ago

Thanks a lot for the PR, I think I have addressed everything.

osorensen commented 3 years ago

Thanks for completing the review, @OwenWard!

osorensen commented 3 years ago

@pfistfl, I have one final comment to the article proof. On page 2, lines 52-54, I believe the last part of the sentence is not grammatically correct, particularly the word "helps".

We hope that with mcboost, Multi-Calibration Boosting can be utilized by a wide community 53 of developers and data scientists to audit and post-process prediction models and helps to 54 promote fairness in machine learning and statistical estimation applications.

Here is a suggested rewrite, put feel free to phrase it differently:

We hope that mcboost lets Multi-Calibration Boosting be utilized by a wide community 53 of developers and data scientists to audit and post-process prediction models, and helps to 54 promote fairness in machine learning and statistical estimation applications.

chkern commented 3 years ago

@whedon generate pdf

whedon commented 3 years ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

chkern commented 3 years ago

Thanks @osorensen, we followed your suggestion.

osorensen commented 3 years ago

@whedon check references

whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41467-020-18297-9 is OK
- 10.1093/jamia/ocaa283 is OK
- 10.1109/FOCS.2019.00016 is OK
- 10.1145/3306618.3314287 is OK
- 10.21105/joss.01903 is OK

MISSING DOIs

- None

INVALID DOIs

- None
osorensen commented 3 years ago

@pfistfl, before we proceed, could you please do the following?

pfistfl commented 3 years ago

@osorensen, thanks so much for the quick & smooth progress

osorensen commented 3 years ago

@whedon set 10.5281/zenodo.5156518 as archive

whedon commented 3 years ago

OK. 10.5281/zenodo.5156518 is the archive.

osorensen commented 3 years ago

@whedon set <v0.3.3> as version

whedon commented 3 years ago

OK. <v0.3.3> is the version.

osorensen commented 3 years ago

@whedon set v.0.3.3 as version

whedon commented 3 years ago

OK. v.0.3.3 is the version.

osorensen commented 3 years ago

@whedon recommend-accept

whedon commented 3 years ago 
Attempting dry run of processing paper acceptance...
whedon commented 3 years ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41467-020-18297-9 is OK
- 10.1093/jamia/ocaa283 is OK
- 10.1109/FOCS.2019.00016 is OK
- 10.1145/3306618.3314287 is OK
- 10.21105/joss.01903 is OK

MISSING DOIs

- None

INVALID DOIs

- None
whedon commented 3 years ago

:wave: @openjournals/joss-eics, this paper is ready to be accepted and published.

Check final proof :point_right: https://github.com/openjournals/joss-papers/pull/2492

If the paper PDF and Crossref deposit XML look good in https://github.com/openjournals/joss-papers/pull/2492, then you can now move forward with accepting the submission by compiling again with the flag deposit=true e.g.

@whedon accept deposit=true
arfon commented 3 years ago

@whedon accept deposit=true

whedon commented 3 years ago 
Doing it live! Attempting automated processing of paper acceptance...
whedon commented 3 years ago

🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦

whedon commented 3 years ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/2500
  2. Wait a couple of minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.03453
  3. If everything looks good, then close this review issue.

  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

    Any issues? Notify your editorial technical team...

arfon commented 3 years ago

@mwt, @OwenWard – many thanks for your reviews here and to @osorensen for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@pfistfl – your paper is now accepted and published in JOSS :zap::rocket::boom:

Also, congratulations to @osorensen for editing his first JOSS paper ✨!

whedon commented 3 years ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.03453/status.svg)](https://doi.org/10.21105/joss.03453)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.03453">
  <img src="https://joss.theoj.org/papers/10.21105/joss.03453/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.03453/status.svg
   :target: https://doi.org/10.21105/joss.03453

This is how it will look in your documentation:

DOI

We need your help!

Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: